Author: Alex Langford
Date: 2023-06-15T14:46:46-07:00
New Revision: 8fb919a1154a593fdf01e759ece7904afc73f687
URL:
https://github.com/llvm/llvm-project/commit/8fb919a1154a593fdf01e759ece7904afc73f687
DIFF:
https://github.com/llvm/llvm-project/commit/8fb919a1154a593fdf01e759ece7904afc73f687.diff
Author: Alex Langford
Date: 2023-06-15T14:57:20-07:00
New Revision: e29cc5216a8608b026e390b69022878b2ec3071a
URL:
https://github.com/llvm/llvm-project/commit/e29cc5216a8608b026e390b69022878b2ec3071a
DIFF:
https://github.com/llvm/llvm-project/commit/e29cc5216a8608b026e390b69022878b2ec3071a.diff
Author: Alex Langford
Date: 2023-06-16T10:44:55-07:00
New Revision: 4c8b6fae4437f9a5b17ddc146592aec0e4c78e02
URL:
https://github.com/llvm/llvm-project/commit/4c8b6fae4437f9a5b17ddc146592aec0e4c78e02
DIFF:
https://github.com/llvm/llvm-project/commit/4c8b6fae4437f9a5b17ddc146592aec0e4c78e02.diff
Author: Alex Langford
Date: 2023-06-16T10:50:15-07:00
New Revision: 193c7d10cb30d846d35085a462f8a6c8ad226f1f
URL:
https://github.com/llvm/llvm-project/commit/193c7d10cb30d846d35085a462f8a6c8ad226f1f
DIFF:
https://github.com/llvm/llvm-project/commit/193c7d10cb30d846d35085a462f8a6c8ad226f1f.diff
Author: Alex Langford
Date: 2023-06-16T10:53:24-07:00
New Revision: 0b90d09898cadc89105c3caf0d01f09e66c49993
URL:
https://github.com/llvm/llvm-project/commit/0b90d09898cadc89105c3caf0d01f09e66c49993
DIFF:
https://github.com/llvm/llvm-project/commit/0b90d09898cadc89105c3caf0d01f09e66c49993.diff
Author: Alex Langford
Date: 2023-06-16T10:55:01-07:00
New Revision: 44930490124d29c07b9538fb08fc6c7713cd74dc
URL:
https://github.com/llvm/llvm-project/commit/44930490124d29c07b9538fb08fc6c7713cd74dc
DIFF:
https://github.com/llvm/llvm-project/commit/44930490124d29c07b9538fb08fc6c7713cd74dc.diff
Author: Alex Langford
Date: 2023-06-16T14:19:13-07:00
New Revision: 7d30878bf8586a991264c5ca9095a7b5a5234a42
URL:
https://github.com/llvm/llvm-project/commit/7d30878bf8586a991264c5ca9095a7b5a5234a42
DIFF:
https://github.com/llvm/llvm-project/commit/7d30878bf8586a991264c5ca9095a7b5a5234a42.diff
Author: Alex Langford
Date: 2023-06-21T10:17:24-07:00
New Revision: b4827a3c0a7ef121ca376713e115b04eff0f5194
URL:
https://github.com/llvm/llvm-project/commit/b4827a3c0a7ef121ca376713e115b04eff0f5194
DIFF:
https://github.com/llvm/llvm-project/commit/b4827a3c0a7ef121ca376713e115b04eff0f5194.diff
Author: Alex Langford
Date: 2023-06-22T16:42:22-07:00
New Revision: 28fb39f16af1003e53008b75c11127b3288742f8
URL:
https://github.com/llvm/llvm-project/commit/28fb39f16af1003e53008b75c11127b3288742f8
DIFF:
https://github.com/llvm/llvm-project/commit/28fb39f16af1003e53008b75c11127b3288742f8.diff
Author: Alex Langford
Date: 2023-06-23T10:29:52-07:00
New Revision: 1a397ecffdea64f5a521b4aac1fa4b98723dec22
URL:
https://github.com/llvm/llvm-project/commit/1a397ecffdea64f5a521b4aac1fa4b98723dec22
DIFF:
https://github.com/llvm/llvm-project/commit/1a397ecffdea64f5a521b4aac1fa4b98723dec22.diff
Author: Alex Langford
Date: 2023-06-26T10:33:18-07:00
New Revision: 718e0cd6e7240a1233991eec472aa904800dce00
URL:
https://github.com/llvm/llvm-project/commit/718e0cd6e7240a1233991eec472aa904800dce00
DIFF:
https://github.com/llvm/llvm-project/commit/718e0cd6e7240a1233991eec472aa904800dce00.diff
Author: Alex Langford
Date: 2023-06-26T10:36:41-07:00
New Revision: 5f69e6682bf0806c13098f79cb5f1ee30f0f8c06
URL:
https://github.com/llvm/llvm-project/commit/5f69e6682bf0806c13098f79cb5f1ee30f0f8c06
DIFF:
https://github.com/llvm/llvm-project/commit/5f69e6682bf0806c13098f79cb5f1ee30f0f8c06.diff
Author: Alex Langford
Date: 2023-06-26T11:06:29-07:00
New Revision: 2014572d9a6839745a920ec19ebfa73814548061
URL:
https://github.com/llvm/llvm-project/commit/2014572d9a6839745a920ec19ebfa73814548061
DIFF:
https://github.com/llvm/llvm-project/commit/2014572d9a6839745a920ec19ebfa73814548061.diff
Author: Alex Langford
Date: 2023-06-26T11:09:09-07:00
New Revision: 9442e81f02a7e83132432269c9ada7c03eab7a38
URL:
https://github.com/llvm/llvm-project/commit/9442e81f02a7e83132432269c9ada7c03eab7a38
DIFF:
https://github.com/llvm/llvm-project/commit/9442e81f02a7e83132432269c9ada7c03eab7a38.diff
Author: Alex Langford
Date: 2023-06-26T14:59:55-07:00
New Revision: 7ed3c2edf017840e0c7c358aa48d2d67d4b55dcb
URL:
https://github.com/llvm/llvm-project/commit/7ed3c2edf017840e0c7c358aa48d2d67d4b55dcb
DIFF:
https://github.com/llvm/llvm-project/commit/7ed3c2edf017840e0c7c358aa48d2d67d4b55dcb.diff
Author: Alex Langford
Date: 2023-06-27T10:43:35-07:00
New Revision: 7ec083107ff2dd72cb28e9cd8a45749e2619046c
URL:
https://github.com/llvm/llvm-project/commit/7ec083107ff2dd72cb28e9cd8a45749e2619046c
DIFF:
https://github.com/llvm/llvm-project/commit/7ec083107ff2dd72cb28e9cd8a45749e2619046c.diff
Author: Alex Langford
Date: 2023-06-27T10:46:34-07:00
New Revision: 1bd69ae0c5a7e704979f6efa1c7d7c39d4e2d5c9
URL:
https://github.com/llvm/llvm-project/commit/1bd69ae0c5a7e704979f6efa1c7d7c39d4e2d5c9
DIFF:
https://github.com/llvm/llvm-project/commit/1bd69ae0c5a7e704979f6efa1c7d7c39d4e2d5c9.diff
Author: Alex Langford
Date: 2023-07-03T09:31:10-07:00
New Revision: 673f91055a41b2273e159eafe86d0d7d87fa474f
URL:
https://github.com/llvm/llvm-project/commit/673f91055a41b2273e159eafe86d0d7d87fa474f
DIFF:
https://github.com/llvm/llvm-project/commit/673f91055a41b2273e159eafe86d0d7d87fa474f.diff
Author: Alex Langford
Date: 2023-07-03T09:35:24-07:00
New Revision: a2ff2921e84aa435e124ad275f70855a185cfb1c
URL:
https://github.com/llvm/llvm-project/commit/a2ff2921e84aa435e124ad275f70855a185cfb1c
DIFF:
https://github.com/llvm/llvm-project/commit/a2ff2921e84aa435e124ad275f70855a185cfb1c.diff
Author: Alex Langford
Date: 2023-07-03T10:03:49-07:00
New Revision: 1b102886c0c33bb01ff8f2360b57c7b8d039abcc
URL:
https://github.com/llvm/llvm-project/commit/1b102886c0c33bb01ff8f2360b57c7b8d039abcc
DIFF:
https://github.com/llvm/llvm-project/commit/1b102886c0c33bb01ff8f2360b57c7b8d039abcc.diff
Author: Alex Langford
Date: 2023-07-03T11:13:50-07:00
New Revision: e3921b8bff693649602760a6221cd1150420a287
URL:
https://github.com/llvm/llvm-project/commit/e3921b8bff693649602760a6221cd1150420a287
DIFF:
https://github.com/llvm/llvm-project/commit/e3921b8bff693649602760a6221cd1150420a287.diff
Author: Alex Langford
Date: 2023-07-03T11:17:48-07:00
New Revision: ebec53e2d7c79b519aec455d048f5f03fc2e7abe
URL:
https://github.com/llvm/llvm-project/commit/ebec53e2d7c79b519aec455d048f5f03fc2e7abe
DIFF:
https://github.com/llvm/llvm-project/commit/ebec53e2d7c79b519aec455d048f5f03fc2e7abe.diff
Author: Alex Langford
Date: 2023-07-03T11:39:38-07:00
New Revision: b709149b76277e8bea4a3d7977ccb4e818499b7b
URL:
https://github.com/llvm/llvm-project/commit/b709149b76277e8bea4a3d7977ccb4e818499b7b
DIFF:
https://github.com/llvm/llvm-project/commit/b709149b76277e8bea4a3d7977ccb4e818499b7b.diff
Author: Alex Langford
Date: 2023-07-05T08:46:48-07:00
New Revision: 1c7c9970379e1949a0b338eba2746dbf84b0bda4
URL:
https://github.com/llvm/llvm-project/commit/1c7c9970379e1949a0b338eba2746dbf84b0bda4
DIFF:
https://github.com/llvm/llvm-project/commit/1c7c9970379e1949a0b338eba2746dbf84b0bda4.diff
Author: Alex Langford
Date: 2023-07-05T08:52:32-07:00
New Revision: 20f99278dbb81e880c23c65688e9752ce7ad019a
URL:
https://github.com/llvm/llvm-project/commit/20f99278dbb81e880c23c65688e9752ce7ad019a
DIFF:
https://github.com/llvm/llvm-project/commit/20f99278dbb81e880c23c65688e9752ce7ad019a.diff
Author: Alex Langford
Date: 2023-07-05T09:00:59-07:00
New Revision: fd5748cb5a45c4178b84eb329bea9055f8ee485d
URL:
https://github.com/llvm/llvm-project/commit/fd5748cb5a45c4178b84eb329bea9055f8ee485d
DIFF:
https://github.com/llvm/llvm-project/commit/fd5748cb5a45c4178b84eb329bea9055f8ee485d.diff
Author: Alex Langford
Date: 2023-07-06T08:49:07-07:00
New Revision: fc55b0b38446be8948a291057b3086b4a01fe0a7
URL:
https://github.com/llvm/llvm-project/commit/fc55b0b38446be8948a291057b3086b4a01fe0a7
DIFF:
https://github.com/llvm/llvm-project/commit/fc55b0b38446be8948a291057b3086b4a01fe0a7.diff
Author: Alex Langford
Date: 2023-07-06T08:51:54-07:00
New Revision: 8f7e41d0400ecc41f8120e330baed15b0d203036
URL:
https://github.com/llvm/llvm-project/commit/8f7e41d0400ecc41f8120e330baed15b0d203036
DIFF:
https://github.com/llvm/llvm-project/commit/8f7e41d0400ecc41f8120e330baed15b0d203036.diff
Author: Alex Langford
Date: 2021-09-08T11:27:10-07:00
New Revision: 303b27f21b98a45621d39f941c88c7e30d69fbe7
URL:
https://github.com/llvm/llvm-project/commit/303b27f21b98a45621d39f941c88c7e30d69fbe7
DIFF:
https://github.com/llvm/llvm-project/commit/303b27f21b98a45621d39f941c88c7e30d69fbe7.diff
Author: Alex Langford
Date: 2021-09-10T14:16:47-07:00
New Revision: 8dae35527fb77a4698d05d39ed66f8c545885098
URL:
https://github.com/llvm/llvm-project/commit/8dae35527fb77a4698d05d39ed66f8c545885098
DIFF:
https://github.com/llvm/llvm-project/commit/8dae35527fb77a4698d05d39ed66f8c545885098.diff
Author: Alex Langford
Date: 2021-09-13T10:37:45-07:00
New Revision: c4fa2c8aa493e4c786446739ba3eb0eb4918d579
URL:
https://github.com/llvm/llvm-project/commit/c4fa2c8aa493e4c786446739ba3eb0eb4918d579
DIFF:
https://github.com/llvm/llvm-project/commit/c4fa2c8aa493e4c786446739ba3eb0eb4918d579.diff
Author: Alex Langford
Date: 2021-09-16T13:13:07-07:00
New Revision: a65f6aafe2d357cd83de62832a2bdae49a2d6749
URL:
https://github.com/llvm/llvm-project/commit/a65f6aafe2d357cd83de62832a2bdae49a2d6749
DIFF:
https://github.com/llvm/llvm-project/commit/a65f6aafe2d357cd83de62832a2bdae49a2d6749.diff
Author: Alex Langford
Date: 2021-09-20T11:44:20-07:00
New Revision: c4a406bbd0fe3afa8366b72c49b1bc494a168624
URL:
https://github.com/llvm/llvm-project/commit/c4a406bbd0fe3afa8366b72c49b1bc494a168624
DIFF:
https://github.com/llvm/llvm-project/commit/c4a406bbd0fe3afa8366b72c49b1bc494a168624.diff
Author: Alex Langford
Date: 2021-09-22T11:01:15-07:00
New Revision: 43552651319e1c39c09ce0f61b588813414cebda
URL:
https://github.com/llvm/llvm-project/commit/43552651319e1c39c09ce0f61b588813414cebda
DIFF:
https://github.com/llvm/llvm-project/commit/43552651319e1c39c09ce0f61b588813414cebda.diff
Author: Alex Langford
Date: 2021-09-29T11:39:09-07:00
New Revision: 385b2189cc4446745e1ea4ac803c22b3daef73ec
URL:
https://github.com/llvm/llvm-project/commit/385b2189cc4446745e1ea4ac803c22b3daef73ec
DIFF:
https://github.com/llvm/llvm-project/commit/385b2189cc4446745e1ea4ac803c22b3daef73ec.diff
Author: Alex Langford
Date: 2021-11-11T15:42:27-08:00
New Revision: ac33e65d2169260364e3e92fed2ba81c58d5ce33
URL:
https://github.com/llvm/llvm-project/commit/ac33e65d2169260364e3e92fed2ba81c58d5ce33
DIFF:
https://github.com/llvm/llvm-project/commit/ac33e65d2169260364e3e92fed2ba81c58d5ce33.diff
Author: Alex Langford
Date: 2023-09-29T12:06:13-07:00
New Revision: 2e12fc3d04032be743b2aded354d81d53c5195ec
URL:
https://github.com/llvm/llvm-project/commit/2e12fc3d04032be743b2aded354d81d53c5195ec
DIFF:
https://github.com/llvm/llvm-project/commit/2e12fc3d04032be743b2aded354d81d53c5195ec.diff
Author: Alex Langford
Date: 2023-09-29T14:09:22-07:00
New Revision: 12f4e113869ff93d7b25cfc83c56f546e3d52c0f
URL:
https://github.com/llvm/llvm-project/commit/12f4e113869ff93d7b25cfc83c56f546e3d52c0f
DIFF:
https://github.com/llvm/llvm-project/commit/12f4e113869ff93d7b25cfc83c56f546e3d52c0f.diff
bulbazord wrote:
I think I am on the same page with Greg for not exposing these symbols for not
shoving everything into `lldb_private`. Perhaps instead of `lldb_plugin` we can
name it something like `lldb_private::plugin` instead? Not a huge difference,
but keeping the top-level private namesp
bulbazord wrote:
Adding Jonas and Adrian for visibility
https://github.com/llvm/llvm-project/pull/67851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/67841
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -19,6 +20,7 @@ struct PlatformShellCommand;
namespace lldb {
class SBLaunchInfo;
+class SBAttachInfo;
bulbazord wrote:
sort
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-comm
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo &launch_info) {
});
}
+SBProcess SBPlatform::Attach(SBAttachInfo &attach_info,
+ const SBDebugger &debugger, SBTarget &target,
+ SBError &error) {
+ LLDB_INS
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo &launch_info) {
});
}
+SBProcess SBPlatform::Attach(SBAttachInfo &attach_info,
+ const SBDebugger &debugger, SBTarget &target,
bulbazord wrote:
I'd like to see the `att
https://github.com/bulbazord commented:
Looks fine to me, but I want to really make sure we get this interface right.
Left some comments inline.
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
Lgtm
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2023-10-03T10:27:18-07:00
New Revision: dd76375c80098be4d08b7e02290e39a8c1d00ab1
URL:
https://github.com/llvm/llvm-project/commit/dd76375c80098be4d08b7e02290e39a8c1d00ab1
DIFF:
https://github.com/llvm/llvm-project/commit/dd76375c80098be4d08b7e02290e39a8c1d00ab1.diff
Author: Alex Langford
Date: 2023-10-03T16:11:02-07:00
New Revision: 91223c92f7f7e1a6c074a28de6b5206c22eec116
URL:
https://github.com/llvm/llvm-project/commit/91223c92f7f7e1a6c074a28de6b5206c22eec116
DIFF:
https://github.com/llvm/llvm-project/commit/91223c92f7f7e1a6c074a28de6b5206c22eec116.diff
bulbazord wrote:
I have no problem with putting things form SymbolFileDWARF into its own
namespace. Let's wait a bit though to see if anyone else has any opinions.
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-comm
bulbazord wrote:
Personally I have no qualms about this. It's just an option that lets you
choose which symbols to export. We already allow exporting every symbol, why
not just some of them? I would be careful though, since we don't guarantee any
stability for lldb_private (including things fr
bulbazord wrote:
> I think we need to make it clear wherever in the build system that the knob
> for turning on these exports lives that you use these symbols at your own
> risk, and we guarantee NO ABI stability for anything but the SB API's. We
> know that on this list but somebody getting t
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/68347
There are only ever 2 FilterRules and their operations are either "regex" or
"match". This does not benefit from deduplication since the strings have static
lifetime and we can just compare StringRefs pointing
https://github.com/bulbazord approved this pull request.
The warnings look good to me, thanks for taking care of that.
How does this look @jimingham?
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/68378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/68347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -162,10 +162,21 @@ lldb::ValueObjectSP lldb_private::formatters::
if (!node_sp || error.Fail())
return nullptr;
- value_sp = node_sp->GetChildMemberWithName("__value_");
hash_sp = node_sp->GetChildMemberWithName("__hash_");
- if (!value_sp |
@@ -252,7 +253,8 @@ class FilterRule {
const bool m_accept;
const size_t m_attribute_index;
- const ConstString m_operation;
+ // The lifetime of m_operation should be static.
bulbazord wrote:
Ah, yeah it is a little confusing now that I look at it. I w
@@ -162,10 +162,21 @@ lldb::ValueObjectSP lldb_private::formatters::
if (!node_sp || error.Fail())
return nullptr;
- value_sp = node_sp->GetChildMemberWithName("__value_");
hash_sp = node_sp->GetChildMemberWithName("__hash_");
- if (!value_sp |
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/68574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -586,6 +586,15 @@ lldb::TemplateArgumentKind
SBType::GetTemplateArgumentKind(uint32_t idx) {
return eTemplateArgumentKindNull;
}
+SBType SBType::FindNestedType(const char *name) {
+ LLDB_INSTRUMENT_VA(this);
bulbazord wrote:
`name` needs to be in the i
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream &strm,
return true;
}
+CompilerType TypeImpl::FindNestedType(ConstString name) {
+ auto type_system = GetTypeSystem(false);
+ auto *symbol_file = type_system->GetSymbolFile();
+ auto decl_context =
@@ -1082,6 +1082,19 @@ bool TypeImpl::GetDescription(lldb_private::Stream &strm,
return true;
}
+CompilerType TypeImpl::FindNestedType(ConstString name) {
+ auto type_system = GetTypeSystem(false);
bulbazord wrote:
Can you add an inline comment for this fa
https://github.com/bulbazord approved this pull request.
I'm alright with this, though I'm a little concerned that the return value of
`ReadCStringFromMemory` and `error.Success()` don't give you the same result.
I'm also somewhat sad that we have to check **both** of those to know if we
succ
https://github.com/bulbazord approved this pull request.
Thanks for taking the time to clean this up, and thanks for taking the time to
make sure this wouldn't hurt us downstream with swift!
https://github.com/llvm/llvm-project/pull/68927
___
lldb-c
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/69231
This function always expects the pointer to be valid, a reference seems more
appropriate.
>From fd70abe32d822be5a791f8650c86ca61a86fa755 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 16 Oct 2023 10:
bulbazord wrote:
> With "lldb-vscode" (which might be "lldb-dap" soon) being a native DAP
> plug-in, I believe this means we can't set settings in the IDE itself if we
> are not a typescript DAP plug-in.
>
> How would anyone specify this extra option when running lldb-vscode? Is there
> a way
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Makes sense to me since this seems to be a relatively common pattern (from the
tests).
Is there anywhere you can begin to use this other than in the tests? Or is this
building up to [your proposal on adding register field info to
lldb-server](https://di
@@ -17,11 +17,17 @@ class RegisterFlags {
public:
class Field {
public:
+/// Where start is the least significant bit and end is the most
+/// significant bit. The start bit must be <= the end bit.
Field(std::string name, unsigned start, unsigned end)
bulbazord wrote:
> There are probably a lot of functions that could be converted from a "Stream
> *" to "Stream &".
Yes, when I have a spare 5-10 minutes I pick a function and convert it. I don't
want to end up with a huge diff that is difficult to merge downstream so I do
it piecemeal.
http
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -280,29 +81,13 @@ void InstrumentationRuntimeASan::Activate() {
if (!process_sp)
return;
- ConstString symbol_name("_ZN6__asanL7AsanDieEv");
- const Symbol *symbol = GetRuntimeModuleSP()->FindFirstSymbolWithNameAndType(
- symbol_name, eSymbolTypeCode);
+ Break
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
bulbazord wrote:
+1
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
https://github.com/bulbazord commented:
Overall looks alright to me. Aside from the inline feedback, I have 2 general
pieces of feedback.
1. It might be easier if you broke this up into 2 separate commits. You're
doing 2 things in 1 commit: Refactoring InstrumentationRuntimeAsan and adding a
n
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 W
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
https://github.com/bulbazord requested changes to this pull request.
Looks fine but it doesn't look like `is_discrete` is being propagated correctly
everywhere?
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits
@@ -16,7 +16,7 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
bulbazord wrote:
You added this parameter but it do
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,5 +37,8 @@ def
test_dwarf_symbol_loading_progress_report_structured_data(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
-message = progress_data.Ge
@@ -16,9 +16,10 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
lldb_private::Debugger *debugger)
-: m_title
https://github.com/bulbazord approved this pull request.
I looked at the implementations and I didn't notice anything too different
either. This brings us from 3 implementations of this logic to 2. Hopefully we
can make it 1 someday soon. 😄
https://github.com/llvm/llvm-project/pull/69531
https://github.com/bulbazord commented:
I was thinking more about this last night, I'm not sure the word "discrete" is
the right word for what this describes. It's not a bad word per se, but if a
ProgressEvent isn't discrete, it's not really "continuous" either (or any of
the other antonyms of
@@ -696,3 +696,55 @@ template <> bool SetNumberFromPyObject(double
&number, PyObject *obj) {
$1 = $input == Py_None;
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+
+// For lldb::SBModuleLocateDwoCallback
+// The `baton` is the actual Python function passed, and
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69517
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback(
return *sb_error_ptr;
}
+
+// `comp_dir` is allowed to be NULL. All other arguments must be valid values.
+static SBError LLDBSwigPythonCallLocateDwoCallback(
+void *baton, const SBFileSpec &ob
@@ -696,3 +696,55 @@ template <> bool SetNumberFromPyObject(double
&number, PyObject *obj) {
$1 = $input == Py_None;
$1 = $1 || PyCallable_Check(reinterpret_cast($input));
}
+
+// For lldb::SBModuleLocateDwoCallback
+// The `baton` is the actual Python function passed, and
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback(
return *sb_error_ptr;
}
+
+// `comp_dir` is allowed to be NULL. All other arguments must be valid values.
+static SBError LLDBSwigPythonCallLocateDwoCallback(
+void *baton, const SBFileSpec &ob
https://github.com/bulbazord commented:
Because SymbolFile is holding onto the function pointer as a static member,
this is a global setting that you can't apply to only just one `SBDebugger`
object. It's an all-or-nothing thing.
Maybe that's what you want, but LLDB already has architectural is
901 - 1000 of 1565 matches
Mail list logo
