Author: Alex Langford
Date: 2023-08-09T15:48:23-07:00
New Revision: 44c876fd75c26482d197a5c5312eac6f43fe
URL:
https://github.com/llvm/llvm-project/commit/44c876fd75c26482d197a5c5312eac6f43fe
DIFF:
https://github.com/llvm/llvm-project/commit/44c876fd75c26482d197a5c5312eac6f43fe.diff
Author: Alex Langford
Date: 2023-08-09T17:10:13-07:00
New Revision: 20c77a5789331956cd47d1804df7885a82094964
URL:
https://github.com/llvm/llvm-project/commit/20c77a5789331956cd47d1804df7885a82094964
DIFF:
https://github.com/llvm/llvm-project/commit/20c77a5789331956cd47d1804df7885a82094964.diff
Author: Alex Langford
Date: 2023-08-09T17:17:18-07:00
New Revision: f2d32ddcec82c20582c6aa32558b82ca7c3d3c50
URL:
https://github.com/llvm/llvm-project/commit/f2d32ddcec82c20582c6aa32558b82ca7c3d3c50
DIFF:
https://github.com/llvm/llvm-project/commit/f2d32ddcec82c20582c6aa32558b82ca7c3d3c50.diff
Author: Alex Langford
Date: 2023-08-10T11:24:40-07:00
New Revision: d21ec35dcf3c351395522807beac0f45b7bcf6b9
URL:
https://github.com/llvm/llvm-project/commit/d21ec35dcf3c351395522807beac0f45b7bcf6b9
DIFF:
https://github.com/llvm/llvm-project/commit/d21ec35dcf3c351395522807beac0f45b7bcf6b9.diff
Author: Alex Langford
Date: 2023-08-14T14:14:48-07:00
New Revision: e634c2f7149392b62e93c1b2b75701a12bc06721
URL:
https://github.com/llvm/llvm-project/commit/e634c2f7149392b62e93c1b2b75701a12bc06721
DIFF:
https://github.com/llvm/llvm-project/commit/e634c2f7149392b62e93c1b2b75701a12bc06721.diff
Author: Alex Langford
Date: 2023-08-14T14:33:08-07:00
New Revision: 69fdbdc4493aacf4d418a063930b39b02b5e18c5
URL:
https://github.com/llvm/llvm-project/commit/69fdbdc4493aacf4d418a063930b39b02b5e18c5
DIFF:
https://github.com/llvm/llvm-project/commit/69fdbdc4493aacf4d418a063930b39b02b5e18c5.diff
Author: Alex Langford
Date: 2023-08-14T15:49:03-07:00
New Revision: 5a25f97e69500d4f65ce0e56027787752c7aab61
URL:
https://github.com/llvm/llvm-project/commit/5a25f97e69500d4f65ce0e56027787752c7aab61
DIFF:
https://github.com/llvm/llvm-project/commit/5a25f97e69500d4f65ce0e56027787752c7aab61.diff
Author: Alex Langford
Date: 2023-08-16T14:23:58-07:00
New Revision: 2f382bfb14e38429e69885406ae8cedc9bb3028e
URL:
https://github.com/llvm/llvm-project/commit/2f382bfb14e38429e69885406ae8cedc9bb3028e
DIFF:
https://github.com/llvm/llvm-project/commit/2f382bfb14e38429e69885406ae8cedc9bb3028e.diff
Author: Alex Langford
Date: 2023-08-17T10:32:23-07:00
New Revision: 90c5675a3db2319dd449a1753c79568355dfaaed
URL:
https://github.com/llvm/llvm-project/commit/90c5675a3db2319dd449a1753c79568355dfaaed
DIFF:
https://github.com/llvm/llvm-project/commit/90c5675a3db2319dd449a1753c79568355dfaaed.diff
Author: Alex Langford
Date: 2023-08-17T10:34:57-07:00
New Revision: 9e6d48ef6085b762d8eb2531bbb481f57446da1c
URL:
https://github.com/llvm/llvm-project/commit/9e6d48ef6085b762d8eb2531bbb481f57446da1c
DIFF:
https://github.com/llvm/llvm-project/commit/9e6d48ef6085b762d8eb2531bbb481f57446da1c.diff
Author: Alex Langford
Date: 2023-08-17T10:44:01-07:00
New Revision: 3415798f7993974a19bd22b0481f2f6a71e4a2ab
URL:
https://github.com/llvm/llvm-project/commit/3415798f7993974a19bd22b0481f2f6a71e4a2ab
DIFF:
https://github.com/llvm/llvm-project/commit/3415798f7993974a19bd22b0481f2f6a71e4a2ab.diff
Author: Alex Langford
Date: 2023-08-21T12:44:17-07:00
New Revision: 58fe7b751dc4a611a013a7708c1c0cac159b5f1e
URL:
https://github.com/llvm/llvm-project/commit/58fe7b751dc4a611a013a7708c1c0cac159b5f1e
DIFF:
https://github.com/llvm/llvm-project/commit/58fe7b751dc4a611a013a7708c1c0cac159b5f1e.diff
Author: Alex Langford
Date: 2023-08-22T10:28:55-07:00
New Revision: edc64d49de92d33e709bcde1db5670ff430f5fad
URL:
https://github.com/llvm/llvm-project/commit/edc64d49de92d33e709bcde1db5670ff430f5fad
DIFF:
https://github.com/llvm/llvm-project/commit/edc64d49de92d33e709bcde1db5670ff430f5fad.diff
Author: Alex Langford
Date: 2023-08-22T10:35:36-07:00
New Revision: a43e23a2141f4fa78940844d810648ff8d40f474
URL:
https://github.com/llvm/llvm-project/commit/a43e23a2141f4fa78940844d810648ff8d40f474
DIFF:
https://github.com/llvm/llvm-project/commit/a43e23a2141f4fa78940844d810648ff8d40f474.diff
Author: Alex Langford
Date: 2023-08-22T10:54:06-07:00
New Revision: ebff12d675aa4db4ee8762c165a387a8d86dd0d5
URL:
https://github.com/llvm/llvm-project/commit/ebff12d675aa4db4ee8762c165a387a8d86dd0d5
DIFF:
https://github.com/llvm/llvm-project/commit/ebff12d675aa4db4ee8762c165a387a8d86dd0d5.diff
Author: Alex Langford
Date: 2023-08-29T16:02:26-07:00
New Revision: 5d49c9ce65881467295fd5ef2022b60d6601e82f
URL:
https://github.com/llvm/llvm-project/commit/5d49c9ce65881467295fd5ef2022b60d6601e82f
DIFF:
https://github.com/llvm/llvm-project/commit/5d49c9ce65881467295fd5ef2022b60d6601e82f.diff
Author: Alex Langford
Date: 2023-08-31T10:55:00-07:00
New Revision: 9ed72d4d4d507b60a54f6b74e86433f837ded93c
URL:
https://github.com/llvm/llvm-project/commit/9ed72d4d4d507b60a54f6b74e86433f837ded93c
DIFF:
https://github.com/llvm/llvm-project/commit/9ed72d4d4d507b60a54f6b74e86433f837ded93c.diff
Author: Alex Langford
Date: 2023-08-31T11:27:59-07:00
New Revision: 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812
URL:
https://github.com/llvm/llvm-project/commit/14d95b26aee0ac0ac8a70252e8a3c7a986e0e812
DIFF:
https://github.com/llvm/llvm-project/commit/14d95b26aee0ac0ac8a70252e8a3c7a986e0e812.diff
Author: Alex Langford
Date: 2023-08-31T15:16:12-07:00
New Revision: 764287f1ad69469cc264bb094e8fcdcfdd0fcdfb
URL:
https://github.com/llvm/llvm-project/commit/764287f1ad69469cc264bb094e8fcdcfdd0fcdfb
DIFF:
https://github.com/llvm/llvm-project/commit/764287f1ad69469cc264bb094e8fcdcfdd0fcdfb.diff
Author: Alex Langford
Date: 2023-09-05T10:53:56-07:00
New Revision: 5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9
URL:
https://github.com/llvm/llvm-project/commit/5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9
DIFF:
https://github.com/llvm/llvm-project/commit/5bff905c0de50ff87b73e6a1e93d0a5b0f38e1a9.diff
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Excellent write up, thanks for taking care of that!
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
bulbazord wrote:
> @bulbazord This would be a good place to put your plugin dependency / const
> string guidance. Or tell me where it lives now and I'll link to it.
Oh, yes! I'd be happy to take care of that after this goes in, thanks for
pointing that out! :)
https://github.com/llvm/llvm-pro
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const
ExecutionContext &exe_ctx) {
return (m_new_value_sp && m_new_value_sp->GetError().Success());
}
+bool Watchpoint::WatchedValueReportable(const ExecutionContext &exe_ctx) {
+ if (!m_watch_modify)
+return tr
@@ -3109,14 +3109,15 @@ static GDBStoppointType GetGDBStoppointType(Watchpoint
*wp) {
assert(wp);
bool watch_read = wp->WatchpointRead();
bool watch_write = wp->WatchpointWrite();
+ bool watch_modify = wp->WatchpointModify();
- // watch_read and watch_write cannot bo
Author: Alex Langford
Date: 2023-09-14T10:19:53-07:00
New Revision: 2f377c5bd713e9ee72faa6a99088bb81358059e3
URL:
https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3
DIFF:
https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3.diff
Author: Alex Langford
Date: 2023-09-14T10:53:39-07:00
New Revision: a5a2a5a3eca06998d9f71186db2ce78ae2716022
URL:
https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022
DIFF:
https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022.diff
bulbazord wrote:
> > ```
> >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> > size, uint32_t access_flags, SBError &error);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > with `eWatchpointAccess{Read,Write,Modify}` f
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/66721
This is a follow-up to 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812. I would have
changed it in that commit, but I don't build the intel-pt plugin so I didn't
see this until later.
>From 5adfbc5bd2c69422a6f03b940
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/66724
Instead of copying memory out of the PythonString (via a std::string) and then
using that to create a ConstString, it would make more sense to just create the
ConstString from the original StringRef in the fir
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/66721
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/66724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I'm aware this has broken the build, working on it. Thanks for your patience.
https://github.com/llvm/llvm-project/pull/66724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Author: Alex Langford
Date: 2023-09-19T10:56:13-07:00
New Revision: f1097e88d22511f3ec96386ca165b75bb75aaa7a
URL:
https://github.com/llvm/llvm-project/commit/f1097e88d22511f3ec96386ca165b75bb75aaa7a
DIFF:
https://github.com/llvm/llvm-project/commit/f1097e88d22511f3ec96386ca165b75bb75aaa7a.diff
bulbazord wrote:
Fixed with `f1097e88d22511f3ec96386ca165b75bb75aaa7a`.
https://github.com/llvm/llvm-project/pull/66724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2023-09-19T17:39:22-07:00
New Revision: b927490d73eebe0a7e8071047d79a330145b0488
URL:
https://github.com/llvm/llvm-project/commit/b927490d73eebe0a7e8071047d79a330145b0488
DIFF:
https://github.com/llvm/llvm-project/commit/b927490d73eebe0a7e8071047d79a330145b0488.diff
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/67055
GetObjectPointer (and other related methods) do not need `ConstString`
parameters. The string parameter in these methods boil down to getting a
StringRef and calling `StackFrame::GetValueForVariableExpressionP
https://github.com/bulbazord approved this pull request.
Makes sense to me, if we're defining a lot of the methods for these classes in
implementation files, we should do the same for constructors and destructors
too.
https://github.com/llvm/llvm-project/pull/67165
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/67055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/67190
I want to work towards unifying the implementations. It would be a lot easier
to do if LLDB's DWARFDebugAbbrev looked more similar to LLVM's implementation,
so this change moves in that direction.
>From 16e6a
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
bulbazord wrote:
Concretely, you can revert the first commit and push that so that your branch
has your first commit, second commit, and a revert commit for the first one. As
Walter said, it should squash down and resolve correctly.
https:
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
bulbazord wrote:
You also may want to change the title of your PR to reflect the actual change
you'll be making as well. When you squash and merge, you'll have an opportunity
to rewrite the commit message to more accurately reflect what you
@@ -935,6 +935,16 @@ lldb_private::Address
ObjectFileELF::GetEntryPointAddress() {
}
Address ObjectFileELF::GetBaseAddress() {
+ if (GetType() == ObjectFile::eTypeObjectFile) {
+for (SectionHeaderCollIter I = std::next(m_section_headers.begin());
+ I != m_section
@@ -0,0 +1,165 @@
+#ifndef
LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H
bulbazord wrote:
This file needs a license header.
https://github.com/llvm/llvm-project/pull/67106
___
lldb-comm
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/67106
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/67190
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
I echo Jim's sentiments here, not sure if this is the right way to go about it.
Independent of that, I have one concern about the implementation and a few
minor points.
https://github.com/llvm/llvm-project/pull/67309
@@ -1535,7 +1535,12 @@ bool ValueObject::SetValueFromCString(const char
*value_str, Status &error) {
}
} else {
// We don't support setting things bigger than a scalar at present.
-error.SetErrorString("unable to write aggregate data type");
+// But maybe our
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/67309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -75,6 +77,10 @@ class SyntheticChildrenFrontEnd {
// display purposes
virtual ConstString GetSyntheticTypeName() { return ConstString(); }
+ virtual bool SetValueFromCString(const char *value_str, Status &error) {
+return false;
+ }
+
bulbazord wr
@@ -34,7 +34,9 @@ class SyntheticChildrenFrontEnd {
public:
SyntheticChildrenFrontEnd(ValueObject &backend)
- : m_backend(backend), m_valid(true) {}
+ : m_backend(backend), m_valid(true) {
+backend.SetSyntheticFrontend(this);
+ }
bulbazord wro
@@ -0,0 +1,770 @@
+#include "lldb/Breakpoint/StoppointCallbackContext.h"
+#include "lldb/Core/Debugger.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/ModuleSpec.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Section.h"
+#include "lldb/Core/StreamFile.h"
+#in
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/67579
The LLVM implementation of DWARFDebugAbbrev does not have a way of listing all
the DW_FORM values that have been parsed but are unsupported or otherwise
unknown. AFAICT this functionality does not exist in LLV
https://github.com/bulbazord commented:
Overall I think this is fine, just a few comments here or there. I like the
idea a lot, thanks for working on this.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@list
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,65 @@
+//===-- ValueObjectVTable.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,325 @@
+//===-- ValueObjectVTable.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM, thanks!
Please fix the python formatting before landing.
https://github.com/llvm/llvm-project/pull/67621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/67579
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/67841
The implementations are now close enough that replacing it is trivial.
>From 8913eb7f4c768545debf12dd42f2e308466f200b Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 29 Sep 2023 11:09:09 -0700
Subject:
bulbazord wrote:
> This LGTM!
>
> I don't think I can see far enough ahead on what you are planning here, but I
> was just wondering if the ultimate goal is to have the `option_arg.getAsT`
> return an `Expected`. In this case, wouldn't all these arguments (short
> option, long option, additio
bulbazord wrote:
> > > This LGTM!
> > > I don't think I can see far enough ahead on what you are planning here,
> > > but I was just wondering if the ultimate goal is to have the
> > > `option_arg.getAsT` return an `Expected`. In this case, wouldn't all
> > > these arguments (short option, lon
https://github.com/bulbazord approved this pull request.
I did a quick manual inspection of all of them, the transformation produced by
Teyit looks correct to me. I did notice a few places where we were doing
convoluted checks (I left a comment on one) but those should be addressed in
follow-u
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/82503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -456,8 +457,9 @@ def queues_with_libBacktraceRecording(self):
"doing_the_work_2",
"queue 2's pending item #0 should be doing_the_work_2",
)
-self.assertTrue(
-queue_performer_2.GetPendingItemAtIndex().IsValid() == False
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/82273
>From 790810f9318c7947fe2edd187f60425a85c949b5 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 15 Feb 2024 17:39:42 -0800
Subject: [PATCH 1/2] [lldb] Standardize command option parsing error messages
I
bulbazord wrote:
I've added a doxygen comment to the new function I introduced. I plan on
landing this later today if there are no objections.
https://github.com/llvm/llvm-project/pull/82273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/bulbazord approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/82526
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/82273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
https://github.com/bulbazord approved this pull request.
LGTM, seems like a good fix. One question/suggestion.
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
🥳
Please wait a little bit for others to look. Thanks for taking care of this!
https://github.com/llvm/llvm-project/pull/82670
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/bulbazord approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3944,15 +3955,22 @@ rnb_err_t RNBRemote::HandlePacket_v(const char *p) {
// The order of these checks is important.
if (process_does_not_exist (pid_attaching_to)) {
DNBLogError("Tried to attach to pid that doesn't exist");
- std::string
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83086
This updates the remaining SetOptionValue methods in CommandObjectBreakpoint to
use CreateOptionParsingError.
I found a few minor bugs that were fixed during this refactor (e.g. using the
wrong flag in an err
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/83086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM
@JDevlieghere @adrian-prantl we should consider adding this to the list of
required python modules on our bots too and enforce it with
`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? Probably not in this PR, but after we
can get our bots
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/83317
This specifically addresses the warnings:
$LLVM/lldb/include/lldb/API/SBCommandReturnObject.h:119: Warning 509:
Overloaded method lldb::SBCommandReturnObject::PutCString(char const *)
effectively ignored, $LLV
https://github.com/bulbazord approved this pull request.
:)
https://github.com/llvm/llvm-project/pull/83330
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83341
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Thinkos are the most insidious bugs. Nice catch.
https://github.com/llvm/llvm-project/pull/83350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
@DavidSpickett If you haven't already, might I suggest looking into a CMake
setting I implemented last year? `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` --
this will cause your CMake configure step to fail if your bots are missing
python packages so that you know your bots are run
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Looks great!!! 😄 Thanks for fixing the bug and gardening!
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
401 - 500 of 1568 matches
Mail list logo
