[Lldb-commits] [lldb] r333299 - Fix typo in CMake comments

2018-05-25 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri May 25 11:59:21 2018 New Revision: 333299 URL: http://llvm.org/viewvc/llvm-project?rev=333299&view=rev Log: Fix typo in CMake comments Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake URL: http://llvm.o

[Lldb-commits] [lldb] r333304 - Move SystemInitializerFull header to source/API

2018-05-25 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri May 25 13:28:16 2018 New Revision: 04 URL: http://llvm.org/viewvc/llvm-project?rev=04&view=rev Log: Move SystemInitializerFull header to source/API Summary: It seems to me that files in include/lldb/API/ are headers that should be exposed to liblldb users. Becaus

[Lldb-commits] [lldb] r333322 - Fix Xcode build broken by SystemInitializerFull.h move

2018-05-25 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri May 25 16:21:07 2018 New Revision: 22 URL: http://llvm.org/viewvc/llvm-project?rev=22&view=rev Log: Fix Xcode build broken by SystemInitializerFull.h move Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r333444 - Remove lldb-private headers when building LLDB.framework with CMake

2018-05-29 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue May 29 11:09:09 2018 New Revision: 333444 URL: http://llvm.org/viewvc/llvm-project?rev=333444&view=rev Log: Remove lldb-private headers when building LLDB.framework with CMake Summary: Generating LLDB.framework when building with CMake+Ninja will copy the lldb-private he

[Lldb-commits] [lldb] r333777 - Add dependency on clang-headers when building LLDB.framework using CMake

2018-06-01 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jun 1 11:14:49 2018 New Revision: 333777 URL: http://llvm.org/viewvc/llvm-project?rev=333777&view=rev Log: Add dependency on clang-headers when building LLDB.framework using CMake Summary: The LLDB.framework generated when building with CMake + Ninja/Make is completely

[Lldb-commits] [lldb] r333968 - Change SWIG output directory when building LLDB.framework with CMake

2018-06-04 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Jun 4 16:47:36 2018 New Revision: 333968 URL: http://llvm.org/viewvc/llvm-project?rev=333968&view=rev Log: Change SWIG output directory when building LLDB.framework with CMake Instead of assuming that SWIG generated files (e.g. lldb.py) will live in scripts, we should s

[Lldb-commits] [lldb] r334219 - Check for process_vm_readv using CheckSymbolExists

2018-06-07 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jun 7 12:53:25 2018 New Revision: 334219 URL: http://llvm.org/viewvc/llvm-project?rev=334219&view=rev Log: Check for process_vm_readv using CheckSymbolExists Instead of checking if code compiles, I think it is a better to check if the symbol exists. This is simpler and

[Lldb-commits] [lldb] r334225 - Remove commented out line from top-level CMakeLists.txt

2018-06-07 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jun 7 13:17:46 2018 New Revision: 334225 URL: http://llvm.org/viewvc/llvm-project?rev=334225&view=rev Log: Remove commented out line from top-level CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt Modified: lldb/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/l

[Lldb-commits] [lldb] r334320 - Delete some dead code

2018-06-08 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jun 8 14:13:26 2018 New Revision: 334320 URL: http://llvm.org/viewvc/llvm-project?rev=334320&view=rev Log: Delete some dead code Modified: lldb/trunk/source/Host/macosx/Host.mm lldb/trunk/tools/debugserver/source/RNBRemote.cpp lldb/trunk/tools/driver/Driver.

[Lldb-commits] [lldb] r334333 - Delete dead code in NativeProcessLinux

2018-06-08 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jun 8 15:14:29 2018 New Revision: 334333 URL: http://llvm.org/viewvc/llvm-project?rev=334333&view=rev Log: Delete dead code in NativeProcessLinux As far as I can tell, this code has always been guarded by `#if 0`. If this is useful code, it can be added back. Modified:

[Lldb-commits] [lldb] r334336 - Remove more dead code from NativeProcessLinux

2018-06-08 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jun 8 15:28:41 2018 New Revision: 334336 URL: http://llvm.org/viewvc/llvm-project?rev=334336&view=rev Log: Remove more dead code from NativeProcessLinux This should have been removed in r334333. Modified: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.h

[Lldb-commits] [lldb] r334968 - Introduce lldb-framework CMake target and centralize its logic

2018-06-18 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Jun 18 11:27:16 2018 New Revision: 334968 URL: http://llvm.org/viewvc/llvm-project?rev=334968&view=rev Log: Introduce lldb-framework CMake target and centralize its logic Summary: In this patch I aim to do the following: 1) Create an lldb-framework target that acts as t

[Lldb-commits] [lldb] r335014 - Fix up Info.plist when building LLDB.framework with CMake

2018-06-18 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Jun 18 19:59:30 2018 New Revision: 335014 URL: http://llvm.org/viewvc/llvm-project?rev=335014&view=rev Log: Fix up Info.plist when building LLDB.framework with CMake Summary: We weren't using the Info.plist template in resources previously. When using that template, some

[Lldb-commits] [lldb] r336395 - [CMake] Simplify a few framework build rules

2018-07-05 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jul 5 15:16:15 2018 New Revision: 336395 URL: http://llvm.org/viewvc/llvm-project?rev=336395&view=rev Log: [CMake] Simplify a few framework build rules Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake Modified: lldb/trunk/cmake/modules/LLDBFramework.cmake URL

[Lldb-commits] [lldb] r337202 - [CMake] Give lldb tools functional install targets when building LLDB.framework

2018-07-16 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Jul 16 12:19:56 2018 New Revision: 337202 URL: http://llvm.org/viewvc/llvm-project?rev=337202&view=rev Log: [CMake] Give lldb tools functional install targets when building LLDB.framework Summary: This change makes the install targets for lldb tools functional when build

[Lldb-commits] [lldb] r337311 - Invert dependency between lldb-framework and lldb-suite

2018-07-17 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Jul 17 11:28:51 2018 New Revision: 337311 URL: http://llvm.org/viewvc/llvm-project?rev=337311&view=rev Log: Invert dependency between lldb-framework and lldb-suite Summary: Currently, if you build lldb-framework the entire framework doesn't actually build. In order to bu

[Lldb-commits] [lldb] r338058 - Make framework-header-fix process copied headers

2018-07-26 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jul 26 12:04:46 2018 New Revision: 338058 URL: http://llvm.org/viewvc/llvm-project?rev=338058&view=rev Log: Make framework-header-fix process copied headers Summary: Previously the framework-header-fix script would change the sources before they were copied, leading to u

[Lldb-commits] [lldb] r338074 - Add back lldb-framework-headers target

2018-07-26 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jul 26 14:55:14 2018 New Revision: 338074 URL: http://llvm.org/viewvc/llvm-project?rev=338074&view=rev Log: Add back lldb-framework-headers target In r338058 we removed the target `lldb-framework-headers`, which mean lldb-framework no longer depended on `framework_header

[Lldb-commits] [lldb] r338154 - Stop building liblldb with CMake's framework functionality

2018-07-27 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jul 27 12:41:17 2018 New Revision: 338154 URL: http://llvm.org/viewvc/llvm-project?rev=338154&view=rev Log: Stop building liblldb with CMake's framework functionality Summary: CMake has a bug in its ninja generator that prevents you from installing targets that are built

[Lldb-commits] [lldb] r338178 - Revert "Stop building liblldb with CMake's framework functionality"

2018-07-27 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jul 27 16:38:58 2018 New Revision: 338178 URL: http://llvm.org/viewvc/llvm-project?rev=338178&view=rev Log: Revert "Stop building liblldb with CMake's framework functionality" This reverts r338154. This change is actually unnecessary, as the CMake bug I referred to was a

[Lldb-commits] [lldb] r338594 - Introduce install-lldb-framework target

2018-08-01 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Wed Aug 1 10:21:18 2018 New Revision: 338594 URL: http://llvm.org/viewvc/llvm-project?rev=338594&view=rev Log: Introduce install-lldb-framework target Summary: Previously, I thought that install-liblldb would fail because CMake had a bug related to installing frameworks. In

[Lldb-commits] [lldb] r338923 - Modify lldb_suite.py to enable python debugging

2018-08-03 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Aug 3 14:37:01 2018 New Revision: 338923 URL: http://llvm.org/viewvc/llvm-project?rev=338923&view=rev Log: Modify lldb_suite.py to enable python debugging Summary: pudb and pdb interfere with the behavior of the inspect module. calling `inspect.getfile(inspect.currentfr

[Lldb-commits] [lldb] r339155 - Add instructions for building LLDB on Mac OS X with CMake

2018-08-07 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Aug 7 10:34:13 2018 New Revision: 339155 URL: http://llvm.org/viewvc/llvm-project?rev=339155&view=rev Log: Add instructions for building LLDB on Mac OS X with CMake Summary: There were previously no instructions for building LLDB on Mac OS X with CMake. It's sufficientl

[Lldb-commits] [lldb] r339959 - Remove outdated TODOs in RegisterValue

2018-08-16 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Aug 16 15:48:46 2018 New Revision: 339959 URL: http://llvm.org/viewvc/llvm-project?rev=339959&view=rev Log: Remove outdated TODOs in RegisterValue These TODOs were for setting m_type in RegisterValue::SetValueFromString in the case where reg_info's encoding was eEncoding

[Lldb-commits] [lldb] r339965 - Remove commented out constructor from Scalar

2018-08-16 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Aug 16 16:23:18 2018 New Revision: 339965 URL: http://llvm.org/viewvc/llvm-project?rev=339965&view=rev Log: Remove commented out constructor from Scalar This appears to have been commented out since the initial checkin of lldb. Modified: lldb/trunk/source/Utility/Sc

[Lldb-commits] [lldb] r340560 - [cmake] Add option to skip building lldb-server

2018-08-23 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Aug 23 11:05:45 2018 New Revision: 340560 URL: http://llvm.org/viewvc/llvm-project?rev=340560&view=rev Log: [cmake] Add option to skip building lldb-server Summary: There is currently a way to skip the debugserver build. See how the CMake variables SKIP_DEBUGSERVER and L

[Lldb-commits] [lldb] r342066 - Add compatibility version to liblldb in framework builds

2018-09-12 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Wed Sep 12 11:10:22 2018 New Revision: 342066 URL: http://llvm.org/viewvc/llvm-project?rev=342066&view=rev Log: Add compatibility version to liblldb in framework builds Summary: Building LLDB with xcodebuild sets the compatibility version of liblldb in LLDB.framework. Buildi

[Lldb-commits] [lldb] r342266 - Fix lldb-vscode README.md

2018-09-14 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Sep 14 12:41:20 2018 New Revision: 342266 URL: http://llvm.org/viewvc/llvm-project?rev=342266&view=rev Log: Fix lldb-vscode README.md Summary: The readme was missing "-" characters to enable links Patch by Nathan Lanza Differential Revision: https://reviews.llvm.org/D

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

2017-10-25 Thread Alex Langford via lldb-commits
$ nm /lib64/libm.so.6| grep " a$" 00093bb0 r a 000c6a80 r a 00093bb0 r a No, they are internal to libm only. Alex On 10/25/17, 4:15 PM, "Greg Clayton" wrote: Not hard. Just find a test that has a shared library and copy it. Modify the shared library to create a sy

[Lldb-commits] [lldb] r351263 - [debugserver][CMake] Remove commented out line

2019-01-15 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Jan 15 14:27:59 2019 New Revision: 351263 URL: http://llvm.org/viewvc/llvm-project?rev=351263&view=rev Log: [debugserver][CMake] Remove commented out line This has been commented out since rL300111 (commit d742d081f3a1e7412cc609765139ba32d597ac15). Looks like it was comm

[Lldb-commits] [lldb] r351276 - [lldb-mi] Remove use of dialog box

2019-01-15 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Jan 15 16:09:50 2019 New Revision: 351276 URL: http://llvm.org/viewvc/llvm-project?rev=351276&view=rev Log: [lldb-mi] Remove use of dialog box Summary: This really is only implemented on Windows, and it requires us to pull in User32. This was only useful when debugging o

[Lldb-commits] [lldb] r351496 - [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds

2019-01-17 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jan 17 15:14:04 2019 New Revision: 351496 URL: http://llvm.org/viewvc/llvm-project?rev=351496&view=rev Log: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds Summary: The flags `LLDB_USE_SYSTEM_DEBUGSERVER` and `LLDB_NO_DEBUGSERVER` w

[Lldb-commits] [lldb] r351498 - [CMake] Only test debugserver if platform can use debugserver

2019-01-17 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jan 17 16:05:25 2019 New Revision: 351498 URL: http://llvm.org/viewvc/llvm-project?rev=351498&view=rev Log: [CMake] Only test debugserver if platform can use debugserver In commit svn r351496 I changed this condition from `if(LLDB_CAN_USE_DEBUGSERVER)` to `if(NOT SKIP_TE

[Lldb-commits] [lldb] r351863 - [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

2019-01-22 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Jan 22 11:26:42 2019 New Revision: 351863 URL: http://llvm.org/viewvc/llvm-project?rev=351863&view=rev Log: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages Summary: I did this for two reasons: - Using the CMake packages simplifies building LLDB Stan

[Lldb-commits] [lldb] r352078 - [CMake] Remove duplicated cache variable. NFC.

2019-01-24 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Jan 24 10:52:19 2019 New Revision: 352078 URL: http://llvm.org/viewvc/llvm-project?rev=352078&view=rev Log: [CMake] Remove duplicated cache variable. NFC. Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake

[Lldb-commits] [lldb] r352235 - [CMake] Use llvm-tblgen from NATIVE LLVM build when cross-compiling

2019-01-25 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Jan 25 11:38:21 2019 New Revision: 352235 URL: http://llvm.org/viewvc/llvm-project?rev=352235&view=rev Log: [CMake] Use llvm-tblgen from NATIVE LLVM build when cross-compiling Summary: When cross-compiling LLDB, we want to use llvm-tblgen built for the host, not the targ

[Lldb-commits] [lldb] r354526 - Merge target triple into module triple when constructing module from memory

2019-02-20 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Wed Feb 20 15:12:56 2019 New Revision: 354526 URL: http://llvm.org/viewvc/llvm-project?rev=354526&view=rev Log: Merge target triple into module triple when constructing module from memory Summary: While debugging an android process remotely from a windows machine, I noticed

[Lldb-commits] [lldb] r354933 - [Utility] Remove Triple{Environment, OS, Vendor}IsUnspecifiedUnknown from ArchSpec

2019-02-26 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Feb 26 15:50:19 2019 New Revision: 354933 URL: http://llvm.org/viewvc/llvm-project?rev=354933&view=rev Log: [Utility] Remove Triple{Environment,OS,Vendor}IsUnspecifiedUnknown from ArchSpec Summary: These functions should always return the opposite of the `Triple{Environm

[Lldb-commits] [lldb] r354938 - [Utility] Fix ArchSpec.MergeFrom to correctly merge environments

2019-02-26 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Feb 26 16:47:39 2019 New Revision: 354938 URL: http://llvm.org/viewvc/llvm-project?rev=354938&view=rev Log: [Utility] Fix ArchSpec.MergeFrom to correctly merge environments Summary: This behavior was originally added in rL252264 (git commit 76a7f365da) in order to be ext

[Lldb-commits] [lldb] r355149 - [CMake] Make liblldb depend on clang-headers

2019-02-28 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Feb 28 14:24:18 2019 New Revision: 355149 URL: http://llvm.org/viewvc/llvm-project?rev=355149&view=rev Log: [CMake] Make liblldb depend on clang-headers Summary: The clang headers are useful when dealing with clang modules. There is also a way to get to the clang headers

[Lldb-commits] [lldb] r355341 - [build.py] Allow clang-cl to build files starting with '/U'

2019-03-04 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Mar 4 13:36:49 2019 New Revision: 355341 URL: http://llvm.org/viewvc/llvm-project?rev=355341&view=rev Log: [build.py] Allow clang-cl to build files starting with '/U' Summary: clang-cl tries to match cl's interface, and treats /U as "Removes a predefined macro" as cl do

[Lldb-commits] [lldb] r355375 - [Expression] Remove unused parameter from Evaluate

2019-03-04 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Mar 4 19:33:34 2019 New Revision: 355375 URL: http://llvm.org/viewvc/llvm-project?rev=355375&view=rev Log: [Expression] Remove unused parameter from Evaluate Modified: lldb/trunk/include/lldb/Expression/UserExpression.h lldb/trunk/source/Expression/REPL.cpp

[Lldb-commits] [lldb] r355463 - [ExpressionParser] Test GetClangResourceDir

2019-03-05 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Mar 5 16:45:16 2019 New Revision: 355463 URL: http://llvm.org/viewvc/llvm-project?rev=355463&view=rev Log: [ExpressionParser] Test GetClangResourceDir Summary: I'm doing this because I plan on implementing `ComputeClangResourceDirectory` on windows so that `GetClangReso

[Lldb-commits] [lldb] r355471 - [ExpressionParser] Fix ComputeClangResourceDirectory for windows

2019-03-05 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Mar 5 17:57:04 2019 New Revision: 355471 URL: http://llvm.org/viewvc/llvm-project?rev=355471&view=rev Log: [ExpressionParser] Fix ComputeClangResourceDirectory for windows The function signature of ComputeClangResourceDirectory for windows wasn't updated when the others

[Lldb-commits] [lldb] r355575 - Repair the build when LLDB_DISABLE_PYTHON is set

2019-03-06 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Wed Mar 6 17:02:55 2019 New Revision: 355575 URL: http://llvm.org/viewvc/llvm-project?rev=355575&view=rev Log: Repair the build when LLDB_DISABLE_PYTHON is set Summary: If LLDB_DISABLE_PYTHON is set, some functions are unavailable but SBReproducer assumes they are. Let's co

[Lldb-commits] [lldb] r355631 - [ExpressionParser] Implement ComputeClangResourceDir for Windows

2019-03-07 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Mar 7 12:09:15 2019 New Revision: 355631 URL: http://llvm.org/viewvc/llvm-project?rev=355631&view=rev Log: [ExpressionParser] Implement ComputeClangResourceDir for Windows Summary: This function is useful for expression evaluation, especially when doing swift debugging

[Lldb-commits] [lldb] r355648 - Fix TestPaths.py on windows

2019-03-07 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Thu Mar 7 14:37:23 2019 New Revision: 355648 URL: http://llvm.org/viewvc/llvm-project?rev=355648&view=rev Log: Fix TestPaths.py on windows I committed an implementation of GetClangResourceDir on windows but forgot to update this test. I merged the tests like I intended to,

[Lldb-commits] [lldb] r355875 - Rewrite comment to be clearer

2019-03-11 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Mar 11 15:49:36 2019 New Revision: 355875 URL: http://llvm.org/viewvc/llvm-project?rev=355875&view=rev Log: Rewrite comment to be clearer Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangHost.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Cl

[Lldb-commits] [lldb] r356079 - [ExpressionParser] Restore removed intance of FileSystem::Resolve while resolving clang resource dir

2019-03-13 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Wed Mar 13 11:51:22 2019 New Revision: 356079 URL: http://llvm.org/viewvc/llvm-project?rev=356079&view=rev Log: [ExpressionParser] Restore removed intance of FileSystem::Resolve while resolving clang resource dir I committed a change that removed this line, but I meant to r

[Lldb-commits] [lldb] r356412 - [CMake] Set LLVM_DEFAULT_EXTERNAL_LIT in standalone build correctly on windows

2019-03-18 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Mon Mar 18 14:32:31 2019 New Revision: 356412 URL: http://llvm.org/viewvc/llvm-project?rev=356412&view=rev Log: [CMake] Set LLVM_DEFAULT_EXTERNAL_LIT in standalone build correctly on windows LLVM installed llvm-lit with a .py suffix on windows. Let's match that behavior here

[Lldb-commits] [lldb] r357030 - [ExpressionParser] Add swift-lldb case for finding clang resource dir

2019-03-26 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Mar 26 14:00:42 2019 New Revision: 357030 URL: http://llvm.org/viewvc/llvm-project?rev=357030&view=rev Log: [ExpressionParser] Add swift-lldb case for finding clang resource dir Summary: I'm adding this to reduce the difference between swift-lldb and llvm.org's lldb. Re

[Lldb-commits] [lldb] r357817 - [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

2019-04-05 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Fri Apr 5 14:01:50 2019 New Revision: 357817 URL: http://llvm.org/viewvc/llvm-project?rev=357817&view=rev Log: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds Summary: This line is unnecessary because add_llvm_executable will handle linking the correct LL

[Lldb-commits] [lldb] r358530 - [Process] Fix linux arm64 single step compilation failure

2019-04-16 Thread Alex Langford via lldb-commits
Author: xiaobai Date: Tue Apr 16 14:21:28 2019 New Revision: 358530 URL: http://llvm.org/viewvc/llvm-project?rev=358530&view=rev Log: [Process] Fix linux arm64 single step compilation failure This was updated in r356703 to use llvm::sys::RetryAfterSignal, which comes from llvm/Support/Errno.h. Th

[Lldb-commits] [lldb] [lldb] Parse and display register field enums (PR #95768)

2024-06-28 Thread Alex Langford via lldb-commits
@@ -4179,21 +4179,124 @@ struct GdbServerTargetInfo { RegisterSetMap reg_set_map; }; -static std::vector ParseFlagsFields(XMLNode flags_node, - unsigned size) { +static FieldEnum::Enumerators ParseEnumEvalues(const XML

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Can't say I know a ton about FreeBSD but this looks fine to me. I left one suggestion but I would recommend getting a sign-off from one of the FreeBSD folks. https://github.com/llvm/llvm-project/pull/85058 ___

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-28 Thread Alex Langford via lldb-commits
@@ -18,9 +18,9 @@ namespace lldb_private { struct RegisterInfo; /// This class manages the storage and detection of register field information -/// for Arm64 Linux registers. The same register may have different fields on -/// different CPUs. This class abstracts out the field

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/97262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -0,0 +1,70 @@ +from abc import abstractmethod bulbazord wrote: This is an entire scripting interface. Maybe a separate PR would be more appropriate? Seems like you're doing multiple things here. https://github.com/llvm/llvm-project/pull/97262 ___

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -25,10 +25,17 @@ if (LLDB_ENABLE_PYTHON AND SPHINX_FOUND) # Pretend that the SWIG generated API is a Python package. file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lldb) get_target_property(lldb_bindings_dir swig_wrapper_python BINARY_DIR) + bul

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I know you've been thinking about and working on this for a while, so glad to see it come together like this! 😃 https://github.com/llvm/llvm-project/pull/97262 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -0,0 +1,36 @@ +Python Extensions += + +LLDB provides many scriptable extensions to augment the debugger capabilities +and give the ability to the user to tailor their experience to their own needs. + +This page describes some of these scripting extension: --

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -0,0 +1,36 @@ +Python Extensions += + +LLDB provides many scriptable extensions to augment the debugger capabilities +and give the ability to the user to tailor their experience to their own needs. bulbazord wrote: Suggestion: `LLDB provides sc

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -10,9 +10,6 @@ class ScriptedPlatform(metaclass=ABCMeta): Most of the base class methods are `@abstractmethod` that need to be overwritten by the inheriting class. - -DISCLAIMER: THIS INTERFACE IS STILL UNDER DEVELOPMENT AND NOT STABLE. -THE METH

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -0,0 +1,36 @@ +Python Extensions += + +LLDB provides many scriptable extensions to augment the debugger capabilities +and give the ability to the user to tailor their experience to their own needs. + +This page describes some of these scripting extension: + +Ope

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting run` (PR #97263)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -518,6 +518,15 @@ void CommandInterpreter::Initialize() { AddAlias("re", cmd_obj_sp); } + cmd_obj_sp = GetCommandSPExact("scripting execute"); + if (cmd_obj_sp) { +AddAlias("sc", cmd_obj_sp); +AddAlias("scr", cmd_obj_sp); +AddAlias("scri", cmd_obj_sp); +

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -127,6 +130,171 @@ class CommandObjectScriptingRun : public CommandObjectRaw { CommandOptions m_options; }; +#pragma mark CommandObjectScriptingTemplateList + +#define LLDB_OPTIONS_scripting_template_list +#include "CommandOptions.inc" + +class CommandObjectScriptingTemp

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly) set(LLDB_STRIPPED_PLUGINS) get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS) +get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS) +list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS}) --

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-07-02 Thread Alex Langford via lldb-commits
bulbazord wrote: Yes, looks good to me. Thanks for taking the time! :) https://github.com/llvm/llvm-project/pull/96685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/docs] Add scripting extensions documentation to the website (PR #97262)

2024-07-02 Thread Alex Langford via lldb-commits
@@ -0,0 +1,36 @@ +Python Extensions += + +LLDB provides many scriptable extensions to augment the debugger capabilities +and give the ability to the user to tailor their experience to their own needs. + +This page describes some of these scripting extension: + +Ope

[Lldb-commits] [lldb] [lldb][AArch64] Add register field enum information (PR #96887)

2024-07-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, seems like the natural progression of this work. :) https://github.com/llvm/llvm-project/pull/96887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb] Add scripted thread plan python base class to lldb & website (PR #97481)

2024-07-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/97481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return optional from getHostCPUFeatures (PR #97824)

2024-07-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: >From an API standpoint, there doesn't actually seem to be a huge difference >between an empty StringMap and an optional with an empty string map in it >right? Why not return a map every time? https://github.com/llvm/llvm-project/pull/97824 _

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-05 Thread Alex Langford via lldb-commits
@@ -29,6 +29,9 @@ add_subdirectory(UnwindAssembly) set(LLDB_STRIPPED_PLUGINS) get_property(LLDB_ALL_PLUGINS GLOBAL PROPERTY LLDB_PLUGINS) +get_property(LLDB_EXTRA_PLUGINS GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS) +list(APPEND LLDB_ALL_PLUGINS ${LLDB_EXTRA_PLUGINS}) --

[Lldb-commits] [lldb] [lldb/Commands] Add `scripting template list` command with auto discovery (PR #97273)

2024-07-05 Thread Alex Langford via lldb-commits
@@ -19,6 +19,12 @@ if (LLDB_ENABLE_LIBEDIT) list(APPEND LLDB_LIBEDIT_LIBS LibEdit::LibEdit) endif() +set_property(GLOBAL PROPERTY LLDB_EXTRA_SCRIPT_PLUGINS + lldbPluginOperatingSystemPythonInterface + lldbPluginScriptedProcessPythonInterface + lldbPluginScriptedThreadPlan

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-08 Thread Alex Langford via lldb-commits
@@ -58,10 +58,17 @@ DAP::DAP() DAP::~DAP() = default; +/// Return string with first character capitalized. +static std::string capitalize(llvm::StringRef str) { + if (str.empty()) +return ""; + return ((llvm::Twine)llvm::toUpper(str[0]) + str.drop_front()).str(); +} +

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-08 Thread Alex Langford via lldb-commits
@@ -26,3 +26,43 @@ SBLanguageRuntime::GetNameForLanguageType(lldb::LanguageType language) { return Language::GetNameForLanguageType(language); } + +bool SBLanguageRuntime::LanguageIsCPlusPlus(lldb::LanguageType language) { + return Language::LanguageIsCPlusPlus(language);

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-08 Thread Alex Langford via lldb-commits
@@ -80,6 +87,46 @@ void DAP::PopulateExceptionBreakpoints() { exception_breakpoints->emplace_back("swift_throw", "Swift Throw", lldb::eLanguageTypeSwift); } +// Besides handling the hardcoded list of languages from above,

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-08 Thread Alex Langford via lldb-commits
@@ -80,6 +87,46 @@ void DAP::PopulateExceptionBreakpoints() { exception_breakpoints->emplace_back("swift_throw", "Swift Throw", lldb::eLanguageTypeSwift); } +// Besides handling the hardcoded list of languages from above,

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

2024-07-08 Thread Alex Langford via lldb-commits
@@ -287,7 +287,7 @@ Status PlatformAndroid::DownloadModuleSlice(const FileSpec &src_file_spec, static constexpr llvm::StringLiteral k_zip_separator("!/"); size_t pos = source_file.find(k_zip_separator); if (pos != std::string::npos) -source_file = source_file.substr(

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

2024-07-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/98089 Fixes https://github.com/llvm/llvm-project/issues/97511 >From 31b3d4db2389dd4bd72b54618ba12c86f51fe02f Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Mon, 8 Jul 2024 13:24:49 -0700 Subject: [PATCH] [lldb]

[Lldb-commits] [lldb] [lldb] Correct invalid format style (PR #98089)

2024-07-08 Thread Alex Langford via lldb-commits
bulbazord wrote: This is the exact same PR as https://github.com/apple/llvm-project/pull/8952 (on apple's LLVM fork). It should have gone here first. https://github.com/llvm/llvm-project/pull/98089 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/97871 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Seems okay to me, but I'm not exactly an expert when it comes to lldb-dap. You'll probably want to get sign-off from at least another person. https://github.com/llvm/llvm-project/pull/97871 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-09 Thread Alex Langford via lldb-commits
@@ -18,6 +18,32 @@ class SBLanguageRuntime { static lldb::LanguageType GetLanguageTypeFromString(const char *string); static const char *GetNameForLanguageType(lldb::LanguageType language); + + /// Returns whether the given language is any version of C++. ---

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-09 Thread Alex Langford via lldb-commits
@@ -26,3 +26,43 @@ SBLanguageRuntime::GetNameForLanguageType(lldb::LanguageType language) { return Language::GetNameForLanguageType(language); } + +bool SBLanguageRuntime::LanguageIsCPlusPlus(lldb::LanguageType language) { + return Language::LanguageIsCPlusPlus(language);

[Lldb-commits] [lldb] [lldb-dap] Support throw and catch exception breakpoints for dynamica… (PR #97871)

2024-07-09 Thread Alex Langford via lldb-commits
@@ -80,6 +87,45 @@ void DAP::PopulateExceptionBreakpoints() { exception_breakpoints->emplace_back("swift_throw", "Swift Throw", lldb::eLanguageTypeSwift); } +// Besides handling the hardcoded list of languages from above,

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-09 Thread Alex Langford via lldb-commits
@@ -47,13 +47,12 @@ namespace sys { /// The particular format of the names are target dependent, and suitable for /// passing as -mattr to the target which matches the host. /// - /// \param Features - A string mapping feature names to either - /// true (if enabled) or

[Lldb-commits] [lldb] [lldb] Fix string truncation method when substring is the prefix of string (NFC) (PR #94785)

2024-07-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Small cleanup of ProcessEventData::ShouldStop (PR #98154)

2024-07-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense to me https://github.com/llvm/llvm-project/pull/98154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [llvm][TargetParser] Return StringMap from getHostCPUFeatures (PR #97824)

2024-07-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/97824 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2024-07-10 Thread Alex Langford via lldb-commits
@@ -195,10 +199,10 @@ enum Format { ///< character arrays that can contain non printable ///< characters eFormatAddressInfo,///< Describe what an address points to (func + offset - ///< with file/line,

[Lldb-commits] [lldb] [lldb][test] Fix ComputeClangResourceDirectory test when CLANG_RESOURCE_DIR is set (PR #98464)

2024-07-11 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Private process events were being delivered to the secondary listener (PR #98571)

2024-07-12 Thread Alex Langford via lldb-commits
@@ -443,11 +474,17 @@ def test_shadow_listener(self): # Put in a counter to make sure we don't spin forever if there is some # error in the logic. counter = 0 +run_wo_stop = False bulbazord wrote: Doesn't look like this is used?

[Lldb-commits] [lldb] [lldb/Symbol] Hoist SymbolLocation from AssertFrameRecognizer to reuse it (PR #98975)

2024-07-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/98975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Target] Add GetStartSymbol method to DynamicLoader plugins (PR #99673)

2024-07-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Looks fine to me, but you probably want @jasonmolenda to sign off to be sure. https://github.com/llvm/llvm-project/pull/99673 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

  1   2   3   4   5   6   7   8   9   10   >