[Lldb-commits] [PATCH] D152012: [lldb/crashlog] Expand crash report file path before parsing

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. The key here is that you're expanding the path and checking for the validity before calling `CrashLogParser.create()` right? It looks like for the `load_crashlog_in_scripted_process` cas

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

bulbazord added a comment. So the idea behind this is fine to me, allowing custom commands to specify a completion style seems like a very nifty feature to have. We should definitely add a test though. An API test or a Shell test where we create a custom command and then try to do some kind of

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:882 + // we have a valid one to set it to. + assert(index_entry); + assert(!m_index_entry); fdeazeve wrote: > If LLVM's function is like this as well, we shouldn't

[Lldb-commits] [PATCH] D152013: [lldb/Commands] Fix disk completion from root directory

bulbazord added inline comments. Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:439-450 +def test_completion_target_create_from_root_dir(self): +"""Tests source file completion by completing .""" +root_dir = os.path.abspath(os.sep) +

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb6f832fbf8: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151962/ne

[Lldb-commits] [PATCH] D151949: [lldb][NFCI] Use size_t in OptionValueProperties

This revision was automatically updated to reflect the committed changes. Closed by commit rG0871f22edca5: [lldb][NFCI] Use size_t in OptionValueProperties (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151949/new/ https://re

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a4636929fd6: [lldb][NFCI] ConstString methods should take StringRefs by value (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152010/

[Lldb-commits] [PATCH] D152013: [lldb/Commands] Fix disk completion from root directory

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, this looks fine to me. I'm not 100% sure this will work on Windows, but we neither Ismail nor I have windows machines to test this on. Watch the windows bots please. CHANGES SINCE

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for adding the test! Most of this change looks fairly mechanical so I think this is probably good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152011/new/ https:

[Lldb-commits] [PATCH] D151960: [lldb][NFCI] Change the way Process stores StructuredData plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rG59af0c389563: [lldb][NFCI] Change the way Process stores StructuredData plugins (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151960

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the interest of keeping the ConstStrin

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Broadcasters don't need their names in the StringPool. It doesn't

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord updated this revision to Diff 529029. bulbazord added a comment. Address @JDevlieghere's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://reviews.llvm.org/D152220 Files: lldb/include/lldb/Utility/Broadcaster.h

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord updated this revision to Diff 529031. bulbazord added a comment. LLDB_LOGF -> LLDB_LOG where needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://reviews.llvm.org/D152220 Files: lldb/include/lldb/Utility/Broadcaster

[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString is simply not needed here. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/Broadcaster.h:358-360 +llvm::StringRef GetBroadcasterName() const { + return m_broadcaster.GetBroadcasterName(); } JDevlieghere wrote: > Why not return a `const std::string &` he

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, fdeazeve, Michael137, augusto2112, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `TypeSystemClang::Get

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

bulbazord updated this revision to Diff 529069. bulbazord added a comment. `llvm::StringRef` -> `const std::string &` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://reviews.llvm.org/D152220 Files: lldb/include/lldb/Utility/Bro

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

bulbazord added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:868 +lldb::BasicType TypeSystemClang::GetBasicTypeEnumeration(llvm::StringRef name) { + if (name.empty()) +return eBasicTypeInvalid; aprantl wrote: > Isn't

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

bulbazord updated this revision to Diff 529081. bulbazord added a comment. Minor pedantry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/new/ https://reviews.llvm.org/D152315 Files: lldb/include/lldb/Symbol/CompilerType.h lldb/source/Plu

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, Michael137, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These don't really need to be in the ConstString

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

bulbazord created this revision. bulbazord added reviewers: wallace, jj10306, persona0220. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The way it works now, it stores a `const char *` that it does

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These don't need to be ConstStrings. They don't really benefit mu

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

This revision was automatically updated to reflect the committed changes. Closed by commit rG867ee3b8a76a: [lldb][NFCI] Change type of Broadcaster's name (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152220/new/ https://revi

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord added a comment. In D152324#4403368 , @aprantl wrote: > Is the idea to remove the ConstString from these APIs too? If yes, this LGTM, > otherwise it seems to needlessly complicate things. Yes, I was going to remove ConstString from these other

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bae706682d5: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rGd29b5673822d: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152310/n

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1a7b7f6d55e: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/ne

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

This revision was automatically updated to reflect the committed changes. Closed by commit rG643ba926c1f6: [lldb][NFCI] Remove use of ConstString from OptionValueProperties (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, fdeazeve, rastogishubham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb's and llvm's implementations of DW

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord updated this revision to Diff 529769. bulbazord added a comment. Changed a bit of formatting to follow LLVM style more closely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151919/new/ https://reviews.llvm.org/D151919 Files: lldb/sour

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

bulbazord added a comment. In D152476#4408654 , @fdeazeve wrote: > This is awesome! I believe you said there was no measurable perf diff? Yeah, my initial experiments measured no significant perf difference no matter how you built lldb. llvm's and lldb'

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

bulbazord updated this revision to Diff 530021. bulbazord added a comment. Adjust formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152476/new/ https://reviews.llvm.org/D152476 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, jingham, fdeazeve, mib, kastiglione, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The purpose of this to

[Lldb-commits] [PATCH] D152573: [lldb][NFCI] Remove use of ConstString from Listener

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The only place ConstString was used in Listener was for filtering

[Lldb-commits] [PATCH] D152579: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, `SectionFileAddressesChanged` clears out the

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The short names of each signal name and alias only exist as Const

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

bulbazord added a comment. In D152582#4410002 , @mib wrote: > Don't you need to update the callers as well ? Otherwise LGTM. ConstString can be implicitly converted to StringRef which is what's happening here. There are only 2 call sites, both pass in a

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord updated this revision to Diff 530084. bulbazord added a comment. - Converted some things to use multiline string literals - Converted some f-strings into string literals when they didn't need interpolation - Applied black formatting Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord marked 3 inline comments as done. bulbazord added inline comments. Comment at: lldb/scripts/generate-project.py:175 +# Building Objects and their respective swiftmodule +f.write(f"$(OBJDIR)/%.o: %.swift objdir\n") +f.write("\t$(SWIFT_FE) -c -prim

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, mgorny. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I want to add some error handling to Dynami

[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In an effort to keep the ConstString StringPool small,

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord added a comment. In D152594#4410620 , @mib wrote: > Are we replacing all the constructors that can fail by static methods ? > Wouldn't it be easier to pass an `Status&` as an extra parameter ? It would probably be easier to do, but I don't thi

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

This revision was automatically updated to reflect the committed changes. Closed by commit rGf09cca4c6f67: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord updated this revision to Diff 530692. bulbazord added a comment. Remove temp variables More multiline string literals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152569/new/ https://reviews.llvm.org/D152569 Files: lldb/scripts/genera

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord updated this revision to Diff 530694. bulbazord added a comment. Address Jonas's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.org/D151597 Files: lldb/include/lldb/Core/Debugger.h lldb/includ

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord added a comment. In D152324#4415324 , @jingham wrote: > I wonder about this one. In every instance where the API is used, its result > is turned into a ConstString first. That's because this variable name lives > in the same slot as normal v

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

This revision was automatically updated to reflect the committed changes. Closed by commit rGf687850de877: [lldb] Change return type of UnixSignals::GetShortName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ http

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord updated this revision to Diff 530712. bulbazord marked an inline comment as done. bulbazord added a comment. Address the other suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.org/D151597 Files:

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord updated this revision to Diff 530720. bulbazord added a comment. Renamed from `CreateFromDict` to `Create` to be more consistent with the rest of LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D152573: [lldb][NFCI] Remove use of ConstString from Listener

This revision was automatically updated to reflect the committed changes. Closed by commit rG35419651c53c: [lldb][NFCI] Remove use of ConstString from Listener (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152573/new/ https:

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -m_sdk_sysroot = sdk_root_directory; + void SetSDKRootDirectory(llvm::StringRef sdk_root_directory) { +m_sd

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

bulbazord added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:10 #include "lldb/Core/ValueObjectDynamicValue.h" +#include "Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h" #include "lldb/Core/Value.h" -

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

bulbazord accepted this revision. bulbazord added a comment. I'm alright with this if Jim is. I think we should remove this parameter since it's never set to anything other than `true` from what I understand, but that can be done in a follow-up. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of writing boilerplate classes to serve as matc

[Lldb-commits] [PATCH] D152848: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:253 case lldb::eStopReasonSignal: { -int signal; +unsigned int signal;

[Lldb-commits] [PATCH] D152842: [lldb] Improve corefile saving ergonomics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM, what do you think @jasonmolenda ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152842/new/ https://reviews.llvm.org/D152842 __

[Lldb-commits] [PATCH] D151951: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cff6ca81335: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

bulbazord added a comment. I noticed you're pulling a lot of raw pointers out of shared pointers. Is there a particular reason you're doing that? `operator bool` on `std::shared_ptr` returns true if the held pointer is non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531084. bulbazord added a comment. Implement Jonas's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files: lldb/include/lldb/Interpreter/OptionGroupPl

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I don't really work on android-related code anymore but this change seems alright to me. There's prior art in LLVM which makes it a lot easier to accept. It's unfortunate that we need th

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

bulbazord added a comment. An environment variable isn't the worst thing in the world, but what would be better is an lldb setting so we can change it at runtime instead of needing to restart the debugging session. That may happen if you make a typo or make a mistake. Something like `plugin.pla

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added a comment. Herald added a subscriber: JDevlieghere. This is definitely useful to support, I had a few comments mostly about matching lldb's coding style. Also, are you running clang-format on your patches? There are a few places where I'm not sure if the formatting is right.

[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGe669011c3cca: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531103. bulbazord added a comment. Update other 2 functions (and one callsite) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files: lldb/include/lldb/Interprete

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531104. bulbazord added a comment. Avoid construction of temporary std::string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files: lldb/include/lldb/Interprete

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord added a comment. I like this idea quite a bit! I assume that when somebody hits a bug, they can give us their diagnostics file and we will hopefully see the assertion somewhere (if there was one)? Comment at: lldb/source/Target/Target.cpp:115 + lldbassert(false &

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D152866#4419413 , @JDevlieghere wrote: > In D152866#4419406 , @bulbazord > wrote: > >> I like this

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the next step in rem

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4be9ff6458f: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

bulbazord updated this revision to Diff 531407. bulbazord added a comment. Use STLExtras where appropriate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/ https://reviews.llvm.org/D152846 Files: lldb/source/Utility/Listener.cpp Index:

[Lldb-commits] [PATCH] D152962: [lldb] Fix SBPlatform after f4be9ff6458f

bulbazord created this revision. bulbazord added a reviewer: jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If you pass `nullptr` (or `None` from python) to SBPlatform::SetSDKRoot, LLDB crash

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord added a comment. Looks like this actually causes TestDebuggerAPI.py to segfault because SBPlatform::SetSDKRoot can take `nullptr` for its argument, and the conversion from `nullptr -> std::string` blows up. I'm fixing that in https://reviews.llvm.org/D152962. Repository: rG LLVM G

[Lldb-commits] [PATCH] D152968: [lldb][NFCI] Remove use of ConstString in ProcessStructReader

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. std::map is naturally replaced with `llvm::StringMap` here. Rep

[Lldb-commits] [PATCH] D152962: [lldb] Fix SBPlatform after f4be9ff6458f

This revision was automatically updated to reflect the committed changes. Closed by commit rG623ad8a8ddc9: [lldb] Fix SBPlatform after f4be9ff6458f (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152962/new/ https://reviews.ll

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

bulbazord created this revision. bulbazord added reviewers: aprantl, Michael137, augusto2112, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method just takes its ConstString parame

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

This revision was automatically updated to reflect the committed changes. Closed by commit rG35b0b244401a: [lldb] Introduce DynamicRegisterInfo::CreateFromDict (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https:

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:76 + + compiler_type = scratch_ts_sp->GetTypeForIdentifier(g_lldb_autogen_nspair); + aprantl wrote: > why not directly pass in `"__lldb_autogen_nspair"` here? It's u

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for reworking it! You may want to wait a little bit before landing so others have some time to look over it, but I don't see anything that should prevent this from going in. Rep

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

bulbazord added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } `GetAdbClient()` calls `make_unique`

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

bulbazord added a comment. What happens if you do `run-as` with an empty package name? I'm also not tied to the name `"platform.plugin.remote-android.run-as"` if others don't like it. `platform.plugin.remote-android.package-name` is fine too. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord added a comment. If nobody else has any comments, I plan on landing this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152569/new/ https://reviews.llvm.org/D152569 ___ lldb-commits ma

[Lldb-commits] [PATCH] D152579: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fb919a1154a: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe29cc5216a86: [lldb][NFCI] Remove use of ConstString from IOHandler (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Big fan of this kind of cleanup. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153088/new/

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c8b6fae4437: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG193c7d10cb30: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D152968: [lldb][NFCI] Remove use of ConstString in ProcessStructReader

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b90d09898ca: [lldb][NFCI] Remove use of ConstString in ProcessStructReader (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152968/new

[Lldb-commits] [PATCH] D153177: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString's benefits are not being utilized here, StringRef is

[Lldb-commits] [PATCH] D153177: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4827a3c0a7e: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15317

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The use of ConstString in StructuredDataPlugin is unnec

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The Objective-C runtime and the shared cache has changed slightly. Given a cla

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG28fb39f16af1: [lldb] Adjust for changes in objc runtime (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153597/new/ https://reviews.l

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me. Does it make sense to add a test case where we mix "printable" characters with "non-printable" ones? I see you have a `\f` at the end there, but that's a special escap

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a397ecffdea: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153482/

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

bulbazord added a comment. I think this patch is probably okay to do, but it does break a supported use case that I'm aware of: One way you can do "object oriented programming" in C is to do exactly what you're trying to prevent. Using the test, you could say that "MyStruct" is the base class a

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I removed ConstString from OptionValueProperties in 643ba926c1f6

[Lldb-commits] [PATCH] D153675: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow-up to b4827a3c0a7ef121ca376713e115b04e

<    4   5   6   7   8   9   10   11   12   13   >