[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. Ok, after looking at this more closely, it's a little clearer to me why `SBFileSpec::GetDirectory` was written this way to begin with. The method itself requires its return value to be denormalized (something not explicitly documented in the header nor the SWIG docstr

[Lldb-commits] [PATCH] D150235: [lldb] Change definition of DisassemblerCreateInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rGf464b7c764bc: [lldb] Change definition of DisassemblerCreateInstance (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150235/new/ http

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Some more numbers: % hyperfine -w 3 -- "$lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App" Benchmark 1: $lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCNam

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I talked to Jonas and did a little research.

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

bulbazord created this revision. bulbazord added reviewers: kparzysz, JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This applies the same trick for Lua that I did for python in 27b

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added a comment. This broke Lua support, so I am fixing it in D150624 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150157/new/ https://reviews.llvm.org/D150157 ___

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

bulbazord requested review of this revision. bulbazord added a comment. So, I agree that we should definitely unify this or else we end up doing this for **every** scripting language that we add support for. That being said, I think this is actually better than what we had before because now we'

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

This revision was automatically updated to reflect the committed changes. Closed by commit rG692ae97ae71d: [lldb] Fix lua build after 27b6a4e63afe (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150624/new/ https://reviews.llv

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord added a comment. In D150621#4344243 , @JDevlieghere wrote: > You can do this simpler with a single `std::once_flag`. +1 I like the idea of this patch a lot! LGTM otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The documentation should have been updated in 662548

[Lldb-commits] [PATCH] D150709: [lldb][NFCI] Change return type of Language::GetInstanceVariableName

bulbazord created this revision. bulbazord added a reviewer: kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't think this needs to be a ConstString. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

This revision was automatically updated to reflect the committed changes. Closed by commit rGec388adbbcbf: [lldb][docs] Update SB API design document (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150630/new/ https://reviews.

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, fdeazeve, rastogishubham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Both LLVM and LLDB implement DWARFAbbreviati

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord accepted this revision. bulbazord added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord created this revision. bulbazord added reviewers: jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB should guarantee that the strings returned by SBAPI methods live forever.

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

bulbazord added a comment. Where do you plan on using this? Downstream I assume? Comment at: lldb/source/Core/Value.cpp:134-135 + return Value::ValueType::Invalid; + } +} + This switch is exhaustive, could you add an `llvm_unreachable` somewhere to indic

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://reviews.llvm.org/D150826 _

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord marked 2 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:27 lldb::offset_t *offset_ptr) { + llvm::DataExtractor llvm_data = data.GetAsLLVM(); co

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord updated this revision to Diff 523500. bulbazord marked 2 inline comments as done. bulbazord added a comment. Redo include order in DWARFDebugAbbrev.h to match project guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150716/new/ ht

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG16eb14806d1e: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150716/n

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > Using an llvm s

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/API/SBFunction.cpp:181 + + return variable_sp->GetName().GetCString(); } mib wrote: > nit: This threw me off, I thought you forgot to create a `ConsString` but

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

This revision was automatically updated to reflect the committed changes. bulbazord marked an inline comment as done. Closed by commit rG915256388f86: [lldb] Refactor ObjCLanguage::MethodName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > bulbazord wrote: > > aprantl wrote: > > > Using an llvm str

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord updated this revision to Diff 523578. bulbazord marked an inline comment as done. bulbazord added a comment. Update SBModule::GetUUIDString -- I slightly changed behavior. Now the behavior matches the previous implementation exactly. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

This revision was automatically updated to reflect the committed changes. Closed by commit rG41714c959d65: [lldb] Guarantee the lifetimes of all strings returned from SBAPI (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150804

[Lldb-commits] [PATCH] D150914: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

bulbazord created this revision. bulbazord added a reviewer: aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The size of a full ObjC MethodName can vary somewhat, but it is computable ahead of

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + bulbazord wrote: > aprantl wrote

[Lldb-commits] [PATCH] D150914: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d3f061ba41: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150914/ne

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

bulbazord added a comment. Bug fixes look good to me, the perf and code simplifications are also great to see. A few nits and I have one concern. Otherwise looks fine to me, I think. Comment at: lldb/include/lldb/Target/DynamicLoader.h:270-273 + LoadBinaryWithUUIDAndAddress(P

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

bulbazord accepted this revision. bulbazord added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150954/new/ https://reviews.llvm.org/D150954 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added a comment. Looks good! A few minor comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the sym

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

bulbazord added a comment. You probably encountered this somewhere, is there a simple test we could add here? The change looks fine to me nonetheless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151002/new/ https://reviews.llvm.org/D151002

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, looks good to me now. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 ___ lld

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere. Herald added a subscriber: tschuett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These functions do the exact

[Lldb-commits] [PATCH] D150709: [lldb][NFCI] Change return type of Language::GetInstanceVariableName

This revision was automatically updated to reflect the committed changes. Closed by commit rGef73ea6cf691: [lldb][NFCI] Change return type of Language::GetInstanceVariableName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:1165-1168 +if os.path.isdir(obj_dir.name): +for file in os.listdir(obj_dir.name): +os.unlink(os.path.join(obj_dir.name, file)) +os.rmdir(obj_dir.name) ---

[Lldb-commits] [PATCH] D151044: [lldb] Move PassthroughScriptedProcess to `lldb.scripted_process` module

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks like you're mostly moving things around which is fine. The bug that you're fixing is with thread handling in `MultiplexerScriptedProcess` right? That looks fine to me too. Reposi

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord added a comment. Ok, this is a pretty big patch so we probably don't want to leave it in review for a long time or it just gets harder to land correctly. I've looked over most of this patch and it looks fine to me. A lot of is rather mechanical: Changing things like `GetIntegerValue`

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Alright, looks good to me. Let's see what the bots think! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150485/new/ https://reviews.llvm.org/D150485 ___

[Lldb-commits] [PATCH] D151045: [lldb/crashlog] Remove tempfile prefix from inlined symbol object file

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151045/new/ https://reviews.llvm.org/D151045 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D151120: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and ObjectFileMachO::GetSDKVersion

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c276eaf8f4a: [lldb][NFCI] Merge implementations of ObjectFileMachO::GetMinimumOSVersion and… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D151236: [lldb][NFCI] Remove unused member from ObjectFileMachO

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. >From what I can see, `m_mach_segments` is completely unused. Let

[Lldb-commits] [PATCH] D151236: [lldb][NFCI] Remove unused member from ObjectFileMachO

This revision was automatically updated to reflect the committed changes. Closed by commit rG973f1fe7a859: [lldb][NFCI] Remove unused member from ObjectFileMachO (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151236/new/ http

[Lldb-commits] [PATCH] D151381: [lldb][NFCI] Include in SBDefines for FILE * definition

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are a few API headers that use FILE * but do not include th

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

bulbazord added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:86 +bool Watchpoint::SetupVariableWatchpointDisabler(StackFrameSP frame_sp) const { + ThreadSP thread_sp = frame_sp->GetThread(); Should you also verify that the `frame_sp` you

[Lldb-commits] [PATCH] D151292: lldb WIP/RFC: Adding support for address fixing on AArch64 with high and low memory addresses

bulbazord added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:1099-1103 // 64 - T1Sz is the highest bit used for auth. // The value we pass in to SetVirtualAddressableBits is // the num

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I have no objections but you should probably wait for others to take another look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151366/new/ https://reviews.llvm.org/D151366 _

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch introduces FileSpec::GetComponents, a me

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:420 + /// A std::vector of std::strings for each path component. + std::vector GetComponents() const; + JDevlieghere wrote: > I'm surprised this returns a vector of `std::string

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:420 + /// A std::vector of std::strings for each path component. + std::vector GetComponents() const; + JDevlieghere wrote: > bulbazord wrote: > > JDevlieghere wrote: > > > I'm

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

bulbazord accepted this revision. bulbazord added a comment. Thanks for doing this work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151451/new/ https://reviews.llvm.org/D151451 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

bulbazord updated this revision to Diff 525757. bulbazord added a comment. Convert return type to `std::vector` Actually fix code so this thing compiles correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151399/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I think it's good to improve the error messaging but I think we can probably do better. "Function caller" is specific to the internals of LLDB and isn't really meaningful for m

[Lldb-commits] [PATCH] D151516: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, labath, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On llvm.org and all downstream forks that I'm aware of,

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D151497#4374495 , @JDevlieghere wrote: > In D151497#4374080 , @bulbazord > wrote: > >> I think it'

[Lldb-commits] [PATCH] D151524: [lldb][NFCI] Change type of SBDebugger::m_instance_name

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This doesn't need to be in the ConstString StringPool. There's li

[Lldb-commits] [PATCH] D151381: [lldb][NFCI] Include in SBDefines for FILE * definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG877ddac051c4: [lldb][NFCI] Include in SBDefines for FILE * definition (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151381/

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

bulbazord added a comment. What is the motivation behind this change? Also, why did you factor out `--show-sdk-path` into an argument? I assume you want to use `xcrun` for other purposes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 _

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

bulbazord accepted this revision. bulbazord added a comment. Sounds good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. None of these need to be in the ConstString StringP

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The strings "DarwinLog" and "log" probably do not n

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl, Michael137, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Remove unused parameter `val

[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. After reading though the code and thinking about it, I believe this change is appropriate. It may or may not have a measurable impact on performance, but my bet is that it doesn't make i

[Lldb-commits] [PATCH] D151615: [lldb] Change GetChildMemberWithName to take a StringRef, not ConstString

bulbazord added a comment. In D151615#4378441 , @kastiglione wrote: > Do you have something in mind? I figured the test suite was enough. Do you > mean stress for perf, or for ensuring this change has no behavior regressions? I meant stress test for pe

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:1001 -bool ObjCLanguage::GetFormatterPrefixSuffix(ValueObject &valobj, -ConstString type_hint, -

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

bulbazord updated this revision to Diff 526705. bulbazord added a comment. Remove use of `std::call_once` where not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ https://reviews.llvm.org/D151603 Files: lldb/include/lldb/Targe

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e0001eb95ce: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ ht

[Lldb-commits] [PATCH] D151524: [lldb][NFCI] Change type of SBDebugger::m_instance_name

This revision was automatically updated to reflect the committed changes. Closed by commit rGf46638b01d1b: [lldb][NFCI] Change type of SBDebugger::m_instance_name (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151524/new/ htt

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

bulbazord updated this revision to Diff 526768. bulbazord added a comment. LLDB_LOGF -> LLDB_LOG to avoid a temporary string construction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151599/new/ https://reviews.llvm.org/D151599 Files: lldb/sou

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e8a412cb37d: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D151748: [lldb] Consult summary provider before printing children of root references

bulbazord accepted this revision. bulbazord added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151748/new/ https://reviews.llvm.org/D151748 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks like my concerns were addressed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150928/new/ https://reviews.llvm.org/D150928

[Lldb-commits] [PATCH] D151399: [lldb] Introduce FileSpec::GetComponents

This revision was automatically updated to reflect the committed changes. Closed by commit rG57154a63a07f: [lldb] Introduce FileSpec::GetComponents (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151399/new/ https://reviews.ll

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. The change itself looks fine and is fairly mechanical. Easy to verify. One thing that I see here is we're treating the result of `llvm::StringRef::data()` as a c-string which isn't guara

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Mutating a FileSpec is quite expensive. E

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

bulbazord accepted this revision. bulbazord added a comment. Very straightforward. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151810/new/ https://reviews.llvm.org/D151810 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

bulbazord accepted this revision. bulbazord added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:434 ValueObjectSP root(GetSP()); - for (ConstString name : names) { + for (auto name : names) { root = root->GetChildMemberWithName(name, true); -

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord added a comment. In D151597#4384734 , @mib wrote: > TBH, it feels like a lot of - risky - changes just so > `IOHandlerGetControlSequence` can return a `llvm::StringRef` ? Is that really > necessary ? I assume you're referring to `IOHandlerDel

[Lldb-commits] [PATCH] D151844: [lldb/crashlog] Fix crash when loading non-symbolicated report

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:599-602 +if 'symbol' in json_frame: +symbol = json_frame['symbol'] +location = 0 +if "symbolLocation" in json_frame and json_frame["symbolLoc

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

bulbazord accepted this revision. bulbazord added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/crashlog.py:493 self.images = list() +self.crashlog = CrashLog(debugger, self.path, self.verbose) --

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:1373-1374 +arch = crashlog.process_arch +if not arch: +arch = platform.machine() +target = debugger.CreateTargetWithFileAndArch(None, arch) mib wrote

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

bulbazord added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:315 + llvm::StringRef name = m_name.GetOptionValue().GetCurrentValueAsRef(); + if (!name.empty()) nit: Comment at: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

bulbazord added a comment. In D151859#4385986 , @jingham wrote: > Make sure we do something sensible with "target select " if the user > has given the same name to two targets (or disallow doing that, one or the > other). In addition to this, what happ

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

bulbazord planned changes to this revision. bulbazord added a comment. In D151765#4385711 , @jingham wrote: > Why did you choose to have a separate FileSpecBuilder class, rather than > making FileSpec smarter about the structure of the path (e.g. have an

[Lldb-commits] [PATCH] D151516: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

This revision was automatically updated to reflect the committed changes. Closed by commit rGab27431596c4: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1515

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord created this revision. bulbazord added reviewers: aprantl, fdeazeve, rastogishubham, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I plan

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

bulbazord added a comment. I feel a little strange about having `SBTarget::SetLabel` give a label to a target that is anything other than what the user specified. In the test, you attempt to name 2 targets `cat`. The first one succeeds, the second one also succeeds but names it `cat 2` (where 2

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:889 +"Package unit with a non-zero abbreviation offset"); + + auto *unit_contrib = index_entry->getContribution(); aprantl wrote: > I know this was also in th

[Lldb-commits] [PATCH] D151949: [lldb][NFCI] Use size_t in OptionValueProperties

bulbazord created this revision. bulbazord added reviewers: jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In many places we're using uint32_t where we should be using size_t. We should

[Lldb-commits] [PATCH] D151951: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

bulbazord created this revision. bulbazord added reviewers: jingham, jasonmolenda, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Most users of this stick it into a StringRef. The one user that d

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

bulbazord added a comment. LGTM modulo typo Comment at: lldb/examples/python/crashlog.py:1374 +if not arch: +raise InteractiveCrashLogException("couldn't create find the architecture to create the target") +target = debugger.CreateTargetWithFileAndA

[Lldb-commits] [PATCH] D151960: [lldb][NFCI] Change the way Process stores StructuredData plugins

bulbazord created this revision. bulbazord added reviewers: jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of having a map from ConstString to StructuredDataPluginS

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

bulbazord created this revision. bulbazord added reviewers: wallace, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These don't really need to be in the ConstString StringPool. I've chan

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

bulbazord added a comment. If every caller sets this to true, why not remove the argument altogether? It looks like `ValueObjectRegister::GetChildMemberWithName` doesn't use the argument, `ValueObject::GetChildMemberWithName` and `ValueObjectSynthetic::GetChildMemberWithName` just pass it along

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

bulbazord created this revision. bulbazord added reviewers: fdeazeve, kastiglione, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. StringRef was made to be passed by value efficientl

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

bulbazord added inline comments. Comment at: lldb/source/Utility/ConstString.cpp:305 -void ConstString::SetString(const llvm::StringRef &s) { - m_string = StringPool().GetConstCStringWithLength(s.data(), s.size()); +void ConstString::SetString(const llvm::StringRef s) { + m_s

[Lldb-commits] [PATCH] D152010: [lldb][NFCI] ConstString methods should take StringRefs by value

bulbazord updated this revision to Diff 527908. bulbazord added a comment. Remove `const` where unneeded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152010/new/ https://reviews.llvm.org/D152010 Files: lldb/include/lldb/Utility/ConstString.h

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151859/new/ https://reviews.llvm.org/D151859 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D152013: [lldb/Commands] Fix disk completion from root directory

bulbazord added a comment. The change itself looks ok to me. Could you add a test for this? We do have some tests to test for completion so the machinery is there, but it's mostly for the expression evaluator right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

<    3   4   5   6   7   8   9   10   11   12   >