[Lldb-commits] [lldb] r355572 - crashlog.py: Catch exception from subprocess.

Author: adrian Date: Wed Mar 6 16:41:51 2019 New Revision: 355572 URL: http://llvm.org/viewvc/llvm-project?rev=355572&view=rev Log: crashlog.py: Catch exception from subprocess. Modified: lldb/trunk/examples/python/crashlog.py Modified: lldb/trunk/examples/python/crashlog.py URL: http://ll

[Lldb-commits] [lldb] r355573 - Avoid using -S in combination with "script"; it's unreliable.

Author: adrian Date: Wed Mar 6 16:46:56 2019 New Revision: 355573 URL: http://llvm.org/viewvc/llvm-project?rev=355573&view=rev Log: Avoid using -S in combination with "script"; it's unreliable. Modified: lldb/trunk/lit/Python/crashlog.test Modified: lldb/trunk/lit/Python/crashlog.test URL:

[Lldb-commits] [lldb] r355632 - Add an LLVM-style dump method to CompilerType for extra convenience during debugging

Author: adrian Date: Thu Mar 7 12:20:02 2019 New Revision: 355632 URL: http://llvm.org/viewvc/llvm-project?rev=355632&view=rev Log: Add an LLVM-style dump method to CompilerType for extra convenience during debugging This change has no effect on Release (NoAsserts) builds. Differential Revisio

[Lldb-commits] [lldb] r355841 - Bring Doxygen comment syntax in sync with LLVM coding style.

Modified: lldb/trunk/source/Target/StackFrame.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=355841&r1=355840&r2=355841&view=diff == --- lldb/trunk/source/Target/StackFrame.cpp (or

[Lldb-commits] [lldb] r355843 - Makefile.rules: Upstream SDKROOT handling code for Darwin.

Author: adrian Date: Mon Mar 11 10:24:10 2019 New Revision: 355843 URL: http://llvm.org/viewvc/llvm-project?rev=355843&view=rev Log: Makefile.rules: Upstream SDKROOT handling code for Darwin. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/trunk/package

[Lldb-commits] [lldb] r355985 - Add more logging to ClangModulesDeclVendor.cpp

Author: adrian Date: Tue Mar 12 14:30:47 2019 New Revision: 355985 URL: http://llvm.org/viewvc/llvm-project?rev=355985&view=rev Log: Add more logging to ClangModulesDeclVendor.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp Modified: lldb/trunk/sour

[Lldb-commits] [lldb] r355986 - Temporarily add more logging to TestBatchMode

Author: adrian Date: Tue Mar 12 14:30:50 2019 New Revision: 355986 URL: http://llvm.org/viewvc/llvm-project?rev=355986&view=rev Log: Temporarily add more logging to TestBatchMode Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py Modified: lldb/trunk/pack

[Lldb-commits] [lldb] r355990 - Revert "Temporarily add more logging to TestBatchMode"

Author: adrian Date: Tue Mar 12 15:20:26 2019 New Revision: 355990 URL: http://llvm.org/viewvc/llvm-project?rev=355990&view=rev Log: Revert "Temporarily add more logging to TestBatchMode" Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py Modified: lldb/t

[Lldb-commits] [lldb] r355991 - Fix the broken Batch test by passing a custom module cache to the inferior lldb.

Author: adrian Date: Tue Mar 12 15:20:29 2019 New Revision: 355991 URL: http://llvm.org/viewvc/llvm-project?rev=355991&view=rev Log: Fix the broken Batch test by passing a custom module cache to the inferior lldb. Modified: lldb/trunk/packages/Python/lldbsuite/test/driver/batch_mode/TestBatch

[Lldb-commits] [lldb] r355994 - Update the macOS implementation of ComputeClangResourceDirectory to

Author: adrian Date: Tue Mar 12 16:59:02 2019 New Revision: 355994 URL: http://llvm.org/viewvc/llvm-project?rev=355994&view=rev Log: Update the macOS implementation of ComputeClangResourceDirectory to comply with the more pedantic TestPaths.py Modified: lldb/trunk/source/Plugins/ExpressionPar

[Lldb-commits] [lldb] r356057 - Make sure FileSystem::Resolve preserves the path/file distinction.

Author: adrian Date: Wed Mar 13 08:54:18 2019 New Revision: 356057 URL: http://llvm.org/viewvc/llvm-project?rev=356057&view=rev Log: Make sure FileSystem::Resolve preserves the path/file distinction. This should finally fix TestPaths.py. Modified: lldb/trunk/source/Host/common/FileSystem.cpp

[Lldb-commits] [lldb] r356090 - Fix an invalid static cast in ClangExpressionParser.cpp

Author: adrian Date: Wed Mar 13 12:46:30 2019 New Revision: 356090 URL: http://llvm.org/viewvc/llvm-project?rev=356090&view=rev Log: Fix an invalid static cast in ClangExpressionParser.cpp This was found by the green dragon sanitizer bot. rdar://problem/48536644 Differential Revision: https://r

[Lldb-commits] [lldb] r356113 - Make sure that a sanitizer LLDB's environment doesn't get passed on

Author: adrian Date: Wed Mar 13 17:46:15 2019 New Revision: 356113 URL: http://llvm.org/viewvc/llvm-project?rev=356113&view=rev Log: Make sure that a sanitizer LLDB's environment doesn't get passed on to test binaries. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [lldb] r356160 - Fix a double-overrelease in the TestDataFormatterObjC test program.

Author: adrian Date: Thu Mar 14 08:58:21 2019 New Revision: 356160 URL: http://llvm.org/viewvc/llvm-project?rev=356160&view=rev Log: Fix a double-overrelease in the TestDataFormatterObjC test program. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-for

[Lldb-commits] [lldb] r356275 - Implement a better way of not passing the sanitizer environment on to tests.

Author: adrian Date: Fri Mar 15 10:22:00 2019 New Revision: 356275 URL: http://llvm.org/viewvc/llvm-project?rev=356275&view=rev Log: Implement a better way of not passing the sanitizer environment on to tests. rdar://problem/48889580 Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbte

[Lldb-commits] [lldb] r356462 - Improve error handling for Clang module imports.

Author: adrian Date: Tue Mar 19 08:38:26 2019 New Revision: 356462 URL: http://llvm.org/viewvc/llvm-project?rev=356462&view=rev Log: Improve error handling for Clang module imports. rdar://problem/48883558 Differential Revision: https://reviews.llvm.org/D59524 Added: lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r356711 - Makefile.rules: Normalize use of trailing slashes in path variables.

Author: adrian Date: Thu Mar 21 13:36:23 2019 New Revision: 356711 URL: http://llvm.org/viewvc/llvm-project?rev=356711&view=rev Log: Makefile.rules: Normalize use of trailing slashes in path variables. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified: lldb/tru

[Lldb-commits] [lldb] r356911 - Update the lldb driver to support the -O and -S options when passing --repl

Author: adrian Date: Mon Mar 25 08:38:18 2019 New Revision: 356911 URL: http://llvm.org/viewvc/llvm-project?rev=356911&view=rev Log: Update the lldb driver to support the -O and -S options when passing --repl At the moment when --repl is passed to lldb it silently ignores any commands passed via

[Lldb-commits] [lldb] r357115 - Add LLDB_LIBDIR_SUFFIX to Config.h to unbreak the Xcode project

Author: adrian Date: Wed Mar 27 12:22:55 2019 New Revision: 357115 URL: http://llvm.org/viewvc/llvm-project?rev=357115&view=rev Log: Add LLDB_LIBDIR_SUFFIX to Config.h to unbreak the Xcode project Modified: lldb/trunk/include/lldb/Host/Config.h Modified: lldb/trunk/include/lldb/Host/Config.h

[Lldb-commits] [lldb] r357268 - Don't abort() in lldb_assert and document why.

Author: adrian Date: Fri Mar 29 09:12:27 2019 New Revision: 357268 URL: http://llvm.org/viewvc/llvm-project?rev=357268&view=rev Log: Don't abort() in lldb_assert and document why. rdar://problem/49356014 Differential Revision: https://reviews.llvm.org/D59911 Added: lldb/trunk/docs/resources

[Lldb-commits] [lldb] r357534 - Revert r357504, r357491, r357482 because of bot breakage.

Author: adrian Date: Tue Apr 2 15:03:22 2019 New Revision: 357534 URL: http://llvm.org/viewvc/llvm-project?rev=357534&view=rev Log: Revert r357504, r357491, r357482 because of bot breakage. See discussion in https://reviews.llvm.org/D60001. Revert Clean up windows build bot. This reverts r35750

Re: [Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

At the moment no. In a hypothetical future where LLVM is hosted on github, we could set up a system similar to the swift-lldb pull request testing, but for now that is all we have. On the flip side, I don't mind trying things out by committing a speculative fix as long as it is quickly reverted

[Lldb-commits] [lldb] r357829 - Unify random timeouts throughout LLDB and make them configurable.

Author: adrian Date: Fri Apr 5 15:43:42 2019 New Revision: 357829 URL: http://llvm.org/viewvc/llvm-project?rev=357829&view=rev Log: Unify random timeouts throughout LLDB and make them configurable. Since these timeouts guard against catastrophic error in debugserver, I also increased all of them

[Lldb-commits] [lldb] r357948 - Fix a stack buffer overflow found by ASAN.

Author: adrian Date: Mon Apr 8 14:58:36 2019 New Revision: 357948 URL: http://llvm.org/viewvc/llvm-project?rev=357948&view=rev Log: Fix a stack buffer overflow found by ASAN. llvm::StringRef host_and_port is not guaranteed to be null-terminated. Generally, it is not safe at all to convert a Stri

[Lldb-commits] [lldb] r357954 - Experiment with a larger packet timeout.

Author: adrian Date: Mon Apr 8 16:02:11 2019 New Revision: 357954 URL: http://llvm.org/viewvc/llvm-project?rev=357954&view=rev Log: Experiment with a larger packet timeout. This is a follow-up to r357829 (https://reviews.llvm.org/D60340) to see whether increasing the packet timeout for non-asan

[Lldb-commits] [lldb] r358137 - Fix undefined behavior in DWARFASTParser::ParseChildArrayInfo()

Author: adrian Date: Wed Apr 10 14:18:44 2019 New Revision: 358137 URL: http://llvm.org/viewvc/llvm-project?rev=358137&view=rev Log: Fix undefined behavior in DWARFASTParser::ParseChildArrayInfo() PR40827: https://bugs.llvm.org/show_bug.cgi?id=40827 Modified: lldb/trunk/include/lldb/Symbol/

[Lldb-commits] [lldb] r358924 - Rename C++ TestGlobalVariables.py to have a distinct name from C version.

Author: adrian Date: Mon Apr 22 15:16:33 2019 New Revision: 358924 URL: http://llvm.org/viewvc/llvm-project?rev=358924&view=rev Log: Rename C++ TestGlobalVariables.py to have a distinct name from C version. Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/global_variables/TestCPPGlo

[Lldb-commits] [lldb] r285424 - Rename DWARF 5 constants to adapt to change in LLVM

Author: adrian Date: Fri Oct 28 13:14:43 2016 New Revision: 285424 URL: http://llvm.org/viewvc/llvm-project?rev=285424&view=rev Log: Rename DWARF 5 constants to adapt to change in LLVM Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp Modified: lldb/trunk/source/Plugin

[Lldb-commits] [lldb] r285441 - Rename DWARF 5 constants to adapt to change in LLVM

Author: adrian Date: Fri Oct 28 15:11:27 2016 New Revision: 285441 URL: http://llvm.org/viewvc/llvm-project?rev=285441&view=rev Log: Rename DWARF 5 constants to adapt to change in LLVM Modified: lldb/trunk/source/Expression/DWARFExpression.cpp Modified: lldb/trunk/source/Expression/DWARFExpr

[Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl created this revision. aprantl added reviewers: granata.enrico, tfiala. aprantl added a subscriber: lldb-commits. This is a work-in-progress patch for adding a "-gmodules" category to the testsuite. It adds clang module debugging as a configuration alongside .dSYM and DWO to ensure that

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl added a comment. In http://reviews.llvm.org/D19998#423277, @labath wrote: > I am glad to see more testing of the modules debugging. I have a couple of > small comments though: > > - `-fmodules`: Why is it not being added to CXXFLAGS? Is this how clang is > supposed to be invoked? (I am

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl added a comment. I still need some expertise on how to disable the configuration on platforms with older versions of clang (or different compilers like gcc). http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.ll

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl updated this revision to Diff 58369. aprantl added a comment. Update with Todds most recent infrastructure additions. http://reviews.llvm.org/D19998 Files: packages/Python/lldbsuite/support/gmodules.py packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/ex

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl added a comment. In http://reviews.llvm.org/D19998#438666, @tfiala wrote: > In http://reviews.llvm.org/D19998#438614, @zturner wrote: > > > So I asked some of the guys here, and they said modules debug info (in > > particular -gmodules) will not work anywhere but OSX. > > > I don't think

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl abandoned this revision. aprantl added a comment. Todd, I'm abandoning the review. This should allow you to claim it as your own so you can iterate quicker. Thanks! http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl created this revision. aprantl added reviewers: jingham, clayborg. aprantl added a subscriber: lldb-commits. aprantl set the repository for this revision to rL LLVM. Here's a fun little idea plus a preliminary patch implementing it. When I'm debugging programs I often wonder what exactly

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl added a comment. I was also wondering if there was a preferred way to detect whether LLDB is connected to a dumb terminal. I noticed that Stream has an eANSI flag, but it seemed to be always zero. Repository: rL LLVM http://reviews.llvm.org/D20835

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl added a subscriber: friss. aprantl removed rL LLVM as the repository for this revision. aprantl updated this revision to Diff 59141. aprantl added a comment. Added a use-column-info setting. http://reviews.llvm.org/D20835 Files: include/lldb/API/SBSourceManager.h include/lldb/Core/D

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl updated this revision to Diff 59154. aprantl added a comment. Rename the property to "stop-show-column" and query the stream whether ansi escape sequences are allowed. http://reviews.llvm.org/D20835 Files: include/lldb/API/SBSourceManager.h include/lldb/Core/Debugger.h include/ll

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl updated this revision to Diff 59264. aprantl added a comment. I have one last question: While trying to add a testcase I noticed that DisplaySourceLinesWithLineNumbers is still exported into Python with the old signature. What is the correct way to update the Python bindings? http://re

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

aprantl abandoned this revision. aprantl added a comment. I'm abandon this review so tfiala can claim it. https://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

For context, here are the relevant LLVM discussions: http://reviews.llvm.org/D16569 (D16569: Emit line 0 line information for interesting 'orphan’ instructions) http://reviews.llvm.org/D9887 [DebugInfo][FastISel] Prevent using debug

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

> On Feb 3, 2016, at 1:58 PM, Zachary Turner wrote: > > I was thinking of a really trivial function that just returned an int or > something. But then again, I don't really know how to write LLVM IR myself > so I was just going off of what other people told me would be possible. I > could b

[Lldb-commits] [PATCH] D17897: Support floating point values in 128-bit SSE vector registers

aprantl created this revision. aprantl added a reviewer: clayborg. aprantl added a subscriber: lldb-commits. aprantl set the repository for this revision to rL LLVM. The System-V x86_64 ABI requires floating point values to be passed in 128-but SSE vector registers (xmm0, ...). When printing such

[Lldb-commits] [lldb] r262947 - Support floating point values in 128-bit SSE vector registers

Author: adrian Date: Tue Mar 8 12:35:09 2016 New Revision: 262947 URL: http://llvm.org/viewvc/llvm-project?rev=262947&view=rev Log: Support floating point values in 128-bit SSE vector registers The System-V x86_64 ABI requires floating point values to be passed in 128-but SSE vector registers (x

Re: [Lldb-commits] [PATCH] D17897: Support floating point values in 128-bit SSE vector registers

aprantl closed this revision. aprantl added a comment. Thanks! Committed as r262947. Repository: rL LLVM http://reviews.llvm.org/D17897 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

Re: [Lldb-commits] [PATCH] D12674: Remove an invalid check in DW_OP_piece processing.

aprantl accepted this revision. aprantl added a comment. Thanks, yes, this check looks like it serves no purpose. http://reviews.llvm.org/D12674 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

adrian-prantl wrote: A high-level concern that I have with this is the grammar is full of C++-specific nodes, which is not something I would like to see in living in `Core`. Have we previously reached any consensus on how we want to handle different languages in DIL? I would be more comfortabl

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Allow transparent lookup through anonymous namespaces (PR #97275)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/97275 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor TypeQuery::ContextMatches, take 2 (PR #101333)

adrian-prantl wrote: @Michael137 Have you tried applying the patch to swift-lldb and running the tests? https://github.com/llvm/llvm-project/pull/101333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/101669 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser][NFC] Factor LangOptions logic out of ClangExpressionParser constructor (PR #101669)

@@ -615,6 +484,147 @@ ClangExpressionParser::ClangExpressionParser( // 'fopen'). Those libc functions are already correctly handled by LLDB, and // additionally enabling them as expandable builtins is breaking Clang. lang_opts.NoBuiltin = true; +} + +static void SetupImpo

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/101697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Log and assert on failure to create TargetInfo (PR #101697)

@@ -465,18 +465,24 @@ ClangExpressionParser::ClangExpressionParser( // A value of 0 means no limit for both LLDB and Clang. m_compiler->getDiagnostics().setErrorLimit(target_sp->GetExprErrorLimit()); - auto target_info = TargetInfo::CreateTargetInfo( - m_compiler->ge

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

@@ -578,7 +657,12 @@ static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) { lang_opts.GNUMode = true; lang_opts.GNUKeywords = true; lang_opts.CPlusPlus11 = true; - lang_opts.BuiltinHeadersInSystemModules = true; + + // FIXME: We should use the driver to

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler, lang_opts.NoBuiltin = true; } -static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) { +// NOTE: should be kept in sync with sdkSupportsBuiltinModules in +// Toolchains/Darwin.cpp +stat

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler, lang_opts.NoBuiltin = true; } -static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) { +// NOTE: should be kept in sync with sdkSupportsBuiltinModules in +// Toolchains/Darwin.cpp +stat

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/102161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

adrian-prantl wrote: @jimingham Should we revert the patch until this is fixed or are there more patches depending on this? https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #102309)

https://github.com/adrian-prantl approved this pull request. Thanks, this LGTM, next step should be to replace the use of `include_directories` with `DW_AT_APPLE_sdk`. https://github.com/llvm/llvm-project/pull/102309 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] Reland "[lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (#102309)" (PR #102497)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/102497 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Platform] Move the GetSDKPathFromDebugInfo helpers from PlatformDarwin into Platform (PR #102488)

@@ -436,6 +437,39 @@ class Platform : public PluginInterface { return lldb_private::ConstString(); } + /// Search each CU associated with the specified 'module' for + /// the SDK paths the CUs were compiled against. In the presence + /// of different SDKs, we try to p

[Lldb-commits] [lldb] [lldb][Platform] Move the GetSDKPathFromDebugInfo helpers from PlatformDarwin into Platform (PR #102488)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/102488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Impove ObjectFileELF's .dynamic parsing and usage. (PR #101237)

adrian-prantl wrote: @clayborg Based on the blamelist in https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/9352/ this broke [lldb-api.functionalities/gdb_remote_client.TestGdbClientModuleLoad.py](https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/9352/testRep

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

@@ -658,6 +659,38 @@ static char ConvertValueObjectStyleToChar( return '\0'; } +static llvm::Regex LLVMFormatPattern{"x[-+]?\\d*|n|d", llvm::Regex::IgnoreCase}; + +static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options, +V

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #91868)

adrian-prantl wrote: > Re-apply https://github.com/llvm/llvm-project/pull/81196, with a fix. It's usually helpful to indicate what/where the fix is to make it easier to re-review. https://github.com/llvm/llvm-project/pull/91868 ___ lldb-commits maili

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

adrian-prantl wrote: > A new user already asked to be assigned to work on #91209 2 days ago in the > comments. **I think that user deserves an opportunity to work on the issue**. > > Next time when you see a **"good first issue"** which a new user had already > asked to get assigned to, please

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

adrian-prantl wrote: @ZequanWu in the future, if one of your commits break a bot, make sure to revert it immediately, you can always re-land it later with a fix or an explanation why it wasn't your commit that broke the bots. Reverting a commit is cheap, red bots are expensive :-) https://git

[Lldb-commits] [lldb] [llvm] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #91880)

adrian-prantl wrote: That's just not how the LLVM project operates. I'd rather deal with two conflicting PRs than deal with an assigned orphaned issue that the assignee lost interest in. This is in the end a communication problem, and I don't mind if someone responds to the bug to say that they

[Lldb-commits] [lldb] [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #90663)

adrian-prantl wrote: > Thanks. Can you provide instructions to repro the failure locally? The bot log should have the cmake line and all the commands that were run there. https://github.com/llvm/llvm-project/pull/90663 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

adrian-prantl wrote: > No, on the terminal it works that way by design. Unless you switch to > something that takes full control of your screen (like curses) there's no > good way to display multiple progress events at the same time and not doing > the shadowing (i.e. letting more recent progr

[Lldb-commits] [lldb] [lldb] Refactor string manipulation in Debugger.cpp (#91209) (PR #92565)

@@ -2067,7 +2067,7 @@ void Debugger::HandleProgressEvent(const lldb::EventSP &event_sp) { const uint32_t term_width = GetTerminalWidth(); const uint32_t ellipsis = 3; if (message.size() + ellipsis >= term_width) -message = message.substr(0, term_width - ellipsis); +

[Lldb-commits] [lldb] [lldb] Add the word "backtrace" to bt help string (PR #92618)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/92618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Change GetChildCompilerTypeAtIndex to return Expected (NFC) (PR #92979)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/92979 This change is a general improvement of the internal API. My motivation is to use this in the Swift typesystem plugin. >From 8a6202f8ae92a62ce577271ec580379f1424f9e3 Mon Sep 17 00:00:00 2001 From: Adrian P

[Lldb-commits] [lldb] Change GetChildCompilerTypeAtIndex to return Expected (NFC) (PR #92979)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/92979 >From a8503fb49ef7964dbde318df103546bde72f7b42 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 21 May 2024 17:41:31 -0700 Subject: [PATCH] Change GetChildCompilerTypeAtIndex to return Expected (NFC)

[Lldb-commits] [lldb] Change GetChildCompilerTypeAtIndex to return Expected (NFC) (PR #92979)

https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/92979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/93209 For the significant amount of call sites that want to create an incontrovertible error, such a wrapper function creates a significant readability improvement and lowers the cost of entry to add error handl

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

adrian-prantl wrote: The obvious downside is that it makes it easier to not even try to find a matching error code, but it looks like most incontrovertible errors are caught before the get reported as an exit status. https://github.com/llvm/llvm-project/pull/93209 _

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() { if (err == 0) { if (wsaData.wVersion < wVersion) { WSACleanup(); - return llvm::make_error( - "WSASock version is not expected.", llvm::inconvertibleErrorCode()); + return llvm::createStringErro

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/93209 >From bece445681b0f810927c799cea53686cd000339b Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 23 May 2024 08:36:48 -0700 Subject: [PATCH] Add a createError variant without error code (NFC) For the

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/93209 >From c5738598436c7a9e1ba38ba8ffd6f67a2e524785 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 23 May 2024 08:36:48 -0700 Subject: [PATCH] Add a createError variant without error code (NFC) For the

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/93209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

@@ -2153,26 +2152,41 @@ bool DWARFExpression::Evaluate( } break; - case Value::ValueType::FileAddress: - case Value::ValueType::HostAddress: -if (error_ptr) { - lldb::addr_t addr = curr_piece_source_value.GetS

[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

adrian-prantl wrote: Thanks for providing the context, Lang! Inside of LLDB we use llvm::Expected often in completely closed environments where the expectation is always that all errors are handled internally and we never would exit the process with an error code, so this would be useful here.

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

@@ -52,9 +52,10 @@ __attribute__((noinline)) void func4_amb(int &sink, int x) { //% expect_cmd_failure=True) //% self.filecheck("expr sink", "main.cpp","-check-prefix=FUNC4-EXPR", //% expect_cmd_failure=True) - // FUNC4-EXPR-FAIL: couldn't get the value of variab

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate( if (pick_idx < stack.size()) stack.push_back(stack[stack.size() - 1 - pick_idx]); else { -if (error_ptr) - error_ptr->SetErrorStringWithFormat( - "Index %u out of range for

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

@@ -2341,9 +2198,7 @@ bool DWARFExpression::Evaluate( // the stack by the called expression may be used as return values by prior // agreement between the calling and called expressions. case DW_OP_call2: - if (error_ptr) -error_ptr->SetErrorString("Uni

[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

https://github.com/adrian-prantl approved this pull request. This is going to be great! Thanks. Minor nitpicks inside. https://github.com/llvm/llvm-project/pull/94420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

@@ -1758,6 +1759,11 @@ DWARFASTParserClang::ParseStructureLikeDIE(const SymbolContext &sc, } if (attrs.is_forward_declaration) { +Progress progress(llvm::formatv( +"Parsing forward declaration {0}: {1}", adrian-prantl wrote: It should either

[Lldb-commits] [lldb] [lldb][test] Add test for completing ObjCObjectType (PR #95405)

@@ -0,0 +1,10 @@ +// RUN: %clangxx_host %s -g -o %t +// +// RUN: %lldb -f %t \ +// RUN: -o "settings set interpreter.stop-command-source-on-error false" \ +// RUN: -o "b main" -o run -o "expression --language objc -- *(id)0x1234" -o exit 2>&1 | FileCheck %s adr

[Lldb-commits] [lldb] [lldb][test] Add test for completing ObjCObjectType (PR #95405)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/95405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   4   5   6   7   8   9   10   >