@@ -14690,6 +14690,13 @@ void Sema::FinalizeDeclaration(Decl *ThisDecl) {
}
}
+ // The result of __builtin_counted_by_ref cannot be assigned to a variable.
+ // It allows leaking and modification of bounds safety information.
+ if (IsBuiltinCountedByRef(VD->getInit())
https://github.com/AaronBallman commented:
Is there a branch up for this on https://llvm-compile-time-tracker.com/ so that
we've verified that this actually improves performance?
https://github.com/llvm/llvm-project/pull/116719
___
lldb-commits mailin
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
AaronBallman wrote:
Thank you for working on cleaning up these APIs! They are definitely a source
of confusion in practice, so paying down this tech debt is great!
> The names for the first two are rather verbose; I’m open to suggestions as to
> better names for these functions since that was
AaronBallman wrote:
> Looks like this change has some compile-time impact even if modules are not
> used:
> https://llvm-compile-time-tracker.com/compare.php?from=edc02351dd11cc4a39b7c541b26b71c6f36c8e55&to=7201cae106260aeb3e97d5291ff30f05076a&stat=instructions:u
> It seems to add about 0.
https://github.com/AaronBallman commented:
I think the changes LG, but please wait for our CMake experts (@petrhosek and
@Ericson2314) to review before landing.
https://github.com/llvm/llvm-project/pull/136843
___
lldb-commits mailing list
lldb-commit
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN)
set(bolt_doxygen_qhp_cust_filter_attrs "")
endif()
- option(LLVM_DOXYGEN_SVG
AaronBallman wrote:
Awesome, thanks!
https://github.com/llvm/llvm-project/pull/136843
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN)
set(bolt_doxygen_qhp_cust_filter_attrs "")
endif()
- option(LLVM_DOXYGEN_SVG
AaronBallman wrote:
Will removing the option be disruptive (particularly to downstreams)? Do we
need a deprecation period before w
AaronBallman wrote:
> > Perhaps silly initial question: why do we need a whole different qualifier
> > for this? Why can you not write `__ptrauth uintptr_t foo`?
>
> Not a silly question, back when first implemented we spent time thinking
> about this.
>
> The concern was basically `T* __ptra
AaronBallman wrote:
Perhaps silly initial question: why do we need a whole different qualifier for
this? Why can you not write `__ptrauth uintptr_t foo`?
https://github.com/llvm/llvm-project/pull/137580
___
lldb-commits mailing list
lldb-commits@lists
AaronBallman wrote:
Thank you for your patience!
In general, I think adding a new qualifier to Clang needs to come with
significant justification for the implementation and maintenance costs. In this
specific case, those costs are somewhat amortized because we already have the
`__ptrauth` qua
101 - 111 of 111 matches
Mail list logo