[Lldb-commits] [clang] [lldb] Variable template and concept template parameters (PR #150823)

2025-07-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Corentin Jabot (cor3ntin) Changes This is a first pass at implementing [P2841R7](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p2841r7.pdf). The implementation is far from complete; however, I'm aiming to do that in

[Lldb-commits] [clang] [lldb] Variable template and concept template parameters (PR #150823)

2025-07-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Corentin Jabot (cor3ntin) Changes This is a first pass at implementing [P2841R7](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p2841r7.pdf). The implementation is far from complete; however, I'm aiming to do that in chunks,

[Lldb-commits] [clang] [lldb] Variable template and concept template parameters (PR #150823)

2025-07-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Corentin Jabot (cor3ntin) Changes This is a first pass at implementing [P2841R7](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p2841r7.pdf). The implementation is far from complete; however, I'm aiming to do that in chunks, t

[Lldb-commits] [clang] [lldb] Variable template and concept template parameters (PR #150823)

2025-07-28 Thread Corentin Jabot via lldb-commits
https://github.com/cor3ntin ready_for_review https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Variable template and concept template parameters (PR #150823)

2025-07-28 Thread Corentin Jabot via lldb-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-28 Thread Ebuka Ezike via lldb-commits
@@ -242,3 +242,29 @@ def test_StackFrameFormat(self): frame = self.get_stackFrames(format={"parameters": False, "module": True})[0] self.assertEqual(frame["name"], "a.out recurse") + +def test_stackFrameModuleIdUUID(self): +program = self.getBuildA

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-28 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Sorry it took this long, my SSD died. Had to get and reinstall everything. https://github.com/llvm/llvm-project/pull/149774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-28 Thread Ebuka Ezike via lldb-commits
@@ -242,3 +242,29 @@ def test_StackFrameFormat(self): frame = self.get_stackFrames(format={"parameters": False, "module": True})[0] self.assertEqual(frame["name"], "a.out recurse") + +def test_stackFrameModuleIdUUID(self): da-viper wrote:

[Lldb-commits] [lldb] [lldb-dap] support moduleId in the stackTrace response (PR #149774)

2025-07-28 Thread Ebuka Ezike via lldb-commits
@@ -242,3 +242,29 @@ def test_StackFrameFormat(self): frame = self.get_stackFrames(format={"parameters": False, "module": True})[0] self.assertEqual(frame["name"], "a.out recurse") + +def test_stackFrameModuleIdUUID(self): +program = self.getBuildA

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From fd6b6e8a3168fc233635e783773554ac980edb46 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 01/10] [lldb][Expression] Encode Module and DIE UIDs into func

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread Jonas Devlieghere via lldb-commits
@@ -2076,6 +2076,13 @@ size_t Platform::GetSoftwareBreakpointTrapOpcode(Target &target, trap_opcode_size = sizeof(g_loongarch_opcode); } break; + case llvm::Triple::wasm32: { +// Unreachable (0x00) triggers an unconditional trap. JDevlieghere wrote

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -2076,6 +2076,13 @@ size_t Platform::GetSoftwareBreakpointTrapOpcode(Target &target, trap_opcode_size = sizeof(g_loongarch_opcode); } break; + case llvm::Triple::wasm32: { +// Unreachable (0x00) triggers an unconditional trap. DavidSpickett wrot

[Lldb-commits] [lldb] 0209e76 - [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (#145033)

2025-07-28 Thread via lldb-commits
Author: David Spickett Date: 2025-07-28T16:40:00+01:00 New Revision: 0209e76fe6440bc45a9ed61b9671d9593db10957 URL: https://github.com/llvm/llvm-project/commit/0209e76fe6440bc45a9ed61b9671d9593db10957 DIFF: https://github.com/llvm/llvm-project/commit/0209e76fe6440bc45a9ed61b9671d9593db10957.diff

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/145033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Corentin Jabot via lldb-commits
cor3ntin wrote: > I don't quite get what is happening here yet, can you give a summary of what > is being accomplished, and how you're doing so? Let me try to see if I can enlighten you a bit. P2841 very simply extends the notion of template template parameters to variable templates and conce

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
b10902118 wrote: Oh no I massed it up with github's conflict resolve. I still have to fix my previous no-reply commit. https://github.com/llvm/llvm-project/pull/147198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 382395408c4b9a38206e984328ab472c25e7c55f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 01/14] [lldb][Expression] Encode Module and DIE UIDs into func

[Lldb-commits] [lldb] [lldb][cmake] Create dependencies for LLDB header targets (PR #150995)

2025-07-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating

[Lldb-commits] [lldb] [lldb][cmake] Create dependencies for LLDB header targets (PR #150995)

2025-07-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/150995 The LLDB standalone build using Xcode currently fails due to the headers being attached to multiple targets, but none of these targets depending on each other. This commit resolves this by creating those

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/150149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
b10902118 wrote: Sorry again. I made a big mass. Just tried to recover the history but... The last five commits are today's changes. Hope that be more readable. https://github.com/llvm/llvm-project/pull/147198 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/150268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Variable template and concept template parameters (PR #150823)

2025-07-28 Thread Corentin Jabot via lldb-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Corentin Jabot via lldb-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-07-28 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks Good! 👍 Appologies for the delay :blush: https://github.com/llvm/llvm-project/pull/145033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
https://github.com/b10902118 updated https://github.com/llvm/llvm-project/pull/147198 >From 102a2f59c07dfb63cc2aabae66a0afcf60388602 Mon Sep 17 00:00:00 2001 From: b10902118 Date: Sun, 6 Jul 2025 23:50:54 +0800 Subject: [PATCH 1/9] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to ar

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
https://github.com/b10902118 updated https://github.com/llvm/llvm-project/pull/147198 >From d2bb9308217cd072af7386b90e762704786f2b90 Mon Sep 17 00:00:00 2001 From: b10902118 Date: Mon, 28 Jul 2025 23:57:51 +0800 Subject: [PATCH] Squash commits. --- .../Plugins/Process/Linux/CMakeLists.txt

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-28 Thread via lldb-commits
https://github.com/award999 converted_to_draft https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
https://github.com/b10902118 edited https://github.com/llvm/llvm-project/pull/147198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-07-28 Thread via lldb-commits
award999 wrote: OK this is not ready yet, looks like there is a bug when it is bundled in a VSIX https://github.com/winstonjs/winston-transport/issues/274 https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -235,7 +237,7 @@ void TemplateParameterList::getAssociatedConstraints( ACs.emplace_back(E); } } - if (HasRequiresClause) + if (HasRequiresClause && getRequiresClause()) erichkeane wrote: Does this mean we can now have a requires clause

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -26,115 +27,116 @@ #include namespace clang { - /// Represents the parsed form of a C++ template argument. - class ParsedTemplateArgument { - public: -/// Describes the kind of template argument that was parsed. -enum KindType { - /// A template type parame

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -1746,6 +1754,16 @@ class TemplateTemplateParmDecl final return SourceRange(getTemplateParameters()->getTemplateLoc(), End); } + TemplateNameKind kind() const { erichkeane wrote: Mild preference for `templateKind` or something like that (perhaps som

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
https://github.com/erichkeane commented: A few comments, else looks reasonable. Thanks for the explaination! https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -339,6 +339,18 @@ bool TemplateArgument::isPackExpansion() const { llvm_unreachable("Invalid TemplateArgument Kind!"); } +bool TemplateArgument::isConceptOrConceptTemplateParameter() const { + bool isConcept = false; + if (getKind() == TemplateArgument::Template) { +

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -5144,6 +5163,56 @@ bool TreeTransform::TransformTemplateArguments( } +template +template +bool TreeTransform::TransformConceptTemplateArguments( +InputIterator First, InputIterator Last, TemplateArgumentListInfo &Outputs, +bool Uneval) { + + auto isConcept = []

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -5144,6 +5163,56 @@ bool TreeTransform::TransformTemplateArguments( } +template +template +bool TreeTransform::TransformConceptTemplateArguments( +InputIterator First, InputIterator Last, TemplateArgumentListInfo &Outputs, +bool Uneval) { + + auto isConcept = []

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread satyanarayana reddy janga via lldb-commits
@@ -692,6 +692,9 @@ class MyResponder(MockGDBServerResponder): "0102030405060708" # t4 "0102030405060708" # t5 "0102030405060708" # t6 +"6162636465666768" # pc satyajanga wrote: The test also

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/148877 >From 382395408c4b9a38206e984328ab472c25e7c55f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 15 Nov 2024 01:59:36 + Subject: [PATCH 01/12] [lldb][Expression] Encode Module and DIE UIDs into func

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-07-28 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. This looks fine to me. BTW freeBSD kernel changes seems to have landed see: https://reviews.freebsd.org/D51008 https://github.com/llvm/llvm-project/pull/145029 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

2025-07-28 Thread Chad Smith via lldb-commits
@@ -220,6 +220,12 @@ ConnectionStatus ConnectionFileDescriptor::Disconnect(Status *error_ptr) { // Prevents reads and writes during shutdown. m_shutting_down = true; + if (!m_io_sp) { cs01 wrote: I will remove and possibly add in a different PR https:/

[Lldb-commits] [lldb] d26ca8b - [lldb][AArch64] Add HWCAP3 to register field detection (#145029)

2025-07-28 Thread via lldb-commits
Author: David Spickett Date: 2025-07-28T16:09:24+01:00 New Revision: d26ca8b87266024546501051ccaf75cb3756aee3 URL: https://github.com/llvm/llvm-project/commit/d26ca8b87266024546501051ccaf75cb3756aee3 DIFF: https://github.com/llvm/llvm-project/commit/d26ca8b87266024546501051ccaf75cb3756aee3.diff

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/145029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
https://github.com/erichkeane commented: I don't quite get what is happening here yet, can you give a summary of what is being accomplished, and how you're doing so? https://github.com/llvm/llvm-project/pull/150823 ___ lldb-commits mailing list lldb

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -140,15 +142,15 @@ class ConceptReference { NamedDecl *FoundDecl; /// \brief The concept named. - ConceptDecl *NamedConcept; + TemplateDecl *NamedConcept; erichkeane wrote: It seems weird for a type named `ConceptReference` to not refer to a `Concep

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-07-28 Thread Erich Keane via lldb-commits
@@ -160,7 +160,7 @@ class alignas(8) InitializedEntity { struct VD { /// The VarDecl, FieldDecl, or BindingDecl being initialized. -ValueDecl *VariableOrMember; +NamedDecl *VariableOrMember; erichkeane wrote: Should the comment above be updated?

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Show MTE store only setting in mte_ctrl (PR #145033)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/145033 >From 6abc5409e823f1de5cd2c60d228aafed2fb32465 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 19 Jun 2025 13:12:49 + Subject: [PATCH 1/2] [lldb][AArch64][Linux] Show MTE store only setting in

[Lldb-commits] [lldb] [lldb][AArch64] Add HWCAP3 to register field detection (PR #145029)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: Since that's so recent and FreeBSD is unlikely to have support for the new MTE feature, I'll leave HWCAP3 set to 0 for FreeBSD. But I'm gonna look and see if they have allocated a number for it yet, thanks for finding that. https://github.com/llvm/llvm-project/pull/145029

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
https://github.com/b10902118 updated https://github.com/llvm/llvm-project/pull/147198 >From 102a2f59c07dfb63cc2aabae66a0afcf60388602 Mon Sep 17 00:00:00 2001 From: b10902118 Date: Sun, 6 Jul 2025 23:50:54 +0800 Subject: [PATCH 1/9] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to ar

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,89 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
https://github.com/b10902118 updated https://github.com/llvm/llvm-project/pull/147198 >From b27c3f0fe8eca19bb3a261edbc10ffc51eaf08f6 Mon Sep 17 00:00:00 2001 From: b10902118 Date: Tue, 29 Jul 2025 00:36:30 +0800 Subject: [PATCH 1/9] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to a

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread via lldb-commits
https://github.com/b10902118 updated https://github.com/llvm/llvm-project/pull/147198 >From 8f4ce760ed4f5fd43cde2a3645d34b1337b97650 Mon Sep 17 00:00:00 2001 From: b10902118 Date: Tue, 29 Jul 2025 00:36:30 +0800 Subject: [PATCH 1/9] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to a

[Lldb-commits] [lldb] [lldb] [Windows] Silence format string warnings (PR #150886)

2025-07-28 Thread Martin Storsjö via lldb-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/150886 From 4ee1be1011c4579325b513f3e7459ac8d0c32a5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 28 Jul 2025 09:27:36 +0300 Subject: [PATCH 1/2] [lldb] [Windows] Silence format string w

[Lldb-commits] [lldb] [lldb] [Windows] Silence format string warnings (PR #150886)

2025-07-28 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: Tested that this still silences the warnings, on both 32 and 64 bit. https://github.com/llvm/llvm-project/pull/150886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Some small comments and you'll need to rebase when the cleanup PR lands. It's good to go in once that's done. https://github.com/llvm/llvm-project/pull/147198 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/147198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,29 @@ +//===-- NativeRegisterContextLinux_arm64dbreg.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,71 @@ +//===-- NativeRegisterContextLinux_arm64dbreg.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
@@ -737,12 +744,17 @@ Status NativeRegisterContextLinux_arm::ReadHardwareDebugInfo() { m_refresh_hwdebug_info = false; return error; +#else // __aarch64__ + return arm64::ReadHardwareDebugInfo(m_thread.GetID(), m_max_hwp_supported, +

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
@@ -737,12 +744,17 @@ Status NativeRegisterContextLinux_arm::ReadHardwareDebugInfo() { m_refresh_hwdebug_info = false; return error; +#else // __aarch64__ + return arm64::ReadHardwareDebugInfo(m_thread.GetID(), m_max_hwp_supported, +

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: >From the PR description: > After tracing linux's compat_ptrace in arch/arm64/kernel/ptrace.c, found that > arm64 lldb-server should just keep using the ptrace commands for 64bit > tracees. Reword this so it's a bit clearer. I get what you mean now, but I had to read it s

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: And by "all" I mean your current stack, not "all" of wasm debugging support. That is of an unknown scope at the moment and I'm fine with that. https://github.com/llvm/llvm-project/pull/150143 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I'll be adding the other features in separate PRs to make reviewing easier. Just for good faith purposes, can you give me a list of the parts you've got it split into at the moment and what state they are in? Done, WIP, whatever. I assume from what you've said, that it's

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-28 Thread Pavel Labath via lldb-commits
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate( // grows to the nearest host integer type. llvm::APInt fail_value(1, 0, false); llvm::APInt ap_int = scalar.UInt128(fail_value); -assert(ap_int.getBitWidth() >= bit_

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-28 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/148877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [Windows] Silence format string warnings (PR #150886)

2025-07-28 Thread Pavel Labath via lldb-commits
Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: https://github.com/labath approved this pull request. Looks good, though personally, I'd use `FromErrorStringWithFormatv` and let it deduce the format. https://github.com/llvm/llvm-project/pull/150886 ___

[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

2025-07-28 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: > > This patch still only recognizes the `xqci` from the ELF file and adds it > > to the disassembly flags (v. ObjectFileELF::GetSectionHeaderInfo, > > ObjectFileELF::ParseRISCVAttributes). > > Is this the only attribute that can be set via this mechanism? is it > > possibl

[Lldb-commits] [lldb] [lldb] Fix updating persistent variables without JIT (PR #149642)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Not really an expert here but it's clear enough for me to approve. Wait a couple of days in case someone has other comments. If not, please merge, or I can do so for you. https://github.com/llvm/llvm-project/pull/149642 _

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/150268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Looks good to me, nice to see more GDB compatibility, but I'll leave it to your chosen reviewers to approve. https://github.com/llvm/llvm-project/pull/150268 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] [lldb] support ieee_single and ieee_double gdbtypes for registers (PR #150268)

2025-07-28 Thread David Spickett via lldb-commits
@@ -692,6 +692,9 @@ class MyResponder(MockGDBServerResponder): "0102030405060708" # t4 "0102030405060708" # t5 "0102030405060708" # t6 +"6162636465666768" # pc DavidSpickett wrote: I guess tha

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
@@ -74,8 +75,10 @@ class NativeRegisterContextLinux_arm : public NativeRegisterContextLinux { bool WatchpointIsEnabled(uint32_t wp_index); - // Debug register type select - enum DREGType { eDREGTypeWATCH = 0, eDREGTypeBREAK }; + using DREGType = NativeRegisterContextDBR

[Lldb-commits] [lldb] [lldb] [Windows] Silence format string warnings (PR #150886)

2025-07-28 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: > Oh but is there a Mingw detail here that means the cast is better? No, mingw should conform quite closely regarding such details. I just didn't feel like assuming such details about the type of DWORD, but you're right, and it should be fine to do that instead. Will update. h

[Lldb-commits] [lldb] [LLDB][NativePDB] Allow type lookup in namespaces (PR #149876)

2025-07-28 Thread Pavel Labath via lldb-commits
@@ -134,7 +134,9 @@ bool TypeQuery::ContextMatches( if (ctx == ctx_end) return false; // Pattern too long. -if (ctx->kind == CompilerContextKind::Namespace && ctx->name.IsEmpty()) { +if ((ctx->kind & CompilerContextKind::Namespace) == labath

[Lldb-commits] [lldb] [lldb][Arm32] Remove unused refcount. (PR #150770)

2025-07-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/150770 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Arm32] Remove unused refcount. (PR #150770)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please setup your Github email settings according to https://llvm.org/docs/DeveloperPolicy.html#email-addresses. It does generate a "co-authored by" using what I assume is a valid email address, but the commit email is still a github noreply. A co author tag *might* be ok

[Lldb-commits] [lldb] [lldb] [Windows] Silence format string warnings (PR #150886)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: Should you use `%lu` instead of casting? https://learn.microsoft.com/en-gb/windows/win32/winprog/windows-data-types?redirectedfrom=MSDN: ``` A 32-bit unsigned integer. The range is 0 through 4294967295 decimal. This type is declared in IntSafe.h as follows: typedef unsigned

[Lldb-commits] [lldb] [lldb] [Windows] Silence format string warnings (PR #150886)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: Oh but is there a Mingw detail here that means the cast is better? https://github.com/llvm/llvm-project/pull/150886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-28 Thread Pavel Labath via lldb-commits
@@ -1775,16 +1775,20 @@ def no_reason(_): attrvalue, "__no_debug_info_test__", False ): # If any debug info categories were explicitly tagged, assume that list to be -# authoritative. If none were specified, try with

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/150579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-28 Thread Pavel Labath via lldb-commits
@@ -1775,16 +1775,20 @@ def no_reason(_): attrvalue, "__no_debug_info_test__", False ): # If any debug info categories were explicitly tagged, assume that list to be -# authoritative. If none were specified, try with

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,131 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-07-28 Thread Pavel Labath via lldb-commits
labath wrote: Would it make sense to also remove the `inOtherRegister` case (make it a special case of this one with offset=0)? https://github.com/llvm/llvm-project/pull/150732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,131 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-07-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: Linux CI failure is: ``` 2025-07-28T08:45:11.0284286Z sccache /opt/llvm/bin/clang++ -DEXPERIMENTAL_KEY_INSTRUCTIONS -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__SHORT

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -2076,6 +2076,13 @@ size_t Platform::GetSoftwareBreakpointTrapOpcode(Target &target, trap_opcode_size = sizeof(g_loongarch_opcode); } break; + case llvm::Triple::wasm32: { +// Unreachable (0x00) triggers an unconditional trap. DavidSpickett wrot

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -1998,6 +1998,19 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWasmCallStack + +Get the Wasm callback for the given thread id. This returns a hex-encoding list +of 64-bit addre

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,85 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -1998,6 +1998,19 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWasmCallStack + +Get the Wasm callback for the given thread id. This returns a hex-encoding list +of 64-bit addre

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,131 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -1998,6 +1998,19 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWasmCallStack + +Get the Wasm callback for the given thread id. This returns a hex-encoding list

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -1998,6 +1998,19 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWasmCallStack + +Get the Wasm callback for the given thread id. This returns a hex-encoding list +of 64-bit addre

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,89 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-28 Thread Pavel Labath via lldb-commits
@@ -2471,6 +2471,47 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +llvm::Error +SymbolFileDWARF::FindAndResolveFunction(SymbolContextList &sc_list, +llvm::StringRef lookup_name) { + std::lock_guar

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

  1   2   >