[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-07-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/144368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please change your email settings as explained in https://llvm.org/docs/DeveloperPolicy.html#email-addresses. Right now it would be merged with a GitHub noreply address. https://github.com/llvm/llvm-project/pull/144368 ___ lldb-c

[Lldb-commits] [clang] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-24 Thread Cả thế giới là Rust via lldb-commits
https://github.com/naoNao89 updated https://github.com/llvm/llvm-project/pull/150365 From 2d9ae771247af025d6319c044e9f8727e9bebfd8 Mon Sep 17 00:00:00 2001 From: naoNao89 <90588855+naona...@users.noreply.github.com> Date: Wed, 23 Jul 2025 20:54:02 +0700 Subject: [PATCH 1/2] [clang][StaticAnalyze

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr created https://github.com/llvm/llvm-project/pull/150382 I wasn't able to build lldb using Mingw-w64 on Windows without changing 3 lines. >From e03e5b5840ba0ee95faa62ee0863a52f11fcc030 Mon Sep 17 00:00:00 2001 From: cvspvr <37761007+cvs...@users.noreply.github.com> Dat

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cvspvr) Changes I wasn't able to build lldb using Mingw-w64 on Windows without changing 3 lines. --- Full diff: https://github.com/llvm/llvm-project/pull/150382.diff 2 Files Affected: - (modified) lldb/source/Host/windows/MainLoopW

[Lldb-commits] [clang] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett requested changes to this pull request. I'm going to go out on a limb and suggest that a certain sort of assistive interactive tool was used to generate this. Which I don't venture an opinion on in general but in this case, it's didn't do so well. A glance at t

[Lldb-commits] [lldb] [LLDB] Make MSVC STL formatters work with (Native/DIA) PDB (PR #150513)

2025-07-24 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/150513 Some formatters for the MSVC STL didn't work with the PDB symbol file plugins. They were only tested with DWARF. The individual changes are quite small (except for variant), so I'm not sure if they should be se

[Lldb-commits] [lldb] [LLDB] Make MSVC STL formatters work with (Native/DIA) PDB (PR #150513)

2025-07-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Some formatters for the MSVC STL didn't work with the PDB symbol file plugins. They were only tested with DWARF. The individual changes are quite small (except for variant), so I'm not sure if they should be separat

[Lldb-commits] [lldb] [lldb] Fix uninitialized memory access. (PR #150544)

2025-07-24 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/20338 Here is the relevant p

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/147655 >From fd971a1109662f763b2c273fb39d2ef431afbe60 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 24 Jul 2025 14:05:55 -0700 Subject: [PATCH 1/4] [lldb][rpc] Add RPC client library tests Adds she

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-24 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/150579 When debug info categories were set for a test method with the `@add_test_categories` decorator, they were all added to its "categories" attribute. If some of these categories were not supported, `LLDBTestR

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) Changes When debug info categories were set for a test method with the `@add_test_categories` decorator, they were all added to its "categories" attribute. If some of these categories were not supported, `LLDBTestR

[Lldb-commits] [lldb] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows (PR #150579)

2025-07-24 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/150579 >From a302c52a378ca5aed5092dbc29ba75447466a66c Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 24 Jul 2025 23:46:37 -0700 Subject: [PATCH] [lldb][test] Fix running TestWithLimitDebugInfo.py on Windows

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-07-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/137383 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4396c87 - [lldb][docs] Update instructions to build standalone (#137383)

2025-07-24 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2025-07-24T12:43:52-07:00 New Revision: 4396c87bfee23ccbb6a106866d28350f5cc08ded URL: https://github.com/llvm/llvm-project/commit/4396c87bfee23ccbb6a106866d28350f5cc08ded DIFF: https://github.com/llvm/llvm-project/commit/4396c87bfee23ccbb6a106866d28350f5cc08ded.d

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jason Molenda via lldb-commits
@@ -1998,6 +1998,18 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWasmCallStack + +Get the Wasm callback for the given thread id. This returns a hex-encoding list +of 64-bit addre

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jason Molenda via lldb-commits
@@ -1998,6 +1998,18 @@ threads (live system debug) / cores (JTAG) in your program have stopped and allows LLDB to display and control your program correctly. +## qWasmCallStack + +Get the Wasm callback for the given thread id. This returns a hex-encoding list +of 64-bit addre

[Lldb-commits] [lldb] [lldb] Fix uninitialized memory access. (PR #150544)

2025-07-24 Thread Jorge Gorbe Moya via lldb-commits
https://github.com/slackito created https://github.com/llvm/llvm-project/pull/150544 lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump64b.py fails under msan with uninitialized memory access errors. The problem is that a few structs are written to the dump wi

[Lldb-commits] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-24 Thread Cả thế giới là Rust via lldb-commits
https://github.com/naoNao89 updated https://github.com/llvm/llvm-project/pull/150365 From 445777d5bfde3dd361dff62212b37534f87f2756 Mon Sep 17 00:00:00 2001 From: naoNao89 <90588855+naona...@users.noreply.github.com> Date: Thu, 24 Jul 2025 10:29:46 +0700 Subject: [PATCH 1/3] [lldb-dap] Add perfor

[Lldb-commits] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-24 Thread Cả thế giới là Rust via lldb-commits
https://github.com/naoNao89 edited https://github.com/llvm/llvm-project/pull/150365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include + +#include "lldb/API/SBDefines.h" + +namespace lldb { +class LLDB_API SBRPC_CHECKARRAYPTR { medismailben wrote: +1 https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-07-24 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,20 @@ +#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H +#define LLDB_API_SBRPC_CHECKARRAYPTR_H + +#include +#include medismailben wrote: Make sure to remove this from every test https://github.com/llvm/llvm-project/pull/147655 __

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Quentin Michaud via lldb-commits
@@ -0,0 +1,81 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-07-24 Thread Pavel Labath via lldb-commits
labath wrote: Don't take this to imply I'm against removing the non-native plugin (I'm not, I'd very much like to get rid of it myself), but here are a couple of alternatives: - it has always bothered me that this is controlled by an environment variable. The original justification was that it

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Certainly lldb being in this conversation early would be a good way to prevent the reliance on GDB specific behaviour that often happens in the native debugging world. https://github.com/llvm/llvm-project/pull/150143 ___ lldb-com

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Long term, if the WASM standard makes recommendations for debugging then that's great. You are correct there. Short term, users will need to know what to expect so we need a short, simple, answer to "I tried lldb with whatever runtime and it didn't work". Which ideally is

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -2471,6 +2471,47 @@ bool SymbolFileDWARF::ResolveFunction(const DWARFDIE &orig_die, return false; } +llvm::Error +SymbolFileDWARF::FindAndResolveFunction(SymbolContextList &sc_list, +llvm::StringRef lookup_name) { + std::lock_guar

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -771,6 +774,63 @@ class LoadAddressResolver { lldb::addr_t m_best_internal_load_address = LLDB_INVALID_ADDRESS; }; +/// Returns address of the function referred to by the special function call +/// label \c label. +/// +/// \param[in] label Function call label encoding th

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -121,6 +121,15 @@ size_t Module::GetNumberAllocatedModules() { return GetModuleCollection().size(); } +Module *Module::GetAllocatedModuleWithUID(lldb::user_id_t uid) { + std::lock_guard guard( + GetAllocationModuleCollectionMutex()); + for (Module *mod : GetModuleC

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -130,8 +139,11 @@ Module *Module::GetAllocatedModuleAtIndex(size_t idx) { return nullptr; } +// TODO: needs a mutex labath wrote: .. or you can make it an atomic. https://github.com/llvm/llvm-project/pull/148877 _

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -130,8 +139,11 @@ Module *Module::GetAllocatedModuleAtIndex(size_t idx) { return nullptr; } +// TODO: needs a mutex +static lldb::user_id_t g_unique_id = 1; + Module::Module(const ModuleSpec &module_spec) -: m_unwind_table(*this), m_file_has_changed(false), +: Us

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -249,6 +250,28 @@ static unsigned GetCXXMethodCVQuals(const DWARFDIE &subprogram, return cv_quals; } +static std::optional MakeLLDBFuncAsmLabel(const DWARFDIE &die) { + char const *name = die.GetMangledName(/*substitute_name_allowed*/ false); + if (!name) +return s

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -9759,3 +9782,51 @@ void TypeSystemClang::LogCreation() const { LLDB_LOG(log, "Created new TypeSystem for (ASTContext*){0:x} '{1}'", &getASTContext(), getDisplayName()); } + +// Expected format is: +// $__lldb_func::: labath wrote: Maybe pu

[Lldb-commits] [lldb] [lldb][Expression] Encode Module and DIE UIDs into function AsmLabels (PR #148877)

2025-07-24 Thread Pavel Labath via lldb-commits
@@ -96,6 +96,31 @@ class Expression { ///invalid. }; +/// Holds parsed information about a function call label that +/// LLDB attaches as an AsmLabel to function AST nodes it parses +/// from debug-info. +/// +/// The format being: +/// +///

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
@@ -0,0 +1,81 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-24 Thread Pavel Labath via lldb-commits
labath wrote: The command does seem rather specialized. Being able to see where a piece of memory was mapped to is useful even if you can't read that piece of memory, but I can definitely imagine the "memory region" command flagging this specially in some way. Not sure how though... https://g

[Lldb-commits] [clang] [lldb] [Serialization] Support loading template specializations lazily (PR #119333)

2025-07-24 Thread Michael Jabbour via lldb-commits
michael-jabbour-sonarsource wrote: Hello, We have encountered crashes after this patch, with stack traces that look like this: ``` PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. Stack

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Quentin Michaud via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/150382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please configure your email settings as explained here https://llvm.org/docs/DeveloperPolicy.html#email-addresses, and then we will merge this. https://github.com/llvm/llvm-project/pull/150382 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Seems harmless enough, thanks for the fix. Surprised @mstorsjo didn't already hit this, but maybe they will appreciate the fix. https://github.com/llvm/llvm-project/pull/150382 ___ lldb-com

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett deleted https://github.com/llvm/llvm-project/pull/150143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: > process connect --plugin wasm connect://localhost:4567 On the original review, auto-detection of the plugin wasn't working which meant this `plugin wasm` was needed. Did you ever find out what was the cause? I presume lldb still has a local copy of the program file, so i

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr updated https://github.com/llvm/llvm-project/pull/150382 >From e03e5b5840ba0ee95faa62ee0863a52f11fcc030 Mon Sep 17 00:00:00 2001 From: cvspvr <37761007+cvs...@users.noreply.github.com> Date: Thu, 24 Jul 2025 17:15:01 +1000 Subject: [PATCH 1/2] Update MainLoopWindows.cpp

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Quentin Michaud via lldb-commits
mh4ck-Thales wrote: Thanks for picking up the work on this! > I'm not aware of any other runtimes besides WAMR that support debugging > through GDB remote. Of all the approaches, I think it's the most "desirable" > going forward. The fact that there is a ByteCode Alliance runtime that > suppo

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead processes on Linux (PR #137041)

2025-07-24 Thread Pavel Labath via lldb-commits
labath wrote: Sorry about the delay. I'm not sure I understand the question, but the way I'm imagining this is to let the server communicate the "is it safe to resume" bit to the client. After that, the client can do whatever it wants/needs (e.g. disable jitting/expression evaluation). I thin

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150396)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr closed https://github.com/llvm/llvm-project/pull/150396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr created https://github.com/llvm/llvm-project/pull/150398 I wasn't able to build lldb using Mingw-w64 on Windows without changing these 3 lines. Sorry for opening another pull request. I closed the old one because I don't know how to update it to fix the Clang formatt

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-24 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Also can we get a vague idea of how many more PRs are in the stack for this? Just so save me asking "why is X missing" over and over. https://github.com/llvm/llvm-project/pull/150143 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [clang] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-24 Thread Balazs Benics via lldb-commits
steakhal wrote: I don't know how the Static Analyzer is involved here. This is definitely strange. https://github.com/llvm/llvm-project/pull/150365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [LLDB] Process minidump is in memory check command (PR #149401)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: Would this be helped with better error messages? ``` $ ./bin/lldb /tmp/test.o --core core.test.o.2152361.tcwg-jade-03-dev.1753366442 (lldb) target create "/tmp/test.o" --core "core.test.o.2152361.tcwg-jade-03-dev.1753366442" Core file '/home/david.spickett/build-llvm-aarc

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova approved this pull request. This actually does get used, but the patches that use this haven't landed yet, so they can be removed for now. https://github.com/llvm/llvm-project/pull/150366 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][headers] Fix header staging target for RPC (PR #150355)

2025-07-24 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: This failure looks to be unrelated to this patch. https://github.com/llvm/llvm-project/pull/150355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > > process connect --plugin wasm connect://localhost:4567 > > On the original review, auto-detection of the plugin wasn't working which > meant this `plugin wasm` was needed. Did you ever find out what was the > cause? I presume lldb still has a local copy of the program f

[Lldb-commits] [lldb] 29b9bdf - [lldb] Remove HasCallbackParameter (#150366)

2025-07-24 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-07-24T09:39:28-07:00 New Revision: 29b9bdf81eba6d0445b0fb84ed42e289cd0940eb URL: https://github.com/llvm/llvm-project/commit/29b9bdf81eba6d0445b0fb84ed42e289cd0940eb DIFF: https://github.com/llvm/llvm-project/commit/29b9bdf81eba6d0445b0fb84ed42e289cd0940eb.diff L

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-24 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/150366 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

2025-07-24 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > This actually does get used, but the patches that use this haven't landed > yet, so they can be removed for now. Thanks for the review! When you re-introduce it, would you mind converting this to a range-based for loop? Thanks again! https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-24 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > The process for that is > [here](https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches), > though it's a bit unfortunate that a week has passed since then (I was OOO > this week so I couldn't reply sooner). At this point, I'm no longer sure it > makes sen

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-07-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/137383 >From a098529886955330080e9135f947910c306d1c4a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Fri, 25 Apr 2025 11:57:30 -0700 Subject: [PATCH] [lldb][docs] Update instructions to build standalone

[Lldb-commits] [clang] [lldb] [lldb-dap] Add performance optimization options to improve launch times (PR #150365)

2025-07-24 Thread via lldb-commits
jimingham wrote: How are timeout lengths relevant to a successful launch? In a successful launch nothing should be timing out, and if it is that's generally either something we shouldn't have been trying to do, or an error where shortening the timeout isn't going to help. In the former cas

[Lldb-commits] [lldb] [llvm] [LLDB] Switch to using DIL as default implementation for 'frame var'. (PR #147887)

2025-07-24 Thread Pavel Labath via lldb-commits
labath wrote: In that case, please create the cherry pick as soon as possible, and we can see where that discussion leads us. For myself, I'm going to defer @JDevlieghere opinion. https://github.com/llvm/llvm-project/pull/147887 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-24 Thread Greg Clayton via lldb-commits
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate( // grows to the nearest host integer type. llvm::APInt fail_value(1, 0, false); llvm::APInt ap_int = scalar.UInt128(fail_value); -assert(ap_int.getBitWidth() >= bit_

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-24 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. I am good with this. We should wait for anyone else to chime in for a day or two. https://github.com/llvm/llvm-project/pull/150149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-24 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/150149 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-24 Thread Greg Clayton via lldb-commits
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate( // grows to the nearest host integer type. llvm::APInt fail_value(1, 0, false); llvm::APInt ap_int = scalar.UInt128(fail_value); -assert(ap_int.getBitWidth() >= bit_

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Alex Crichton via lldb-commits
alexcrichton wrote: > I'm bringing @alexcrichton into the loop, he's involved in the Bytecode > Alliance and LLVM, maybe he'll be able to help us on these topics. 👋 FWIW I'm very much an outsider here so I don't fully understand all the dynamics in play per se, but what I can speak more to i

[Lldb-commits] [lldb] [lldb] Zero extend APInt when piece size is bigger than the bitwidth (PR #150149)

2025-07-24 Thread Greg Clayton via lldb-commits
clayborg wrote: I added Pavel Labath and David Blaikie in case they have any info on this. The story if we have some RiscV code that is creating location values for variables that use DW_OP_piece and they are using: ``` DW_OP_lit0, DW_OP_stack_value, DW_OP_piece 0x28 ``` to try and zero fill i

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
@@ -2076,6 +2076,12 @@ size_t Platform::GetSoftwareBreakpointTrapOpcode(Target &target, trap_opcode_size = sizeof(g_loongarch_opcode); } break; + case llvm::Triple::wasm32: { +static const uint8_t g_wasm_opcode[] = {0x00}; // unreachable JDevlieghe

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// JDevlieghere wrote: Yes, this was changed with https://discourse.llvm.org/t/is-c-in-header-files-still-relevant/83124/. New files shouldn't have the filename or

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Sure, so this is like qemu-user? You want to debug the wasm process being > hosted within the runtime not the runtime itself. > > Because the internet is 99% "use a web browser" for debug, then > https://docs.wasmtime.dev/examples-debugging-native-debugger.html seems to be

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][docs] Update instructions to build standalone (PR #137383)

2025-07-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/137383 >From a098529886955330080e9135f947910c306d1c4a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Fri, 25 Apr 2025 11:57:30 -0700 Subject: [PATCH] [lldb][docs] Update instructions to build standalone

[Lldb-commits] [lldb] Draft: [LLDB] Add scalar literal node (PR #147064)

2025-07-24 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > We can definitely add functions to covert (directly) between Scalars and > ValueObjects (in fact, I think the only reason that the APInt overloads > currently exists is because of the initial attempt to upstream the DIL > implementation). Ah, I didn't know that, I think I joi

[Lldb-commits] [lldb] Draft: [LLDB] Add scalar literal node (PR #147064)

2025-07-24 Thread Pavel Labath via lldb-commits
labath wrote: > single interface to traverse the AST tree: That's the part that would change in this setup. Instead of one API, we'd have two: `EvaluateValueNode()` and `EvaluateScalarNode()`, and we'd have two node hierarchies: ValueNode and ScalarNode. MemberOfNode would be a ValueNode beca

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Nick Fitzgerald via lldb-commits
fitzgen wrote: Great to see more interest in WebAssembly from `lld`, and thanks for sharing our debugging plans here, @alexcrichton. > We do not currently have anyone slated to implement this work as it hasn't > been a priority for existing maintainers yet and we haven't had other > voluntee

[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-07-24 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/150331 >From b79edf938d49d03498ec3a9228344a684d0cbf6e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Wed, 23 Jul 2025 15:17:29 -0700 Subject: [PATCH 1/3] [LLDB] added getName method in SBModule --- lldb/inc

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is an overly harsh way of phrasing it, but hopefully it gives you an idea of why I'm asking for an overview of this effort: * We already have at least one barely tested architecture, I would like to avoid picking up another one. I think WASM is cool (all WASM userspac

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
@@ -323,6 +323,11 @@ ProcessGDBRemote::~ProcessGDBRemote() { KillDebugserverProcess(); } +std::shared_ptr DavidSpickett wrote: `static` https://github.com/llvm/llvm-project/pull/150143 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150396)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr created https://github.com/llvm/llvm-project/pull/150396 I wasn't able to build lldb using Mingw-w64 on Windows without changing 3 lines. >From 8f8169dd2e63e782a28362d4e4f64595de29e9ce Mon Sep 17 00:00:00 2001 From: cvspvr Date: Thu, 24 Jul 2025 19:54:50 +1000 Subject

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150396)

2025-07-24 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150396)

2025-07-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cvspvr) Changes I wasn't able to build lldb using Mingw-w64 on Windows without changing 3 lines. --- Full diff: https://github.com/llvm/llvm-project/pull/150396.diff 1 Files Affected: - (modified) lldb/source/Host/windows/PipeWindo

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr closed https://github.com/llvm/llvm-project/pull/150382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150396)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr edited https://github.com/llvm/llvm-project/pull/150396 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cvspvr) Changes I wasn't able to build lldb using Mingw-w64 on Windows without changing these 3 lines. Sorry for opening another pull request. I closed the old one because I don't know how to update it to fix the Clang formatting er

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150398)

2025-07-24 Thread via lldb-commits
https://github.com/cvspvr edited https://github.com/llvm/llvm-project/pull/150398 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I've been told that the runtime can have a different stack (separate from the > native stack) for the Wasm code and also that the format of call frames may > not match native stack frame ABI. Sure, so this is like qemu-user? You want to debug the wasm process being host

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Developer Policy](https://llvm.org/docs/DeveloperPol

[Lldb-commits] [lldb] [lldb] Allow building using Mingw-w64 on Windows. (PR #150382)

2025-07-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Host/windows/MainLoopWindows.cpp lldb/so

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Quentin Michaud via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-07-24 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > > I can't find where a `Stream` actually gets "printed" to the stdout. > > A `NativeFile` stream is used, which is created > [here](https://github.com/llvm/llvm-project/blob/a676ecd83fad9b04d315c4e667742d25679cbc9f/lldb/source/Core/Debugger.cpp#L967-L970). > > > [2b8c69

[Lldb-commits] [lldb] Draft: [LLDB] Add scalar literal node (PR #147064)

2025-07-24 Thread Pavel Labath via lldb-commits
labath wrote: > 1. Constant wrapping/unwrapping of Scalar(APInt). For literals, it goes: > parse as APInt -> wrap to Scalar to create a node -> unwrap APInt to create > ValueObjectSP -> wrap to Scalar to use arithmetic operation -> unwrap APInt > to create ValueObjectSP. Not sure if it's a pro

[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

2025-07-24 Thread Quentin Michaud via lldb-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

  1   2   >