[Lldb-commits] [lldb] [lldb][Formatters] Consistently unwrap pointer element_type in std::shared_ptr formatters (PR #147340)

2025-07-07 Thread Pavel Labath via lldb-commits
labath wrote: I'm not entirely comfortable with putting the (obviously c++ specific) helper function into the DataFormatters) library. There's no reason to call this from outside the c++ language plugin, right? What would you say to putting this into some header inside the plugin (or creating

[Lldb-commits] [lldb] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-07 Thread Abdullah Mohammad Amin via lldb-commits
https://github.com/UltimateForce21 created https://github.com/llvm/llvm-project/pull/147460 This PR builds upon the functionality introduced in [PR #144238](https://github.com/llvm/llvm-project/pull/144238), which adds support for annotating disassembly output with DWARF variable locations. T

[Lldb-commits] [lldb] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-07 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Annotate disassembly with register‐resident variable locations (PR #147460)

2025-07-07 Thread Abdullah Mohammad Amin via lldb-commits
UltimateForce21 wrote: @JDevlieghere @adrian-prantl I have created the [PR #144238](https://github.com/llvm/llvm-project/pull/144238) dependent Rich Disassembler Annotations PR. https://github.com/llvm/llvm-project/pull/147460 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (PR #147031)

2025-07-07 Thread Pavel Labath via lldb-commits
@@ -1,7 +1,5 @@ CXX_SOURCES := main.cpp -USE_LIBCPP := 1 - # We need debug info tuning for lldb in order to emit the preferred name for # std::string. See https://reviews.llvm.org/D145803. CXXFLAGS_EXTRAS := -std=c++14 -glldb labath wrote: Good idea. https

[Lldb-commits] [lldb] [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (PR #147031)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ tuple tests into generic test (PR #147139)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147139 >From 5835f9f8adfbbafba9fb3ecea9b339bd82b0ba19 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 5 Jul 2025 11:15:23 +0100 Subject: [PATCH 1/4] [lldb][test] Combine libstdc++ and libc++ tuple tests into

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ iterator tests into generic test (PR #147175)

2025-07-07 Thread Pavel Labath via lldb-commits
labath wrote: It looks like the libstdc++ test just crashes. https://github.com/llvm/llvm-project/pull/147175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::shared_ptr tests into generic test (PR #147141)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147141 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ tuple tests into generic test (PR #147139)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147139 >From 5835f9f8adfbbafba9fb3ecea9b339bd82b0ba19 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 5 Jul 2025 11:15:23 +0100 Subject: [PATCH 1/3] [lldb][test] Combine libstdc++ and libc++ tuple tests into

[Lldb-commits] [lldb] 074ccde - [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (#147031)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T10:13:03+01:00 New Revision: 074ccde3b092ed231d344d4ffad50de93438196c URL: https://github.com/llvm/llvm-project/commit/074ccde3b092ed231d344d4ffad50de93438196c DIFF: https://github.com/llvm/llvm-project/commit/074ccde3b092ed231d344d4ffad50de93438196c.diff

[Lldb-commits] [lldb] [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (PR #147031)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (PR #147253)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/147253 This combines the libc++ and libstdc++ test cases. The libstdc++ test had an additional test-case for "reference to typedef". So I added those to the generic test. The rest of the tests was the same as libc+

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (PR #147253)

2025-07-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This combines the libc++ and libstdc++ test cases. The libstdc++ test had an additional test-case for "reference to typedef". So I added those to the generic test. The rest of the tests was the same as lib

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (PR #147253)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/147253 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread Michael Buch via lldb-commits
@@ -0,0 +1,39 @@ +""" +Test lldb behaves sanely when formatting corrupted `std::string`s. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class LibcxxInvalidStringDataFormatterTestCase(Te

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
Michael137 wrote: > Looking up global variables is not completely ideal (can be slow and look up > unrelated things). Would index_obj.GetValueAs**Signed**() == -1 work by any > chance? Actually after some more investigating it turns out the test was just flawed. A default-constructed variant

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/147283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter tests for valueless variants (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/147283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (PR #147031)

2025-07-07 Thread Pavel Labath via lldb-commits
labath wrote: (The test is failing due to std::make_unique not being defined. I'd be fine both with bringing back -std=c++14 and using explicit construction.) https://github.com/llvm/llvm-project/pull/147031 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] b7d4735 - [lldb][test] Combine libstdc++ and libc++ vector tests into generic test (#147137)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T08:39:47+01:00 New Revision: b7d4735a0e2a65c27aa74a56e19020a34de790fe URL: https://github.com/llvm/llvm-project/commit/b7d4735a0e2a65c27aa74a56e19020a34de790fe DIFF: https://github.com/llvm/llvm-project/commit/b7d4735a0e2a65c27aa74a56e19020a34de790fe.diff

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ vector tests into generic test (PR #147137)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::shared_ptr tests into generic test (PR #147141)

2025-07-07 Thread Michael Buch via lldb-commits
Michael137 wrote: > There are two failures: > > * the libc++ pointer child is called `__ptr_`, not `pointer`. I think we > should clone/rename the child so that the child has a consistent name. This > could be particularly useful for writing other data formatters, which may > want to dere

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/147252 As a pre-requisite to combine the libcxx and libstdcxx string formatter tests (see https://github.com/llvm/llvm-project/pull/146740) this patch splits out the libcxx specific parts into a separate test. The

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes As a pre-requisite to combine the libcxx and libstdcxx string formatter tests (see https://github.com/llvm/llvm-project/pull/146740) this patch splits out the libcxx specific parts into a separate test. T

[Lldb-commits] [lldb] 912ab52 - [lldb][test] Adjust import-std-module shared_ptr/weak_ptr tests

2025-07-07 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-07-07T11:22:55+01:00 New Revision: 912ab5241379b4dd525080cd9a3e468d6779340c URL: https://github.com/llvm/llvm-project/commit/912ab5241379b4dd525080cd9a3e468d6779340c DIFF: https://github.com/llvm/llvm-project/commit/912ab5241379b4dd525080cd9a3e468d6779340c.diff

[Lldb-commits] [lldb] c19c71b - [lldb][test] Split out libc++ std::string tests that check corrupted strings (#147252)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T11:33:33+01:00 New Revision: c19c71b90593dcbb94a9592d7cf75e58c99df6da URL: https://github.com/llvm/llvm-project/commit/c19c71b90593dcbb94a9592d7cf75e58c99df6da DIFF: https://github.com/llvm/llvm-project/commit/c19c71b90593dcbb94a9592d7cf75e58c99df6da.diff

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147252 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (PR #147253)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147253 >From 1ea1e91899edc945030c02b6e84adedb48d7aa57 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 09:58:02 +0100 Subject: [PATCH 1/2] [lldb][test] Combine libstdc++ and libc++ std::variant tes

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Instead of using the byte-size to make a guess at what the `std::variant_npos` value is, just look it up in debug-info. Unblocks https://github.com/llvm/llvm-project/pull/147253 --- Full diff: https://git

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Looking up global variables is not completely ideal (can be slow and look up unrelated things). Would index_obj.GetValueAs**Signed**() == -1 work by any chance? https://github.com/llvm/llvm-project/pull/147283 ___

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Andrew Savonichev via lldb-commits
https://github.com/asavonic created https://github.com/llvm/llvm-project/pull/147289 Shared modules are stored in a global `ModuleList` cache, and it is intentionally leaked to avoid doing cleanup when lldb exits. However, when lldb is used as a library, we need a way to manage opened modules

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Andrew Savonichev (asavonic) Changes Shared modules are stored in a global `ModuleList` cache, and it is intentionally leaked to avoid doing cleanup when lldb exits. However, when lldb is used as a library, we need a way to manage opened m

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Andrew Savonichev via lldb-commits
asavonic wrote: > Python code formatter, darker found issues in your code. Fixed. https://github.com/llvm/llvm-project/pull/147289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/python_api/debugger/TestDebuggerAPI.py `` View th

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Andrew Savonichev via lldb-commits
https://github.com/asavonic updated https://github.com/llvm/llvm-project/pull/147289 >From a01eb1943afb03d1dc9439e9ae8f3a01b8c15398 Mon Sep 17 00:00:00 2001 From: Andrew Savonichev Date: Mon, 7 Jul 2025 17:33:50 +0900 Subject: [PATCH] [lldb] Clear ModuleList shared modules in SBDebugger::Clear

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147283 >From be3eb2431b0649ce2730a4cf832dc474e262f49e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Jul 2025 12:40:37 +0100 Subject: [PATCH 1/3] [lldb][test] Fix libstdc++ std::variant formatter for empt

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread via lldb-commits
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { unsigned NumExpansions; }; + enum class PredefinedSugarKind { +/// The "size_t" type. +SizeT, + +/// The signed integer type corresponding to "size_t". --

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter tests for valueless variants (PR #147283)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Cool. Thanks for looking into this. https://github.com/llvm/llvm-project/pull/147283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] 9ebe6f9 - [lldb][test] Fix libstdc++ std::variant formatter tests for valueless variants (#147283)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T14:28:19+01:00 New Revision: 9ebe6f9a1f9e3473166cd57282c9827df12416a3 URL: https://github.com/llvm/llvm-project/commit/9ebe6f9a1f9e3473166cd57282c9827df12416a3 DIFF: https://github.com/llvm/llvm-project/commit/9ebe6f9a1f9e3473166cd57282c9827df12416a3.diff

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter tests for valueless variants (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::shared_ptr tests into generic test (PR #147141)

2025-07-07 Thread Pavel Labath via lldb-commits
labath wrote: There are two failures: - the libc++ pointer child is called `__ptr_`, not `pointer`. I think we should clone/rename the child so that the child has a consistent name. This could be particularly useful for writing other data formatters, which may want to dereference a shared_ptr

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147252 >From 81f856c7c851d5b03ddd176977e7d0c55e7c7f6f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 09:47:39 +0100 Subject: [PATCH 1/3] [lldb][test] Split out libc++ std::string tests that check

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147252 >From 81f856c7c851d5b03ddd176977e7d0c55e7c7f6f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 09:47:39 +0100 Subject: [PATCH 1/2] [lldb][test] Split out libc++ std::string tests that check

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -320,6 +320,92 @@ bool clang::analyze_format_string::ParseUTF8InvalidSpecifier( // Methods on ArgType. //===--===// +static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT, +

[Lldb-commits] [lldb] [lldb][Formatters] Add shared/weak count to libstdc++ std::shared_ptr summary (PR #147166)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147166 >From f9be1d811b66b050a79f83c16c7b404948c37505 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 5 Jul 2025 12:42:39 +0100 Subject: [PATCH 1/4] [lldb][Formatters] Make libc++ and libstdc++ std::shared_p

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
https://github.com/erichkeane commented: I'm a little concerned about the semi-canonical nature of this type, requiring the separate 'getCanonicalSizeType' esque functions, which should just be either stored as a CanQualType or compared properly. That said, for hte most part I like this change

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/143653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { unsigned NumExpansions; }; + enum class PredefinedSugarKind { +/// The "size_t" type. +SizeT, + +/// The signed integer type corresponding to "size_t". --

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -1002,14 +1002,14 @@ RValue CodeGenFunction::EmitCoroutineIntrinsic(const CallExpr *E, } case llvm::Intrinsic::coro_size: { auto &Context = getContext(); -CanQualType SizeTy = Context.getSizeType(); +CanQualType SizeTy = Context.getCanonicalSizeType(); -

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -7248,6 +7248,12 @@ QualType TreeTransform::TransformDependentBitIntType( return Result; } +template +QualType TreeTransform::TransformPredefinedSugarType( +TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) { + llvm_unreachable("This type does not need to be transfor

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -696,11 +696,17 @@ void TypeLocWriter::VisitPipeTypeLoc(PipeTypeLoc TL) { void TypeLocWriter::VisitBitIntTypeLoc(clang::BitIntTypeLoc TL) { addSourceLocation(TL.getNameLoc()); } + erichkeane wrote: Another unrelated change. https://github.com/llvm/llvm-p

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -2595,8 +2595,12 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T) const { Align = static_cast(Width); } } + erichkeane wrote: Unrelated change? https://github.com/llvm/llvm-project/pull/143653

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -721,7 +721,8 @@ static bool matchesStlAllocatorFn(const Decl *D, const ASTContext &Ctx) { (MD->getNumParams() != 1 && MD->getNumParams() != 2)) return false; - if (MD->parameters()[0]->getType().getCanonicalType() != Ctx.getSizeType()) + if (MD->parameters()[0

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -5613,3 +5613,16 @@ HLSLAttributedResourceType::findHandleTypeOnResource(const Type *RT) { } return nullptr; } + +StringRef PredefinedSugarType::getName(Kind KD) { + switch (KD) { + case Kind::SizeT: +return "__size_t"; + case Kind::SignedSizeT: +return "__si

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -320,6 +320,92 @@ bool clang::analyze_format_string::ParseUTF8InvalidSpecifier( // Methods on ArgType. //===--===// +static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT, +

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -2258,6 +2258,30 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { unsigned NumExpansions; }; + enum class PredefinedSugarKind { +/// The "size_t" type. +SizeT, + +/// The signed integer type corresponding to "size_t". +SignedSiz

[Lldb-commits] [lldb] [lldb][Formatters] Use container summary helper for libstdc++ formatters (PR #147140)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. I see we already have some C++ stuff in this file, but given that there really isn't anything specific in this function, maybe we could also drop the Cxx part from the name (maybe call it `ContainerSizeSummaryProvider `)? https://github.com

[Lldb-commits] [lldb] [lldb] Update the String table offset based on the DWARF format (PR #147054)

2025-07-07 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > This is the relevant part of the standard, correct? Yes exactly that's what I am referring too. > I see also "7.4 32-Bit and 64-Bit DWARF Formats", is there anything else in > there we need to handle? I see there is one form `DW_FORM_strp_sup` which is not at all added

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ tuple tests into generic test (PR #147139)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6fec6a9 - [lldb][Formatters] Make libc++ and libstdc++ std::shared_ptr formatters consistent with each other (#147165)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T09:13:52+01:00 New Revision: 6fec6a98c01523a5478ce2aa9617e884dc772f6f URL: https://github.com/llvm/llvm-project/commit/6fec6a98c01523a5478ce2aa9617e884dc772f6f DIFF: https://github.com/llvm/llvm-project/commit/6fec6a98c01523a5478ce2aa9617e884dc772f6f.diff

[Lldb-commits] [lldb] 49d7c53 - [lldb][test] Combine libstdc++ and libc++ std::map tests into generic test (#147174)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T09:14:10+01:00 New Revision: 49d7c53756bc6e06bb6ae160bef5f944f18dfa2f URL: https://github.com/llvm/llvm-project/commit/49d7c53756bc6e06bb6ae160bef5f944f18dfa2f DIFF: https://github.com/llvm/llvm-project/commit/49d7c53756bc6e06bb6ae160bef5f944f18dfa2f.diff

[Lldb-commits] [lldb] [lldb][Formatters] Make libc++ and libstdc++ std::shared_ptr formatters consistent with each other (PR #147165)

2025-07-07 Thread Michael Buch via lldb-commits
Michael137 wrote: > Ah, I see you've done that already. > > Not required, but I noticed that the pointer child still contains the goo: > > ``` > (lldb) v a.__ptr_ > (std::shared_ptr::element_type *) a.__ptr_ = 0xa2b8 > ``` > > If we do the casting centrally, we could have both of t

[Lldb-commits] [lldb] [lldb][Formatters] Make libc++ and libstdc++ std::shared_ptr formatters consistent with each other (PR #147165)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Add shared/weak count to libstdc++ std::shared_ptr summary (PR #147166)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147166 >From f9be1d811b66b050a79f83c16c7b404948c37505 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sat, 5 Jul 2025 12:42:39 +0100 Subject: [PATCH 1/3] [lldb][Formatters] Make libc++ and libstdc++ std::shared_p

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::map tests into generic test (PR #147174)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ iterator tests into generic test (PR #147175)

2025-07-07 Thread Michael Buch via lldb-commits
Michael137 wrote: > It looks like the libstdc++ test just crashes. Ah I misnamed the test-category. https://github.com/llvm/llvm-project/pull/147175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] Update the String table offset based on the DWARF format (PR #147054)

2025-07-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Yes I already found it and its in my list to fix, there are few places where > DWARF32 parsing but I was planing to do in separate PR. or you want me to do > it here only ? Separate PR please. https://github.com/llvm/llvm-project/pull/147054

[Lldb-commits] [lldb] [lldb][test] Split out libc++ std::string tests that check corrupted strings (PR #147252)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147252 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ vector tests into generic test (PR #147137)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/144919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-07-07 Thread Pavel Labath via lldb-commits
@@ -150,3 +150,84 @@ TEST(ListenerTest, StartStopListeningForEventSpec) { ASSERT_EQ(event_sp->GetBroadcaster(), &broadcaster1); ASSERT_FALSE(listener_sp->GetEvent(event_sp, std::chrono::seconds(0))); } + +TEST(ListenerTest, MoveEventsOnHijackAndRestore) { + Broadcaster bro

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. That's pretty much what I had in mind. Thanks. https://github.com/llvm/llvm-project/pull/144919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::map tests into generic test (PR #147174)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147174 >From afaebb5e6a16bbf91f3de26ae69050e503d55158 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 07:37:17 +0100 Subject: [PATCH 1/6] [lldb][test] Combine libstdc++ and libc++ std::map tests i

[Lldb-commits] [lldb] [lldb][Formatters] Use container summary helper for libstdc++ formatters (PR #147140)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d06956e - [lldb][Formatters] Use container summary helper for libstdc++ formatters (#147140)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T09:04:40+01:00 New Revision: d06956e24afaed103dfbcc67e81257692ae0a8b2 URL: https://github.com/llvm/llvm-project/commit/d06956e24afaed103dfbcc67e81257692ae0a8b2 DIFF: https://github.com/llvm/llvm-project/commit/d06956e24afaed103dfbcc67e81257692ae0a8b2.diff

[Lldb-commits] [lldb] [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (PR #147031)

2025-07-07 Thread Pavel Labath via lldb-commits
labath wrote: > It turns out the libstdc++ formatter supports dereferencing using the > "object" or "obj" names. I don't think there's any harm in supporting those, though I'd be surprised if many people are aware of that functionality. I kind of like this "hidden child" concept, but it feels

[Lldb-commits] [lldb] [lldb][Formatters] Make libc++ and libstdc++ std::shared_ptr formatters consistent with each other (PR #147165)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Ah, I see you've done that already. Not required, but I noticed that the pointer child still contains the goo: ``` (lldb) v a.__ptr_ (std::shared_ptr::element_type *) a.__ptr_ = 0xa2b8 ``` If we do the casting centrally, we could

[Lldb-commits] [lldb] [lldb][Formatters] Add shared/weak count to libstdc++ std::shared_ptr summary (PR #147166)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::map tests into generic test (PR #147174)

2025-07-07 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/147174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ iterator tests into generic test (PR #147175)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147175 >From 24240c7efa951340d7f19e0f74d1075ab100598e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 07:49:57 +0100 Subject: [PATCH 1/3] [lldb][test] Combine libstdc++ and libc++ iterator tests i

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ iterator tests into generic test (PR #147175)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/147175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147283 >From be3eb2431b0649ce2730a4cf832dc474e262f49e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Jul 2025 12:40:37 +0100 Subject: [PATCH 1/2] [lldb][test] Fix libstdc++ std::variant formatter for empt

[Lldb-commits] [lldb] [lldb][test] Fix libstdc++ std::variant formatter for empty variant (PR #147283)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/147283 Instead of using the byte-size to make a guess at what the `std::variant_npos` value is, just look it up in debug-info. Unblocks https://github.com/llvm/llvm-project/pull/147253 >From be3eb2431b0649ce2730a4

[Lldb-commits] [lldb] e14e982 - [lldb][test] Combine libstdc++ and libc++ std::shared_ptr tests into generic test (#147141)

2025-07-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-07-07T12:48:15+01:00 New Revision: e14e98290e71abe5d34b1d4724fde1b85b350547 URL: https://github.com/llvm/llvm-project/commit/e14e98290e71abe5d34b1d4724fde1b85b350547 DIFF: https://github.com/llvm/llvm-project/commit/e14e98290e71abe5d34b1d4724fde1b85b350547.diff

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::shared_ptr tests into generic test (PR #147141)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/147141 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread Erich Keane via lldb-commits
@@ -320,6 +320,92 @@ bool clang::analyze_format_string::ParseUTF8InvalidSpecifier( // Methods on ArgType. //===--===// +static bool namedTypeToLengthModifierKind(ASTContext &Ctx, QualType QT, +

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (PR #147253)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147253 >From e592d39c751480838ed90fcaa2b247e96b5bab59 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 09:58:02 +0100 Subject: [PATCH 1/4] [lldb][test] Combine libstdc++ and libc++ std::variant tes

[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

2025-07-07 Thread John Harrison via lldb-commits
@@ -242,6 +242,8 @@ struct Configuration { std::string platformName; }; +enum Terminal : unsigned { eConsole, eIntegrated, eExternal }; ashgti wrote: I believe the format for these should be `eTerminalConsole`, `eTerminalIntegrated`, `eTerminalExternal`.

[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

2025-07-07 Thread John Harrison via lldb-commits
@@ -236,6 +236,7 @@ contain the following key/value pairs: | **env** | dictionary | | Environment variables to set when launching the program. The format of each environment variable string is "VAR=VALUE" for environment variables with values or j

[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

2025-07-07 Thread John Harrison via lldb-commits
@@ -236,6 +236,7 @@ contain the following key/value pairs: | **env** | dictionary | | Environment variables to set when launching the program. The format of each environment variable string is "VAR=VALUE" for environment variables with values or j

[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

2025-07-07 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/146950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > How should a proper debugger shutdown sequence look like? > > 1. Release all `SBModule` pointers. > 2. Call `SBDebugger::MemoryPressureDetected`. > 3. Call `SBDebugger::Destroy`. Ideally, `SBDebugger::Destroy` would clean up all the modules in the module cache. You say we

[Lldb-commits] [clang] [clang-tools-extra] [libcxx] [lldb] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-07-07 Thread via lldb-commits
@@ -1002,14 +1002,14 @@ RValue CodeGenFunction::EmitCoroutineIntrinsic(const CallExpr *E, } case llvm::Intrinsic::coro_size: { auto &Context = getContext(); -CanQualType SizeTy = Context.getSizeType(); +CanQualType SizeTy = Context.getCanonicalSizeType(); -

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-07 Thread John Harrison via lldb-commits
@@ -44,26 +163,20 @@ MainLoopWindows::~MainLoopWindows() { } llvm::Expected MainLoopWindows::Poll() { - std::vector events; + std::vector events; events.reserve(m_read_fds.size() + 1); - for (auto &[fd, info] : m_read_fds) { -int result = WSAEventSelect(fd, info.even

[Lldb-commits] [lldb] [lldb] Clear ModuleList shared modules in SBDebugger::Clear (PR #147289)

2025-07-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > However, when lldb is used as a library, we need a way to manage opened > modules to avoid problems with file locks (on some systems) for modules that > we no longer need. Can you give a concrete example? This seems like its own issue that should be solved rather than wo

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-07 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/145621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::variant tests into generic test (PR #147253)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/147253 >From 30e4862aceee140084e10610b0ac2e7962d195dd Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 6 Jul 2025 09:58:02 +0100 Subject: [PATCH 1/3] [lldb][test] Combine libstdc++ and libc++ std::variant tes

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-07-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138032 >From 44b7628d7d77d3c63001890cb678ee6ab85e8034 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:24:03 -0700 Subject: [PATCH] [lldb[RPC] Upstream RPC server interface emitters Thi

[Lldb-commits] [lldb] [lldb][Formatters] Consistently unwrap pointer element_type in std::shared_ptr formatters (PR #147340)

2025-07-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/147340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >