[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
Thrrr wrote: Hi [dwblaikie](https://github.com/dwblaikie), Thanks for the clear explanation and guidance on handling cross-project changes between LLVM and LLDB. I completely understand the reasoning behind avoiding/splitting such commits, and your suggestions make perfect sense for better

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/139170 >From c7432d04896c1eea67ed6a6d5f4b4c28941e5a90 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 8 May 2025 07:38:20 -0700 Subject: [PATCH 1/6] [lldb] Do not create SymbolFileDWARFDebugMap for non-Mach-O files

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-06-04 Thread via lldb-commits
@@ -246,6 +246,9 @@ llvm::StringRef SymbolFileDWARFDebugMap::GetPluginDescriptionStatic() { } SymbolFile *SymbolFileDWARFDebugMap::CreateInstance(ObjectFileSP objfile_sp) { + // Don't create a debug map if the object file isn't a Mach-O. + if (!objfile_sp->GetArchitecture()

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
https://github.com/Thrrr closed https://github.com/llvm/llvm-project/pull/142747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4b6c608 - [lldb-dap] Use structured types for stepInTargets request (#142439)

2025-06-04 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-04T08:05:31+01:00 New Revision: 4b6c608615a285d81132acf8e33b81b2ec2c9bf9 URL: https://github.com/llvm/llvm-project/commit/4b6c608615a285d81132acf8e33b81b2ec2c9bf9 DIFF: https://github.com/llvm/llvm-project/commit/4b6c608615a285d81132acf8e33b81b2ec2c9bf9.diff L

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. thanks! i keep forgetting https://github.com/llvm/llvm-project/pull/142676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/18803 Here is the relevant piece of the b

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
https://github.com/Thrrr created https://github.com/llvm/llvm-project/pull/142747 This Pull Request introduces support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer` and `DW_OP_implicit_pointer`. These operators are commonly found in debug information and are used to enhance

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Thanks @HemangGadhavi , just add a link to the ibm doc link for reference. https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Thrrr (Thrrr) Changes This Pull Request introduces support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer` and `DW_OP_implicit_pointer`. These operators are commonly found in debug information and are used to enha

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Thrrr (Thrrr) Changes This Pull Request introduces support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer` and `DW_OP_implicit_pointer`. These operators are commonly found in debug information and are used to enhance

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 41841e6 - [lldb][llvm][AIX] Added support for getProcFile with TID (#142586)

2025-06-04 Thread via lldb-commits
Author: Hemang Gadhavi Date: 2025-06-04T14:44:57+05:30 New Revision: 41841e625db8d14d6701e7cb211b2fcab6a32a50 URL: https://github.com/llvm/llvm-project/commit/41841e625db8d14d6701e7cb211b2fcab6a32a50 DIFF: https://github.com/llvm/llvm-project/commit/41841e625db8d14d6701e7cb211b2fcab6a32a50.diff

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > Thanks @HemangGadhavi , just add a link to the ibm doc for reference. Thanks @DhruvSrivastavaX updated in description. https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/142751 fixes the failed tests on arch64. complements #142439 >From ed06cb782cca2a7433ae2dc81e1838009ca6e6d8 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 4 Jun 2025 10:18:54 +0100 Subject: [PATCH] [lldb-dap]

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes fixes the failed tests on arch64. complements #142439 --- Full diff: https://github.com/llvm/llvm-project/pull/142751.diff 1 Files Affected: - (modified) lldb/tools/lldb-dap/EventHelper.cpp (+3-1) `

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/142751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX approved this pull request. https://github.com/llvm/llvm-project/pull/142586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/142751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add missing key for capabilities event. (PR #142751)

2025-06-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/142751 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Implicitly pass arguments to llvm_add_library (PR #142583)

2025-06-04 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/142583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/142684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2c4f677 - [lldb/cmake] Implicitly pass arguments to llvm_add_library (#142583)

2025-06-04 Thread via lldb-commits
Author: Pavel Labath Date: 2025-06-04T11:33:37+02:00 New Revision: 2c4f67794bff4df984b43db453fc0f5241ee72c8 URL: https://github.com/llvm/llvm-project/commit/2c4f67794bff4df984b43db453fc0f5241ee72c8 DIFF: https://github.com/llvm/llvm-project/commit/2c4f67794bff4df984b43db453fc0f5241ee72c8.diff

[Lldb-commits] [lldb] 7214a3d - [lldb] Do not accept invalid `process save-core` plugins (#142684)

2025-06-04 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-04T11:33:35+01:00 New Revision: 7214a3d3da851018a96ac85060a2f9aeb7715f7f URL: https://github.com/llvm/llvm-project/commit/7214a3d3da851018a96ac85060a2f9aeb7715f7f DIFF: https://github.com/llvm/llvm-project/commit/7214a3d3da851018a96ac85060a2f9aeb7715f7f.diff L

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-04 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks! Cleaning up small things like this has a bigger impact than you'd think. https://github.com/llvm/llvm-project/pull/142684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb] Do not accept invalid `process save-core` plugins (PR #142684)

2025-06-04 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `lldb` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/16568 Here is the relevant p

[Lldb-commits] [lldb] 159de36 - [lldb-dap] Add missing key for capabilities event. (#142751)

2025-06-04 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-04T10:26:39+01:00 New Revision: 159de3633640a5cb2d322ebe8cc4ec0c1c9a896d URL: https://github.com/llvm/llvm-project/commit/159de3633640a5cb2d322ebe8cc4ec0c1c9a896d DIFF: https://github.com/llvm/llvm-project/commit/159de3633640a5cb2d322ebe8cc4ec0c1c9a896d.diff L

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Hemang Gadhavi via lldb-commits
@@ -290,6 +290,45 @@ else() endif() endif() +# Stage all headers in the include directory in the build dir. +file(GLOB public_headers ${LLDB_SOURCE_DIR}/include/lldb/API/*.h) +set(lldb_header_staging_dir ${CMAKE_BINARY_DIR}/include/lldb) +file(GLOB root_public_headers ${LLDB

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #142439)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142439 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-06-04 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi edited https://github.com/llvm/llvm-project/pull/141116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][llvm][AIX] Added support for getProcFile with TID (PR #142586)

2025-06-04 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-fast` running on `sanitizer-buildbot4` while building `lldb,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/11975 Here is the relevant pi

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -116,78 +119,78 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) { // Send a thread stopped event for all threads as long as the process // is stopped. -void SendThreadStoppedEvent(DAP &dap) { +llvm::Error SendThreadStoppedEvent(DAP &dap, bool on_entry) { +

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -110,4 +116,48 @@ std::string GetLoadAddressString(const lldb::addr_t addr) { return "0x" + llvm::utohexstr(addr, false, 16); } +protocol::Thread CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { + std::string name; + lldb::SBStream stream; + if (format &&

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/142510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread Ebuka Ezike via lldb-commits
@@ -8,10 +8,11 @@ #include "EventHelper.h" #include "DAP.h" -#include "DAPLog.h" +#include "DAPERror.h" da-viper wrote: ```suggestion #include "DAPError.h" ``` https://github.com/llvm/llvm-project/pull/142510 ___ l

[Lldb-commits] [lldb] a48e1ab - [lldb-dap][test] Fix DAP disassemble test (#142129)

2025-06-04 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-06-04T12:56:10+01:00 New Revision: a48e1aba63b8cb20de32a8db7ea29bb4d54cf3a1 URL: https://github.com/llvm/llvm-project/commit/a48e1aba63b8cb20de32a8db7ea29bb4d54cf3a1 DIFF: https://github.com/llvm/llvm-project/commit/a48e1aba63b8cb20de32a8db7ea29bb4d54cf3a1.diff L

[Lldb-commits] [lldb] [lldb-dap][test] Fix DAP disassemble test (PR #142129)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/142129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c9e1c52 - [lldb] Fix a warning

2025-06-04 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-06-04T07:00:25-07:00 New Revision: c9e1c52e2e75a91a44a98df818cc9bd11655e51d URL: https://github.com/llvm/llvm-project/commit/c9e1c52e2e75a91a44a98df818cc9bd11655e51d DIFF: https://github.com/llvm/llvm-project/commit/c9e1c52e2e75a91a44a98df818cc9bd11655e51d.diff L

[Lldb-commits] [lldb] da8271e - [lldb][test] Disable TestCxxFrameFormatRecursive on Linux

2025-06-04 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-06-04T14:01:46Z New Revision: da8271e88793909b738e2afdf17d0ae11dade455 URL: https://github.com/llvm/llvm-project/commit/da8271e88793909b738e2afdf17d0ae11dade455 DIFF: https://github.com/llvm/llvm-project/commit/da8271e88793909b738e2afdf17d0ae11dade455.diff LOG

[Lldb-commits] [lldb] [WIP] [lldb] Add fetching of source files used in modules. (PR #141773)

2025-06-04 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/141773 >From 429c656be7e8176c1c4d6f7c4339b7c6d76fa56c Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 28 May 2025 09:04:08 +0100 Subject: [PATCH] [lldb] Inital implementation of fetching source files used in mo

[Lldb-commits] [lldb] [llvm] support in LLDB for the DWARF operations `DW_OP_GNU_implicit_pointer/DW_OP_implicit_pointer`. (PR #142747)

2025-06-04 Thread via lldb-commits
https://github.com/Thrrr updated https://github.com/llvm/llvm-project/pull/142747 >From 64785ba97f670ace37c3d1e43aef1141a232c00c Mon Sep 17 00:00:00 2001 From: jinruiShi <1379998...@qq.com> Date: Wed, 4 Jun 2025 16:24:53 +0800 Subject: [PATCH] LLDB support for DW_OP_GNU_implicit_pointer/DW_

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > TrackingOutputBufferDeleter Yes, that would be a good improvement, especially since the test method here has an early return. I'd like to land this as-is to plug the leak, but I'll start a new branch now w/ that suggestion. https://github.com/llvm/llvm-project/pull/142676

[Lldb-commits] [lldb] 79f298e - [lldb][test] Free buffers in demangling tests to avoid leaks (#142676)

2025-06-04 Thread via lldb-commits
Author: Jordan Rupprecht Date: 2025-06-04T10:34:16-05:00 New Revision: 79f298e7e5ac88bc0041b1bd03e5210b8583cf03 URL: https://github.com/llvm/llvm-project/commit/79f298e7e5ac88bc0041b1bd03e5210b8583cf03 DIFF: https://github.com/llvm/llvm-project/commit/79f298e7e5ac88bc0041b1bd03e5210b8583cf03.di

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/142676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
@@ -116,78 +119,78 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) { // Send a thread stopped event for all threads as long as the process // is stopped. -void SendThreadStoppedEvent(DAP &dap) { +llvm::Error SendThreadStoppedEvent(DAP &dap, bool on_entry) { +

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142510 >From 2fd86de03cbb207420ee45334639f82d19dbbc28 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Jun 2025 18:07:52 -0700 Subject: [PATCH 1/3] [lldb-dap] Migrating 'threads' request to structured types.

[Lldb-commits] [lldb] [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (PR #142689)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/142689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream LLDB to RPC converstion Python script (PR #138028)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 4f818cc2d9933a21adb845f9e020dd3fd1177b13 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream LLDB to RPC converstion Python sc

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM with one nit. https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread David Peixotto via lldb-commits
@@ -94,4 +94,59 @@ TEST_F(ObjectFileMachOTest, IndirectSymbolsInTheSharedCache) { for (size_t i = 0; i < 10; i++) OF->ParseSymtab(symtab); } + +TEST_F(ObjectFileMachOTest, ObjectFileFormatWithoutLoadCommand) { dmpots wrote: The test name is a bit mislea

[Lldb-commits] [lldb] [lldb][RPC] Upstream LLDB to RPC converstion Python script (PR #138028)

2025-06-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/scripts/convert-lldb-header-to-rpc-header.py `` View the d

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream LLDB to RPC converstion Python script (PR #138028)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From ba96f130307617d150fad215025509835cbca4f0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream LLDB to RPC converstion Python sc

[Lldb-commits] [lldb] [lldb][RPC] Upstream LLDB to RPC converstion Python script (PR #138028)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Might be worth making this match the other scripts and doing this once > instead of line-by-line. Updated the patch to do this 👍🏾 https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142510 >From 2fd86de03cbb207420ee45334639f82d19dbbc28 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Jun 2025 18:07:52 -0700 Subject: [PATCH 1/4] [lldb-dap] Migrating 'threads' request to structured types.

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Adrian Prantl via lldb-commits
@@ -56,11 +56,14 @@ def run_with(self, arch, os, vers, env, expected_load_command): sdk_root = lldbutil.get_xcode_sdk_root(sdk) clang = lldbutil.get_xcode_clang(sdk) +print(triple) adrian-prantl wrote: ```suggestion if self.Trace

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
@@ -110,4 +116,48 @@ std::string GetLoadAddressString(const lldb::addr_t addr) { return "0x" + llvm::utohexstr(addr, false, 16); } +protocol::Thread CreateThread(lldb::SBThread &thread, lldb::SBFormat &format) { + std::string name; + lldb::SBStream stream; + if (format &&

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread via lldb-commits
royitaqi wrote: FWIW, the tvOS tests fails on my macOS machine with the following error ([full log](https://pastebin.com/3gDZU0Xb)): > AssertionError: No value is not true : Could not create a valid process for > a.out: no valid simulator instance I think this is because I don't have the "tvOS

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
@@ -116,78 +119,78 @@ void SendProcessEvent(DAP &dap, LaunchMethod launch_method) { // Send a thread stopped event for all threads as long as the process // is stopped. -void SendThreadStoppedEvent(DAP &dap) { +llvm::Error SendThreadStoppedEvent(DAP &dap, bool on_entry) { +

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
@@ -56,11 +56,14 @@ def run_with(self, arch, os, vers, env, expected_load_command): sdk_root = lldbutil.get_xcode_sdk_root(sdk) clang = lldbutil.get_xcode_clang(sdk) +print(triple) JDevlieghere wrote: This can go altogether, this was

[Lldb-commits] [lldb] [llvm] [NFC] Separate high-level-dependent portions of DWARFExpression (PR #139175)

2025-06-04 Thread via lldb-commits
Sterling-Augustine wrote: Anyone? https://github.com/llvm/llvm-project/pull/139175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/142815 Suggested in #142676 as a way to automatically free the buffer in tests >From 14a5860c98b5c0c067c8b12ccbaf32bfa45b1a66 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 4 Jun 2025 09:53:12 -0700 Subj

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Adrian Prantl via lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self): self.run_with( arch=self.getArchitecture(), os="ios", -vers="11.0", +vers="14.0", adrian-prantl wrote: Ah, but that's the arm64 test, so th

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/142244 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Free buffers in demangling tests to avoid leaks (PR #142676)

2025-06-04 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: > LGTM. Maybe an opportunity to use a unique_ptr with a custom deleter? > Something like: > > ``` > struct TrackingOutputBufferDeleter { > void operator()(TrackingOutputBuffer* TOB) { > if (!TOB) > return; > std::free(TOB->getBuffer()); > std::free(TOB); >

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self): self.run_with( arch=self.getArchitecture(), os="ios", -vers="11.0", +vers="14.0", JDevlieghere wrote: I kept 11.0 for the non-Apple Silicon

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > If this is indeed the root cause, then it seems to me the test should skip by > observing the unavailability of the tvOS simulator. LMK if that makes sense. Yes, `TestAppleSimulatorOSType` seems to be doing this correctly but we should have the same logic here. I'll see i

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes Suggested in #142676 as a way to automatically free the buffer in tests --- Full diff: https://github.com/llvm/llvm-project/pull/142815.diff 2 Files Affected: - (modified) lldb/include/lldb/Core/Deman

[Lldb-commits] [lldb] [lldb-dap] Migrating 'threads' request to structured types. (PR #142510)

2025-06-04 Thread John Harrison via lldb-commits
ashgti wrote: > I was trying to avoid putting JSON in the test because I find it hard to > maintain (your editor/IDE doesn't understand it's JSON, refactoring tools > don't work, no automatic formatting, etc) but if we think this is easier to > maintain (and means folks write more tests) then

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Adrian Prantl via lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self): self.run_with( arch=self.getArchitecture(), os="ios", -vers="11.0", +vers="14.0", adrian-prantl wrote: The version 11 here is (I believe) s

[Lldb-commits] [lldb] [lldb][RPC] Upstream RPC server interface emitters (PR #138032)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: @DavidSpickett I think I've address any previous comments to this point and that this patch is ready to land (contingent on the rpc-gen tool itself landing first). If possible, could you give this another once over? https://github.com/llvm/llvm-project/pull/138032

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,549 @@ +//===-- lldb-rpc-gen.cpp *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Revive TestSimulatorPlatform.py (PR #142244)

2025-06-04 Thread Adrian Prantl via lldb-commits
@@ -198,7 +202,7 @@ def test_ios_backdeploy_apple_silicon(self): self.run_with( arch=self.getArchitecture(), os="ios", -vers="11.0", +vers="14.0", adrian-prantl wrote: Apple silicon and/or macCatalyst mad

[Lldb-commits] [lldb] [lldb] Provide TrackingOutputBufferDeleter for custom unique_ptr deleter (PR #142815)

2025-06-04 Thread Michael Buch via lldb-commits
@@ -159,4 +160,23 @@ struct TrackingOutputBuffer : public llvm::itanium_demangle::OutputBuffer { }; } // namespace lldb_private +/// Custom deleter to use with unique_ptr. +/// +/// Usage: +/// \code{.cpp} +/// +/// auto OB = +/// std::unique_ptr( +/// new Trackin

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,107 @@ +//===-- RPCCommon.h ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/142820 This test is failing for me on arm64 due to the capabilities not being sent until 'configurationDone' is called. I adjusted the test to ensure we call 'configurationDone' so the value is sent to the test correc

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This test is failing for me on arm64 due to the capabilities not being sent until 'configurationDone' is called. I adjusted the test to ensure we call 'configurationDone' so the value is sent to the test cor

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/142820 >From 0fc2c8223ecb0888c15152331474f4ffb63c142b Mon Sep 17 00:00:00 2001 From: John Harrison Date: Wed, 4 Jun 2025 10:29:33 -0700 Subject: [PATCH 1/2] [lldb-dap] Adjust the stepInTargets tests on non-intel platfo

[Lldb-commits] [lldb] [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (PR #142689)

2025-06-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/142689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] db54719 - [lldb] Remove USE_ALLOCATE_MEMORY_CACHE (#142689)

2025-06-04 Thread via lldb-commits
Author: Alex Langford Date: 2025-06-04T10:43:36-07:00 New Revision: db5471945b7e36f55c66dfa74e218390c0329dd4 URL: https://github.com/llvm/llvm-project/commit/db5471945b7e36f55c66dfa74e218390c0329dd4 DIFF: https://github.com/llvm/llvm-project/commit/db5471945b7e36f55c66dfa74e218390c0329dd4.diff

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-04 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,502 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
ashgti wrote: Looking at this, I think I'll take a different approach to fixing this and close this PR for now. https://github.com/llvm/llvm-project/pull/142820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
royitaqi wrote: > > It's not clear if there are legitimate production use cases where the > > Mach-O files don't have said load commands. If there is, then what is their > > expected object format? Without this patch, they are currently ELF. With > > this patch, they will become MachO > > At

[Lldb-commits] [lldb] [lldb-dap] Adjust the stepInTargets tests on non-intel platforms. (PR #142820)

2025-06-04 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/142820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set default object format to `MachO` in `ObjectFileMachO` (PR #142704)

2025-06-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/142704 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >