@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj):
args.append("-fms-compatibility-version=19")
args.append("/c")
+if self.std:
Nerixyz wrote:
`/std` was appended after the `--`, so the compiler interpreted it a
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj):
args.append("-fms-compatibility-version=19")
args.append("/c")
+if self.std:
Michael137 wrote:
I see, lets do that in a separate patch please
https://github.co
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/138687
>From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Tue, 6 May 2025 07:59:45 -0500
Subject: [PATCH 1/2] [lldb][AIX] get host info for AIX (cont..)
---
lldb/s
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run"
-o "fr v" -o c | FileCheck %s
+
+#include
Nerixyz
Nerixyz wrote:
> Seems like a fine stop-gap for now to avoid crashing
Yes, exactly. The formatted output for these types is still incomplete (often,
types are formatted without any children).
I'd love to help with support for MSVC's STL, but it's probably better to
discuss that in #24834.
htt
@@ -18,5 +20,18 @@ void HostInfoAIX::Terminate() { HostInfoBase::Terminate(); }
FileSpec HostInfoAIX::GetProgramFileSpec() {
static FileSpec g_program_filespec;
+ struct psinfo psinfoData;
+ auto BufferOrError = getProcFile(getpid(), "psinfo");
+ if (BufferOrError) {
+
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
@@ -133,7 +142,45 @@ static bool GetProcessAndStatInfo(::pid_t pid,
uint32_t Host::FindProcessesImpl(const ProcessInstanceInfoMatch &match_info,
ProcessInstanceInfoList &process_infos) {
- return 0;
+ static const char procdir[] = "/proc/";
+
https://github.com/beetrees updated
https://github.com/llvm/llvm-project/pull/98369
>From 52f00a10537e738762adc62b5e88b71008336e65 Mon Sep 17 00:00:00 2001
From: beetrees
Date: Wed, 10 Jul 2024 18:49:45 +0100
Subject: [PATCH] [lldb] Add support for displaying `__float128` variables
---
lldb/b
@@ -4737,19 +4750,23 @@ CompilerType
TypeSystemClang::CreateGenericFunctionPrototype() {
// Exploring the type
const llvm::fltSemantics &
-TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) {
+TypeSystemClang::GetFloatTypeSemantics(size_t byte_size, bool prefer_float128
@@ -335,6 +336,10 @@ static const llvm::fltSemantics &GetFloatSemantics(const
TargetSP &target_sp,
return llvm::APFloat::IEEEsingle();
case 8:
return llvm::APFloat::IEEEdouble();
+case 16:
+ if (prefer_float128) {
beetrees wrote:
Done
HemangGadhavi wrote:
> Could you also make unit tests for these two functions:
>
> * call GetProgramFileSpec and make sure the result is reasonable (exists?)
> * create a Process and make sure FindProcesses finds it (you can use
> [this](https://github.com/llvm/llvm-project/blob/52f568dbbb61ffe
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Recently the Linux Kernel has fixed a bunch of issues in SME support and while
testing that, I found two tests failing: FAIL:
test_za_register_dynamic_config_main_disabled
(TestZAThreadedDynamic.AArc
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/140875
Recently the Linux Kernel has fixed a bunch of issues in SME support and while
testing that, I found two tests failing: FAIL:
test_za_register_dynamic_config_main_disabled
(TestZAThreadedDynamic.AArch64Z
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tal Keren (talkeren)
Changes
This change remove the call to GetPlatform from GetDeploymentInfo and instead
pass it as an argument,so GetPlatform will be called only once for all the
load commands. The reason is that if we try to query the pl
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/5] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
@@ -62,9 +64,13 @@ def set_source_breakpoints(self, source_path, lines,
data=None):
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.wait_for_breakpoi
@@ -45,20 +43,34 @@ def run_test_evaluate_expressions(
enableAutoVariableSummaries=enableAutoVariableSummaries,
)
source = "main.cpp"
-self.set_source_breakpoints(
-source,
-[
-line_number(source, "// b
@@ -1731,8 +1737,11 @@ lldb::TypeCategoryImplSP
CPlusPlusLanguage::GetFormatters() {
DataVisualization::Categories::GetCategory(ConstString(GetPluginName()),
g_category);
if (g_category) {
- LoadLibStdcppFormatters(g_
@@ -2,10 +2,14 @@
Test lldb data formatter subsystem.
"""
-
-import lldb
-from lldbsuite.test.decorators import *
-from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import add_test_categories, expectedFailureAll,
skip
+from lldbsuite.test.lldbtest import (
@@ -1731,8 +1737,11 @@ lldb::TypeCategoryImplSP
CPlusPlusLanguage::GetFormatters() {
DataVisualization::Categories::GetCategory(ConstString(GetPluginName()),
g_category);
if (g_category) {
- LoadLibStdcppFormatters(g_
@@ -48,10 +65,13 @@ def cleanup():
self.runCmd("frame variable ii --show-types")
+match = f"std::{namespace}map<"
self.runCmd(
-'type summary add -x "std::map<" --summary-string "map has
${svar%#} items" -e'
+f'type summary ad
@@ -19,9 +23,22 @@ def setUp(self):
@add_test_categories(["libstdcxx"])
@expectedFailureAll(bugnumber="llvm.org/pr50861", compiler="gcc")
def test_with_run_command(self):
+build_args = {"EXE": "a.out"}
+self.with_run_command("", build_args)
+
+@a
@@ -74,9 +74,11 @@ lldb::ChildCacheState GenericOptionalFrontend::Update() {
if (m_stdlib == StdLib::LibCxx)
engaged_sp = m_backend.GetChildMemberWithName("__engaged_");
- else if (m_stdlib == StdLib::LibStdcpp)
-engaged_sp = m_backend.GetChildMemberWithName("_M_pay
@@ -379,7 +379,7 @@ LibStdcppSharedPtrSyntheticFrontEnd::CalculateNumChildren()
{
lldb::ValueObjectSP
LibStdcppSharedPtrSyntheticFrontEnd::GetChildAtIndex(uint32_t idx) {
- if (idx == 0)
+ if (idx == 0 && m_ptr_obj)
Michael137 wrote:
```suggestion
if (!m
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj):
args.append("-fms-compatibility-version=19")
args.append("/c")
+if self.std:
Michael137 wrote:
Why is this change necessary?
https://github.com/llvm/llvm-proje
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run"
-o "fr v" -o c | FileCheck %s
+
+#include
Michael1
https://github.com/Michael137 commented:
Seems like a fine stop-gap for now to avoid crashing
Just left some clarification questions
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
Michael137 wrote:
FYI @charles-zablit
https://github.com/llvm/llvm-project/pull/140761
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/140875
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,57 @@
+// clang-format off
+
+// REQUIRES: target-windows
+// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s
+// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run"
-o "fr v" -o c | FileCheck %s
+
+#include
Michael1
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
@@ -59,10 +59,24 @@ struct DemangledNameInfo {
/// \endcode
std::pair QualifiersRange;
+ /// Indicates the [start, end) of the function's prefix. This is a
+ /// catch-all range for anything that is not tracked by the rest of
+ /// the pairs.
+ std::pair PrefixRange;
+
DavidSpickett wrote:
Candidates for how it ever worked:
* Out of bounds write managing to break something else in just the right way.
Then adding new extension registers meant it was invalidating registers again,
probably guarded control stack registers.
* LLDB got less aggressive about re-read
https://github.com/mstorsjo approved this pull request.
LGTM
IIRC @petrhosek had commented on this before, and was generally in favour of
it, but I'd still leave it open for a couple days if he wants to comment
further on it.
https://github.com/llvm/llvm-project/pull/138587
__
@@ -88,6 +88,7 @@ struct Entry {
FunctionNameWithArgs,
FunctionNameNoArgs,
FunctionMangledName,
+FunctionPrefix,
Michael137 wrote:
If we add a new variable here we will need to update the documentation under
`lldb/docs/use/formatting.rst`
htt
DavidSpickett wrote:
> I added my gist to the description, let me know what you think
This part looks good, that'll be enough to test this / explain why it exists.
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-com
@@ -6,7 +6,7 @@ add_lldb_unittest(LLDBCoreTests
DumpDataExtractorTest.cpp
DumpRegisterInfoTest.cpp
FormatEntityTest.cpp
- MangledTest.cpp
+ ItaniumMangledTest.cpp
Michael137 wrote:
I don't mind renaming the file but there are already swift mangling tes
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
labath wrot
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/140927
Basically, disable everything except the eh_frame unwind plan, as that's the
only one which supports this right now. The other plans are working with now
trying the interpret everything in between the function p
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Basically, disable everything except the eh_frame unwind plan, as that's the
only one which supports this right now. The other plans are working with now
trying the interpret everything in between the function
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) {
EXPECT_TRUE(HostInfo::GetHostname(s));
}
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+ // Test GetProgramFileSpec()
+ FileSpec filespec = HostInfo::GetProgramFileSpec();
+ EXPECT_FALSE(filespec.GetFilename().IsEmpty()
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) {
EXPECT_TRUE(HostInfo::GetHostname(s));
}
+TEST_F(HostInfoTest, GetProgramFileSpec) {
+ // Test GetProgramFileSpec()
labath wrote:
That much is obvious.
```suggestion
```
https://github.com/llvm/llvm-
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
[I'm sorry, this is going to be long]
Most of David's comments are there because you copied the existing attach
implementation. Even if we go down the path of different attach methods, I
don't think it's necessary to copy all of that. Actual attaching is a
@@ -312,10 +312,27 @@ NativeProcessLinux::Manager::Attach(
Log *log = GetLog(POSIXLog::Process);
LLDB_LOG(log, "pid = {0:x}", pid);
- auto tids_or = NativeProcessLinux::Attach(pid);
- if (!tids_or)
-return tids_or.takeError();
- ArrayRef<::pid_t> tids = *tids_or;
+
Author: Ebuka Ezike
Date: 2025-05-21T18:17:38+01:00
New Revision: d219a71849f9209b01ee9e71af83747ad44b2a18
URL:
https://github.com/llvm/llvm-project/commit/d219a71849f9209b01ee9e71af83747ad44b2a18
DIFF:
https://github.com/llvm/llvm-project/commit/d219a71849f9209b01ee9e71af83747ad44b2a18.diff
L
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/140788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -312,10 +312,27 @@ NativeProcessLinux::Manager::Attach(
Log *log = GetLog(POSIXLog::Process);
LLDB_LOG(log, "pid = {0:x}", pid);
- auto tids_or = NativeProcessLinux::Attach(pid);
- if (!tids_or)
-return tids_or.takeError();
- ArrayRef<::pid_t> tids = *tids_or;
+
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
I leave the discussion of race conditions or lack of to @labath .
https://github.com/llvm/llvm-project/pull/137041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -444,6 +461,88 @@ NativeProcessLinux::NativeProcessLinux(::pid_t pid, int
terminal_fd,
SetState(StateType::eStateStopped, false);
}
+llvm::Expected> NativeProcessLinux::Seize(::pid_t pid) {
+ Log *log = GetLog(POSIXLog::Process);
+
+ uint64_t options = GetDefaultPtrace
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/DavidSpickett commented:
A couple of comments to be addressed but otherwise I have no problems with this.
https://github.com/llvm/llvm-project/pull/138032
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/140788
>From a9824d7b8a4b6ad4b7baf1d43901aa796beeff2a Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 20 May 2025 20:11:29 +0100
Subject: [PATCH 1/2] [lldb][lldb-dap][tests] Make sure evaluate test exists
with
@@ -422,8 +431,27 @@ def wait_for_breakpoint_events(self, timeout:
Optional[float] = None):
if not event:
break
breakpoint_events.append(event)
+
+self._update_verified_breakpoints(
ashgti wrote:
We should call
https://github.com/ashgti approved this pull request.
Looks like a good cleanup!
https://github.com/llvm/llvm-project/pull/140788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -136,6 +136,7 @@ def __init__(
self.initialized = False
self.frame_scopes = {}
self.init_commands = init_commands
+self.resolved_breakpoints = set([])
ashgti wrote:
Should we use `self.breakpoints = {}` and we can key them by
@@ -1011,7 +1042,10 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/98369
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,6 +90,31 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+TEST(Host, FindProcesses) {
+ SubsystemRAII subsystems;
+
+ if (test_arg != 0)
+exit(0);
+
+ ProcessLaunchInfo info;
+ ProcessInstanceInfoList processes;
+ Pro
labath wrote:
> > Could you also make unit tests for these two functions:
> >
> > * call GetProgramFileSpec and make sure the result is reasonable (exists?)
> > * create a Process and make sure FindProcesses finds it (you can use
> > [this](https://github.com/llvm/llvm-project/blob/52f568dbbb61
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/140761
>From e08ec0697c9d22ad002c83c4e5c7ce3e0d10b0b6 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Wed, 21 May 2025 17:32:48 +0200
Subject: [PATCH 1/2] [LLDB] Pass `/std:...` before `--` on MSVC
---
lldb/test/Shell/h
@@ -985,7 +1013,10 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+breakpo
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
ashgti wrot
labath wrote:
The failure is in lldb_private::HostInfoBase::GetArchitecture. To fix this, you
need to `Initialize()` the HostInfo class.
https://github.com/llvm/llvm-project/pull/138687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
jimingham wrote:
This behavior has gotten fairly complicated, you need to describe how it works
somewhere that users can consult.
https://github.com/llvm/llvm-project/pull/140938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
@@ -422,8 +431,27 @@ def wait_for_breakpoint_events(self, timeout:
Optional[float] = None):
if not event:
break
breakpoint_events.append(event)
+
+self._update_verified_breakpoints(
eronnen wrote:
:100:
https:
@@ -1011,7 +1042,10 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+
@@ -985,7 +1013,10 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+breakpo
medismailben wrote:
Hey @eronnen, I think this change broke the macOS lldb incremental bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/26259/execution/node/106/log/?consoleFull
Let me know if you need help to investigate it or if we should revert it if you
don't have t
@@ -1102,3 +1103,28 @@ def is_feature_enabled():
return "%s is not supported on this system." % feature
return skipTestIfFn(is_feature_enabled)
+
+
+def skipIfBinaryToLarge(path: Optional[str], maxSize: int):
+"""Skip the test if a binary is to large.
+
medismailben wrote:
That doesn't solve the issue:
```
File
"/Users/mib/Developer/open-source/llvm.org/lldb/test/API/tools/lldb-dap/disassemble/TestDAP_disassemble.py",
line 28, in test_disassemble
self.assertIn("location", pc_assembly, "Source location missing.")
AssertionError: 'locatio
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pat Doyle (patdoyle-google)
Changes
similar to #140570
getting this error:
exit status 1
ld.lld: error: section '.text' address (0x8074) is smaller than image base
(0x1); specify --image-base
---
Full diff: https://github.com/llvm/ll
https://github.com/patdoyle-google created
https://github.com/llvm/llvm-project/pull/140978
similar to #140570
getting this error:
exit status 1
ld.lld: error: section '.text' address (0x8074) is smaller than image base
(0x1); specify --image-base
>From 0483de4c38c49fbda6a7965d246c0a5423
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/140978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/patdoyle-google updated
https://github.com/llvm/llvm-project/pull/140978
>From 0483de4c38c49fbda6a7965d246c0a5423c47b65 Mon Sep 17 00:00:00 2001
From: Pat Doyle
Date: Wed, 21 May 2025 18:32:59 -0700
Subject: [PATCH 1/2] Update dissassemble-entry-point.s
---
lldb/test/Shell/
@@ -1,7 +1,7 @@
# REQUIRES: lld, arm
# RUN: llvm-mc -triple=thumbv7-eabi %s -filetype=obj -o %t.o
-# RUN: ld.lld %t.o -o %t --section-start=.text=0x8074 -e 0x8075 -s
+# RUN: ld.lld %t.o -o %t --image-base=0x8074 --section-start=.text=0x8074 -e
0x8075 -s
patdo
patdoyle-google wrote:
btw I don't have commit access yet so if you could merge for me that would be
lovely :)
https://github.com/llvm/llvm-project/pull/140978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
always using the "frame-format-unique" even when you weren't doing the unique
backtrace mode.
---
Full diff: https://github.com/llvm/llvm-project/pull/140993.diff
2 Files Affected:
- (modified) lldb/source/Comma
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
`
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/138587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/140958
Convert the Maintainers file from reStructuredText to Markdown and include
links to GitHub and Discouse. The new layout improves readability, makes it
easier to navigate from GitHub and matches LLVM's Main
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Convert the Maintainers file from reStructuredText to Markdown and include
links to GitHub and Discouse. The new layout improves readability, makes it
easier to navigate from GitHub and matches LLVM
Author: Jason Molenda
Date: 2025-05-21T17:38:35-07:00
New Revision: cea82573bb39230f6ddf47f8ee5a83f85c255025
URL:
https://github.com/llvm/llvm-project/commit/cea82573bb39230f6ddf47f8ee5a83f85c255025
DIFF:
https://github.com/llvm/llvm-project/commit/cea82573bb39230f6ddf47f8ee5a83f85c255025.diff
eronnen wrote:
@medismailben Unfortunately I dont own a mac so I can't really test but I think
maybe this patch should fix it: https://github.com/llvm/llvm-project/pull/140975
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing l
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests
VariablesTest.cpp
LINK_LIBS
+liblldb
lldbDAP
+lldbUtilityHelpers
LLVMTestingSupport
LINK_COMPONENTS
Support
)
+
+set(test_inputs
+ linux-x86_64.out
+ linux-x86_64.core
ashgti wrot
https://github.com/adrian-prantl approved this pull request.
That looks like a nice improvement!
https://github.com/llvm/llvm-project/pull/140424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
1 - 100 of 118 matches
Mail list logo
