[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-20 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/138551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Change the launch sequence (PR #138219)

2025-05-20 Thread Pavel Labath via lldb-commits
labath wrote: That would be great, thanks. BTW, I've checked the test and its form after https://github.com/llvm/llvm-project/pull/140331 (where `self.launch` does not send the configurationDone` event) does reproduce the problem I encountered. https://github.com/llvm/llvm-project/pull/138219

[Lldb-commits] [lldb] [lldb] Don't create instance of `SymbolFileDWARFDebugMap` for non-Mach-O files (PR #139170)

2025-05-20 Thread Pavel Labath via lldb-commits
labath wrote: I'm glad we're in (abstract) agreement. As much as I would like to, I can't promise to do this by any particular date. I'd can *try*, but I don't know when will that happen. In a way, I feel that this patch isn't the a good reason to motivate this (although I think that legalisi

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-05-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/137041 >From 68077c22670ec044aab57bacb50c1edc0eb72eef Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 8 May 2025 12:56:14 -0700 Subject: [PATCH] Implement PTRACE_SEIZE when a process is coredumping --- .../Pr

[Lldb-commits] [lldb] [lldb-dap] In DAP unit tests, add helpers for loading a CoreFile. (PR #140738)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -10,8 +10,16 @@ add_lldb_unittest(DAPTests VariablesTest.cpp LINK_LIBS +liblldb lldbDAP +lldbUtilityHelpers LLVMTestingSupport LINK_COMPONENTS Support ) + +set(test_inputs + linux-x86_64.out + linux-x86_64.core JDevliegher

[Lldb-commits] [lldb] 1b6b036 - [lldb][docs] add command to save core file in gdb to lldb command map. (#140771)

2025-05-20 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-05-20T20:57:51+01:00 New Revision: 1b6b036c0220c095c2917308775aa2ddcba506ad URL: https://github.com/llvm/llvm-project/commit/1b6b036c0220c095c2917308775aa2ddcba506ad DIFF: https://github.com/llvm/llvm-project/commit/1b6b036c0220c095c2917308775aa2ddcba506ad.diff L

[Lldb-commits] [lldb] 3f196e0 - [lldb][core] Fix getting summary of a variable pointing to r/o memory (#139196)

2025-05-20 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-05-20T13:50:24-07:00 New Revision: 3f196e029314e3ccb429413a5f38ad241e50f3c5 URL: https://github.com/llvm/llvm-project/commit/3f196e029314e3ccb429413a5f38ad241e50f3c5 DIFF: https://github.com/llvm/llvm-project/commit/3f196e029314e3ccb429413a5f38ad241e50f3c5.diff L

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-20 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/139196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140486 >From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Tue, 20 May 2025 00:47:48 +0200 Subject: [PATCH 1/3] [lldb-dap] Fix disassemble request instruction offset handling

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments &args) const { } } + int64_t instructionOffset = args.instructionOffset.value_or(0); + if (instructionOffset > 0) { +lldb::SBInstructionList forward_insts = dap.target.ReadInstructions

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments &args) const { } } + int64_t instructionOffset = args.instructionOffset.value_or(0); + if (instructionOffset > 0) { +lldb::SBInstructionList forward_insts = dap.target.ReadInstructions

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere I Tried to simplify the logics as much as I can in the way you asked, handling the case of unfixed opcode size and disassembling backwards is still a bit complex because there is the edge case where padding is needed, but I hope it's readable enough now. https://g

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -70,9 +71,21 @@ export class DebugSessionTracker /** Clear information from the active session. */ private onExit(session: vscode.DebugSession) { this.modules.delete(session); +// close when there is no more sessions +if (this.modules.size <= 0) { ---

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/140603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-20 Thread Pavel Labath via lldb-commits
labath wrote: Correct. https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes When inspecting/printing types from MSVC's STL, LLDB would crash because it assumes these types were from libstdc++. Specifically, `std::shared_ptr` and `std::optional` would crash because of a null pointer derefere

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-20 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/140762 This PR is a subset of the commits made in https://github.com/swiftlang/llvm-project/pull/10710. The most notable change is the addition of `PrefixRange` and `SuffixRange` which are a catch-all to trac

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-20 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/140761 When inspecting/printing types from MSVC's STL, LLDB would crash because it assumes these types were from libstdc++. Specifically, `std::shared_ptr` and `std::optional` would crash because of a null pointer der

[Lldb-commits] [lldb] [lldb][lldb-dap][tests] Make sure evaluate test exists with no errors. (PR #140788)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/140788 I was running the tests and encounted this ```sh TIMEOUT: lldb-api :: tools/lldb-dap/gotoTargets/TestDAP_gotoTargets.py (55 of 55) TEST 'lldb-api :: tools/lldb-dap/gotoTargets/TestDAP_go

[Lldb-commits] [lldb] [lldb][lldb-dap][tests] Make sure evaluate test exists with no errors. (PR #140788)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes I was running the tests and encounted this ```sh TIMEOUT: lldb-api :: tools/lldb-dap/gotoTargets/TestDAP_gotoTargets.py (55 of 55) TEST 'lldb-api :: tools/lldb-dap/gotoTargets/TestDAP_g

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
da-viper wrote: @ashgti I haven't check this yet because of #140788, before remove the skipifs. https://github.com/llvm/llvm-project/pull/140777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes This PR is a subset of the commits made in https://github.com/swiftlang/llvm-project/pull/10710. The most notable change is the addition of `PrefixRange` and `SuffixRange` which are a catch-all to

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -35,14 +35,24 @@ export class DebugSessionTracker * The modules are kept in an array to maintain the load order of the modules. */ private modules = new Map(); - private modulesChanged = new vscode.EventEmitter(); + private modulesChanged = new vscode.EventEmitter

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-20 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/140762 >From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Tue, 20 May 2025 17:45:20 +0100 Subject: [PATCH 1/2] refactor demangler range tracking --- lldb/include

[Lldb-commits] [lldb] [lldb][docs] add command to save core file in gdb to lldb command map. (PR #140771)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140771.diff 1 Files Affected: - (modified) lldb/docs/use/map.rst (+11) ``diff diff --git a/lldb/docs/use/map.rst b/lldb/docs/use/map.rst

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-05-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/137041 >From 68077c22670ec044aab57bacb50c1edc0eb72eef Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 8 May 2025 12:56:14 -0700 Subject: [PATCH 1/2] Implement PTRACE_SEIZE when a process is coredumping --- ..

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere Fixed comments, sorry for the trouble. I'll try to pay extra attention next time :) https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] add @skipIfWindows to unresolved disassemble test on windows (PR #140852)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140852 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] add @skipIfWindows to unresolved disassemble test on windows (PR #140852)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/140852 Fix https://lab.llvm.org/buildbot/#/builders/141/builds/8867 >From cb69d50e158d9197b6e0fdb997de0086da1b8afa Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 08:09:23 +0200 Subject: [PATCH] add @

[Lldb-commits] [lldb] 2ed8c27 - add @skipIfWindows to unresolved disassemble test on windows (#140852)

2025-05-20 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-21T08:10:22+02:00 New Revision: 2ed8c27d03dac098744d51f580e7cca38707b183 URL: https://github.com/llvm/llvm-project/commit/2ed8c27d03dac098744d51f580e7cca38707b183 DIFF: https://github.com/llvm/llvm-project/commit/2ed8c27d03dac098744d51f580e7cca38707b183.diff LO

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-20 Thread Ely Ronnen via lldb-commits
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions, condition=None, hitCondition=None) breakpoint_ids = [] for breakpoint in breakpoints: breakpoint_ids.append("%i" % (breakpoint["id"])) +if wait_for_resolve: +self.w

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-20 Thread Ely Ronnen via lldb-commits
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference): } return self.send_recv(command_dict) -def request_testGetTargetBreakpoints(self): +def request_testGetTargetBreakpoints(self, only_resolved=False): eronnen wrote:

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/3] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] [lldb-dap] Synchronously wait for breakpoints resolves in tests (PR #140470)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140470 >From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 18 May 2025 20:56:47 +0200 Subject: [PATCH 1/4] [lldb-dap] Attempt to synchronously wait for breakpoints resol

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-20 Thread Tal Keren via lldb-commits
https://github.com/talkeren closed https://github.com/llvm/llvm-project/pull/140611 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Properly cache the result of MachProcess::GetPlatform (PR #140611)

2025-05-20 Thread Tal Keren via lldb-commits
talkeren wrote: Closing it following the discussion in the issue - I made a new PR that fixes it differently without change the current behaviour. https://github.com/llvm/llvm-project/pull/140611 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb] Don't query the platform for each load command (PR #140853)

2025-05-20 Thread Tal Keren via lldb-commits
https://github.com/talkeren created https://github.com/llvm/llvm-project/pull/140853 This change remove the call to GetPlatform from GetDeploymentInfo and instead pass it as an argument,so GetPlatform will be called only once for all the load commands. The reason is that if we try to query the p

[Lldb-commits] [lldb] add @skipIfWindows to unresolved disassemble test on windows (PR #140852)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes Fix https://lab.llvm.org/buildbot/#/builders/141/builds/8867 --- Full diff: https://github.com/llvm/llvm-project/pull/140852.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/disassemble/TestDA

<    1   2