[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-20 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think this is a pretty good attempt. Thanks for trying it out. My main problem with it is that I still think that this functionality should be in the platform class. I have a couple of reasons for that: - the platform class is the one who defines the layou

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140603 >From 8ca0be7cdd49caa32db43097d9ff9c4060b1d87d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Mon, 19 May 2025 20:44:31 +0100 Subject: [PATCH 1/4] [lldb][lldb-dap] show modules pane if supported by the adapt

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -787,7 +787,7 @@ { "id": "lldb-dap.modules", "name": "Modules", - "when": "inDebugMode && debugType == 'lldb-dap'", + "when": "inDebugMode && debugType == 'lldb-dap' && lldb-dap.showModules", da-viper wrote: I

[Lldb-commits] [lldb] [lldb-dap] In DAP unit tests, add helpers for loading a CoreFile. (PR #140738)

2025-05-20 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/140738 This allows us to have a SBTarget and SBProcess for creating unit tests. >From ac49fd8160b358a809be627502e1c03ad9cde08a Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 20 May 2025 07:34:02 -0700 Subject:

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread Anthony Cabrera-Lara via lldb-commits
https://github.com/anthonycabreralara created https://github.com/llvm/llvm-project/pull/140746 Fix typo in interpreter property description >From cd4f55e952ea2b5f8420d9f8ca3affde2045819a Mon Sep 17 00:00:00 2001 From: Anthony Cabrera-Lara <60250777+anthonycabreral...@users.noreply.github.com>

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Anthony Cabrera-Lara (anthonycabreralara) Changes Fix typo in interpreter property description --- Full diff: https://github.com/llvm/llvm-project/pull/140746.diff 1 Files Affected: - (modified) lldb/source/Interpreter/InterpreterPropert

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -219,6 +218,9 @@ struct DAP { llvm::StringSet<> modules; /// @} + /// Number of lines of assembly code to show when no debug info is available. + static constexpr uint32_t number_of_assembly_lines_for_nodebug = 32; JDevlieghere wrote: Constants use a

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -33,16 +36,51 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap, m_line(breakpoint.line), m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {} -void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) { +llvm::Error SourceBreakpoint::S

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -1620,6 +1620,88 @@ void DAP::EventThread() { } } +std::vector DAP::SetSourceBreakpoints( +const protocol::Source &source, +const std::optional> &breakpoints) { + std::vector response_breakpoints; + if (source.sourceReference) { +// breakpoint set by assemb

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -63,14 +65,31 @@ protocol::Breakpoint Breakpoint::ToProtocolBreakpoint() { std::string formatted_addr = "0x" + llvm::utohexstr(bp_addr.GetLoadAddress(m_bp.GetTarget())); breakpoint.instructionReference = formatted_addr; + +lldb::StopDisassemblyType stop_d

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Mostly style nits at this point. The comments and braces are relatively easy to spot, so in the future please do a review pass over your own PRs. I bet you'll be able to catch most of these yourself. https://github.com/llvm/llvm-project/pull/139969 __

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/139969 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -72,21 +99,31 @@ BreakpointLocationsRequestHandler::Run( } } - // The line entries are sorted by addresses, but we must return the list - // ordered by line / column position. - std::sort(locations.begin(), locations.end()); - locations.erase(llvm::unique(location

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -19,19 +19,46 @@ namespace lldb_dap { llvm::Expected BreakpointLocationsRequestHandler::Run( const protocol::BreakpointLocationsArguments &args) const { - std::string path = args.source.path.value_or(""); uint32_t start_line = args.line; uint32_t start_column = ar

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -1620,6 +1620,88 @@ void DAP::EventThread() { } } +std::vector DAP::SetSourceBreakpoints( +const protocol::Source &source, +const std::optional> &breakpoints) { + std::vector response_breakpoints; + if (source.sourceReference) { +// breakpoint set by assemb

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -1620,6 +1620,88 @@ void DAP::EventThread() { } } +std::vector DAP::SetSourceBreakpoints( +const protocol::Source &source, +const std::optional> &breakpoints) { + std::vector response_breakpoints; + if (source.sourceReference) { +// breakpoint set by assemb

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -33,16 +36,51 @@ SourceBreakpoint::SourceBreakpoint(DAP &dap, m_line(breakpoint.line), m_column(breakpoint.column.value_or(LLDB_INVALID_COLUMN_NUMBER)) {} -void SourceBreakpoint::SetBreakpoint(const llvm::StringRef source_path) { +llvm::Error SourceBreakpoint::S

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -1620,6 +1620,88 @@ void DAP::EventThread() { } } +std::vector DAP::SetSourceBreakpoints( +const protocol::Source &source, +const std::optional> &breakpoints) { + std::vector response_breakpoints; + if (source.sourceReference) { +// breakpoint set by assemb

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/140746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/140746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-20 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/138551 >From ad204cdfd226ca2a886c5475775fe67b29a70926 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Wed, 30 Apr 2025 22:03:50 +0500 Subject: [PATCH 1/7] [LLDB] Add array subscription and integer parsing to DIL ---

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-20 Thread Ilia Kuklin via lldb-commits
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const ArraySubscriptNode *node) { + auto lhs_or_err = Evaluate(node->GetBase()); + if (!lhs

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140727 >From f7d90b3e3ec052adc10ca79459249409a5ed69c2 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/6] [lldb] optionally match the `__debug` namespace for libstdc+

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,300 @@ +""" +Test lldb data formatter subsystem. +""" + +from abc import abstractmethod +from lldbsuite.test.decorators import add_test_categories, expectedFailureAll +from lldbsuite.test.lldbtest import ( +CURRENT_EXECUTABLE_SET, +RUN_SUCCEEDED, +STOPPED_DU

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -4737,19 +4750,23 @@ CompilerType TypeSystemClang::CreateGenericFunctionPrototype() { // Exploring the type const llvm::fltSemantics & -TypeSystemClang::GetFloatTypeSemantics(size_t byte_size) { +TypeSystemClang::GetFloatTypeSemantics(size_t byte_size, bool prefer_float128

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -335,6 +336,10 @@ static const llvm::fltSemantics &GetFloatSemantics(const TargetSP &target_sp, return llvm::APFloat::IEEEsingle(); case 8: return llvm::APFloat::IEEEdouble(); +case 16: + if (prefer_float128) { Michael137 wrote: Mi

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Fixes #60841 --- Patch is 59.74 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/140727.diff 14 Files Affected: - (modified) lldb/source/Plugins/Language/CPlusPlu

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1449,104 +1449,110 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_deref_flags.SetFrontEndWantsDereference(); cpp_category_sp->AddTypeSynthetic( - "^std::vector<.+>(( )?&)?$", eFormatterMatchRegex, - SyntheticChildrenSP

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/140727 Fixes #60841 >From f7d90b3e3ec052adc10ca79459249409a5ed69c2 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Sun, 18 May 2025 09:55:25 +0100 Subject: [PATCH 1/5] [lldb] optionally match the `__debug` namespace

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/libstdcpp/ma

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Ebuka Ezike via lldb-commits
da-viper wrote: Not sure who to ping, used the GitHub's reviewers suggestions. https://github.com/llvm/llvm-project/pull/140727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -0,0 +1,300 @@ +""" +Test lldb data formatter subsystem. +""" + +from abc import abstractmethod +from lldbsuite.test.decorators import add_test_categories, expectedFailureAll +from lldbsuite.test.lldbtest import ( +CURRENT_EXECUTABLE_SET, +RUN_SUCCEEDED, +STOPPED_DU

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -1449,104 +1449,110 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_deref_flags.SetFrontEndWantsDereference(); cpp_category_sp->AddTypeSynthetic( - "^std::vector<.+>(( )?&)?$", eFormatterMatchRegex, - SyntheticChildrenSP

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -1731,8 +1737,8 @@ lldb::TypeCategoryImplSP CPlusPlusLanguage::GetFormatters() { DataVisualization::Categories::GetCategory(ConstString(GetPluginName()), g_category); if (g_category) { - LoadLibStdcppFormatters(g_c

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -1449,104 +1449,110 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { stl_deref_flags.SetFrontEndWantsDereference(); cpp_category_sp->AddTypeSynthetic( - "^std::vector<.+>(( )?&)?$", eFormatterMatchRegex, - SyntheticChildrenSP

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -0,0 +1,300 @@ +""" +Test lldb data formatter subsystem. +""" + +from abc import abstractmethod +from lldbsuite.test.decorators import add_test_categories, expectedFailureAll +from lldbsuite.test.lldbtest import ( +CURRENT_EXECUTABLE_SET, +RUN_SUCCEEDED, +STOPPED_DU

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
@@ -1731,8 +1737,8 @@ lldb::TypeCategoryImplSP CPlusPlusLanguage::GetFormatters() { DataVisualization::Categories::GetCategory(ConstString(GetPluginName()), g_category); if (g_category) { - LoadLibStdcppFormatters(g_c

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] optionally match the `__debug` namespace for libstdc++ containers. (PR #140727)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,300 @@ +""" +Test lldb data formatter subsystem. +""" + +from abc import abstractmethod +from lldbsuite.test.decorators import add_test_categories, expectedFailureAll +from lldbsuite.test.lldbtest import ( +CURRENT_EXECUTABLE_SET, +RUN_SUCCEEDED, +STOPPED_DU

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-05-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Sounds sensible. If docker has bundled the fixed kernel, then that's most of the M4 users covered and anyone else can update their kernel. https://github.com/llvm/llvm-project/pull/135563 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-20 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @labath I think I misunderstand the vision you're trying to get at. Are you suggesting we have Platform determine the Signal description and the ProcessElfThread would call out to the platform_sp for it? https://github.com/llvm/llvm-project/pull/140150 ___

[Lldb-commits] [lldb] ff12762 - [lldb] Reduce max-children-count default to readable size (#139826)

2025-05-20 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-20T09:34:42-07:00 New Revision: ff127624be8cca921d1a6ed457cc3310b094ff59 URL: https://github.com/llvm/llvm-project/commit/ff127624be8cca921d1a6ed457cc3310b094ff59 DIFF: https://github.com/llvm/llvm-project/commit/ff127624be8cca921d1a6ed457cc3310b094ff59.diff LOG:

[Lldb-commits] [lldb] [lldb] Reduce max-children-count default to readable size (PR #139826)

2025-05-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/139826 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes A bit of test gardenining. Enabling tests that were marked as skipped as part of https://github.com/llvm/llvm-project/issues/137660. Fixed up some comments and doc comments and fixed some test helpers. ---

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/140777 A bit of test gardenining. Enabling tests that were marked as skipped as part of https://github.com/llvm/llvm-project/issues/137660. Fixed up some comments and doc comments and fixed some test helpers. >From e5

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-20 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] add command to save core file in gdb to lldb command map. (PR #140771)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/140771 None >From 9e29cc1dd3a7a80fe2935b373b28ba998d2d053b Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 20 May 2025 18:41:29 +0100 Subject: [PATCH] [lldb][docs] add command to save core file in gdb to lldb

[Lldb-commits] [lldb] [lldb][docs] add command to save core file in gdb to lldb command map. (PR #140771)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140771 >From 9e29cc1dd3a7a80fe2935b373b28ba998d2d053b Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 20 May 2025 18:41:29 +0100 Subject: [PATCH 1/2] [lldb][docs] add command to save core file in gdb to lldb co

[Lldb-commits] [lldb] [lldb][docs] add command to save core file in gdb to lldb command map. (PR #140771)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -1350,6 +1350,17 @@ Dump all symbols in ``a.out`` and ``liba.so`` (lldb) image dump symtab a.out liba.so +Save current process as a core file +~ JDevlieghere wrote: ```suggestion Save current process as a core

[Lldb-commits] [lldb] [lldb][docs] add command to save core file in gdb to lldb command map. (PR #140771)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/140771 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread Anthony Cabrera-Lara via lldb-commits
https://github.com/anthonycabreralara reopened https://github.com/llvm/llvm-project/pull/140746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread Anthony Cabrera-Lara via lldb-commits
https://github.com/anthonycabreralara closed https://github.com/llvm/llvm-project/pull/140746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] be5b4fa - Update InterpreterProperties.td (#140746)

2025-05-20 Thread via lldb-commits
Author: Anthony Cabrera-Lara Date: 2025-05-20T12:55:59-07:00 New Revision: be5b4fad2921dc28a0b9af8106177aa4c4862ce0 URL: https://github.com/llvm/llvm-project/commit/be5b4fad2921dc28a0b9af8106177aa4c4862ce0 DIFF: https://github.com/llvm/llvm-project/commit/be5b4fad2921dc28a0b9af8106177aa4c4862ce

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140746 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Update InterpreterProperties.td (PR #140746)

2025-05-20 Thread via lldb-commits
github-actions[bot] wrote: @anthonycabreralara Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem wi

[Lldb-commits] [lldb] [lldb][docs] add command to save core file in gdb to lldb command map. (PR #140771)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140771 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-05-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/137041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ptrace seize dead process (PR #137041)

2025-05-20 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @DavidSpickett fixed the test, I gotcha'd myself checking an optional of a bool. I added my gist to the description, let me know what you think https://github.com/llvm/llvm-project/pull/137041 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
@@ -1102,3 +1103,28 @@ def is_feature_enabled(): return "%s is not supported on this system." % feature return skipTestIfFn(is_feature_enabled) + + +def skipIfBinaryToLarge(path: Optional[str], maxSize: int): +"""Skip the test if a binary is to large. +

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/140777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Avoid double 'new' events for dyld on Darwin (PR #140810)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/140810 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7b51339 - [lldb-dap] Avoid double 'new' events for dyld on Darwin (#140810)

2025-05-20 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-20T18:51:59-07:00 New Revision: 7b513393872fe608721ce4014606b03dd780a5c9 URL: https://github.com/llvm/llvm-project/commit/7b513393872fe608721ce4014606b03dd780a5c9 DIFF: https://github.com/llvm/llvm-project/commit/7b513393872fe608721ce4014606b03dd780a5c9.d

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-20 Thread John Harrison via lldb-commits
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public CommandObjectParsed { return Status::FromErrorStringWithFormat("invalid line number: '%s'.", option_arg.str().c_str()); break; - case 'b':

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread John Harrison via lldb-commits
@@ -1,26 +1,23 @@ """ -Test lldb-dap setBreakpoints request +Test lldb-dap console output """ -import dap_server import lldbdap_testcase -from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -def get_subproces

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1,26 +1,23 @@ """ -Test lldb-dap setBreakpoints request +Test lldb-dap console output """ -import dap_server import lldbdap_testcase -from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -def get_subproces

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -62,6 +65,71 @@ def test(self): substrs=["error"], ) +def test_jump_offset(self): +"""Test Thread Jump by negative or positive offset""" +exe = self.getBuildArtifact("a.out") +file_name = "main.cpp" +self.runCmd(f"targ

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread John Harrison via lldb-commits
@@ -349,6 +349,10 @@ class LLDB_API SBTarget { SBError SetLabel(const char *label); + uint32_t GetMinimumOpcodeByteSize() const; + + uint32_t GetMaximumOpcodeByteSize() const; ashgti wrote: Can we add a comment? ``` Architecture opcode byte size width ac

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add ContinueRequestHandler unit test (PR #140566)

2025-05-20 Thread via lldb-commits
jimingham wrote: You can also use ScriptedProcesses for testing. They would allow wrapping a real process and changing the answers it hands out in some way useful to you, or just making up the process state out of whole cloth. https://github.com/llvm/llvm-project/pull/140566 _

[Lldb-commits] [lldb] [lldb-dap] Avoid double 'new' events for dyld on Darwin (PR #140810)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/140810 I got a bug report where a pedantic DAP client complains about getting two "new" module events for the same UUID. This is caused by the dyld transition from the on-disk dyld to the shared cache dyld, which

[Lldb-commits] [lldb] [lldb-dap] Avoid double 'new' events for dyld on Darwin (PR #140810)

2025-05-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes I got a bug report where a pedantic DAP client complains about getting two "new" module events for the same UUID. This is caused by the dyld transition from the on-disk dyld to the shared cache dyld

[Lldb-commits] [lldb] [lldb][lldb-dap] show modules pane if supported by the adapter (PR #140603)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Support] [lldb] Fix thread jump #45326 (PR #135778)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1649,11 +1649,14 @@ class CommandObjectThreadJump : public CommandObjectParsed { return Status::FromErrorStringWithFormat("invalid line number: '%s'.", option_arg.str().c_str()); break; - case 'b':

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thank you. This is a big improvement compared to the previous revision and makes it much easier to follow. Great job! https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb-dap] Avoid double 'new' events for dyld on Darwin (PR #140810)

2025-05-20 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/140810 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread John Harrison via lldb-commits
@@ -1102,3 +1103,28 @@ def is_feature_enabled(): return "%s is not supported on this system." % feature return skipTestIfFn(is_feature_enabled) + + +def skipIfBinaryToLarge(path: Optional[str], maxSize: int): +"""Skip the test if a binary is to large. +

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/140777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] dfc65ef - [lldb][lldb-dap] show modules pane if supported by the adapter (#140603)

2025-05-20 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-05-20T23:29:34+01:00 New Revision: dfc65ef65e4e92fee244c0eed7ec9223fc943b65 URL: https://github.com/llvm/llvm-project/commit/dfc65ef65e4e92fee244c0eed7ec9223fc943b65 DIFF: https://github.com/llvm/llvm-project/commit/dfc65ef65e4e92fee244c0eed7ec9223fc943b65.diff L

[Lldb-commits] [lldb] [lldb][lldb-dap] Basic implementation of a deferred request. (PR #140260)

2025-05-20 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test gardening, enabling tests and improving doc comments. (PR #140777)

2025-05-20 Thread Ebuka Ezike via lldb-commits
@@ -1,26 +1,23 @@ """ -Test lldb-dap setBreakpoints request +Test lldb-dap console output """ -import dap_server import lldbdap_testcase -from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * -def get_subproces

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
@@ -349,6 +349,10 @@ class LLDB_API SBTarget { SBError SetLabel(const char *label); + uint32_t GetMinimumOpcodeByteSize() const; + + uint32_t GetMaximumOpcodeByteSize() const; eronnen wrote: :100: https://github.com/llvm/llvm-project/pull/140486 __

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/140486 >From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Tue, 20 May 2025 00:47:48 +0200 Subject: [PATCH 1/4] [lldb-dap] Fix disassemble request instruction offset handling

[Lldb-commits] [lldb] 9d0614e - [lldb-dap] fix disassembly request instruction offset handling (#140486)

2025-05-20 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-21T06:50:13+02:00 New Revision: 9d0614e77ab1c5e2264e07d9b4b5f9780b38781c URL: https://github.com/llvm/llvm-project/commit/9d0614e77ab1c5e2264e07d9b4b5f9780b38781c DIFF: https://github.com/llvm/llvm-project/commit/9d0614e77ab1c5e2264e07d9b4b5f9780b38781c.diff LO

[Lldb-commits] [lldb] [lldb-dap] fix disassembly request instruction offset handling (PR #140486)

2025-05-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-05-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: So if you have code that wants to use SVE2 and may run on an SME only device with this older kernel, I think you could make it check for HWCAP_SVE and HWCAP2_SVE2. As the Architecture manual says: ``` FEAT_SVE2, Scalable Vector Extension version 2 <...> If FEAT_SVE2 is impl

[Lldb-commits] [lldb] [lldb][AArch64] Fix Apple M4 on Linux (PR #135563)

2025-05-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: I checked cpuinfo and hwcaps for 6.5 (doesn't have the fix) and 6.15 (does, and it was what I was using anyway). Same machine configuration, SME only. ``` $ uname -a Linux e125016 6.5.0 #6 SMP PREEMPT Tue May 20 09:43:29 UTC 2025 aarch64 aarch64 aarch64 GNU/Linux Features

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-20 Thread Pavel Labath via lldb-commits
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const ArraySubscriptNode *node) { + auto lhs_or_err = Evaluate(node->GetBase()); + if (!lhs

[Lldb-commits] [lldb] [lldb] Extend information for failed connection for gdb server (PR #139916)

2025-05-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/139916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend information for failed connection for gdb server (PR #139916)

2025-05-20 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/139916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b3e15ba - [lldb] Extend information for failed connection for gdb server (#139916)

2025-05-20 Thread via lldb-commits
Author: ita-sc Date: 2025-05-20T09:32:40+01:00 New Revision: b3e15baf7c649a12e71ff281b83e9213abae2977 URL: https://github.com/llvm/llvm-project/commit/b3e15baf7c649a12e71ff281b83e9213abae2977 DIFF: https://github.com/llvm/llvm-project/commit/b3e15baf7c649a12e71ff281b83e9213abae2977.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-20 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/138551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-20 Thread Pavel Labath via lldb-commits
@@ -272,4 +272,52 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const ArraySubscriptNode *node) { + auto lhs_or_err = Evaluate(node->GetBase()); + if (!lhs

[Lldb-commits] [lldb] [lldb][core] Fix getting summary of a variable pointing to r/o memory (PR #139196)

2025-05-20 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/139196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatters] Adjust retrieval of unordered_map element type (PR #140256)

2025-05-20 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/140256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 034eaed - [lldb][DataFormatters] Adjust retrieval of unordered_map element type (#140256)

2025-05-20 Thread via lldb-commits
Author: Michael Buch Date: 2025-05-20T09:44:26+01:00 New Revision: 034eaeddc30cbaf273744580f15325514d5fb928 URL: https://github.com/llvm/llvm-project/commit/034eaeddc30cbaf273744580f15325514d5fb928 DIFF: https://github.com/llvm/llvm-project/commit/034eaeddc30cbaf273744580f15325514d5fb928.diff

[Lldb-commits] [lldb] [lldb][DataFormatters] Adjust retrieval of unordered_map element type (PR #140256)

2025-05-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/140256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support riscv32 ELF corefiles (PR #115408)

2025-05-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: 1. This went in without tests, intentional? 2. Seems like a release note worthy feature. https://github.com/llvm/llvm-project/pull/115408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

  1   2   >