[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-15 Thread via lldb-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/138587 >From 052580cd9ee141cd8c79e9588ad1c71e31f58cb3 Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 5 May 2025 14:11:44 -0700 Subject: [PATCH 1/7] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS In #1

[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-15 Thread via lldb-commits
jeremyd2019 wrote: > > I rebased this on top of #138783 and adjusted the title and description. > > Now it should be in a good state to push cmake changes for other projects. > > The changes look good, but it looks like the changes from #138783 still show > up when viewing the changes; can you

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Adding an assert that the 'continue' request succeeds caused a number of tests to fail. This showed a number of tests that were not specifying if they should be stopped or not at key points in the test. This

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-15 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/138551 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-15 Thread Ilia Kuklin via lldb-commits
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const ArraySubscriptNode *node) { + auto lhs_or_err = Evaluate(node->GetBase()); + if (!lhs

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-15 Thread Ilia Kuklin via lldb-commits
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const ArraySubscriptNode *node) { + auto lhs_or_err = Evaluate(node->GetBase()); + if (!lhs

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-15 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: I think I addressed everything I could, please take a look again. https://github.com/llvm/llvm-project/pull/138551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-15 Thread Ilia Kuklin via lldb-commits
@@ -111,7 +111,42 @@ ASTNodeUP DILParser::ParseUnaryExpression() { llvm_unreachable("invalid token kind"); } } - return ParsePrimaryExpression(); + return ParsePostfixExpression(); +} + +// Parse a postfix_expression. +// +// postfix_expression: +//primary_ex

[Lldb-commits] [lldb] 58b9b86 - [lldb-dap] Setup DAP for unit testing. (#139937)

2025-05-15 Thread via lldb-commits
Author: John Harrison Date: 2025-05-15T10:45:16-07:00 New Revision: 58b9b865feffede59616cfc05cefa956d5352314 URL: https://github.com/llvm/llvm-project/commit/58b9b865feffede59616cfc05cefa956d5352314 DIFF: https://github.com/llvm/llvm-project/commit/58b9b865feffede59616cfc05cefa956d5352314.diff

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/140107 Adding an assert that the 'continue' request succeeds caused a number of tests to fail. This showed a number of tests that were not specifying if they should be stopped or not at key points in the test. This is

[Lldb-commits] [lldb] [lldb-dap] Setup DAP for unit testing. (PR #139937)

2025-05-15 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/139937 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-15 Thread Ilia Kuklin via lldb-commits
@@ -272,4 +272,67 @@ Interpreter::Visit(const UnaryOpNode *node) { m_expr, "invalid ast: unexpected binary operator", node->GetLocation()); } +llvm::Expected +Interpreter::Visit(const ArraySubscriptNode *node) { + auto lhs_or_err = Evaluate(node->GetBase()); + if (!lhs

[Lldb-commits] [lldb] [lldb-dap] Refactor lldb-dap event handling. (PR #139669)

2025-05-15 Thread John Harrison via lldb-commits
ashgti wrote: I'm working on splitting out the test changes, #140107 is the main set that I think are related. If so, this may become a more of a NFC from the test perspective. https://github.com/llvm/llvm-project/pull/139669 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/138116 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/138116 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[Lldb-commits] [lldb] [lldb][lldb-dap] Migrate ScopesRequest to structured types (PR #138116)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/138116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4ba8f4e - [lldb][lldb-dap] Migrate ScopesRequest to structured types (#138116)

2025-05-15 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-05-15T10:16:05+01:00 New Revision: 4ba8f4e213c97733e3b61e5856b0e85e3d7d6a7f URL: https://github.com/llvm/llvm-project/commit/4ba8f4e213c97733e3b61e5856b0e85e3d7d6a7f DIFF: https://github.com/llvm/llvm-project/commit/4ba8f4e213c97733e3b61e5856b0e85e3d7d6a7f.diff L

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap] fix C++20 extension warning (PR #140031)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/140031 warning for designated initializers >From 0a8d16445c531f7a65283ab2a9a7db522eeb3a5a Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 15 May 2025 10:36:39 +0100 Subject: [PATCH] [NFC][lldb][lldb-dap] fix C+

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap] fix C++20 extension warning (PR #140031)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140031 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap] fix C++20 extension warning (PR #140031)

2025-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes warning for designated initializers --- Full diff: https://github.com/llvm/llvm-project/pull/140031.diff 1 Files Affected: - (modified) lldb/unittests/DAP/ProtocolTypesTest.cpp (+5-5) ``diff diff

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap] fix C++20 extension warning (PR #140031)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/140031 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap] fix C++20 extension warning (PR #140031)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/140031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e3867cb - [NFC][lldb][lldb-dap] fix C++20 extension warning (#140031)

2025-05-15 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-05-15T11:13:19+01:00 New Revision: e3867cb07ed1ed319609fbea0ce15f40e2a0efad URL: https://github.com/llvm/llvm-project/commit/e3867cb07ed1ed319609fbea0ce15f40e2a0efad DIFF: https://github.com/llvm/llvm-project/commit/e3867cb07ed1ed319609fbea0ce15f40e2a0efad.diff L

[Lldb-commits] [lldb] [NFC][lldb][lldb-dap] fix C++20 extension warning (PR #140031)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/140031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix race condition during iteration through modules (#139283) (PR #139862)

2025-05-15 Thread via lldb-commits
https://github.com/neverov-test deleted https://github.com/llvm/llvm-project/pull/139862 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix race condition during iteration through modules (#139283) (PR #139862)

2025-05-15 Thread via lldb-commits
@@ -1510,6 +1510,7 @@ bool Target::IgnoreWatchpointByID(lldb::watch_id_t watch_id, } ModuleSP Target::GetExecutableModule() { + std::lock_guard guard(m_images.GetMutex()); neverov-test wrote: done https://github.com/llvm/llvm-project/pull/139862 __

[Lldb-commits] [clang] [flang] [lld] [lldb] [llvm] [mlir] [polly] [CMake] respect LLVMConfig.cmake's LLVM_DEFINITIONS in standalone builds (PR #138587)

2025-05-15 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: > I rebased this on top of #138783 and adjusted the title and description. Now > it should be in a good state to push cmake changes for other projects. The changes look good, but it looks like the changes from #138783 still show up when viewing the changes; can you check that y

[Lldb-commits] [lldb] 42ee758 - Complete the Implementation of DAP modules explorer. (#139934)

2025-05-15 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-05-15T12:21:26+01:00 New Revision: 42ee758bec885deaad08162cc8e97a87d2aba100 URL: https://github.com/llvm/llvm-project/commit/42ee758bec885deaad08162cc8e97a87d2aba100 DIFF: https://github.com/llvm/llvm-project/commit/42ee758bec885deaad08162cc8e97a87d2aba100.diff L

[Lldb-commits] [lldb] Complete the Implementation of DAP modules explorer. (PR #139934)

2025-05-15 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/139934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,71 @@ +//===-- NativeThreadAIX.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/139537 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Shall I merge it now? @labath https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/source/Plugins/Process/AIX/NativeThreadAIX.cpp

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/139537 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[Lldb-commits] [lldb] [lldb] Add support for displaying `__float128` variables (PR #98369)

2025-05-15 Thread Michael Buch via lldb-commits
@@ -666,7 +667,9 @@ lldb::offset_t lldb_private::DumpDataExtractor( const unsigned format_precision = 0; const llvm::fltSemantics &semantics = - GetFloatSemantics(target_sp, item_byte_size); + item_format == eFormatFloat128 && item_byte_size == 16

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #140011)

2025-05-15 Thread Tim Gymnich via lldb-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/140011 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::unique (NFC) (PR #139910)

2025-05-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139910 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9f569fe - [lldb] Use std::optional::value_or (NFC) (#140011)

2025-05-15 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-15T07:17:18-07:00 New Revision: 9f569fe2e7b68db856716a1ae3b0a6738a281d1e URL: https://github.com/llvm/llvm-project/commit/9f569fe2e7b68db856716a1ae3b0a6738a281d1e DIFF: https://github.com/llvm/llvm-project/commit/9f569fe2e7b68db856716a1ae3b0a6738a281d1e.diff L

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #140011)

2025-05-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140011 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (PR #140065)

2025-05-15 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/140065 The motivation here is being (un)able to treat pointer values as an array consistently. This works for pointers to simple/scalar values, but for aggregates, we get a very surprising result: - GetChildAtIndex(x,

[Lldb-commits] [lldb] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (PR #140065)

2025-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The motivation here is being (un)able to treat pointer values as an array consistently. This works for pointers to simple/scalar values, but for aggregates, we get a very surprising result: - GetChildAtIndex(x

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Ship it. https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (PR #140065)

2025-05-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/python_api/sbvalue_synthetic/TestSBValueSynthetic.py `

[Lldb-commits] [lldb] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (PR #140065)

2025-05-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/API/SBValue.h lldb/source/API/SBV

[Lldb-commits] [lldb] 1f570b1 - [lldb] Use llvm::unique (NFC) (#139910)

2025-05-15 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-15T07:15:59-07:00 New Revision: 1f570b1c2df6ec93a90ec8f0751fe8355644f1c6 URL: https://github.com/llvm/llvm-project/commit/1f570b1c2df6ec93a90ec8f0751fe8355644f1c6 DIFF: https://github.com/llvm/llvm-project/commit/1f570b1c2df6ec93a90ec8f0751fe8355644f1c6.diff L

[Lldb-commits] [lldb] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (PR #140065)

2025-05-15 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/140065 >From 59829616c0897325795f667a8cd3bdcb309ff91c Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 15 May 2025 14:55:09 +0200 Subject: [PATCH] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) The motiva

[Lldb-commits] [lldb] [lldb]Make `list` command work with headers when possible. (PR #139002)

2025-05-15 Thread Vy Nguyen via lldb-commits
@@ -714,6 +714,8 @@ uint32_t ModuleList::ResolveSymbolContextsForFileSpec( const FileSpec &file_spec, uint32_t line, bool check_inlines, SymbolContextItem resolve_scope, SymbolContextList &sc_list) const { std::lock_guard guard(m_modules_mutex); + // If we're looking

[Lldb-commits] [lldb] [lldb]Make `list` command work with headers when possible. (PR #139002)

2025-05-15 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/139002 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/139537 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[Lldb-commits] [lldb] [lldb]Make `list` command work with headers when possible. (PR #139002)

2025-05-15 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/139002 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] [LLDB] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread via lldb-commits
@@ -584,22 +584,26 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch, // 64b ELF have a 4 byte pad. if (data.GetAddressByteSize() == 8) offset += 4; - // Not every stop signal has a valid address, but that will get resolved in - // the

[Lldb-commits] [lldb] [LLDB] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread Jacob Lalonde via lldb-commits
@@ -584,22 +584,26 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch, // 64b ELF have a 4 byte pad. if (data.GetAddressByteSize() == 8) offset += 4; - // Not every stop signal has a valid address, but that will get resolved in - // the

[Lldb-commits] [lldb] [lldb] Reduce max-children-count default to readable size (PR #139826)

2025-05-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. As an 80x24 terminal user, I approve of this change :-) https://github.com/llvm/llvm-project/pull/139826 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb]Make `list` command work with headers when possible. (PR #139002)

2025-05-15 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/139002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb]Make `list` command work with headers when possible. (PR #139002)

2025-05-15 Thread Pavel Labath via lldb-commits
@@ -1113,17 +1123,25 @@ class CommandObjectSourceList : public CommandObjectParsed { ModuleSpec module_spec(module_file_spec); matching_modules.Clear(); target.GetImages().FindModules(module_spec, matching_modules); -num_matches

[Lldb-commits] [lldb] Extending LLDB to work on AIX (PR #102601)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/102601 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[Lldb-commits] [lldb] [lldb-dap] Listen for broadcast classes. (PR #140142)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I had thought about also including a check on the target to see if it was the > `DAP.target`, but again during launch or attach commands we may not know > which target we need to focus on yet. Can we use the selected target until we've decided on the dap target? I guess

[Lldb-commits] [lldb] bcb1227 - [lldb][AIX] Adding NativeThreadAIX (#139537)

2025-05-15 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2025-05-16T11:30:07+05:30 New Revision: bcb1227c3c1cc904fe6bc724b78c8c737234c709 URL: https://github.com/llvm/llvm-project/commit/bcb1227c3c1cc904fe6bc724b78c8c737234c709 DIFF: https://github.com/llvm/llvm-project/commit/bcb1227c3c1cc904fe6bc724b78c8c737234c709.di

[Lldb-commits] [lldb] [lldb][AIX] Adding NativeThreadAIX (PR #139537)

2025-05-15 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/139537 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Listen for broadcast classes. (PR #140142)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > We do support the `startDebugging` reverse request > https://microsoft.github.io/debug-adapter-protocol/specification#Reverse_Requests_StartDebugging. > I use this to attach to multiple processes when tests are running from some > scripts that involve multiple processes.

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/140107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
@@ -78,13 +78,13 @@ def waitUntil(self, condition_callback): time.sleep(0.5) return False -def verify_breakpoint_hit(self, breakpoint_ids): +def verify_breakpoint_hit(self, breakpoint_ids, timeout=timeoutval): JDevlieghere wrote: A

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Overall looks good. Reviewing this, I think this could probably be broken down further into NFC-ish changes, but I'm not sure it's worth the overhead of doing that. No need to do it on my behalf at least. https://github.com/llvm/llvm-project/pull/140

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
@@ -67,7 +67,7 @@ def test_core_file_source_mapping_array(self): self.create_debug_adapter() source_map = [["/home/labath/test", current_dir]] -self.attach(exe_file, coreFile=core_file, sourceMap=source_map) +self.attach(program=exe_file, coreFi

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
@@ -487,115 +453,36 @@ def cleanup(): response = self.dap_server.request_launch( program, -args=args, -cwd=cwd, -env=env, stopOnEntry=stopOnEntry, -disableASLR=disableASLR, -disableSTD

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
@@ -263,46 +262,61 @@ def set_global(self, name, value, id=None): return self.dap_server.request_setVariable(2, name, str(value), id=id) def stepIn( -self, threadId=None, targetId=None, waitForStop=True, granularity="statement" +self, +thre

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
@@ -487,115 +453,36 @@ def cleanup(): response = self.dap_server.request_launch( program, -args=args, -cwd=cwd, -env=env, stopOnEntry=stopOnEntry, -disableASLR=disableASLR, -disableSTD

[Lldb-commits] [lldb] [lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (PR #140065)

2025-05-15 Thread via lldb-commits
@@ -193,7 +188,7 @@ class LLDB_API SBValue { /// and also if the target can be run to figure out the dynamic /// type of the child value. /// - /// \param[in] can_create_synthetic + /// \param[in] use_synthetic jimingham wrote: I think this cha

[Lldb-commits] [lldb] [LLDB][Progress-On-Dap] Have indeterminate progress actually send events. (PR #140162)

2025-05-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140162 >From 0673dc530a91cb2dd1bdd60dd5136d64e4ed48e8 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 15 May 2025 16:37:06 -0700 Subject: [PATCH 1/2] Have interderminate events actually broadcast to dap --- .

[Lldb-commits] [lldb] [LLDB][Progress-On-Dap] Have indeterminate progress actually send events. (PR #140162)

2025-05-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140162 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[Lldb-commits] [lldb] [LLDB][Progress-On-Dap] Have indeterminate progress actually send events. (PR #140162)

2025-05-15 Thread John Harrison via lldb-commits
@@ -77,16 +77,19 @@ ProgressEvent::Create(uint64_t progress_id, std::optional message, if (event.GetEventType() == progressStart && event.GetEventName().empty()) return std::nullopt; - if (prev_event && prev_event->EqualsForIDE(event)) + if (prev_event && prev_event->

[Lldb-commits] [lldb] [lldb-dap] Listen for broadcast classes. (PR #140142)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Summarizing the problem to make sure I understand: with the new launch/attach flow, we set the breakpoints in the dummy target before the actual target is created. If the target is created through launch commands, we're calling SetTarget with the currently selected target.

[Lldb-commits] [lldb] Extending LLDB to work on AIX (PR #102601)

2025-05-15 Thread via lldb-commits
https://github.com/ravindra-shinde2 updated https://github.com/llvm/llvm-project/pull/102601 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Ari

[Lldb-commits] [lldb] [lldb-dap] Listen for broadcast classes. (PR #140142)

2025-05-15 Thread John Harrison via lldb-commits
ashgti wrote: > Summarizing the problem to make sure I understand: with the new launch/attach > flow, we set the breakpoints in the dummy target before the actual target is > created. If the target is created through launch commands, we're calling > SetTarget with the currently selected target

[Lldb-commits] [lldb] [lldb][NFC] Split RegisterContextUnwind::SavedLocationForRegister (PR #139817)

2025-05-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/139817 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[Lldb-commits] [lldb] [lldb] Use std::optional::value_or (NFC) (PR #140011)

2025-05-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/140011 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use llvm::unique (NFC) (PR #139910)

2025-05-15 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Makes sense. `std::unique` doesn't invalidate the end iterator, so I believe this should be ok. https://github.com/llvm/llvm-project/pull/139910 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [lldb] Fix race condition during iteration through modules (#139283) (PR #139862)

2025-05-15 Thread via lldb-commits
https://github.com/nd updated https://github.com/llvm/llvm-project/pull/139862 >From f6b1c03607582e580f0b3167c0e337c35c31cbeb Mon Sep 17 00:00:00 2001 From: "Dmitry.Neverov" Date: Wed, 14 May 2025 11:09:07 +0200 Subject: [PATCH] [lldb] Fix race condition during iteration through modules (#13928

[Lldb-commits] [lldb] Fix race condition during iteration through modules (#139283) (PR #139862)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/139862 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
@@ -263,46 +262,61 @@ def set_global(self, name, value, id=None): return self.dap_server.request_setVariable(2, name, str(value), id=id) def stepIn( -self, threadId=None, targetId=None, waitForStop=True, granularity="statement" +self, +thre

[Lldb-commits] [lldb] [lldb] Limit formatter-section extractor range (PR #140139)

2025-05-15 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/140139 The formatter extraction would look at too much data for one type. This PR limits the size of the `DataExtractor` to the one specified in the record size before - previously, the whole section was looked at. Sim

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Jonas Devlieghere via lldb-commits
@@ -263,46 +262,61 @@ def set_global(self, name, value, id=None): return self.dap_server.request_setVariable(2, name, str(value), id=id) def stepIn( -self, threadId=None, targetId=None, waitForStop=True, granularity="statement" +self, +thre

[Lldb-commits] [lldb] [lldb] Limit formatter-section extractor range (PR #140139)

2025-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes The formatter extraction would look at too much data for one type. This PR limits the size of the `DataExtractor` to the one specified in the record size before - previously, the whole section was looked at. Similarl

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread Jacob Lalonde via lldb-commits
@@ -584,22 +584,26 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch, // 64b ELF have a 4 byte pad. if (data.GetAddressByteSize() == 8) offset += 4; - // Not every stop signal has a valid address, but that will get resolved in - // the

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
@@ -78,13 +78,13 @@ def waitUntil(self, condition_callback): time.sleep(0.5) return False -def verify_breakpoint_hit(self, breakpoint_ids): +def verify_breakpoint_hit(self, breakpoint_ids, timeout=timeoutval): ashgti wrote: Done.

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/140107 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
@@ -263,46 +262,61 @@ def set_global(self, name, value, id=None): return self.dap_server.request_setVariable(2, name, str(value), id=id) def stepIn( -self, threadId=None, targetId=None, waitForStop=True, granularity="statement" +self, +thre

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
@@ -16,8 +16,10 @@ def spawn_and_wait(program, delay): +print("spawn_and_wait started...", time.time()) ashgti wrote: Removed the extra prints. https://github.com/llvm/llvm-project/pull/140107 ___ lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
@@ -67,7 +67,7 @@ def test_core_file_source_mapping_array(self): self.create_debug_adapter() source_map = [["/home/labath/test", current_dir]] -self.attach(exe_file, coreFile=core_file, sourceMap=source_map) +self.attach(program=exe_file, coreFi

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/140107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread John Harrison via lldb-commits
@@ -487,115 +453,36 @@ def cleanup(): response = self.dap_server.request_launch( program, -args=args, -cwd=cwd, -env=env, stopOnEntry=stopOnEntry, -disableASLR=disableASLR, -disableSTD

[Lldb-commits] [lldb] [lldb-dap] Adding additional asserts to unit tests. (PR #140107)

2025-05-15 Thread Ebuka Ezike via lldb-commits
@@ -16,8 +16,10 @@ def spawn_and_wait(program, delay): +print("spawn_and_wait started...", time.time()) da-viper wrote: I don't think print statement works in tests. https://github.com/llvm/llvm-project/pull/140107 _

[Lldb-commits] [lldb] [lldb-dap] Listen for broadcast classes. (PR #140142)

2025-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes The recent change to the startup flow has highlighted a problem with breakpoint events being missed. Previously, we would handle `attach`/`launch` commands immediately, leaving the process in a suspended unt

[Lldb-commits] [lldb] [lldb-dap] Listen for broadcast classes. (PR #140142)

2025-05-15 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/140142 The recent change to the startup flow has highlighted a problem with breakpoint events being missed. Previously, we would handle `attach`/`launch` commands immediately, leaving the process in a suspended until

[Lldb-commits] [lldb] [lldb-dap] assembly breakpoints (PR #139969)

2025-05-15 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/139969 >From ae324862f516ebb5be3206485476b586b22488b7 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sat, 10 May 2025 20:45:17 +0200 Subject: [PATCH 1/4] support assembly in BreakpointLocationsRequestHandler --- ...

[Lldb-commits] [lldb] [LLDB] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/140150 Recently, I was on an issue that generated a large number of Coredumps, and every time in both LLDB and GDB the signal was just `SIGSEGV`. This was frustrating because we would expect a `SIGSEGV` to have an add

[Lldb-commits] [lldb] [LLDB] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Recently, I was on an issue that generated a large number of Coredumps, and every time in both LLDB and GDB the signal was just `SIGSEGV`. This was frustrating because we would expect a `SIGSEGV` to have an