https://github.com/ravi-sh updated
https://github.com/llvm/llvm-project/pull/102601
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
labath wrote:
Declare it where
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -111,7 +111,27 @@ ASTNodeUP DILParser::ParseUnaryExpression() {
llvm_unreachable("invalid token kind");
}
}
- return ParsePrimaryExpression();
+ return ParsePostfixExpression();
+}
+// Parse a postfix_expression.
labath wrote:
```suggestion
/
@@ -88,6 +89,29 @@ class IdentifierNode : public ASTNode {
std::string m_name;
};
+class MemberOfNode : public ASTNode {
+public:
+ MemberOfNode(uint32_t location, ASTNodeUP base, bool is_arrow,
+ std::string name)
+ : ASTNode(location, NodeKind::eMemberO
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
@@ -0,0 +1,59 @@
+int
+main(int argc, char**argv)
+{
+ int x = 2;
+ struct Sx {
+int x;
+int& r;
+char y;
+ } s{1, x, 2};
+
+ Sx& sr = s;
+ Sx* sp = &s;
+
+ Sx sarr[2] = {{5, x, 2}, {1, x, 3}};
+
+ using SxAlias = Sx;
+ SxAlias sa{3, x, 4};
+
+ return 0; // Se
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/131304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -190,7 +190,59 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
bool ObjectFileXCOFF::IsStripped() { return false; }
-void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {}
+void ObjectFileXCOFF::CreateSections(SectionList &unified_section_l
@@ -190,7 +190,59 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
bool ObjectFileXCOFF::IsStripped() { return false; }
-void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {}
+void ObjectFileXCOFF::CreateSections(SectionList &unified_section_l
@@ -190,8 +190,83 @@ void ObjectFileXCOFF::ParseSymtab(Symtab &lldb_symtab) {}
bool ObjectFileXCOFF::IsStripped() { return false; }
-void ObjectFileXCOFF::CreateSections(SectionList &unified_section_list) {}
-
+void ObjectFileXCOFF::CreateSections(SectionList &unified_section
@@ -7,6 +7,9 @@
# CHECK: Stripped: false
# CHECK: Type: executable
# CHECK: Strata: unknown
+# CHECK: Name: .text
+# CHECK-NEXT: code
+# CHECK-NEXT: r-x
labath wrote:
That's because most of their code is very old. I definitely wouldn't want to
emulate that as
@@ -1114,15 +1115,15 @@ class CommandObjectSourceList : public
CommandObjectParsed {
matching_modules.Clear();
target.GetImages().FindModules(module_spec, matching_modules);
num_matches += matching_modules.ResolveSymbolContextForFilePath(
-
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1170,10 +1171,41 @@ class CommandObjectSourceList : public
CommandObjectParsed {
if (m_options.num_lines == 0)
m_options.num_lines = 10;
const uint32_t column = 0;
+
+ // Headers aren't always in the DWARF but if they have
+
https://github.com/labath commented:
It seems rather wasteful (and error-prone) to repeat the search through the
support files of a compile unit, given that ResolveSymbolContextForFilePath has
already searched through them and told us that the CU really does contain a
file with the given name.
@@ -734,15 +734,22 @@ size_t ValueObject::GetPointeeData(DataExtractor &data,
uint32_t item_idx,
} break;
case eAddressTypeLoad: {
ExecutionContext exe_ctx(GetExecutionContextRef());
- Process *process = exe_ctx.GetProcessPtr();
- if (process) {
-
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/igorkudrin updated
https://github.com/llvm/llvm-project/pull/139196
>From 499f723c3f974ff53deb8f354d879e0baaa7a9e8 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
Date: Wed, 7 May 2025 19:55:07 -0700
Subject: [PATCH 1/4] [lldb][core] Fix getting summary of a variable pointing
to
@@ -1,20 +1,11 @@
-if(APPLE)
- configure_file(
-${CMAKE_CURRENT_SOURCE_DIR}/lldb-dap-Info.plist.in
-${CMAKE_CURRENT_BINARY_DIR}/lldb-dap-Info.plist
-)
- # Inline info plist in binary (use target_link_options for this as soon as
CMake 3.13 is available)
- set(CMAKE_
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/138116
>From 98659ed9520b5364092e72420aee5edea7cb7bba Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 29 Apr 2025 18:19:18 +0100
Subject: [PATCH 1/2] [lldb][lldb-dap] Migrate 'Scopes' to structured types.
---
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/138116
>From 98659ed9520b5364092e72420aee5edea7cb7bba Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 29 Apr 2025 18:19:18 +0100
Subject: [PATCH 1/3] [lldb][lldb-dap] Migrate 'Scopes' to structured types.
---
@@ -98,9 +83,15 @@ void ScopesRequestHandler::operator()(const
llvm::json::Object &request) const {
/*statics=*/true,
/*in_scope_only=*/true);
dap.variables.registers = frame.GetRegiste
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
medismailben wrote:
> @felipepiovezan I don't have a machine to run ObjC tests on, could you apply
> this patch and see if it fixes the issue in #135843 ?
I'll try that for you.
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailin
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/139502
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
JDevlieghere wrote:
Updated the PR and settled on the roundtrip approach for `Source` and
`ExceptionBreakpointsFilter`.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
medismailben wrote:
> @felipepiovezan I don't have a machine to run ObjC tests on, could you apply
> this patch and see if it fixes the issue in #135843 ?
The test pass after applying this patch. Feel free to land this whenever :)
https://github.com/llvm/llvm-project/pull/139567
_
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/139596
A number of unit tests are unstable at the moment and I believe this is due to
event handling between the event thread and the DAP::Loop.
One way this manifests is the 'disconnect' request terminating the SBTarg
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
A number of unit tests are unstable at the moment and I believe this is due to
event handling between the event thread and the DAP::Loop.
One way this manifests is the 'disconnect' request terminating the SBT
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/139252
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-
ashgti wrote:
I've been thinking about that as well. I wasn't sure if there was an easy way
to integrate the event system into a MainLoop helper but that would definitely
help.
https://github.com/llvm/llvm-project/pull/139596
___
lldb-commits mailin
@@ -7,6 +7,9 @@
# CHECK: Stripped: false
# CHECK: Type: executable
# CHECK: Strata: unknown
+# CHECK: Name: .text
+# CHECK-NEXT: code
+# CHECK-NEXT: r-x
DhruvSrivastavaX wrote:
Right, thats reasonable! Will increment accordingly in upcoming additions.
https:/
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,62 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
dmpots wrote:
ping @clayborg @JDevlieghere @jimingham. Please take a look when you get a
chance. Thanks!
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -0,0 +1,62 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/138116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
One style nit question but otherwise LGTM
https://github.com/llvm/llvm-project/pull/138116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -269,17 +271,16 @@ struct Capabilities {
};
llvm::json::Value toJSON(const Capabilities &);
-enum PresentationHint : unsigned {
- ePresentationHintNormal,
- ePresentationHintEmphasize,
- ePresentationHintDeemphasize,
-};
-llvm::json::Value toJSON(PresentationHint hint);
@@ -0,0 +1,62 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
JDevlieghere wrote:
Fixed by fb9b43a0c56de9b1f36e862565c33e0ad637fb36
https://github.com/llvm/llvm-project/pull/139402
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,268 @@
+//===-- ProtocolTypesTest.cpp ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Jan Svoboda (jansvoboda11)
Changes
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerInvocation` owns the `DiagnosticOptio
llvmbot wrote:
@llvm/pr-subscribers-clang-format
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerIn
Author: Jonas Devlieghere
Date: 2025-05-12T13:23:50-07:00
New Revision: 8bec5e5b88de6cfa7cd979b73eafdc2ba69ee053
URL:
https://github.com/llvm/llvm-project/commit/8bec5e5b88de6cfa7cd979b73eafdc2ba69ee053
DIFF:
https://github.com/llvm/llvm-project/commit/8bec5e5b88de6cfa7cd979b73eafdc2ba69ee053.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> FWIW, I completely agree @royitaqi. I'm not saying inter-plugin dependencies
> should be a free-for-all (*), but I think that some kinds of dependencies
> make sense and I definitely think this is one of them. The debug map format
> is intimately tied to the MachO and dar
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Remove the `lldb-vscode` -> `lldb-dap` symlink in the `tools` directory. I
initially created the symlink when we renamed the tool to make migration
easier. I think enough time has passed that we do
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/131304
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Ari
jpienaar wrote:
I agree a condition variable would work here. I realized this later too (wanted
all destroyed at end), one could do that as follows too
// In ManualDWARFIndex
...
std::vector clear_cu_dies;
clear_cu_dies.reserve(units_to_index.size());
for (auto &unit : units_to_index
https://github.com/jpienaar updated
https://github.com/llvm/llvm-project/pull/139252
>From c5ffbd84f8b68bae2112e8cec68803cefe571a72 Mon Sep 17 00:00:00 2001
From: Jacques Pienaar
Date: Fri, 9 May 2025 05:23:00 -0700
Subject: [PATCH 1/3] [lldb][plugin] Clear in same thread as set
Here we were i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
test_common is force-included into every compilation, which causes problems
when we're compiling assembly code, as we were in #138805.
This avoids that as we can include the header only when it's needed.
---
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/139550
test_common is force-included into every compilation, which causes problems
when we're compiling assembly code, as we were in #138805.
This avoids that as we can include the header only when it's needed.
labath wrote:
@DavidSpickett, following up on
https://github.com/llvm/llvm-project/issues/138085#issuecomment-2871438305, I
noticed that some of these tests don't have the synchronization to prevent the
test attaching before they disable YAMA -- and I think most of those tests are
marked `@fl
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/139552
`TypeSystemClang::GetNumBaseClasses` does exactly the same base-class
accounting that we were doing in GetNumChildren. So re-use it.
Rate limit · GitHub
body {
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
`TypeSystemClang::GetNumBaseClasses` does exactly the same base-class
accounting that we were doing in GetNumChildren. So re-use it.
---
Full diff: https://github.com/llvm/llvm-project/pull/139552.diff
1
labath wrote:
I looked at why the test fails on linux. It turns out it's due to a bunch of
reasons, but most of them are unrelated to the problem at hand. #139545 and
#139550 fix the surrounding issues, and
https://github.com/llvm/llvm-project/commit/c290e555d6e7d196ebbe5fd6d64e0be25275a5b4
i
felipepiovezan wrote:
hi @kuilpd , I think this may have broken the mac incremental bots:
https://green.lab.llvm.org//job/as-lldb-cmake/25656/
```
[2025-05-12T12:08:03.542Z] runCmd: frame variable -d run-target *cfDictionaryRef
[2025-05-12T12:08:03.542Z]
[2025-05-12T12:08:03.542Z] runCmd fail
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/139545
>From 2aa2fd0d0777bd0bcdd1b627c2c3d306b79512c4 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 12 May 2025 04:38:05 -0700
Subject: [PATCH] [lldb] Merge/unify ABI-provided AArch64 unwind plans
The macos an
https://github.com/labath approved this pull request.
yay
https://github.com/llvm/llvm-project/pull/139552
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -189,17 +189,23 @@ DWARFUnit::ScopedExtractDIEs
DWARFUnit::ExtractDIEsScoped() {
}
DWARFUnit::ScopedExtractDIEs::ScopedExtractDIEs(DWARFUnit &cu) : m_cu(&cu) {
- m_cu->m_die_array_scoped_mutex.lock_shared();
+ llvm::sys::ScopedLock lock(m_cu->m_die_array_scoped_mutex);
+
labath wrote:
> But if plain counter preferred, will switch to that.
That is the first idea that crossed my mind, I'm not saying its the best one.
I'm not really sure how would a condition variable help here (like, you still
need some kind of a counter to trigger the condition), but I'm open t
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/139621
Remove the `lldb-vscode` -> `lldb-dap` symlink in the `tools` directory. I
initially created the symlink when we renamed the tool to make migration
easier. I think enough time has passed that we don't nee
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/139621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,546 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -269,17 +271,16 @@ struct Capabilities {
};
llvm::json::Value toJSON(const Capabilities &);
-enum PresentationHint : unsigned {
- ePresentationHintNormal,
- ePresentationHintEmphasize,
- ePresentationHintDeemphasize,
-};
-llvm::json::Value toJSON(PresentationHint hint);
https://github.com/JDevlieghere approved this pull request.
LGTM modulo the enum nit. Please add a unit test for `Scope` now that that's
possible :-)
https://github.com/llvm/llvm-project/pull/138116
___
lldb-commits mailing list
lldb-commits@lists.ll
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/139301
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans
oontvoo wrote:
> Maybe we should use line 1 than as that's the first real line number?
done! thanks!
https://github.com/llvm/llvm-project/pull/139002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
Author: Jonas Devlieghere
Date: 2025-05-12T09:51:15-07:00
New Revision: fb9b43a0c56de9b1f36e862565c33e0ad637fb36
URL:
https://github.com/llvm/llvm-project/commit/fb9b43a0c56de9b1f36e862565c33e0ad637fb36
DIFF:
https://github.com/llvm/llvm-project/commit/fb9b43a0c56de9b1f36e862565c33e0ad637fb36.d
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/139584
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerInvocation` owns the `DiagnosticOption
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/139002
>From 5746e997eea55c05cbbb63ad6f78ca225c9ac855 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 7 May 2025 21:37:31 -0400
Subject: [PATCH 1/8] [lldb]Make `list` command work with headers when
possible.
---
https://github.com/kuilpd ready_for_review
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ilia Kuklin
Date: 2025-05-12T22:59:40+05:00
New Revision: c8a0513a1a694078e5ea927faf8249ce77084d80
URL:
https://github.com/llvm/llvm-project/commit/c8a0513a1a694078e5ea927faf8249ce77084d80
DIFF:
https://github.com/llvm/llvm-project/commit/c8a0513a1a694078e5ea927faf8249ce77084d80.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kuilpd wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/139567
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I too have been contemplating this for a while...
Given that the request handlers currently lock the API mutex and now the event
thread does the same, this patch means that the two are essentially fully
synchronized. That begs the question: Should these be separate threads
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: Jonas Devlieghere
Date: 2025-05-12T11:56:57-07:00
New Revision: 4086d5ff74729e655c3b29479845c35c971541d9
URL:
https://github.com/llvm/llvm-project/commit/4086d5ff74729e655c3b29479845c35c971541d9
DIFF:
https://github.com/llvm/llvm-project/commit/4086d5ff74729e655c3b29479845c35c971541d9.d
ashgti wrote:
I'll take a look at refactoring the `DAP::Loop` and `EventThread`.
https://github.com/llvm/llvm-project/pull/139596
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -272,4 +272,66 @@ Interpreter::Visit(const UnaryOpNode *node) {
m_expr, "invalid ast: unexpected binary operator", node->GetLocation());
}
+llvm::Expected
+Interpreter::Visit(const MemberOfNode *node) {
+ Status error;
+ auto base_or_err = Evaluate(node->GetBase());
ashgti wrote:
The tests are passing for me locally on macOS, but I need to check Linux at
least before this is fully ready for review. I'll let the CI job run and go
from there.
https://github.com/llvm/llvm-project/pull/139669
___
lldb-commits mailin
Author: Ilia Kuklin
Date: 2025-05-12T16:46:58+05:00
New Revision: 3aacd74594b1f8ab04904d277b6a106c98904b29
URL:
https://github.com/llvm/llvm-project/commit/3aacd74594b1f8ab04904d277b6a106c98904b29
DIFF:
https://github.com/llvm/llvm-project/commit/3aacd74594b1f8ab04904d277b6a106c98904b29.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/135843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
da-viper wrote:
LGTM. tiny nit for concrete types
https://github.com/llvm/llvm-project/pull/139502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/139537
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/labath requested changes to this pull request.
This defeats the purpose of storing the sentinel object -- the goal was to
clear it only after performing all the indexing.
I think the ScopedExtractDIEs object needs to be implemented differently. It
uses the RWMutex as a count
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/131304
>From 106e137fea7d4b420ce3d97a8df16c3a91400997 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 14 Mar 2025 02:51:21 -0500
Subject: [PATCH 1/6] Support for XCOFF Sections
---
.../ObjectFile/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The macos and sysv ABIs return functionally equivalent unwind plans, so they
can be implemented in the base AArch64 class. The only difference between them
was that the macos plan provided a "pc=lr" rule where
1 - 100 of 137 matches
Mail list logo
