[Lldb-commits] [lldb] [lldb-dap] Don't emit a removed module event for unseen modules (PR #139324)

2025-05-10 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/8574 Here is the relevant piece of t

[Lldb-commits] [lldb] [lldb-dap] Split lldb-dap into library and tool (NFC) (PR #139402)

2025-05-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/139402 >From b0996a236d9eaf70de562ae2cf0e1900417cae93 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sat, 10 May 2025 12:08:29 -0700 Subject: [PATCH 1/2] [lldb-dap] Split lldb-dap into library and tool (NF

[Lldb-commits] [lldb] [lldb-dap] Split lldb-dap into library and tool (NFC) (PR #139402)

2025-05-10 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Looks good to me, I started something similar to write unit tests for the c++ code a while ago but never made it to a PR. Looks good to start having more direct tests of the c++ parts. https://github.com/llvm/llvm-project/pull/139402 __

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139428)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139428 None >From 4001252c4cd0cc8fedfb1773ef3a53befe2774f6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 25 Mar 2025 00:24:37 -0700 Subject: [PATCH] [lldb] Remove redundant calls to std::unique_ptr::get

[Lldb-commits] [lldb] bae77d5 - [lldb-dap] Skip TestDAP_module_event on Windows

2025-05-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-10T09:36:07-07:00 New Revision: bae77d5b02df562277a335433551e2c53b37917a URL: https://github.com/llvm/llvm-project/commit/bae77d5b02df562277a335433551e2c53b37917a DIFF: https://github.com/llvm/llvm-project/commit/bae77d5b02df562277a335433551e2c53b37917a.d

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139428)

2025-05-10 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/139428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fadd427 - [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (#139428)

2025-05-10 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-10T19:31:35-07:00 New Revision: fadd42b23a63248d57745126a3a30db71b02 URL: https://github.com/llvm/llvm-project/commit/fadd42b23a63248d57745126a3a30db71b02 DIFF: https://github.com/llvm/llvm-project/commit/fadd42b23a63248d57745126a3a30db71b02.diff L

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139428)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139428 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Provide lr value in faulting frame on arm64 (PR #138805)

2025-05-10 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/138805 >From 4fc9acd03a58a3617b113352c48e5dd2fdb58eda Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 6 May 2025 22:37:17 -0700 Subject: [PATCH 01/12] [lldb] Provide lr value in faulting frame on arm64 Wh

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread via lldb-commits
fivemeyestoreserver wrote: This is a well-structured codebase. I appreciate the clean separation of concerns. https://github.com/llvm/llvm-project/pull/139395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139395.diff 2 Files Affected: - (modified) lldb/source/API/SBSaveCoreOptions.cpp (+1-1) - (modified) lldb/source/Plugins/ExpressionParser/Cl

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139395 None Rate limit ยท GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread via lldb-commits
ayestoro wrote: I'm impressed by the modularity of this codebase. Makes it very maintainable. https://github.com/llvm/llvm-project/pull/139395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] cb0f6d0 - [lldb] Simplify string comparisons (NFC) (#139394)

2025-05-10 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-10T10:44:04-07:00 New Revision: cb0f6d002918c6f7f02324638089d9821badcc3b URL: https://github.com/llvm/llvm-project/commit/cb0f6d002918c6f7f02324638089d9821badcc3b DIFF: https://github.com/llvm/llvm-project/commit/cb0f6d002918c6f7f02324638089d9821badcc3b.diff L

[Lldb-commits] [lldb] [lldb-dap] Move registration of requests into DAP (NFC) (PR #139397)

2025-05-10 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/139397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Simplify string comparisons (NFC) (PR #139394)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread Iris Shi via lldb-commits
https://github.com/el-ev approved this pull request. https://github.com/llvm/llvm-project/pull/139395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139395)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d151ad6 - [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (#139395)

2025-05-10 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-10T11:03:09-07:00 New Revision: d151ad650ccbab752f9c10c191dac24593e8198a URL: https://github.com/llvm/llvm-project/commit/d151ad650ccbab752f9c10c191dac24593e8198a DIFF: https://github.com/llvm/llvm-project/commit/d151ad650ccbab752f9c10c191dac24593e8198a.diff L

[Lldb-commits] [lldb] [lldb] Simplify string comparisons (NFC) (PR #139394)

2025-05-10 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139394 None >From ab137cc177482af73941f2b4cf22aef886d500f6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 28 Apr 2025 09:38:32 -0700 Subject: [PATCH] [lldb] Simplify string comparisons (NFC) --- lldb/s

[Lldb-commits] [lldb] [lldb] Simplify string comparisons (NFC) (PR #139394)

2025-05-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139394.diff 3 Files Affected: - (modified) lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp (+1-1) - (modified) lldb/source/Plu

[Lldb-commits] [lldb] [lldb-dap] Move registration of requests into DAP (NFC) (PR #139397)

2025-05-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/139397 Make the registration of request handlers a private implementation detail of the DAP class. >From 019d481c18207b3726af24038804c71d3c4f939e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sat, 10 Ma

[Lldb-commits] [lldb] [lldb-dap] Move registration of requests into DAP (NFC) (PR #139397)

2025-05-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Make the registration of request handlers a private implementation detail of the DAP class. --- Full diff: https://github.com/llvm/llvm-project/pull/139397.diff 3 Files Affected: - (modified) lld

[Lldb-commits] [lldb] [lldb] Simplify string comparisons (NFC) (PR #139394)

2025-05-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/139394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a92de02 - [lldb-dap] Move registration of requests into DAP (NFC) (#139397)

2025-05-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-05-10T11:53:46-07:00 New Revision: a92de02ea3553b7536187f57870b4c1da9b21b2e URL: https://github.com/llvm/llvm-project/commit/a92de02ea3553b7536187f57870b4c1da9b21b2e DIFF: https://github.com/llvm/llvm-project/commit/a92de02ea3553b7536187f57870b4c1da9b21b2e.d

[Lldb-commits] [lldb] [lldb-dap] Move registration of requests into DAP (NFC) (PR #139397)

2025-05-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/139397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Split lldb-dap into library and tool (NFC) (PR #139402)

2025-05-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/139402 Split lldb-dap into a library (lldbDAP) and a tool (lldb-dap). The motivation is being able to link parts of lldb-dap separately, for example to support unit testing and fizzing. >From b0996a236d9eaf70de5

[Lldb-commits] [lldb] [lldb-dap] Split lldb-dap into library and tool (NFC) (PR #139402)

2025-05-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Split lldb-dap into a library (lldbDAP) and a tool (lldb-dap). The motivation is being able to link parts of lldb-dap separately, for example to support unit testing and fizzing. --- Full diff: htt

[Lldb-commits] [lldb] [lldb-dap] Split lldb-dap into library and tool (NFC) (PR #139402)

2025-05-10 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: In part motivated by #139393 https://github.com/llvm/llvm-project/pull/139402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139428)

2025-05-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139428.diff 1 Files Affected: - (modified) lldb/source/Target/RegisterContextUnwind.cpp (+6-6) ``diff diff --git a/lldb/source/Targ