github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
lldb/test/API/commands/frame/var-dil/basics/MemberO
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
Add the arrow and period operators, allowing DIL to find and access member
fields.
---
Patch is 28.98 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/138093.diff
18 Files
real-mikhail wrote:
I assume that there will be no further comments here.
Since this is my first change in LLVM I cannot merge it myself. @jimingham may
I kindly ask you to merge this PR?
https://github.com/llvm/llvm-project/pull/129092
___
lldb-comm
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/138093
Add the arrow and period operators, allowing DIL to find and access member
fields.
>From fe9ac0fa05bb43ea718214746f0ea9b7eefc929a Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Thu, 1 May 2025 00:05:57 -070
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/commands/frame/var-dil/basics/MemberOf/TestFrameVarDILMemberOf
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/138174
None
>From d6f69414e3ac5c1a22f6509149609258ef980c13 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
---
clang/incl
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From b34e9b6c708dfbe097504804a0a85e1169518911 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
---
clang/include/cl
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/137515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Mikhail Zakharov
Date: 2025-05-01T11:10:41-07:00
New Revision: 6aa963f780d63d4c8fa80de97dd79c932bc35f4e
URL:
https://github.com/llvm/llvm-project/commit/6aa963f780d63d4c8fa80de97dd79c932bc35f4e
DIFF:
https://github.com/llvm/llvm-project/commit/6aa963f780d63d4c8fa80de97dd79c932bc35f4e.di
github-actions[bot] wrote:
@real-mikhail Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a b
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/129092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Done. Thanks for working on this.
https://github.com/llvm/llvm-project/pull/129092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham requested changes to this pull request.
Sorry for more round trips, but can you remove the no-SBError overload. Adding
that was really a poor choice on my part (which I seem to want to repeat for
some reason...)
https://github.com/llvm/llvm-project/pull/137904
___
@@ -105,6 +105,10 @@ class LLDB_API SBThreadPlan {
SBThreadPlan QueueThreadPlanForStepOut(uint32_t frame_idx_to_step_to,
bool first_insn, SBError &error);
+ SBThreadPlan QueueThreadPlanForStepSingleInstruction(bool step_over);
--
AaronBallman wrote:
> > Perhaps silly initial question: why do we need a whole different qualifier
> > for this? Why can you not write `__ptrauth uintptr_t foo`?
>
> Not a silly question, back when first implemented we spent time thinking
> about this.
>
> The concern was basically `T* __ptra
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/138111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,102 @@
+# REQUIRES: x86, lld
+
+# RUN: split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux %t/file.s -o %t/file.o
+# RUN: ld.lld %t/file.o -o %t/file.out -T %t/file.lds
+# RUN: %lldb %t/file.out -o "disassemble --name func1" -o exit | FileCheck %s
+
+
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/138116
None
>From 437c69ffb1f86733649a82aa2a991360dd40fd7c Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 29 Apr 2025 18:19:18 +0100
Subject: [PATCH 1/4] [lldb][lldb-dap] Migrate 'Scopes' to structured types.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
---
Patch is 27.92 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/138116.diff
14 Files Affected:
- (modified) lldb/tools/lldb-dap/DAP.cpp (+1-14)
- (modified)
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
if (!abi.empty())
response.Printf("elf_abi:%s;", abi.c_str());
response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+std::optional non_resumable = proc_info.IsNonResumable();
+if (n
Author: David Spickett
Date: 2025-05-01T16:40:47+01:00
New Revision: 09488bcfba77d1a16b0b83c2d6b1135e5e7d5302
URL:
https://github.com/llvm/llvm-project/commit/09488bcfba77d1a16b0b83c2d6b1135e5e7d5302
DIFF:
https://github.com/llvm/llvm-project/commit/09488bcfba77d1a16b0b83c2d6b1135e5e7d5302.diff
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
if (!abi.empty())
response.Printf("elf_abi:%s;", abi.c_str());
response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+std::optional non_resumable = proc_info.IsNonResumable();
+if (n
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/138111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/138111
Something to do with control code handling in Windows terminals breaks the
statusline in various ways. It makes LLDB unusable and even if you set the
setting to disable statusline, it's too late, and the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Something to do with control code handling in Windows terminals breaks the
statusline in various ways. It makes LLDB unusable and even if you set the
setting to disable statusline, it's too late, and
DavidSpickett wrote:
Tests are pexpect so they're not running on Windows anyway.
https://github.com/llvm/llvm-project/pull/138111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/137668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kusmour wrote:
> Also, the configuration done event can be emitted at any time during
> initialization. It could even be emitted before the actual launching and
> attaching happen.
No, this is something we can control. `configurationDone` request will only
emit after `initialized` event. And
ashgti wrote:
> Technically the response of launch/attach should be the end of the chain.
Thats not how its implemented in VS Code at least:
* `initialize` is sent then `launch` or `attach`
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/debugService.ts#L
https://github.com/kuilpd ready_for_review
https://github.com/llvm/llvm-project/pull/137688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
`ValueObject::AddressOf()` used to return address as a value which has it's own
address, allowing to do `value.AddressOf().AddressOf()`.
This patch makes the return address a simple const value.
---
Full diff:
https://github.com/ashgti approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/137920
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
-
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138169
>From ef04502d17c36044cd5fb96f333c328c8215f354 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 10:11:10 -0700
Subject: [PATCH 1/2] Add new API to expose the expected size in bytes of a
core b
@@ -119,6 +119,19 @@ class LLDB_API SBSaveCoreOptions {
/// an empty collection will be returned.
SBThreadCollection GetThreadsToSave() const;
+ /// Get the current total number of bytes the core is expected to be but not
+ /// including the overhead of the core file f
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/python_api/sbsavecoreoptions/TestSBSaveCoreOptions.py
walter-erquinigo wrote:
Just throwing out some ideas that might simplify this.
Is it possible to do the launching and attaching in asynchronous mode so that
the stop events are always emitted?
Also, the configuration done event can be emitted at any time during
initialization. It could even b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
My current internal work requires some sensitivity to IO usage. I had a work
around to calculate the expected size of a Minidump, but I've added this PR so
an automated system could look at the expected size
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/138169
My current internal work requires some sensitivity to IO usage. I had a work
around to calculate the expected size of a Minidump, but I've added this PR so
an automated system could look at the expected size of
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/138169
>From ef04502d17c36044cd5fb96f333c328c8215f354 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 1 May 2025 10:11:10 -0700
Subject: [PATCH 1/3] Add new API to expose the expected size in bytes of a
core b
https://github.com/DavidSpickett commented:
> Currently we're creating inheritable (~FD_CLOEXEC) file descriptors in the
> (few) cases where we need to pass an FD to a subprocess. The problem with
> these is that, in a multithreaded application such as lldb, there's
> essentially no way to pre
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/126935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -87,3 +89,41 @@ TEST(Host, LaunchProcessSetsArgv0) {
ASSERT_THAT_ERROR(Host::LaunchProcess(info).takeError(), Succeeded());
ASSERT_THAT(exit_status.get_future().get(), 0);
}
+
+#ifdef LLVM_ON_UNIX
+TEST(Host, LaunchProcessDuplicatesHandle) {
+ static constexpr llvm::Str
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
+
https://github.com/DrSergei created
https://github.com/llvm/llvm-project/pull/138160
Added `runInTerminal` support for Windows based on Windows Named Pipes. Adapted
existed `FifoFile` class to Windows client-server pipes model. When server side
owns the assosieted filesystem handle and client
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (DrSergei)
Changes
Added `runInTerminal` support for Windows based on Windows Named Pipes. Adapted
existed `FifoFile` class to Windows client-server pipes model. When server side
owns the assosieted filesystem handle and client side o
DavidSpickett wrote:
> This is pretty complicated to test because it requires integration with the
> Kernel
Can you make the same thing happen without using a coredumper? I feel like the
answer is a solid no but I'm not sure why.
Another way we can do it is to write a test that checks that if
@@ -1676,7 +1681,11 @@ GDBRemoteCommunication::PacketResult
GDBRemoteCommunicationServerLLGS::Handle_vCont_actions(
StringExtractorGDBRemote &packet) {
StreamString response;
- response.Printf("vCont;c;C;s;S;t");
+ if (m_current_process && m_current_process->CanResume()
@@ -105,6 +105,10 @@ class LLDB_API SBThreadPlan {
SBThreadPlan QueueThreadPlanForStepOut(uint32_t frame_idx_to_step_to,
bool first_insn, SBError &error);
+ SBThreadPlan QueueThreadPlanForStepSingleInstruction(bool step_over);
--
@@ -1304,6 +1304,9 @@ void GDBRemoteCommunicationServerCommon::
if (!abi.empty())
response.Printf("elf_abi:%s;", abi.c_str());
response.Printf("ptrsize:%d;", proc_arch.GetAddressByteSize());
+std::optional non_resumable = proc_info.IsNonResumable();
+if (n
kusmour wrote:
> > Technically the response of launch/attach should be the end of the chain.
>
> Thats not how its implemented in VS Code at least:
>
> * `initialize` is sent then `launch` or `attach`
> https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/debug/browser/debugS
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/7] [lldb] Expose language plugin commands based based on
langua
@@ -1018,6 +1018,26 @@ CommandInterpreter::VerifyUserMultiwordCmdPath(Args
&path, bool leaf_is_command,
return cur_as_multi;
}
+CommandObjectSP CommandInterpreter::GetFrameLanguageCommand() const {
+ if (auto frame_sp = GetExecutionContext().GetFrameSP()) {
+auto frame
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/6] [lldb] Expose language plugin commands based based on
langua
Author: Kazu Hirata
Date: 2025-05-01T12:27:08-07:00
New Revision: 2bff80f25d51e24d3c552e033a2863dd36ef648b
URL:
https://github.com/llvm/llvm-project/commit/2bff80f25d51e24d3c552e033a2863dd36ef648b
DIFF:
https://github.com/llvm/llvm-project/commit/2bff80f25d51e24d3c552e033a2863dd36ef648b.diff
L
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
>From 94caf0b58ace58ae5159e3819f776ad6b2988329 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 22 Apr 2025 13:58:25 -0700
Subject: [PATCH 1/7] [lldb] Expose language plugin commands based based on
langua
JDevlieghere wrote:
> Is it possible to do the launching and attaching in asynchronous mode so that
> the stop events are always emitted?
Yes, that's the alternative I mentioned the PR description:
> An alternative approach could be to stop trying to hide the initial stop
> event, and instea
kazutakahirata wrote:
@real-mikhail @jimingham I've landed 2bff80f25d51e24d3c552e033a2863dd36ef648b
to fix a warning from this PR. Thanks!
https://github.com/llvm/llvm-project/pull/129092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/commands/command/language/TestFrameLanguageCommands.py
lldb/t
Author: David Spickett
Date: 2025-05-01T09:30:33Z
New Revision: 47424df2d5c6cc5a2b2d49a8cad438d8e75fec61
URL:
https://github.com/llvm/llvm-project/commit/47424df2d5c6cc5a2b2d49a8cad438d8e75fec61
DIFF:
https://github.com/llvm/llvm-project/commit/47424df2d5c6cc5a2b2d49a8cad438d8e75fec61.diff
LOG
Author: David Spickett
Date: 2025-05-01T10:01:14Z
New Revision: 2dbab4ca8ddb218af555d8d1fd86b72612387582
URL:
https://github.com/llvm/llvm-project/commit/2dbab4ca8ddb218af555d8d1fd86b72612387582
DIFF:
https://github.com/llvm/llvm-project/commit/2dbab4ca8ddb218af555d8d1fd86b72612387582.diff
LOG
@@ -283,39 +283,42 @@ uint32_t Block::GetRangeIndexContainingAddress(const
Address &addr) {
return m_ranges.FindEntryIndexThatContains(file_addr - func_file_addr);
}
+static AddressRange ToAddressRange(const Address &func_addr,
+ const Bloc
ashgti wrote:
To clarify the DAP flow a little, see 'Launch Sequencing' in
https://microsoft.github.io/debug-adapter-protocol/overview
Once the DAP server send the response to the `initialize` request the following
happen in parallel:
* The `initialized` event triggers the client sending `set
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/137410
>From 8a5e25a6e850222fcbb94f685d46895d2666041f Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 25 Apr 2025 15:35:12 -0700
Subject: [PATCH 1/4] Make stop-hooks fire when lldb first gains control of a
proc
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/136766
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
kastiglione wrote:
I've updated the implementation to not resolve to a language specific command
whenever the entered command prefix matches a top level command.
In other words, given a python command `abcdef` and a language specific command
`abc`, then running `abc` will resolve to the python
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/138174
>From de1b49fc6b8819b591e48b81634567ceeffe5089 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Apr 2025 23:47:37 -0700
Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy
Add `llvm::uninitiali
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/138160
>From 95b85c773ec662ab47420d5c820c84dd18c63d89 Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Thu, 1 May 2025 18:46:22 +0300
Subject: [PATCH] [lldb-dap] Add runInTerminal support for Windows
---
.../run
kastiglione wrote:
I have not implemented the mentioned idea of using the top frame that has a
known language. I think that situation would be rare, and makes this more
magic. I think it's better to wait for feedback then to add implement something
that users may not need/want.
https://github
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
>From b901b71abbaac768e67913cdbc15da2337c8bb03 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 30 Apr 2025 02:00:44 +0200
Subject: [PATCH 1/4] Expose QueueThreadPlanForStepSingleInstruction function
to SBT
eronnen wrote:
Removed the version without `SBError`, but I'm not sure what to do with it in
the python test because this function is not called in the test body, so we
can't assert it
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits
eronnen wrote:
Also note that all the other `QueueThreadPlanFor*` functions still have a
version without SBError :/
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
jimingham wrote:
> Also note that all the other `QueueThreadPlanFor*` functions still have a
> version without SBError :/
Yes, we don't remove API's from the SB API set, which means we do get left with
our mistakes.
https://github.com/llvm/llvm-project/pull/137904
https://github.com/jimingham approved this pull request.
LEBTM
https://github.com/llvm/llvm-project/pull/137904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
Sounds good, I can close this PR then and add the shell tests back in once the
PR for the client-side emitters are up.
https://github.com/llvm/llvm-project/pull/138030
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/137904
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-s
DrSergei wrote:
> There's an existing PR that adds this functionality as well: #121269 with
> quite a bit of discussion. Does this PR have anything that's lacking in the
> other PR?
It's quite similar. I use slightly different functionalites, but main idea is
the same. Another PR looks abando
@@ -154,6 +154,20 @@ endif()
add_definitions(-DLLDB_USE_OS_LOG)
+if(NOT CMAKE_OSX_SYSROOT)
+ execute_process(COMMAND xcodebuild -version -sdk macosx Path
+OUTPUT_VARIABLE SDKROOT
+ERROR_QUIET
+OUTPUT_STRIP_TRAILING_WHITESPACE)
+
+ if(NOT EXISTS ${SDKROOT})
+
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = {
"${target.file.fullpath}",
"${var.dummy-var-to-test-wildcard}"};
-TEST(FormatEntity, LookupAllEntriesInTree) {
+TEST_F(FormatEntityTest, LookupAllEntriesInTree) {
for (const llvm::StringRef testStri
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DrSergei wrote:
Just a question, as far as I see, there is no `Static` scope and static
variables are included in the `Global` scope. This may not be optimal for large
projects with a large number of global variables (for example, global variables
provided by libraries). Basically, there are n
@@ -155,6 +155,9 @@ class SourceManager {
~SourceManager();
FileSP GetLastFile() { return GetFile(m_last_support_file_sp); }
+ bool AsLastLine(bool reverse) {
JDevlieghere wrote:
Is this a typo?
```suggestion
bool AtLastLine(bool reverse) {
```
https:
JDevlieghere wrote:
There's an existing PR that adds this functionality as well:
https://github.com/llvm/llvm-project/pull/121269 with quite a bit of
discussion. Does this PR have anything that's lacking in the other PR?
https://github.com/llvm/llvm-project/pull/138160
JDevlieghere wrote:
> > After the response to `configurationDone` is sent, the debug adapter may
> > respond to the `launch` or `attach` request, and then the debug session has
> > started.
>
> Technically the response of launch/attach should be the end of the chain. But
> because of the sing
ojhunt wrote:
> I realize you've got downstream users making use of this additional
> qualifier. Can you mention how prevalent the use is?
it's used a bunch in libcxx, libcxxabi, libunwind, compiler-rt and a few other
places. We can obviously use a macro to wrap this, but we need to have a wa
@@ -153,10 +173,37 @@ constexpr llvm::StringRef lookupStrings[] = {
"${target.file.fullpath}",
"${var.dummy-var-to-test-wildcard}"};
-TEST(FormatEntity, LookupAllEntriesInTree) {
+TEST_F(FormatEntityTest, LookupAllEntriesInTree) {
for (const llvm::StringRef testStri
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/137751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138020
>From 350648f15e834a3734ab9fcafb610d27d9c6dd33 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 28 Apr 2025 10:28:03 -0700
Subject: [PATCH] [lldb][cmake] Error out when building debugserver with
Author: jimingham
Date: 2025-05-01T13:46:19-07:00
New Revision: 4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87
URL:
https://github.com/llvm/llvm-project/commit/4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87
DIFF:
https://github.com/llvm/llvm-project/commit/4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/137410
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/138206
Custom regions in Process::GetUserSpecifiedCoreFileSaveRanges originally used
entry that contains. This made sense on my first attempt, but what we really
want are *intersecting* regions. This is so the user ca
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Custom regions in Process::GetUserSpecifiedCoreFileSaveRanges originally used
entry that contains. This made sense on my first attempt, but what we really
want are *intersecting* regions. This is so the user
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCore
96 matches
Mail list logo
