yuvald-sweet-security wrote:
> FYI, I reverted this because of problems test failures on mac:
> https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/24395/testReport/junit/lldb-api/commands_target_auto-install-main-executable/TestAutoInstallMainExecutable_py/
>
> I'm not quite su
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN)
set(bolt_doxygen_qhp_cust_filter_attrs "")
endif()
- option(LLVM_DOXYGEN_SVG
Ericson2314 wrote:
(Not to us in Nixpkgs at least!) Though I doubt downstream distros are the
people who want to build the API doc
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/134563
>From f7e2bf51c51de0f38a59c741dd7f75b806cbbe9e Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 22 Apr 2025 19:37:05 -0700
Subject: [PATCH] Add symbol locator time for each module in statistics
---
lld
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From c86c50e6914b017a25a1ba29bbc47ea46f5dfaf2 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:22:27 +0100
Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled
n
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
@emaxx-google thanks for the reproducer.
I will be off to C++Now soon, so it's unlikely I will have time to take a look
at
that in the next two weeks, sorry about that.
https://github.com/llvm/llvm-project/pull/132401
___
lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/132783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Robert O'Callahan
Date: 2025-04-23T16:16:30-07:00
New Revision: 239718055d7260caa3e6631e82d68ac27e01c1f4
URL:
https://github.com/llvm/llvm-project/commit/239718055d7260caa3e6631e82d68ac27e01c1f4
DIFF:
https://github.com/llvm/llvm-project/commit/239718055d7260caa3e6631e82d68ac27e01c1f4.d
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/137071
Migrates the 'stepIn' request handler to have well structured types instead of
raw json values.
I also noticed in the 'next' request handler we were not passing the 'RunMode'
flag. Updated the 'next' request ha
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/136766
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
I didn't realize lldb-dap was handing the process output separately. In that
case, this LGTM. Apologies for the confusion!
https://github.com/llvm/llvm-project/pull/137002
___
lldb-commits m
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/136785
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-04-23T11:03:40-07:00
New Revision: 213424b94792d730510a12046abfc05e0262c985
URL:
https://github.com/llvm/llvm-project/commit/213424b94792d730510a12046abfc05e0262c985
DIFF:
https://github.com/llvm/llvm-project/commit/213424b94792d730510a12046abfc05e0262c985.d
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/134563
>From d40024584089f5342407c3b5e5d78ff1bde0f765 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 22 Apr 2025 19:37:05 -0700
Subject: [PATCH] Add symbol locator time for each module in statistics
---
lld
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Apr 2025 13:22:27 +0100
Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled
n
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/137113
The debug adapter protocol supports an option to provide formatting information
for a stack frames as part of the StackTrace request. lldb-dap incorrectly
advertises it supports this, but until this PR tha
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The debug adapter protocol supports an option to provide formatting information
for a stack frames as part of the StackTrace request. lldb-dap incorrectly
advertises it supports this, but until this
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/137092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,81 @@
+"""Test that all of the GPR registers are read correctly from a riscv32
corefile."""
+
+import os
+import re
+import subprocess
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/137092
>From 0a1b1c19bfd4102fe58a04736efed22c6de4fd0d Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 23 Apr 2025 17:05:43 -0700
Subject: [PATCH 1/2] [lldb][MachO] MachO corefile support for riscv32 binari
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/137092
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -42,10 +43,19 @@ SourceRequestHandler::Run(const protocol::SourceArguments
&args) const {
if (!frame.IsValid())
return llvm::make_error("source not found");
- lldb::SBInstructionList insts =
frame.GetSymbol().GetInstructions(dap.target);
lldb::SBStream stream;
@@ -783,6 +783,16 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
// Line numbers are 1-based.
object.try_emplace("line", inst_line + 1);
object.try_emplace("column", 1);
+ } else {
+// No valid line entry or symbol
JDevlieghere wro
@@ -783,6 +783,16 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame,
// Line numbers are 1-based.
object.try_emplace("line", inst_line + 1);
object.try_emplace("column", 1);
+ } else {
+// No valid line entry or symbol
+llvm::json::Object source;
+
https://github.com/JDevlieghere approved this pull request.
Nice test. LGTM!
https://github.com/llvm/llvm-project/pull/136777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/136777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/136777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,81 @@
+"""Test that all of the GPR registers are read correctly from a riscv32
corefile."""
+
+import os
+import re
+import subprocess
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
@@ -0,0 +1,81 @@
+"""Test that all of the GPR registers are read correctly from a riscv32
corefile."""
+
+import os
+import re
+import subprocess
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/137026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: John Harrison
Date: 2025-04-23T11:02:33-07:00
New Revision: 3b48e2a7508ab090b1b7c6a68f87e3eddad5473d
URL:
https://github.com/llvm/llvm-project/commit/3b48e2a7508ab090b1b7c6a68f87e3eddad5473d
DIFF:
https://github.com/llvm/llvm-project/commit/3b48e2a7508ab090b1b7c6a68f87e3eddad5473d.diff
da-viper wrote:
I think that may not apply to LLDB-dap.
Since dap uses the SBAPI it sends the debugee output to the client here.
https://github.com/llvm/llvm-project/blob/1b6cbaa7b64f54b127d139d653468e213bae007e/lldb/tools/lldb-dap/EventHelper.cpp#L205-L215
https://github.com/llvm/llvm-proj
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
---
Patch is 30.04 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/115408.diff
10 Files Affected:
- (modified) lldb/source/Plugins/Process/Utility/CMa
@@ -395,8 +395,8 @@
lldb_private::formatters::NSSetISyntheticFrontEnd::GetIndexOfChildWithName(
(idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors()))
return llvm::createStringError(
"'SyntheticChildrenFrontEnd::NSSetISyntheticFrontEnd' cannot fin
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef
&format_str,
return parent;
}
+/// Parses a single highlighting format specifier.
+///
+/// Example syntax for such specifier:
+/// \code
+/// ${function.name-with-args:%highlight_basename(ansi.
Michael137 wrote:
Will give others some time to look over
Any preference on how to land this? Would be nice to keep the commits separate
and not get them squashed. Perhaps push them to HEAD without the github UI but
mention the PR in each commit message?
https://github.com/llvm/llvm-project/p
@@ -37,6 +37,16 @@ void OptionValueEnumeration::DumpValue(const
ExecutionContext *exe_ctx,
}
}
+llvm::json::Value
+OptionValueEnumeration::ToJSON(const ExecutionContext *exe_ctx) {
+ for (const auto &enums : m_enumerations) {
+if (enums.value.value == m_current_value)
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/137007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/137007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-04-23T15:21:34-07:00
New Revision: dd17cf4480fc55c38813769a46fb2807397d8f72
URL:
https://github.com/llvm/llvm-project/commit/dd17cf4480fc55c38813769a46fb2807397d8f72
DIFF:
https://github.com/llvm/llvm-project/commit/dd17cf4480fc55c38813769a46fb2807397d8f72.diff
LOG:
@@ -0,0 +1,185 @@
+//===-- RegisterInfos_riscv32.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -8,72 +8,37 @@
#include "DAP.h"
#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "Protocol/ProtocolTypes.h"
#include "RequestHandler.h"
+#include "llvm/Support/Error.h"
+
+using namespace llvm;
+using namespace lldb_dap::protocol;
namespace lldb_dap {
-// "N
@@ -37,6 +37,18 @@ void OptionValueEnumeration::DumpValue(const
ExecutionContext *exe_ctx,
}
}
+llvm::json::Value
+OptionValueEnumeration::ToJSON(const ExecutionContext *exe_ctx) {
+ const size_t count = m_enumerations.GetSize();
+ for (size_t i = 0; i < count; ++i) {
+
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object
&arguments) {
return envs;
}
+std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) {
+ lldb::SBStructuredData result =
+ debugger.GetSetting("stop-disassembly-display");
+ const si
@@ -202,6 +202,10 @@ struct DAP {
lldb::SBFormat frame_format;
lldb::SBFormat thread_format;
+
+ /// The value of stop-disassembly-display setting in LLDB.
+ std::string stop_disassembly_display;
JDevlieghere wrote:
I'm wondering if we should be caching
ashgti wrote:
I updated my branch with main and updated the launch handler to return an
`llvm::Error` to simplify the body.
https://github.com/llvm/llvm-project/pull/133624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/132783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/115408
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/137075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/137075
In some core file, we are seeing that it's not always the case that the ELF
header would exist in the first region in NT_FILES section. Therefore the
FindModuleUUID is not able to find the module UUID by j
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object
&arguments) {
return envs;
}
+std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) {
+ lldb::SBStructuredData result =
+ debugger.GetSetting("stop-disassembly-display");
+ const si
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/136494
>From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 20 Apr 2025 17:07:09 +0200
Subject: [PATCH 1/5] fallback to assembly when source code is not available
---
ll
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
-
+ Log *log = GetLog(LLDBLog::Platform);
labath wrote:
> @labath @jimingham This is just one way to allow C/C++ to dereference arrays
> and let other languages decide on which types they allow to dereference. I
> tried making a `GetDereferencedType` function in TypeSystem, but it doesn't
> really need to do anything right now, everyt
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/135008
>From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Wed, 9 Apr 2025 14:35:09 +0100
Subject: [PATCH 1/7] [lldb][lldb-dap] fix repeating commands in repl mode
Fixes #1
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object
&arguments) {
return envs;
}
+std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) {
+ std::string stop_disassembly_display = "no-debuginfo"; // default value
+ lldb::SBCommandReturnObj
DavidSpickett wrote:
Jonas is added as he's listed as the code owner for this area, but does not
necessarily review all PRs.
In general, you only need one approval -
https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted
Unless you happen to know or suspect others would want to co
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/136843
Despite our attempt (build-docs.sh)
to build the documentation with SVG,
it still uses PNG https://llvm.org/doxygen/classllvm_1_1StringRef.html,
and that renders terribly on any high dpi display.
SVG leads to
https://github.com/JDevlieghere requested changes to this pull request.
I don't believe this is correct. LLDB has a notion of an output and error
stream, which combines the output from the debuggee, and output from the
debugger. Since we can't detangle the two, I think the current implementatio
Author: John Harrison
Date: 2025-04-23T10:18:31-07:00
New Revision: 1041d54bd4f693c1ac03077680ece67e03c99e22
URL:
https://github.com/llvm/llvm-project/commit/1041d54bd4f693c1ac03077680ece67e03c99e22
DIFF:
https://github.com/llvm/llvm-project/commit/1041d54bd4f693c1ac03077680ece67e03c99e22.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/136642
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mstorsjo wrote:
> Closing this since Docker on macOS simply disabled SME, SVE, etc. I believe
> this is still an issue in theory for users with Linux installed directly on
> M4 hardware but if such a user exists I haven't heard of them.
Wouldn't this still be an issue if running virtualized Li
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/137002
Based on the DAP specification.
The output categories stdout and stderr should only be used for the debuggee's
stdout and stderr.
```jsonc
/**
* The output category. If not specified or if the category i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
Based on the DAP specification.
The output categories stdout and stderr should only be used for the debuggee's
stdout and stderr.
```jsonc
/**
* The output category. If not specified or if the category
Author: Michael Buch
Date: 2025-04-23T16:27:23+01:00
New Revision: 96519028d514853d429c2d09482ba0bd9a899c57
URL:
https://github.com/llvm/llvm-project/commit/96519028d514853d429c2d09482ba0bd9a899c57
DIFF:
https://github.com/llvm/llvm-project/commit/96519028d514853d429c2d09482ba0bd9a899c57.diff
@@ -14,6 +14,7 @@
#include "llvm/Support/Format.h"
#include "llvm/Support/FormatProviders.h"
#include "llvm/Support/FormatVariadicDetails.h"
+#include
charles-zablit wrote:
Fixed, thanks!
https://github.com/llvm/llvm-project/pull/136693
_
@@ -456,9 +464,13 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
-? StringLayout::DSC
-: StringLayout::CSD;
+ auto index_or_
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public
SyntheticChildrenFrontEnd {
GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib);
- size_t GetIndexOfChildWithName(ConstString name) override {
+ llvm::Expected GetIndexOfChildWithName(ConstString name) override
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,26 @@
+//===-- Support.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -7,17 +7,139 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
@@ -7,17 +7,139 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
@@ -7,17 +7,139 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
@@ -67,7 +67,9 @@ TypeFilterImpl::FrontEnd::GetIndexOfChildWithName(ConstString
name) {
}
}
}
- return UINT32_MAX;
+ return llvm::createStringError(
+ "'SyntheticChildrenFrontEnd::FrontEnd' cannot find index of child '%s'",
adrian-prantl wro
real-mikhail wrote:
Oh, sorry about unnecessary ping then and thanks for clarification and the link!
Yes, I cannot merge changes myself since this is my first PR.
https://github.com/llvm/llvm-project/pull/129092
___
lldb-commits mailing list
lldb-commi
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
@@ -113,6 +113,14 @@ TEST(ArchSpecTest, TestSetTriple) {
.consume_front("powerpc-apple-darwin"));
EXPECT_EQ(ArchSpec::eCore_ppc_ppc970, AS.GetCore());
+ AS = ArchSpec();
+ EXPECT_TRUE(AS.SetTriple("24-0-apple-unknown"));
+ EXPECT_EQ(uint32_t(llvm::MachO:
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN)
set(bolt_doxygen_qhp_cust_filter_attrs "")
endif()
- option(LLVM_DOXYGEN_SVG
AaronBallman wrote:
Will removing the option be disruptive (particularly to downstreams)? Do we
need a deprecation period before w
@@ -113,6 +113,14 @@ TEST(ArchSpecTest, TestSetTriple) {
.consume_front("powerpc-apple-darwin"));
EXPECT_EQ(ArchSpec::eCore_ppc_ppc970, AS.GetCore());
+ AS = ArchSpec();
+ EXPECT_TRUE(AS.SetTriple("24-0-apple-unknown"));
+ EXPECT_EQ(uint32_t(llvm::MachO:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/include/lldb/Symbol/DWARFCallFrameInfo.h
lldb
@@ -131,25 +138,19 @@ UnwindTable::GetFuncUnwindersContainingAddress(const
Address &addr,
// There is an UnwindTable per object file, so we can safely use file handles
addr_t file_addr = addr.GetFileAddress();
- iterator end = m_unwinds.end();
- iterator insert_pos = en
@@ -131,25 +138,19 @@ UnwindTable::GetFuncUnwindersContainingAddress(const
Address &addr,
// There is an UnwindTable per object file, so we can safely use file handles
addr_t file_addr = addr.GetFileAddress();
- iterator end = m_unwinds.end();
- iterator insert_pos = en
@@ -1345,9 +1343,9 @@ RegisterContextUnwind::SavedLocationForRegister(
// value instead of the Return Address register.
// If $pc is not available, fall back to the RA reg.
UnwindPlan::Row::AbstractRegisterLocation scratch;
-if (m_frame_type == e
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/137006
>From afea97e6d1613ef0247d021079f9463ec189c388 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 23 Apr 2025 17:17:45 +0200
Subject: [PATCH 1/2] [lldb] Parse DWARF CFI for discontinuous functions
This patch
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
We should also have a test for this. A unit test for the new function should be
easy enough. I'm not going to insist on a test for the whole "lldb-server
platform" flow, but I would recommend it, as that's the only way to ensure this
does not break again.
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Despite our attempt (build-docs.sh)
to build the documentation with SVG,
it still uses PNG https://llvm.org/doxygen/classllvm_1_1StringRef.html,
and that renders terribly on any high dpi display.
SVG leads to s
https://github.com/HemangGadhavi updated
https://github.com/llvm/llvm-project/pull/134354
>From e7b3d8d95477f96b4c1b1a2bbec5cce49f4c15cd Mon Sep 17 00:00:00 2001
From: HemangGadhavi
Date: Fri, 4 Apr 2025 00:59:17 -0500
Subject: [PATCH 1/6] [lldb][AIX] get host info for AIX
---
lldb/source/Hos
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
@@ -113,6 +113,14 @@ TEST(ArchSpecTest, TestSetTriple) {
.consume_front("powerpc-apple-darwin"));
EXPECT_EQ(ArchSpec::eCore_ppc_ppc970, AS.GetCore());
+ AS = ArchSpec();
+ EXPECT_TRUE(AS.SetTriple("24-0-apple-unknown"));
+ EXPECT_EQ(uint32_t(llvm::MachO:
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
@@ -353,6 +353,8 @@ static const ArchDefinitionEntry g_macho_arch_entries[] = {
{ArchSpec::eCore_x86_64_x86_64, llvm::MachO::CPU_TYPE_X86_64,
llvm::MachO::CPU_SUBTYPE_X86_ARCH1, UINT32_MAX, SUBTYPE_MASK},
{ArchSpec::eCore_x86_64_x86_64h, llvm::MachO::CPU_TYPE
labath wrote:
> > which (according to the paragraph you quote) means that the function's
> > entry point is 0x1cfb0, which is not the lowest address in the function.
>
> I managed to nitpick the text but then go on to assume the ranges would be
> sorted with start address increasing. Bad idea.
1 - 100 of 200 matches
Mail list logo
