[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-23 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: > FYI, I reverted this because of problems test failures on mac: > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/24395/testReport/junit/lldb-api/commands_target_auto-install-main-executable/TestAutoInstallMainExecutable_py/ > > I'm not quite su

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [openmp] [polly] [Documentation] Always use SVG for dot-generated doxygen images. (PR #136843)

2025-04-23 Thread John Ericson via lldb-commits
@@ -48,14 +48,6 @@ if (LLVM_ENABLE_DOXYGEN) set(bolt_doxygen_qhp_cust_filter_attrs "") endif() - option(LLVM_DOXYGEN_SVG Ericson2314 wrote: (Not to us in Nixpkgs at least!) Though I doubt downstream distros are the people who want to build the API doc

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

2025-04-23 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From f7e2bf51c51de0f38a59c741dd7f75b806cbbe9e Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 22 Apr 2025 19:37:05 -0700 Subject: [PATCH] Add symbol locator time for each module in statistics --- lld

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From c86c50e6914b017a25a1ba29bbc47ea46f5dfaf2 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-23 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: @emaxx-google thanks for the reproducer. I will be off to C++Now soon, so it's unlikely I will have time to take a look at that in the next two weeks, sorry about that. https://github.com/llvm/llvm-project/pull/132401 ___ lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2397180 - [lldb] Implement CLI support for reverse-continue (#132783)

2025-04-23 Thread via lldb-commits
Author: Robert O'Callahan Date: 2025-04-23T16:16:30-07:00 New Revision: 239718055d7260caa3e6631e82d68ac27e01c1f4 URL: https://github.com/llvm/llvm-project/commit/239718055d7260caa3e6631e82d68ac27e01c1f4 DIFF: https://github.com/llvm/llvm-project/commit/239718055d7260caa3e6631e82d68ac27e01c1f4.d

[Lldb-commits] [lldb] [lldb-dap] Migrate 'stepIn' request to well structured types. (PR #137071)

2025-04-23 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/137071 Migrates the 'stepIn' request handler to have well structured types instead of raw json values. I also noticed in the 'next' request handler we were not passing the 'RunMode' flag. Updated the 'next' request ha

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (PR #137002)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. I didn't realize lldb-dap was handing the process output separately. In that case, this LGTM. Apologies for the confusion! https://github.com/llvm/llvm-project/pull/137002 ___ lldb-commits m

[Lldb-commits] [lldb] [llvm] Add RISC-V CPU type and CPU subtype to llvm & lldb (PR #136785)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 213424b - Add MachO RISC-V CPU type and CPU subtype to llvm & lldb (#136785)

2025-04-23 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-23T11:03:40-07:00 New Revision: 213424b94792d730510a12046abfc05e0262c985 URL: https://github.com/llvm/llvm-project/commit/213424b94792d730510a12046abfc05e0262c985 DIFF: https://github.com/llvm/llvm-project/commit/213424b94792d730510a12046abfc05e0262c985.d

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

2025-04-23 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From d40024584089f5342407c3b5e5d78ff1bde0f765 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 22 Apr 2025 19:37:05 -0700 Subject: [PATCH] Add symbol locator time for each module in statistics --- lld

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/131836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From b3e1aa9ff4817af23d99a8b0b668c62149524181 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 7 Apr 2025 13:22:27 +0100 Subject: [PATCH 1/5] [lldb] Implement TrackingOutputBuffer to track demangled n

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/137113 The debug adapter protocol supports an option to provide formatting information for a stack frames as part of the StackTrace request. lldb-dap incorrectly advertises it supports this, but until this PR tha

[Lldb-commits] [lldb] [lldb-dap] Support StackFrameFormat (PR #137113)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The debug adapter protocol supports an option to provide formatting information for a stack frames as part of the StackTrace request. lldb-dap incorrectly advertises it supports this, but until this

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/137092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,81 @@ +"""Test that all of the GPR registers are read correctly from a riscv32 corefile.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/137092 >From 0a1b1c19bfd4102fe58a04736efed22c6de4fd0d Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 23 Apr 2025 17:05:43 -0700 Subject: [PATCH 1/2] [lldb][MachO] MachO corefile support for riscv32 binari

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -42,10 +43,19 @@ SourceRequestHandler::Run(const protocol::SourceArguments &args) const { if (!frame.IsValid()) return llvm::make_error("source not found"); - lldb::SBInstructionList insts = frame.GetSymbol().GetInstructions(dap.target); lldb::SBStream stream;

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -783,6 +783,16 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame, // Line numbers are 1-based. object.try_emplace("line", inst_line + 1); object.try_emplace("column", 1); + } else { +// No valid line entry or symbol JDevlieghere wro

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -783,6 +783,16 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame, // Line numbers are 1-based. object.try_emplace("line", inst_line + 1); object.try_emplace("column", 1); + } else { +// No valid line entry or symbol +llvm::json::Object source; +

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Nice test. LGTM! https://github.com/llvm/llvm-project/pull/136777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/136777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/136777 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,81 @@ +"""Test that all of the GPR registers are read correctly from a riscv32 corefile.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +

[Lldb-commits] [lldb] [lldb][MachO] MachO corefile support for riscv32 binaries (PR #137092)

2025-04-23 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,81 @@ +"""Test that all of the GPR registers are read correctly from a riscv32 corefile.""" + +import os +import re +import subprocess + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/136693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-04-23 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/137026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3b48e2a - [lldb-dap] Ensure we acquire the SB API lock while handling requests. (#137026)

2025-04-23 Thread via lldb-commits
Author: John Harrison Date: 2025-04-23T11:02:33-07:00 New Revision: 3b48e2a7508ab090b1b7c6a68f87e3eddad5473d URL: https://github.com/llvm/llvm-project/commit/3b48e2a7508ab090b1b7c6a68f87e3eddad5473d DIFF: https://github.com/llvm/llvm-project/commit/3b48e2a7508ab090b1b7c6a68f87e3eddad5473d.diff

[Lldb-commits] [lldb] [lldb][lldb-dap] Redirect LLDB's messages to the right output category. (PR #137002)

2025-04-23 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I think that may not apply to LLDB-dap. Since dap uses the SBAPI it sends the debugee output to the client here. https://github.com/llvm/llvm-project/blob/1b6cbaa7b64f54b127d139d653468e213bae007e/lldb/tools/lldb-dap/EventHelper.cpp#L205-L215 https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes --- Patch is 30.04 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/115408.diff 10 Files Affected: - (modified) lldb/source/Plugins/Process/Utility/CMa

[Lldb-commits] [lldb] [lldb] Upgrade `GetIndexOfChildWithName` to use `llvm::Expected` (PR #136693)

2025-04-23 Thread Michael Buch via lldb-commits
@@ -395,8 +395,8 @@ lldb_private::formatters::NSSetISyntheticFrontEnd::GetIndexOfChildWithName( (idx < UINT32_MAX && idx >= CalculateNumChildrenIgnoringErrors())) return llvm::createStringError( "'SyntheticChildrenFrontEnd::NSSetISyntheticFrontEnd' cannot fin

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Michael Buch via lldb-commits
Michael137 wrote: Will give others some time to look over Any preference on how to land this? Would be nice to keep the commits separate and not get them squashed. Perhaps push them to HEAD without the github UI but mention the PR in each commit message? https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -37,6 +37,16 @@ void OptionValueEnumeration::DumpValue(const ExecutionContext *exe_ctx, } } +llvm::json::Value +OptionValueEnumeration::ToJSON(const ExecutionContext *exe_ctx) { + for (const auto &enums : m_enumerations) { +if (enums.value.value == m_current_value)

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] dd17cf4 - [lldb] Minor improvements to AddNamesMatchingPartialString (NFC) (#136760)

2025-04-23 Thread via lldb-commits
Author: Dave Lee Date: 2025-04-23T15:21:34-07:00 New Revision: dd17cf4480fc55c38813769a46fb2807397d8f72 URL: https://github.com/llvm/llvm-project/commit/dd17cf4480fc55c38813769a46fb2807397d8f72 DIFF: https://github.com/llvm/llvm-project/commit/dd17cf4480fc55c38813769a46fb2807397d8f72.diff LOG:

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,185 @@ +//===-- RegisterInfos_riscv32.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Updating the 'next' request handler use well structured types (PR #136642)

2025-04-23 Thread John Harrison via lldb-commits
@@ -8,72 +8,37 @@ #include "DAP.h" #include "EventHelper.h" -#include "JSONUtils.h" +#include "Protocol/ProtocolTypes.h" #include "RequestHandler.h" +#include "llvm/Support/Error.h" + +using namespace llvm; +using namespace lldb_dap::protocol; namespace lldb_dap { -// "N

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -37,6 +37,18 @@ void OptionValueEnumeration::DumpValue(const ExecutionContext *exe_ctx, } } +llvm::json::Value +OptionValueEnumeration::ToJSON(const ExecutionContext *exe_ctx) { + const size_t count = m_enumerations.GetSize(); + for (size_t i = 0; i < count; ++i) { +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + lldb::SBStructuredData result = + debugger.GetSetting("stop-disassembly-display"); + const si

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
@@ -202,6 +202,10 @@ struct DAP { lldb::SBFormat frame_format; lldb::SBFormat thread_format; + + /// The value of stop-disassembly-display setting in LLDB. + std::string stop_disassembly_display; JDevlieghere wrote: I'm wondering if we should be caching

[Lldb-commits] [lldb] [lldb-dap] Refactoring lldb-dap 'launch' request to use typed RequestHandler<>. (PR #133624)

2025-04-23 Thread John Harrison via lldb-commits
ashgti wrote: I updated my branch with main and updated the launch handler to return an `llvm::Error` to simplify the body. https://github.com/llvm/llvm-project/pull/133624 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [llvm] [lldb] Implement CLI support for reverse-continue (PR #132783)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/132783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support riscv32 corefiles (PR #115408)

2025-04-23 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/115408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Bug fix in FindModuleUUID (PR #137075)

2025-04-23 Thread via lldb-commits
https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/137075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Bug fix in FindModuleUUID (PR #137075)

2025-04-23 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/137075 In some core file, we are seeing that it's not always the case that the ELF header would exist in the first region in NT_FILES section. Therefore the FindModuleUUID is not able to find the module UUID by j

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + lldb::SBStructuredData result = + debugger.GetSetting("stop-disassembly-display"); + const si

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/5] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Dmitry Vasilyev via lldb-commits
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; - + Log *log = GetLog(LLDBLog::Platform);

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Pavel Labath via lldb-commits
@@ -174,6 +175,9 @@ int main(int argc, char **argv) { //% self.expect("expr (new struct C[1]); side_effect", endstr=" = 4\n") //% self.expect("expr delete c2; side_effect", endstr=" = 1\n") //% self.expect("expr delete[] c3; side_effect", endstr=" = 2\n") + //% self.expe

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Dmitry Vasilyev via lldb-commits
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) { lldb_private::Args inferior_arguments; inferior_arguments.SetArguments(argc, const_cast(argv)); - Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain; slydiman wrote: There is a p

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Dmitry Vasilyev via lldb-commits
@@ -182,3 +191,22 @@ std::vector DomainSocket::GetListeningConnectionURI() const { return {llvm::formatv("unix-connect://{0}", addr.sun_path)}; } + +Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close, + Status &error) { +#ifdef _

[Lldb-commits] [lldb] [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (PR #137007)

2025-04-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper closed https://github.com/llvm/llvm-project/pull/137007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fb0000b - [lldb][lldb-dap] Add ToJSON for OptionValueEnumeration (#137007)

2025-04-23 Thread via lldb-commits
Author: Ebuka Ezike Date: 2025-04-24T07:38:35+01:00 New Revision: fbb6624a5f2df25d10e3667111e96dd1abd5 URL: https://github.com/llvm/llvm-project/commit/fbb6624a5f2df25d10e3667111e96dd1abd5 DIFF: https://github.com/llvm/llvm-project/commit/fbb6624a5f2df25d10e3667111e96dd1abd5.diff L

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Yingwei Zheng (dtcxzyw) Changes `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not exist or is set to zero. So I decided to change

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-23 Thread Yingwei Zheng via lldb-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/137123 `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not exist or is set to zero. So I decided to change lldb to match

[Lldb-commits] [lldb] [llvm] [lldb] Prefer `DW_AT_bit_size` over `DW_AT_byte_size` in `GetDIEBitSizeAndSign` (PR #137123)

2025-04-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-lldb Author: Yingwei Zheng (dtcxzyw) Changes `DW_AT_bit_size` will be ignored by lldb if `DW_AT_byte_size` is available and non-zero. Unfortunately, gdb crashes when `DW_AT_byte_size` does not exist or is set to zero. So

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/6] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136777 >From e513345b74d5dac5b80fcddebcd52ff1aa2ea4dd Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 23 Apr 2025 00:06:28 +0200 Subject: [PATCH 1/2] [lldb-dap] handle stack frames without a module --- .../lldb-

[Lldb-commits] [lldb] [lldb][CPlusPlus] Always use CPlusPlusNameParser for parsing C++ function names (PR #137072)

2025-04-23 Thread Pavel Labath via lldb-commits
labath wrote: Yeah, getting some numbers would be nice. Maybe just repeating the benchmark in that diff. It might be a good idea to do it with and without the accelerator tables, just to rule out any effect from those. FWIW, I expect this to not matter these days. It looks like this change (h

[Lldb-commits] [lldb] [lldb-dap] Handle stack frames without a module (PR #136777)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -783,6 +783,16 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame, // Line numbers are 1-based. object.try_emplace("line", inst_line + 1); object.try_emplace("column", 1); + } else { +// No valid line entry or symbol +llvm::json::Object source; +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/6] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Ensure we acquire the SB API lock while handling requests. (PR #137026)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Ptrace seize dead process (PR #137041)

2025-04-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/137041 This the actual PR to my [SEIZE RFC](https://discourse.llvm.org/t/rfc-ptrace-seize-when-attaching-to-dead-processes/85825/8). This is currently the bare bones on seizing a dead process, and being able to attac

[Lldb-commits] [lldb] [llvm] [lldb] Add new per-language frame-format variables for formatting function names (PR #131836)

2025-04-23 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,166 @@ +//===-- DemangledNameInfo.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Remerge #136236 (PR #136795)

2025-04-23 Thread Greg Clayton via lldb-commits
@@ -209,6 +209,26 @@ def test_default_no_run(self): ) self.assertGreater(module_stats["symbolsLoaded"], 0) clayborg wrote: Same here, renamed "symbolTableSymbolCount" https://github.com/llvm/llvm-project/pull/136795 ___

[Lldb-commits] [lldb] [lldb-dap] Show load addresses in disassembly (PR #136755)

2025-04-23 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere I don't have write access, fee free to merge this PR if possible (I don't know how the procedures of LLVM work in order to merge) https://github.com/llvm/llvm-project/pull/136755 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/136766 >From daf394bf76b5fd627f77aee6e451e7d706d26916 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 22 Apr 2025 13:58:25 -0700 Subject: [PATCH 1/2] [lldb] Expose language plugin commands based based on langua

[Lldb-commits] [lldb] [lldb-dap] Show load addresses in disassembly (PR #136755)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/136755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1da856a - [lldb] Fix typo in ManualDWARFIndexSet.h

2025-04-23 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-04-23T18:22:26+02:00 New Revision: 1da856a685cf427ab1f5b810125c41e7859ed362 URL: https://github.com/llvm/llvm-project/commit/1da856a685cf427ab1f5b810125c41e7859ed362 DIFF: https://github.com/llvm/llvm-project/commit/1da856a685cf427ab1f5b810125c41e7859ed362.diff

[Lldb-commits] [lldb] Add commands to list/enable/disable plugins (PR #134418)

2025-04-23 Thread David Peixotto via lldb-commits
dmpots wrote: > > 1. Are we ok to start with a static table of plugin namespaces or do we > > want dynamic registration from the beginning? > >[Add commands to list/enable/disable pluginsĀ #134418 > > (comment)](https://github.com/llvm/llvm-project/pull/134418#discussion_r2029164327) > > I

[Lldb-commits] [lldb] [lldb] Fix logic error in AppleObjCTypeEncodingParser (PR #137067)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/137067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

2025-04-23 Thread Emre Kultursay via lldb-commits
https://github.com/emrekultursay updated https://github.com/llvm/llvm-project/pull/136466 >From b6c46b7a28a807b507f06d748ed93f20d26fdfcc Mon Sep 17 00:00:00 2001 From: Emre Kultursay Date: Sun, 20 Apr 2025 01:11:31 + Subject: [PATCH 1/4] Fix connecting via abstract socket Commit 82ee31f an

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > What if a language plugin adds a command that conflicts with a top-level > command? @bulbazord the top-level command will be used. This is a fallback, for when no such top-level command exists. If a language plugin adds a subcommand that conflicts with a top-level command

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 9bb3be7a7fe315cda2e63dd10d90b161e6677263 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/5] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -37,6 +37,18 @@ void OptionValueEnumeration::DumpValue(const ExecutionContext *exe_ctx, } } +llvm::json::Value +OptionValueEnumeration::ToJSON(const ExecutionContext *exe_ctx) { + const size_t count = m_enumerations.GetSize(); + for (size_t i = 0; i < count; ++i) { +

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -202,6 +202,10 @@ struct DAP { lldb::SBFormat frame_format; lldb::SBFormat thread_format; + + /// The value of stop-disassembly-display setting in LLDB. + std::string stop_disassembly_display; eronnen wrote: Agree, changed it https://github.com/llvm

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-23 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,19 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + lldb::SBStructuredData result = + debugger.GetSetting("stop-disassembly-display"); + const si

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > maybe you step into a frame you don't have debug info or symbols for @bulbazord one potential solution to this is to use the top-most stack frame for which a language is known. https://github.com/llvm/llvm-project/pull/136766 ___

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione ready_for_review https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland: [clang] preserve class type sugar when taking pointer to member (PR #132401)

2025-04-23 Thread Maksim Ivanov via lldb-commits
emaxx-google wrote: Hello, the minimized reproducer for the determinism issue is there: https://pastebin.com/6aL6rmBe . To build it, unpack it into separate files (via `split-file`), then run `CLANG=path/to/clang make`. The nondeterminism can be checked by looping `make clean` + `make` + `md5s

[Lldb-commits] [lldb] [lldb] Remerge #136236 (PR #136795)

2025-04-23 Thread Greg Clayton via lldb-commits
@@ -209,6 +209,26 @@ def test_default_no_run(self): ) self.assertGreater(module_stats["symbolsLoaded"], 0) +def test_default_no_run_no_preload_symbols(self): +"""Test "statistics dump" without running the target and without +preloadi

[Lldb-commits] [lldb] [lldb] Remerge #136236 (PR #136795)

2025-04-23 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/136795 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-04-23 Thread Dave Lee via lldb-commits
kastiglione wrote: > Many of our users are opinionated about how commands should work ("This > breaks my python scripts!" @bulbazord I agree. I don't think this should break anything. https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136486 >From 5cb1442b1df0befbc55806aee6c9dea4edd68816 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 14:27:53 +0200 Subject: [PATCH 1/2] fix wrong assembly line number when debugging assembly with di

[Lldb-commits] [lldb] [lldb] Minor improvements to AddNamesMatchingPartialString (NFC) (PR #136760)

2025-04-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/136760 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Ptrace seize dead process (PR #137041)

2025-04-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/137041 >From a33b865302e0d489cc4426c038128d8dde47500e Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 22 Apr 2025 16:35:00 -0700 Subject: [PATCH 1/2] Create proc status reader --- .../Plugins/Process/Utility/

[Lldb-commits] [lldb] d72f1f9 - Bug fix in FindModuleUUID (#137075)

2025-04-23 Thread via lldb-commits
Author: GeorgeHuyubo Date: 2025-04-23T15:46:12-07:00 New Revision: d72f1f92f469a5d0ee28dc89f72977634d90d111 URL: https://github.com/llvm/llvm-project/commit/d72f1f92f469a5d0ee28dc89f72977634d90d111 DIFF: https://github.com/llvm/llvm-project/commit/d72f1f92f469a5d0ee28dc89f72977634d90d111.diff

[Lldb-commits] [lldb] Bug fix in FindModuleUUID (PR #137075)

2025-04-23 Thread via lldb-commits
GeorgeHuyubo wrote: > LGTM. Any chance you could artifically craft such a core file for a test? I think this file historically lack a good way of testing changes due to difficulties in hand craft a ELF core file using YAML. https://github.com/llvm/llvm-project/pull/137075 _

[Lldb-commits] [lldb] [lldb-dap] Migrate 'stepIn' request to well structured types. (PR #137071)

2025-04-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/137071 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   >