[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-02 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/134184 >From 7cc45f1a300b1b0f2cbb529f11a0f9e56c41ffea Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 2 Apr 2025 18:05:29 -0700 Subject: [PATCH 1/3] [lldb][debugserver] Save and restore the SVE/SME registe

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-02 Thread David Peixotto via lldb-commits
dmpots wrote: This is my guess on what is causing the test failures. Can revert this and the original PR if it doesn't work. https://github.com/llvm/llvm-project/pull/134173 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-02 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Seems unrelated, but I will check in the morning. https://github.com/llvm/llvm-project/pull/134163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use the "reverse video" effect when colors are disabled. (PR #134203)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/134203 When you run lldb without colors (`-X), the status line looks weird because it doesn't have a background. You end up with what appears to be floating text at the bottom of your terminal. This patch change

[Lldb-commits] [lldb] [lldb] Use the "reverse video" effect when colors are disabled. (PR #134203)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/134203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use the "reverse video" effect when colors are disabled. (PR #134203)

2025-04-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/statusline/TestStatusline.py `` V

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-02 Thread Karl Traunmüller via lldb-commits
ktraunmueller wrote: Thank you! FYI, I created a [bug report](https://github.com/llvm/llvm-project/issues/133904) (which can now be closed) for this problem, but forgot to add that information to the Swift forum post, sorry for that. https://github.com/llvm/llvm-project/pull/134150 _

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix tagged-pointer info address parsing (PR #134123)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Make TestDAP_Progress more resilient (again) (PR #134157)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134157 >From 50b4967465b16955c2ac144044680c2e889445c7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 2 Apr 2025 15:10:25 -0700 Subject: [PATCH] [lldb-dap] Add progress events to the packet list Befor

[Lldb-commits] [lldb] [lldb-dap] Add progress events to the packet list (PR #134157)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Addressed review comments https://github.com/llvm/llvm-project/pull/134160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes The motivation for this patch is that in Statistics.cpp we [check to see if the module symfile is loaded](https://github.com/llvm/llvm-project/blob/990a086d9da0bc2fd53a6a4c95ecbbe23a297a83/lldb/source/Target

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-04-02 Thread Vy Nguyen via lldb-commits
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] 3f7ca88 - [lldb-dap] Add progress events to the packet list (#134157)

2025-04-02 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-02T15:33:07-07:00 New Revision: 3f7ca8826776f32526e948b89816db492435f2e2 URL: https://github.com/llvm/llvm-project/commit/3f7ca8826776f32526e948b89816db492435f2e2 DIFF: https://github.com/llvm/llvm-project/commit/3f7ca8826776f32526e948b89816db492435f2e2.d

[Lldb-commits] [lldb] 93d3775 - [lldb] Fix tagged-pointer info address parsing (#134123)

2025-04-02 Thread via lldb-commits
Author: Dave Lee Date: 2025-04-02T15:16:58-07:00 New Revision: 93d3775da8810e1542873b1cdcec2ea142704561 URL: https://github.com/llvm/llvm-project/commit/93d3775da8810e1542873b1cdcec2ea142704561 DIFF: https://github.com/llvm/llvm-project/commit/93d3775da8810e1542873b1cdcec2ea142704561.diff LOG:

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes When using `SBFrame::EvaluateExpression` on a frame that's not the currently selected frame, we would sometimes run into errors such as: ``` error: error: The context has changed before we could JIT the exp

[Lldb-commits] [lldb] b55bab2 - [lldb] Fix plugin manager test failure on windows (#134173)

2025-04-02 Thread via lldb-commits
Author: David Peixotto Date: 2025-04-02T17:22:46-07:00 New Revision: b55bab229228218341e2f24fc8529c7aaab51e2f URL: https://github.com/llvm/llvm-project/commit/b55bab229228218341e2f24fc8529c7aaab51e2f DIFF: https://github.com/llvm/llvm-project/commit/b55bab229228218341e2f24fc8529c7aaab51e2f.diff

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-02 Thread David Peixotto via lldb-commits
dmpots wrote: The windows bots are now passing on this test so I think it was ICF that was the problem: https://lab.llvm.org/buildbot/#/changes/32645 https://github.com/llvm/llvm-project/pull/134173 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-02 Thread David Peixotto via lldb-commits
https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/134173 This is an attempt to fix a test failure from #133794 when running on windows builds. I suspect we are running into a case where the [ICF](https://learn.microsoft.com/en-us/cpp/build/reference/opt-optimizations?

[Lldb-commits] [lldb] [lldb-dap] Add a -v/--version command line argument (PR #134114)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4e40c7c - [lldb][debugserver] Save and restore the SVE/SME register state (#134184)

2025-04-02 Thread via lldb-commits
Author: Jason Molenda Date: 2025-04-02T20:37:07-07:00 New Revision: 4e40c7c4bd66d98f529a807dbf410dc46444f4ca URL: https://github.com/llvm/llvm-project/commit/4e40c7c4bd66d98f529a807dbf410dc46444f4ca DIFF: https://github.com/llvm/llvm-project/commit/4e40c7c4bd66d98f529a807dbf410dc46444f4ca.diff

[Lldb-commits] [lldb] [lldb/DWARF] Remove "range lower than function low_pc" check (PR #132395)

2025-04-02 Thread Pavel Labath via lldb-commits
labath wrote: Ping. https://github.com/llvm/llvm-project/pull/132395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: /cherry-pick 39e7efe1e4304544289d8d1b45f4d04d11b4a791 https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-04-02 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#134079 https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs, lite (PR #134081)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Replace with std::unique_ptr. Previous attempt at replacing them with values failed because x86AssemblyInspectionEngine was storing pointers to the rows while modifying the plan. Changing that is relatively ea

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs, lite (PR #134081)

2025-04-02 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/134081 Replace with std::unique_ptr. Previous attempt at replacing them with values failed because x86AssemblyInspectionEngine was storing pointers to the rows while modifying the plan. Changing that is relatively easy

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs, lite (PR #134081)

2025-04-02 Thread Pavel Labath via lldb-commits
labath wrote: Ftr, this is what it takes to fix the use after free problem. I didn't do that because it strictly increases the number of copies, and the use pattern is reasonable, but I'd be totally fine with doing that instead (I don't expect anyone will notice the extra copies). https://git

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-02 Thread Pavel Labath via lldb-commits
labath wrote: Long term, I think we should have a different way to set/compute/retrieve these paths, but locally, what you're doing is correct. lldb-server doesn't have a way to compute the "shared library directory", nor does it have any reason to do that, so returning an empty file spec inst

[Lldb-commits] [lldb] [lldb/telemetry] Report exit status only once (PR #134078)

2025-04-02 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo approved this pull request. https://github.com/llvm/llvm-project/pull/134078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread via lldb-commits
@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/134160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
@@ -1137,9 +1132,18 @@ class StopInfoUnixSignal : public StopInfo { return m_description.c_str(); } + bool ShouldSelect() const override { return IsShouldStopSignal(); } + private: // In siginfo_t terms, if m_value is si_signo, m_code is si_code. std::optional m_

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-02 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/134184 debugserver isn't saving and restoring the SVE/SME register state around inferior function calls. Making arbitrary function calls while in Streaming SVE mode is generally a poor idea because a NEON instru

[Lldb-commits] [lldb] [lldb][debugserver] Save and restore the SVE/SME register state (PR #134184)

2025-04-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImp

[Lldb-commits] [lldb] [lldb-dap] Add a -v/--version command line argument (PR #134114)

2025-04-02 Thread via lldb-commits
https://github.com/hstk30-hw approved this pull request. https://github.com/llvm/llvm-project/pull/134114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 18c43d0 - [lldb-dap] Add a -v/--version command line argument (#134114)

2025-04-02 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-04-02T18:40:37-07:00 New Revision: 18c43d01fc61648369fef50999e7df62b3ec292f URL: https://github.com/llvm/llvm-project/commit/18c43d01fc61648369fef50999e7df62b3ec292f DIFF: https://github.com/llvm/llvm-project/commit/18c43d01fc61648369fef50999e7df62b3ec292f.d

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-02 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15362 Here is the relevant piece of the b

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/134163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-02 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. https://github.com/llvm/llvm-project/pull/134163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revert plugin manager changes to investigate failure (PR #134183)

2025-04-02 Thread David Peixotto via lldb-commits
https://github.com/dmpots created https://github.com/llvm/llvm-project/pull/134183 Revert the below two commits while we investigate the test failures. Revert "[lldb] Fix plugin manager test failure on windows (#134173)" This reverts commit b55bab229228218341e2f24fc8529c7aaab51e2f. Revert "Ad

[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @z2oh Would you mind cherry-picking this to https://github.com/swiftlang/llvm-project/tree/stable/20240723? https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/134097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add progress events to the packet list (PR #134157)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/134157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] be3abfc - [lldb] Clear thread name container before writing UTF8 bytes (#134150)

2025-04-02 Thread via lldb-commits
Author: Jeremy Day Date: 2025-04-02T16:35:02-07:00 New Revision: be3abfc00f37d07c641b3e2f93eef5d1a446af8e URL: https://github.com/llvm/llvm-project/commit/be3abfc00f37d07c641b3e2f93eef5d1a446af8e DIFF: https://github.com/llvm/llvm-project/commit/be3abfc00f37d07c641b3e2f93eef5d1a446af8e.diff LO

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/134097 >From 151ad919ab6f2d87991511b293f4a9797210f82f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Apr 2025 15:48:25 +0100 Subject: [PATCH 1/3] [lldb][Target] RunThreadPlan to save/restore the Execution

[Lldb-commits] [lldb] Add enable/disable api for SystemRuntime plugins (PR #133794)

2025-04-02 Thread David Peixotto via lldb-commits
dmpots wrote: I have an attempted fix for these failures in #134173. I suspect ICF is combining the create functions into a single address which make us unable to remove them based on a unique address (which the plugin manager assumes). https://github.com/llvm/llvm-project/pull/133794

[Lldb-commits] [lldb] [lldb] Fix plugin manager test failure on windows (PR #134173)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Let's try it! https://github.com/llvm/llvm-project/pull/134173 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix tagged-pointer info address parsing (PR #134123)

2025-04-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/134123 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (PR #134163)

2025-04-02 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15374 Here is the relevant piece of the b

[Lldb-commits] [lldb] b8d8405 - [LLDB] Expose checking if the symbol file exists/is loaded via SBModule (#134163)

2025-04-02 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-04-02T21:27:44-07:00 New Revision: b8d8405238387ddd92450d6a3ad84350254e76a3 URL: https://github.com/llvm/llvm-project/commit/b8d8405238387ddd92450d6a3ad84350254e76a3 DIFF: https://github.com/llvm/llvm-project/commit/b8d8405238387ddd92450d6a3ad84350254e76a3.diff

[Lldb-commits] [lldb] [lldb] Use the "reverse video" effect when colors are disabled. (PR #134203)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes When you run lldb without colors (`-X`), the status line looks weird because it doesn't have a background. You end up with what appears to be floating text at the bottom of your terminal. This patc

[Lldb-commits] [lldb] [lldb] Update examples in docs/use/python-reference.rst to work with Python 3 (PR #134204)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/134204 The examples on this page were using the Python 2-style print. I ran the updated code examples under Python 3 to confirm they are still up-to-date. >From a4ce285ba4921fdf43382a1c24764c1619eaf663 Mon Sep 17

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] Fix typos: paramter, parametr, parametere (PR #134092)

2025-04-02 Thread Owen Pan via lldb-commits
@@ -12304,7 +12304,7 @@ TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); verifyFormat("f(* /* confusing comment */ foo);"); verifyFormat("void (* /*deleter*/)(const Slice &key, void *value)"); - verifyFo

[Lldb-commits] [lldb] [lldb] Use the "reverse video" effect when colors are disabled. (PR #134203)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134203 >From c5df5b2684a42f11c13efa6b03a28ea4e8ff900e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 2 Apr 2025 22:52:39 -0700 Subject: [PATCH 1/2] [lldb] Use the "reverse video" effect when colors ar

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-04-02 Thread Hu Jialun via lldb-commits
https://github.com/SuibianP updated https://github.com/llvm/llvm-project/pull/121269 >From babc347b5ad20d9d155c717323dc9796fce6b756 Mon Sep 17 00:00:00 2001 From: Jialun Hu Date: Mon, 24 Feb 2025 22:10:17 +0800 Subject: [PATCH] [lldb-dap] Implement runInTerminal for Windows Currently, the name

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: > if I start lldb with no arguments: https://github.com/llvm/llvm-project/issues/134064 > Does not happen if I have a program file, but this is also strange: This part appears to have been fixed. https://github.com/llvm/llvm-project/pull/121860 ___

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-04-02 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/133247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-04-02 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @labath > LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` [lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/7046) is broken too. https://github.com/llvm/llvm-project/pull/133247 ___

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-02 Thread Pavel Labath via lldb-commits
labath wrote: Okay. The last comment makes sense to me. Thank you for getting to the bottom of this. I fully agree this should be resolved in lldb as lldb-server has no good reason to depend on this code in the first place. So as far as I am concerned (I can't speak about others), I think some

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] Fix typos: paramter, parametr, parametere (PR #134092)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format @llvm/pr-subscribers-backend-webassembly Author: Jay Foad (jayfoad) Changes --- Patch is 24.76 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/134092.diff 30 Files Affected: - (modified) bolt

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-04-02 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @bulbazord, Do you have the opportunity to complete the patch https://github.com/swiftlang/llvm-project/pull/3240 (sort language plug-ins in cmake or hardcode the sorted list of language plug-ins)? I can try to complete it, if you don't mind. https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-02 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: > I'm just thinking about whether there's a way to test this. You've said that > there's a test for the scenario where lldb-server and lldb are not in the > same directory. Which one is it? Would it be possible to use a similar > approach to test this scenario as w

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] Fix typos: paramter, parametr, parametere (PR #134092)

2025-04-02 Thread Jay Foad via lldb-commits
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/134092 None >From 10ab02a61b5e2ec3f58a12c78e7b3b989a349a8f Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Wed, 2 Apr 2025 15:35:32 +0100 Subject: [PATCH] Fix typos: paramter, parametr, parametere --- bolt/utils/bughu

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: /cherry-pick 945c494e2c3c078e26ff521ef3e9455e0ff764ac https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett milestoned https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-04-02 Thread Pavel Labath via lldb-commits
@@ -36,18 +36,19 @@ class FuncUnwinders { ~FuncUnwinders(); - lldb::UnwindPlanSP GetUnwindPlanAtCallSite(Target &target, Thread &thread); + std::shared_ptr GetUnwindPlanAtCallSite(Target &target, labath wrote: Heh, that seems like quite a long time ago.

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Didn't look at the code all too closely but it looks okay to me. I believe my earlier concerns about cancellation races are resolved now. https://github.com/llvm/llvm-project/pull/130169 ___ lldb-c

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-04-02 Thread Pavel Labath via lldb-commits
@@ -778,28 +817,121 @@ llvm::Error DAP::Disconnect(bool terminateDebuggee) { return ToError(error); } +bool DAP::IsCancelled(const protocol::Request &req) { + std::lock_guard lock(m_cancelled_requests_mutex); + return m_cancelled_requests.contains(req.seq); +} + +void DAP:

[Lldb-commits] [lldb] [lldb] Show the path to the .o instead of the containing .a in progress events (PR #133370)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Any concerns with this @clayborg? This pretty much does exactly what you suggested in https://github.com/llvm/llvm-project/pull/133211. https://github.com/llvm/llvm-project/pull/133370 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread via lldb-commits
@@ -0,0 +1,283 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Speed up TestDAP_Progress (PR #134048)

2025-04-02 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. LGTM! Thanks for fixing https://github.com/llvm/llvm-project/pull/134048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: `test_platform_process_launch_gdb_server` is worth looking into. https://github.com/llvm/llvm-project/pull/131609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-04-02 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15320 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/133662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/134097 When using `SBFrame::EvaluateExpression` on a frame that's not the currently selected frame, we would sometimes run into errors such as: ``` error: error: The context has changed before we could JIT the expre

[Lldb-commits] [lldb] [lldb-dap] Speed up TestDAP_Progress (PR #134048)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes While trying to make progress on #133782, I noticed that TestDAP_Progress was taking 90 seconds to complete. This patch brings that down to 10 seocnds by making the following changes: 1. Don't call

[Lldb-commits] [lldb] [lldb-dap] Speed up TestDAP_Progress (PR #134048)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134048 >From 960aefe0d5f79eef7cc9cb6d4912f6075e60a816 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 2 Apr 2025 01:19:58 -0700 Subject: [PATCH] [lldb-dap] Speed up TestDAP_Progress While trying to ma

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

2025-04-02 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/133662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,283 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-04-02 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,283 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb/telemetry] Report exit status only once (PR #134078)

2025-04-02 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/134078 SetExitStatus can be called the second time when we reap the debug server process. This shouldn't be interesting as at that point, we've already told everyone that the process has exited. I believe/hope this wi

[Lldb-commits] [lldb] [lldb/telemetry] Report exit status only once (PR #134078)

2025-04-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes SetExitStatus can be called the second time when we reap the debug server process. This shouldn't be interesting as at that point, we've already told everyone that the process has exited. I believe/hope this

[Lldb-commits] [lldb] [LLDB][NFC]Move fields that might be referenced in scope-exit to beginning (PR #133785)

2025-04-02 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/133785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/134097 >From 151ad919ab6f2d87991511b293f4a9797210f82f Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Apr 2025 15:48:25 +0100 Subject: [PATCH 1/2] [lldb][Target] RunThreadPlan to save/restore the Execution

[Lldb-commits] [lldb] [lldb][Target] RunThreadPlan to save/restore the ExecutionContext's frame if one exists (PR #134097)

2025-04-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/134097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Hoist UUID generation into the UUID class (PR #133662)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133662 >From f0a4b9bc2f20a812f7f37e5f5a2417dbbb4d45e0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 30 Mar 2025 16:10:05 -0700 Subject: [PATCH 1/5] [lldb] Hoist UUID generation into the UUID class H

[Lldb-commits] [lldb] [lldb][NFC] Move ShouldShow/ShouldSelect logic into Stopinfo (PR #134160)

2025-04-02 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/134160 This NFC patch simplifies the main loop in HandleProcessStateChanged event by moving duplicated code into the StopInfo class, also allowing StopInfo subclasses to override behavior. More specifically, t

[Lldb-commits] [lldb] [lldb-dap] Make TestDAP_Progress more resilient (again) (PR #134157)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
@@ -12,17 +12,31 @@ class TestDAP_progress(lldbdap_testcase.DAPTestCaseBase): +MAX_ATTEMPS = 10 JDevlieghere wrote: Yeah, that's a good point. Here's my understanding why how this works: We have a packet read thread (`read_packet_thread`) which looks at

[Lldb-commits] [lldb] [lldb-dap] Add progress events to the packet list (PR #134157)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/134157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating a common configuration structure for launch and attach requests. (PR #133960)

2025-04-02 Thread Jonas Devlieghere via lldb-commits
@@ -118,6 +118,81 @@ bool fromJSON(const llvm::json::Value &, InitializeRequestArguments &, /// Response to `initialize` request. The capabilities of this debug adapter. using InitializeResponseBody = std::optional; +/// DAP Launch and Attach common configurations. +struct DA

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-02 Thread Mikhail Zakharov via lldb-commits
https://github.com/real-mikhail updated https://github.com/llvm/llvm-project/pull/129092 >From 1d2da22bceb83cbda54567e5f819e5eef4e6 Mon Sep 17 00:00:00 2001 From: Mikhail Zakharov Date: Thu, 27 Feb 2025 18:43:33 +0100 Subject: [PATCH 1/9] [lldb] Do not bump memory modificator ID when "inter