@@ -12,26 +12,28 @@
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Endian.h"
+#include "llvm/Support/Error.h"
#include
#include
#include
+#include
labath wrote:
bad autocomplete?
https://github.com/llvm/llvm-proje
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/112555
>From a9d02c8b0c22138d9337bf33883f7e6c937bd655 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Mon, 14 Oct 2024 14:14:30 +
Subject: [PATCH 1/3] [lldb] add --platform-available-ports option to the
dotest.
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/112555
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
I don't think this needs to be a setting as the goal here is to weed out truly
egregious report frequencies (O(thousands) per second). I think the rest would
be better handled at the receiving side.
I guess making a constant for that is fin
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/133275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/133250
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-03-31T11:45:11+02:00
New Revision: 9d61eaa9ecd9a46d22a8a4efc67d31b9abba3616
URL:
https://github.com/llvm/llvm-project/commit/9d61eaa9ecd9a46d22a8a4efc67d31b9abba3616
DIFF:
https://github.com/llvm/llvm-project/commit/9d61eaa9ecd9a46d22a8a4efc67d31b9abba3616.diff
@@ -36,18 +36,19 @@ class FuncUnwinders {
~FuncUnwinders();
- lldb::UnwindPlanSP GetUnwindPlanAtCallSite(Target &target, Thread &thread);
+ std::shared_ptr GetUnwindPlanAtCallSite(Target &target,
labath wrote:
Currently we need them, because the unwind p
Author: Jonas Devlieghere
Date: 2025-03-31T08:29:20-07:00
New Revision: 799e9053641a6478d3144866a97737b37b87c260
URL:
https://github.com/llvm/llvm-project/commit/799e9053641a6478d3144866a97737b37b87c260
DIFF:
https://github.com/llvm/llvm-project/commit/799e9053641a6478d3144866a97737b37b87c260.d
JDevlieghere wrote:
> I don't think this needs to be a setting as the goal here is to weed out
> truly egregious report frequencies (O(thousands) per second). I think the
> rest would be better handled at the receiving side.
👍
> I guess making a constant for that is fine, though the name is s
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/131519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Yuval Deutscher
Date: 2025-03-31T08:20:40-07:00
New Revision: 945c494e2c3c078e26ff521ef3e9455e0ff764ac
URL:
https://github.com/llvm/llvm-project/commit/945c494e2c3c078e26ff521ef3e9455e0ff764ac
DIFF:
https://github.com/llvm/llvm-project/commit/945c494e2c3c078e26ff521ef3e9455e0ff764ac.dif
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/133295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@yuvald-sweet-security Congratulations on having your first Pull Request (PR)
merged into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem
Author: David Peixotto
Date: 2025-03-31T09:53:46-07:00
New Revision: f0b3bdd6dfa035653de5ead7b8d0582a8c0c158e
URL:
https://github.com/llvm/llvm-project/commit/f0b3bdd6dfa035653de5ead7b8d0582a8c0c158e
DIFF:
https://github.com/llvm/llvm-project/commit/f0b3bdd6dfa035653de5ead7b8d0582a8c0c158e.diff
@@ -744,6 +744,10 @@ let Command = "process continue" in {
Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to,
temporarily "
"ignoring other breakpoints. Can be specified more than once. "
"The continue action will be done synchronously if this o
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/133295
>From 79241d2f5701ab789f7fdbb5bd881c4494cb67eb Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 27 Mar 2025 11:24:50 -0700
Subject: [PATCH 1/4] [lldb] Expose the Target API mutex through the SB A
slydiman wrote:
> I think there's something else happening here.
Ok, it seems the dependency chain is longer:
Module.cpp -> CPlusPlusLanguage::ExtractContextAndIdentifier() ->
CPlusPlusLanguage.cpp ->
BlockPointer.cpp ->
TypeSystemClang.cpp - >
ClangUserExpression.cpp ->
ClangExpressionParser
JDevlieghere wrote:
This is part of a few small cleanups I'm doing before adopting SBMutex in
lldb-dap.
https://github.com/llvm/llvm-project/pull/133746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -0,0 +1,59 @@
+//===-- SBMutexTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/133662
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
I'm wondering how badly do we need this to be "secure". I'm asking because
basically the only reason this can fail is if it fails to open /dev/random or
something. So, like if we're fine with falling back to a lower entropy source
(some c++11 RNG initialize
@@ -8,7 +8,10 @@
#include "LinuxSignals.h"
-#ifdef __linux__
+// Now, because we do not support mips debugging, if we compile LLVM on mips
+// target, would report error `static assertion failed:Value mismatch for
signal
+// number SIGBUS`, so add this condition to avoid err
https://github.com/labath approved this pull request.
LGTM, I just tweaked the comment a bit. Please also update the endif comment on
line 39.
https://github.com/llvm/llvm-project/pull/132688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/133295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/133662
>From f0a4b9bc2f20a812f7f37e5f5a2417dbbb4d45e0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 30 Mar 2025 16:10:05 -0700
Subject: [PATCH 1/2] [lldb] Hoist UUID generation into the UUID class
H
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/133740
Include the LLDB version in the lldbassert error message, and prompt users to
include it in the bug report. The majority of users that bother filing a bug
report just copy past the stack trace and often fo
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/133740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ashgti wrote:
Anyone have any other comments on supporting 'cancel'?
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-03-31T09:40:33-07:00
New Revision: 94b04b411903e97bd228c6bdbdb845c29f6de6a1
URL:
https://github.com/llvm/llvm-project/commit/94b04b411903e97bd228c6bdbdb845c29f6de6a1
DIFF:
https://github.com/llvm/llvm-project/commit/94b04b411903e97bd228c6bdbdb845c29f6de6a1.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/133740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -397,6 +402,23 @@ struct DAP {
InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
InstructionBreakpoint *GetInstructionBPFromStopReason(lldb::SBThread
&thread);
+
+ /// Checks if the request is cancelled.
+ bool IsCancelled(const protocol
@@ -19,10 +19,39 @@
#include "lldb/lldb-forward.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
-#include
+#include
+#include
namespace lldb_dap {
+class EndOfFileError : public llvm::ErrorInfo {
+public:
+ static char ID;
+
+ EndOfFileError() = def
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/133746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/133746
Replace GetBreakpointLabel with kDAPBreakpointLabel constant to avoid an
unnecessary function call.
>From 29a800b072d6841397ebe77db01b50d3db507748 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mo
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/133746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -671,11 +693,25 @@ void DAP::SetTarget(const lldb::SBTarget target) {
}
}
-bool DAP::HandleObject(const protocol::Message &M) {
- if (const auto *req = std::get_if(&M)) {
+bool DAP::HandleObject(const Message &M) {
+ if (const auto *req = std::get_if(&M)) {
+{
+
dlav-sc wrote:
I'm going to land this by the end of the week. If you have any concerns, please
let me know.
https://github.com/llvm/llvm-project/pull/127505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Convert Breakpoint & Watchpoints structs to classes to provide proper
access control. This is in preparation for adopting SBMutex to protect the
underlying SBBreakpoint and SBWatchpoint.
---
Patch
Author: Jonas Devlieghere
Date: 2025-03-31T11:46:23-07:00
New Revision: 0bdc9e6d080009dc87b9458181c5a41cc13f26ae
URL:
https://github.com/llvm/llvm-project/commit/0bdc9e6d080009dc87b9458181c5a41cc13f26ae
DIFF:
https://github.com/llvm/llvm-project/commit/0bdc9e6d080009dc87b9458181c5a41cc13f26ae.d
@@ -52,14 +37,33 @@ struct SourceBreakpoint : public Breakpoint {
static bool BreakpointHitCallback(void *baton, lldb::SBProcess &process,
lldb::SBThread &thread,
lldb::SBBreakpointLocation &location);
-}
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This makes the DAP test server resilient against broken pipes. I'm not sure
what is causing the broken pipe, but IIRC this isn't the first time we've seen
an issues related to that. I worry about sw
@@ -397,6 +402,23 @@ struct DAP {
InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
InstructionBreakpoint *GetInstructionBPFromStopReason(lldb::SBThread
&thread);
+
+ /// Checks if the request is cancelled.
+ bool IsCancelled(const protocol
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/133811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/133840
The `locked` variable can be accessed from the asynchronous thread until the
call to f.wait() completes. However, the variable is scoped in a lexical block
that ends before that, leading to a use-after-fre
Author: Jonas Devlieghere
Date: 2025-03-31T19:36:05-07:00
New Revision: 0b8c8ed04211dae629811f24e6033e5c2185508f
URL:
https://github.com/llvm/llvm-project/commit/0b8c8ed04211dae629811f24e6033e5c2185508f
DIFF:
https://github.com/llvm/llvm-project/commit/0b8c8ed04211dae629811f24e6033e5c2185508f.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/133824
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/yingopq updated
https://github.com/llvm/llvm-project/pull/132688
>From 4cd95bb97c04fa26dc12c64ab3b6ccf9a911cc33 Mon Sep 17 00:00:00 2001
From: Ying Huang
Date: Mon, 24 Mar 2025 03:44:41 -0400
Subject: [PATCH] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips
targe
@@ -0,0 +1,57 @@
+//===-- SBMutexTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/junlarsen created
https://github.com/llvm/llvm-project/pull/133869
Part of #123569
>From 84298350a0cab997d4d98ae16f6203a07cfcbb13 Mon Sep 17 00:00:00 2001
From: Mats Jun Larsen
Date: Mon, 31 Mar 2025 18:57:35 +0200
Subject: [PATCH] [lldb] Prefer PointerType::get with LLVMCon
junlarsen wrote:
* **#133869** https://app.graphite.dev/github/pr/llvm/llvm-project/133869?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/13
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/133785
Details: The ScopedDiscpatcher's dtor may reference these fields so we need the
fields' dtor to be be invoked *after* the dispatcher's.
>From 55d20dc85389bdeacf806b18ff132030e2626d9a Mon Sep 17 00:00:00 2001
Fr
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/133780
>From 2f22b24840ec0f3cb650da97ad0bd2caea0a8cef Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 31 Mar 2025 11:47:02 -0700
Subject: [PATCH 1/2] [lldb] Convert Breakpoint & Watchpoints structs to
@@ -12,25 +12,35 @@
#include "DAPForward.h"
#include "lldb/API/SBBreakpoint.h"
#include "lldb/lldb-enumerations.h"
+#include "llvm/ADT/StringRef.h"
#include
#include
namespace lldb_dap {
-struct ExceptionBreakpoint {
- DAP &dap;
- std::string filter;
- std::string l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Peixotto (dmpots)
Changes
The tests for the
[intel-pt](https://github.com/llvm/llvm-project/blob/348374028970c956f2e49ab7553b495d7408ccd9/lldb/docs/use/intel_pt.rst)
trace plugin were failing for multiple reasons.
On machines where t
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/133290
>From effad9525461611ed47598b53a77ee5aabb0e4cf Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 27 Mar 2025 11:04:26 -0700
Subject: [PATCH 1/3] Add a new affordance that the Python module in a dSYM can
be
https://github.com/kuhar approved this pull request.
https://github.com/llvm/llvm-project/pull/133846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-03-31T22:11:22-07:00
New Revision: 4d68cf384df6be405598ec23be0e23e0837db3a3
URL:
https://github.com/llvm/llvm-project/commit/4d68cf384df6be405598ec23be0e23e0837db3a3
DIFF:
https://github.com/llvm/llvm-project/commit/4d68cf384df6be405598ec23be0e23e0837db3a3.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/133846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,57 @@
+//===-- SBMutexTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/133780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dmpots wrote:
This PR modifies the PluginManager to support enable/disable. A following
[commit](https://github.com/dmpots/llvm-project/commit/aaa3ab3d063580747bb106f39e6792232cc0af00)
will expose the commands to the user.
This is currently only working for the SystemRuntime plugins. Once thes
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/132688
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -19,10 +19,39 @@
#include "lldb/lldb-forward.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
-#include
+#include
+#include
namespace lldb_dap {
+class EndOfFileError : public llvm::ErrorInfo {
+public:
+ static char ID;
+
+ EndOfFileError() = def
@@ -19,10 +19,39 @@
#include "lldb/lldb-forward.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
-#include
+#include
+#include
namespace lldb_dap {
+class EndOfFileError : public llvm::ErrorInfo {
+public:
+ static char ID;
+
+ EndOfFileError() = def
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130169
>From c183231db80d6c97bdd5e9bd0b21d041189146e8 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 18 Mar 2025 14:05:38 -0700
Subject: [PATCH 01/12] [lldb-dap] Adding support for cancelling a request.
Adding
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
Details: The ScopedDiscpatcher's dtor may reference these fields so we need the
fields' dtor to be be invoked *after* the dispatcher's.
---
Full diff: https://github.com/llvm/llvm-project/pull/133785.diff
1 Fi
Author: Tom Yang
Date: 2025-03-31T13:29:31-07:00
New Revision: a8d2d169c7add4b0106ae76e186cf815c0b84825
URL:
https://github.com/llvm/llvm-project/commit/a8d2d169c7add4b0106ae76e186cf815c0b84825
DIFF:
https://github.com/llvm/llvm-project/commit/a8d2d169c7add4b0106ae76e186cf815c0b84825.diff
LOG:
@@ -49,6 +41,17 @@ struct BreakpointBase {
/// breakpoint in one of the DAP breakpoints that we should report changes
/// for.
static constexpr const char *kDAPBreakpointLabel = "dap";
+
+protected:
+ /// Associated DAP session.
+ DAP &dap;
+
+ /// An optional expressi
@@ -52,14 +37,33 @@ struct SourceBreakpoint : public Breakpoint {
static bool BreakpointHitCallback(void *baton, lldb::SBProcess &process,
lldb::SBThread &thread,
lldb::SBBreakpointLocation &location);
-}
ashgti wrote:
A `SIGPIPE` is raised if your process writes a pipe that is closed on the other
end. If the python script is getting that then `lldb-dap` must have closed
stdin.
The Transport `input` does take ownership of stdin
(https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-da
@@ -52,14 +37,33 @@ struct SourceBreakpoint : public Breakpoint {
static bool BreakpointHitCallback(void *baton, lldb::SBProcess &process,
lldb::SBThread &thread,
lldb::SBBreakpointLocation &location);
-}
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Peixotto (dmpots)
Changes
This commit adds support for enabling and disabling plugins by name. The
changes are made generically in the `PluginInstances` class, but currently we
only expose the ability to SystemRuntime plugins. Other
ashgti wrote:
Wanted to also double check with @labath as well, any additional thoughts?
https://github.com/llvm/llvm-project/pull/130169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
Author: John Harrison
Date: 2025-03-31T19:50:36-07:00
New Revision: a417a868cd2dad41765e43715379a54289f7da67
URL:
https://github.com/llvm/llvm-project/commit/a417a868cd2dad41765e43715379a54289f7da67
DIFF:
https://github.com/llvm/llvm-project/commit/a417a868cd2dad41765e43715379a54289f7da67.diff
@@ -8,7 +8,10 @@
#include "LinuxSignals.h"
-#ifdef __linux__
+// Now, because we do not support mips debugging, if we compile LLVM on mips
+// target, would report error `static assertion failed:Value mismatch for
signal
+// number SIGBUS`, so add this condition to avoid err
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/133846
None
>From f40080fe8aad7233f6388d699b662a447703915d Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Sun, 30 Mar 2025 23:19:44 -0700
Subject: [PATCH] [lldb] Use DenseMap::insert_range (NFC)
---
lldb/so
Author: Jonas Devlieghere
Date: 2025-03-31T16:04:31-07:00
New Revision: 46457ed1dfbfaf4ccc9245813450ba3fd561f067
URL:
https://github.com/llvm/llvm-project/commit/46457ed1dfbfaf4ccc9245813450ba3fd561f067
DIFF:
https://github.com/llvm/llvm-project/commit/46457ed1dfbfaf4ccc9245813450ba3fd561f067.d
https://github.com/rocallahan updated
https://github.com/llvm/llvm-project/pull/132783
>From 87af424e911ac5b22ee75d801390d29b9b3f367a Mon Sep 17 00:00:00 2001
From: Robert O'Callahan
Date: Fri, 19 Jul 2024 22:48:14 +1200
Subject: [PATCH] [lldb] Implement CLI support for reverse-continue
This i
@@ -468,7 +468,23 @@ class CommandObjectProcessContinue : public
CommandObjectParsed {
case 'b':
m_run_to_bkpt_args.AppendArgument(option_arg);
m_any_bkpts_specified = true;
- break;
+break;
rocallahan wrote:
Thanks. Actuall
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/133846.diff
1 Files Affected:
- (modified) lldb/source/Plugins/ABI/X86/ABIX86.cpp (+1-1)
``diff
diff --git a/lldb/source/Plugins/AB
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/133811
>From 9053618204265ea71a6a30382937cff584f8c02d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 31 Mar 2025 14:36:16 -0700
Subject: [PATCH 1/2] [lldb-dap] Do not take ownership of stdin.
There isn't any b
@@ -571,7 +571,7 @@ int main(int argc, char *argv[]) {
}
lldb::IOObjectSP input = std::make_shared(
- fileno(stdin), File::eOpenOptionReadOnly, true);
+ fileno(stdin), File::eOpenOptionReadOnly, false);
ashgti wrote:
Applied.
https://github.com
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/133811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -571,7 +571,7 @@ int main(int argc, char *argv[]) {
}
lldb::IOObjectSP input = std::make_shared(
- fileno(stdin), File::eOpenOptionReadOnly, true);
+ fileno(stdin), File::eOpenOptionReadOnly, false);
JDevlieghere wrote:
```suggestion
fi
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/133811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
There isn't any benefit to taking ownership of stdin and it may cause issues if
`Transport` is dealloced.
---
Full diff: https://github.com/llvm/llvm-project/pull/133811.diff
1 Files Affected:
- (modified)
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/133811
There isn't any benefit to taking ownership of stdin and it may cause issues if
`Transport` is dealloced.
>From 9053618204265ea71a6a30382937cff584f8c02d Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 3
@@ -0,0 +1,57 @@
+//===-- SBMutexTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
91 matches
Mail list logo