[Lldb-commits] [lldb] [lldb] Fix TestGdbRemoteForkNonStop.py test (PR #131293)

2025-03-19 Thread Georgiy Samoylov via lldb-commits
https://github.com/sga-sc updated https://github.com/llvm/llvm-project/pull/131293 >From cb1c55bd6015520a1b0834546d083f22823d1d2e Mon Sep 17 00:00:00 2001 From: Georgiy Samoylov Date: Mon, 17 Mar 2025 19:21:22 +0300 Subject: [PATCH 1/2] [lldb] Adapted test for remote debugging case --- .../Py

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-19 Thread Vy Nguyen via lldb-commits
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() { bool Process::SetExitStatus(int status, llvm::StringRef exit_string) { // Use a mutex to protect setting the exit status. std::lock_guard guard(m_exit_status_mutex); + telemetry::ScopedDispatcher helper; +

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-03-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes New changes: add check to avoid accessing invalid obj --- Full diff: https://github.com/llvm/llvm-project/pull/132043.diff 5 Files Affected: - (modified) lldb/include/lldb/Core/Telemetry.h (+68-6) - (modifi

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-03-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/132043 New changes: add check to avoid accessing invalid obj >From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Mar 2025 10:44:12 -0400 Subject: [PATCH 1/2] Reapply

[Lldb-commits] [lldb] [lldb] Use UnwindPlan::Row as values, part 2 (PR #132008)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🚚 https://github.com/llvm/llvm-project/pull/132008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-03-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 67a01131a8d70fcd06c6bd9cea30a8a6262c8c94 8a84a2e3328d7058917a63693632bacb0357f639 --e

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread Santhosh Kumar Ellendula via lldb-commits
@@ -463,6 +463,8 @@ void InitializeRequestHandler::operator()( body.try_emplace("supportsDataBreakpoints", true); // The debug adapter supports the `readMemory` request. body.try_emplace("supportsReadMemoryRequest", true); + // The debug adapter supports the 'writeMemory

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread John Harrison via lldb-commits
@@ -112,3 +112,23 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-19 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/131916 >From 6aa311afe9832bbd4a4118874e411243b05e490d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 18 Mar 2025 14:03:12 -0700 Subject: [PATCH 1/6] [lldb-dap] Ensure logging statements are written as a single

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-19 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > Btw, the x86_64 macOS bots are still failing: > https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10698/execution/node/102/log/?consoleFull Where is this reported? I did not see it in any of the commit annotations in Github. > I think it'd make sense for the

[Lldb-commits] [lldb] [LLDB][NFC]Refactor common test setup into SetUp method (PR #131203)

2025-03-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/131203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread John Harrison via lldb-commits
@@ -0,0 +1,147 @@ +//===-- WriteMemoryRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb-dap] Stop linking explicitly against pthread (PR #132111)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/132111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > oh, that regression test will need to be added to the swiftlang cherrypick. Nice! I've added it to that PR. https://github.com/llvm/llvm-project/pull/132079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Move two methods from Platfrom -> Host (NFC) (PR #132119)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/132119 This moves two functions from Platform to Host: 1. GetCurrentXcodeToolchainDirectory 2. GetCurrentCommandLineToolsDirectory. These two functions caused a layering violation in the Swift fork, which add

[Lldb-commits] [lldb] 2e5a751 - [lldb-dap] Stop linking explicitly against pthread (#132111)

2025-03-19 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-19T15:59:56-07:00 New Revision: 2e5a751ee95026dab7056f779e4df3fc75e8803a URL: https://github.com/llvm/llvm-project/commit/2e5a751ee95026dab7056f779e4df3fc75e8803a DIFF: https://github.com/llvm/llvm-project/commit/2e5a751ee95026dab7056f779e4df3fc75e8803a.d

[Lldb-commits] [lldb] [lldb-dap] Stop linking explicitly against pthread (PR #132111)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Looking [around > llvm](https://github.com/search?q=repo%3Allvm%2Fllvm-project%20HAVE_LIBPTHREAD&type=code) > is this the only place using that check? Could this be cleaned up in other > places as well? Yeah, I can't find any other uses. Let me remove that in a separate

[Lldb-commits] [lldb] [lldb-dap] Stop linking explicitly against pthread (PR #132111)

2025-03-19 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. Looking [around llvm](https://github.com/search?q=repo%3Allvm%2Fllvm-project%20HAVE_LIBPTHREAD&type=code) is this the only place using that check? Could this be cleaned up in other places as well? https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] 09b0e56 - [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (#132079)

2025-03-19 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-03-19T20:07:28-03:00 New Revision: 09b0e5624c7673cffd84a497c4b6ac7a41c59269 URL: https://github.com/llvm/llvm-project/commit/09b0e5624c7673cffd84a497c4b6ac7a41c59269 DIFF: https://github.com/llvm/llvm-project/commit/09b0e5624c7673cffd84a497c4b6ac7a4

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-19 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen closed https://github.com/llvm/llvm-project/pull/131200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-19 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/132128 This fixes an uncommon bug with debugserver controlling an inferior process that is hitting an internal breakpoint & continuing when multiple interrupts are sent by SB API to lldb. In the reproducing setu

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-19 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen edited https://github.com/llvm/llvm-project/pull/131200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/131820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (PR #132128)

2025-03-19 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/132128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I left a few small comments but overall this looks good. The approach is slightly different from how I expected you to implement this. Note that I don't know if it's actually better, it's more of a "if I had to implement this, that's how I would have started." You've been

[Lldb-commits] [lldb] 460c0f5 - [lldb] Move two methods from Platfrom -> Host (NFC) (#132119)

2025-03-19 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-19T22:22:01-07:00 New Revision: 460c0f567cc83378d4aafd9fba95561bacf57fe4 URL: https://github.com/llvm/llvm-project/commit/460c0f567cc83378d4aafd9fba95561bacf57fe4 DIFF: https://github.com/llvm/llvm-project/commit/460c0f567cc83378d4aafd9fba95561bacf57fe4.d

[Lldb-commits] [lldb] 571e4de - [lldb] Use UnwindPlan::Row as values (#131150)

2025-03-19 Thread via lldb-commits
Author: Pavel Labath Date: 2025-03-19T12:22:26+01:00 New Revision: 571e4de02ee527ef6d0399008fb57440e51c5d22 URL: https://github.com/llvm/llvm-project/commit/571e4de02ee527ef6d0399008fb57440e51c5d22 DIFF: https://github.com/llvm/llvm-project/commit/571e4de02ee527ef6d0399008fb57440e51c5d22.diff

[Lldb-commits] [lldb] [lldb] Use UnwindPlan::Row as values (PR #131150)

2025-03-19 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/131150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use UnwindPlan::Row as values, part 2 (PR #132008)

2025-03-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-hexagon Author: Pavel Labath (labath) Changes This is the mechanical part of #131150. I'm also removing the interfaces taking a RowSP. --- Patch is 46.65 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb] Use UnwindPlan::Row as values, part 2 (PR #132008)

2025-03-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is the mechanical part of #131150. I'm also removing the interfaces taking a RowSP. --- Patch is 46.65 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/132008.d

[Lldb-commits] [lldb] [lldb] Use UnwindPlan::Row as values, part 2 (PR #132008)

2025-03-19 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/132008 This is the mechanical part of #131150. I'm also removing the interfaces taking a RowSP. >From bbd56611f21f3ed65b7c31d562500776645a3e15 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 19 Mar 2025 12:40:3

[Lldb-commits] [lldb] [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (PR #131917)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/131917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-03-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/131800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid having to list all the headers in headers.swig (PR #131934)

2025-03-19 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Good idea. I don't think it's even a question of "shipping" as swig processing happens at (lldb) build time. After that, we don't care whether the header exists or not. https://github.com/llvm/llvm-project/pull/131934 __

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-19 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/131645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-19 Thread Michael Buch via lldb-commits
Michael137 wrote: Btw, the x86_64 macOS bots are still failing: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10698/execution/node/102/log/?consoleFull ``` Failed Tests (2): lldb-api :: functionalities/reverse-execution/TestReverseContinueBreakpoints.py lldb-api :: funct

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Pavel Labath via lldb-commits
@@ -1692,6 +1692,20 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +struct APILock { + APILock(std::recursive_mutex &mutex) : lock(mutex) {} + std::lock_guard lock; +}; + +/// The private implementation used by

[Lldb-commits] [lldb] 7dbcdd5 - Revert "[LLDB][Telemetry]Define TargetInfo for collecting data about a target (#127834)"

2025-03-19 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-03-19T09:51:10+01:00 New Revision: 7dbcdd578cd4d37b1f4094dbd17556be6382f1cc URL: https://github.com/llvm/llvm-project/commit/7dbcdd578cd4d37b1f4094dbd17556be6382f1cc DIFF: https://github.com/llvm/llvm-project/commit/7dbcdd578cd4d37b1f4094dbd17556be6382f1cc.diff

[Lldb-commits] [lldb] [lldb] Fix prologue size calculation for discontinuous functions (PR #131597)

2025-03-19 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/131597 >From 9874a78efa086dfc3168a514051a521964ad55f3 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 17 Mar 2025 11:12:44 +0100 Subject: [PATCH 1/2] [lldb] Fix prologue size calculation for discontinuous functi

[Lldb-commits] [lldb] [lldb] Fix prologue size calculation for discontinuous functions (PR #131597)

2025-03-19 Thread Pavel Labath via lldb-commits
@@ -662,10 +662,12 @@ uint32_t Function::GetPrologueByteSize() { } } -const addr_t func_start_file_addr = -m_range.GetBaseAddress().GetFileAddress(); -const addr_t func_end_file_addr = -func_start_file_addr + m_range.Ge

[Lldb-commits] [lldb] 861efd4 - [lldb] Skip reverse continue tests on x86_64-darwin

2025-03-19 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-03-19T13:35:14+01:00 New Revision: 861efd4b3f93d30d353f0a6eea249fbdac1778a0 URL: https://github.com/llvm/llvm-project/commit/861efd4b3f93d30d353f0a6eea249fbdac1778a0 DIFF: https://github.com/llvm/llvm-project/commit/861efd4b3f93d30d353f0a6eea249fbdac1778a0.diff

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,142 @@ +//===-- WriteMemoryRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-19 Thread Pavel Labath via lldb-commits
labath wrote: > Should we perhaps skip this on intel+macOS? 861efd4b3f93d30d353f0a6eea249fbdac1778a0 > Maybe disabling tests for macOS < 15 would be OK even in the long term? There > isn't any looming plan to actually use this code on macOS < 15. The main > reason to run these tests on non-

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,142 @@ +//===-- WriteMemoryRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[Lldb-commits] [lldb] [lldb] Fix TestGdbRemoteForkNonStop.py test (PR #131293)

2025-03-19 Thread Georgiy Samoylov via lldb-commits
https://github.com/sga-sc updated https://github.com/llvm/llvm-project/pull/131293 >From 09aa2a57cdc4be801589141390c02d0f1991cf45 Mon Sep 17 00:00:00 2001 From: Georgiy Samoylov Date: Wed, 19 Mar 2025 15:50:00 +0300 Subject: [PATCH 1/2] [lldb] Rewrote with lldbutil function --- .../tools/lldb

[Lldb-commits] [lldb] [lldb] Fix TestGdbRemoteForkNonStop.py test (PR #131293)

2025-03-19 Thread Georgiy Samoylov via lldb-commits
@@ -743,6 +743,20 @@ def getBuildArtifact(self, name="a.out"): """Return absolute path to an artifact in the test's build directory.""" return os.path.join(self.getBuildDir(), name) +def get_process_working_directory(self): +"""Get the working dire

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -27,6 +27,7 @@ def test_default(self): lines = output.splitlines() self.assertIn(program, lines[0], "make sure program path is in first argument") +@skipIfWindows vogelsgesang wrote: why? Did this work previously and was now broken by

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -463,6 +463,8 @@ void InitializeRequestHandler::operator()( body.try_emplace("supportsDataBreakpoints", true); // The debug adapter supports the `readMemory` request. body.try_emplace("supportsReadMemoryRequest", true); + // The debug adapter supports the `cancel` req

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestGdbRemoteForkNonStop.py test (PR #131293)

2025-03-19 Thread Georgiy Samoylov via lldb-commits
@@ -743,6 +743,20 @@ def getBuildArtifact(self, name="a.out"): """Return absolute path to an artifact in the test's build directory.""" return os.path.join(self.getBuildDir(), name) +def get_process_working_directory(self): +"""Get the working dire

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb] s/ValidRange/ValidRanges in UnwindPlan (PR #127661)

2025-03-19 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/127661 >From 064801d84f1b4ae0255d666b7f846d0f8e034cd3 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 18 Feb 2025 16:14:30 +0100 Subject: [PATCH] [lldb] s/ValidRange/ValidRanges in UnwindPlan To be able to descr

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
@@ -1692,6 +1692,20 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +struct APILock { + APILock(std::recursive_mutex &mutex) : lock(mutex) {} + std::lock_guard lock; +}; + +/// The private implementation used by

[Lldb-commits] [lldb] [lldb] Change test paths to resolve symlinks (PR #132053)

2025-03-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Peixotto (dmpots) Changes This commit modifes the `getSourceDir()` and `getBuildDir()` functions to use os.path.realpath to resolve symlinks in the Base test class used for API tests. A few tests were failing when the build and sourc

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > The one remaining question seems to be: Should we also support (and test) > this API from Python? Also see comments in the RFC Yup, this patch now makes SBlock available from Python and Lua. I didn't add the test yet because I wanted to add the `__enter__` and `__exit__`

[Lldb-commits] [lldb] [lldb] s/ValidRange/ValidRanges in UnwindPlan (PR #127661)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/127661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-19 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/131916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-19 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/130104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/131404 >From ab4700b007becba1dfe63310bbb2a627214b6a60 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 19 Mar 2025 10:39:50 -0700 Subject: [PATCH] [lldb] Expose the Target API lock through the SB API -

[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-03-19 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/131979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebased + implement the Python extension. https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/131404 >From 180e736b110c3ba6ba36719326138b6cece5a51b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 14 Mar 2025 15:19:58 -0700 Subject: [PATCH] [lldb] Expose the Target API lock through the SB API -

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -394,6 +394,13 @@ class TestGetTargetBreakpointsRequestHandler : public LegacyRequestHandler { void operator()(const llvm::json::Object &request) const override; }; +class WriteMemoryRequestHandler : public LegacyRequestHandler { +public: + using LegacyRequestHandler::L

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-03-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/132043 >From 9f0a47af2b7fdb90e4fa4cc7f8f97c840af1d2bc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Mar 2025 10:44:12 -0400 Subject: [PATCH 1/3] Reapply "[LLDB][Telemetry]Define TargetInfo for collecting data

[Lldb-commits] [lldb] [lldb/gdb-remote] Do not crash on an invalid server response (PR #131979)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/131979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [LLDB][NFC] Fix typo in docs (PR #131388)

2025-03-19 Thread Benjamin Maxwell via lldb-commits
MacDue wrote: `kon72` does not have commit access, so @labath you should probably land this if you know the change is correct :) https://github.com/llvm/llvm-project/pull/131388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Jonas Devlieghere via lldb-commits
@@ -1692,6 +1692,20 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +struct APILock { + APILock(std::recursive_mutex &mutex) : lock(mutex) {} + std::lock_guard lock; +}; + +/// The private implementation used by

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread John Harrison via lldb-commits
@@ -96,7 +115,7 @@ Expected> Transport::Read() { return createStringError( formatv("invalid content length {0}", *raw_length).str()); - Expected raw_json = ReadFull(*input, length); ashgti wrote: Also, frustrating on Windows stdin is an anonymous

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Dave Lee via lldb-commits
https://github.com/kastiglione approved this pull request. https://github.com/llvm/llvm-project/pull/132079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Dave Lee via lldb-commits
kastiglione wrote: oh, that regression test will need to be added to the swiftlang cherrypick. https://github.com/llvm/llvm-project/pull/132079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: The one remaining question seems to be: Should we also support (and test) this from Python? Also see comments in the RFC https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Dave Lee via lldb-commits
kastiglione wrote: Here's a regression test: ``` diff --git a/lldb/test/API/lang/swift/async/expr/TestSwiftAsyncExpressions.py b/lldb/test/API/lang/swift/async/expr/TestSwiftAsyncExpressions.py index 1510faa5820d..8cc699b3f0bf 100644 --- a/lldb/test/API/lang/swift/async/expr/TestSwiftAsyncExpre

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-03-19 Thread via lldb-commits
jimingham wrote: > > I think something like that might work. > > Clarification: that will work only for cases if there are `VariableObject` > for each variable and they are checked. If, for instance, non-persistent > variable holds reference to persistent variable and only `MemoryCacheId` is

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,142 @@ +//===-- WriteMemoryRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-03-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 1/3] [LLDB][Telemetry] Collect telemetry from client when allowed. T

[Lldb-commits] [lldb] Reapply LLDB-Telemetry TargetInfo branch (pr/127834) (PR #132043)

2025-03-19 Thread Vy Nguyen via lldb-commits
oontvoo wrote: @labath Hi, friendly ping? thanks https://github.com/llvm/llvm-project/pull/132043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/132079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5720a79 - [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (#131917)

2025-03-19 Thread via lldb-commits
Author: John Harrison Date: 2025-03-19T08:49:52-07:00 New Revision: 5720a792a950f46a9b1ebdf0b658b76dc02a9833 URL: https://github.com/llvm/llvm-project/commit/5720a792a950f46a9b1ebdf0b658b76dc02a9833 DIFF: https://github.com/llvm/llvm-project/commit/5720a792a950f46a9b1ebdf0b658b76dc02a9833.diff

[Lldb-commits] [lldb] [lldb-dap] Ensure logging statements are written as a single chunk. (PR #131916)

2025-03-19 Thread John Harrison via lldb-commits
@@ -0,0 +1,31 @@ +//===-- DAPLog.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Waiting for the test binary to exit prior to dumping logs. (PR #131917)

2025-03-19 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/131917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-19 Thread Daniel Chen via lldb-commits
https://github.com/DanielCChen updated https://github.com/llvm/llvm-project/pull/131200 >From 55653ee989d41d4caf5ba5396bb2406dcc443945 Mon Sep 17 00:00:00 2001 From: Daniel Chen Date: Thu, 13 Mar 2025 15:52:23 -0400 Subject: [PATCH 01/10] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DI

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-19 Thread Adrian Vogelsgesang via lldb-commits
@@ -96,7 +115,7 @@ Expected> Transport::Read() { return createStringError( formatv("invalid content length {0}", *raw_length).str()); - Expected raw_json = ReadFull(*input, length); vogelsgesang wrote: we should probably only apply a timeout befo

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-19 Thread John Harrison via lldb-commits
@@ -112,3 +112,23 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/132079 These allow for more efficient saving/restoring state after an expression is evaluated. >From e619ec8d09fec2e0567ad6194f60968e89e40627 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed

[Lldb-commits] [lldb] [lldb] Add RegisterCheckpoint overload for register methods in RegisterContextThreadMemory (PR #132079)

2025-03-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes These allow for more efficient saving/restoring state after an expression is evaluated. --- Full diff: https://github.com/llvm/llvm-project/pull/132079.diff 2 Files Affected: - (modifi