labath wrote:
> Let me know what other info might be useful
It would be useful to know if you can reproduce this problem locally (because I
can't -- the test passes on my mac). If you can't then it would be useful to
get as much information about this buildbot as possible (what kind of
debugs
DhruvSrivastavaX wrote:
Hi @labath @DavidSpickett,
So please let me know if I should add more apis in this PR or this much
granularity is enough.
Also, we are working on 32-bit implementation as well, so I am thinking of
extending the xcoff for the 32 bit as well as it should not take much
a
DhruvSrivastavaX wrote:
These are the previous reference commits for the xcoff support:
[ca4cd08](https://github.com/llvm/llvm-project/commit/ca4cd08fb9d7a03fbd00bca05d5dbfa87cd6db4e),
[0c68606](https://github.com/llvm/llvm-project/commit/0c6860622c249ae7adc784c66a8d0b1335a9e7df)
https://githu
@@ -5,11 +5,11 @@
# RUN: rm -rf %t.existing
# RUN: mkdir -p %t.existing
# RUN: %lldb -o 'diagnostics dump -d %t.existing'
-# RUN: file %t.existing | FileCheck %s
+# RUN: test -d %t.existing && echo "directory" | FileCheck %s
AlexK0 wrote:
Fixed
https://github
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 03a4172a3a4dae7d1ed45570fff66a89e792ca71 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 11 Mar 2025 08:57:13 +
Subject: [PATCH 1/4] [llvm][ItaniumDemangle] Add function name location
tracki
adrian-prantl wrote:
> It would be useful to know if you can reproduce this problem locally (because
> I can't -- the test passes on my mac). If you can't then it would be useful
> to get as much information about this buildbot as possible (what kind of
> debugserver it uses, OS versions and s
adrian-prantl wrote:
May I recommend we add a skip for macOS < 15 to get the bot green again?
https://github.com/llvm/llvm-project/pull/128156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0a21ef9536e0f591d334b230bd388bcb503e27ec
5656cdd65048c0af5482aef7de1e163dd078d437 --e
Michael137 wrote:
> It would be useful to know if you can reproduce this problem locally (because
> I can't -- the test passes on my mac). If you can't then it would be useful
> to get as much information about this buildbot as possible (what kind of
> debugserver it uses, OS versions and such
@@ -63,7 +63,7 @@ def execute(self, test, litConfig):
try:
out, err, exitCode = lit.util.executeCommand(
cmd,
-env=test.config.environment,
+env={**os.environ, **test.config.environment},
AlexK
Michael137 wrote:
FYI, these are also failing on x86_64 on macOS:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10678/
```
Failed Tests (3):
lldb-api ::
functionalities/reverse-execution/TestReverseContinueBreakpoints.py
lldb-api ::
functionalities/reverse-execution/Test
https://github.com/labath commented:
I think something like this makes sense, but if we're doing this, I think we
should do it properly and actually remove the DWARFExpression->SymbolFileDWARF
dependency. We can't do that if `DWARFUnitInterface` is defined in the symbol
file plugin, nor while
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/131658
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-03-18T09:48:34-07:00
New Revision: 7b3455e24ab5aa090e5b2b9ce50c249843c45754
URL:
https://github.com/llvm/llvm-project/commit/7b3455e24ab5aa090e5b2b9ce50c249843c45754
DIFF:
https://github.com/llvm/llvm-project/commit/7b3455e24ab5aa090e5b2b9ce50c249843c45754.d
Author: Pavel Labath
Date: 2025-03-18T17:52:36+01:00
New Revision: 6d38dbf6eb56fd2b3399565af455de96a99ffa0f
URL:
https://github.com/llvm/llvm-project/commit/6d38dbf6eb56fd2b3399565af455de96a99ffa0f
DIFF:
https://github.com/llvm/llvm-project/commit/6d38dbf6eb56fd2b3399565af455de96a99ffa0f.diff
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/131645
>From 464460db7550673bac788ad11e3ed4d45946cd71 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 17 Mar 2025 19:13:20 +0400
Subject: [PATCH 1/2] [LLDB][NFC] Added the interface DWARFUnitInterface to
br
https://github.com/labath approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/131600
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
This is what I've got at 23743f5bf974ed1171fd8123f8d2af0f43be3596:
[success.log](https://github.com/user-attachments/files/19319458/success.log)
https://github.com/llvm/llvm-project/pull/128156
___
lldb-commits mailing list
lldb-commits
https://github.com/igorkudrin closed
https://github.com/llvm/llvm-project/pull/131736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/131836
This is a prototype of highlighting function basenames in LLDB's backtraces.
This is done by tracking information about components of a demangled function
name and plumbing that from the demangler through to
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/131736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -83,6 +99,127 @@ class OutputBuffer {
return std::string_view(Buffer, CurrentPosition);
}
+ // Stores information about parts of a demangled function name.
+ struct FunctionNameInfo {
+///< A [start, end) pair for the function basename.
adrian-p
@@ -83,6 +99,127 @@ class OutputBuffer {
return std::string_view(Buffer, CurrentPosition);
}
+ // Stores information about parts of a demangled function name.
adrian-prantl wrote:
```suggestion
/// Stores information about parts of a demangled functi
@@ -138,10 +139,10 @@ class CPlusPlusLanguage : public Language {
ConstString
GetDemangledFunctionNameWithoutArguments(Mangled mangled) const override;
- bool GetFunctionDisplayName(const SymbolContext *sc,
- const ExecutionContext *exe_ctx,
-
Author: Igor Kudrin
Date: 2025-03-18T09:25:35-07:00
New Revision: 6542cf1973208a83b2f883f2143464c4fdbac9eb
URL:
https://github.com/llvm/llvm-project/commit/6542cf1973208a83b2f883f2143464c4fdbac9eb
DIFF:
https://github.com/llvm/llvm-project/commit/6542cf1973208a83b2f883f2143464c4fdbac9eb.diff
L
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/130503
>From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 9 Mar 2025 12:46:54 +
Subject: [PATCH 01/19] [lldb-dap] implement jump to cursor.
---
lldb/cmake/module
@@ -0,0 +1,76 @@
+//===-- ProtocolEvents.h
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,57 @@
+//===-- EventHandler.h
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/clayborg commented:
Pretty good start. There can be more than one breakpoint at a location and we
need to be sure we test these cases. Like we can have an exception breakpoint
(which might be at `cxa_throw`) and we can have a function breakpoint for this
as well. We need to
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 351bcd9fe229121fac58e051f9a83dce2d3066ae
9a6d64373f45921c5b23460b12544869355ddd15 --e
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/129728
>From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 4 Mar 2025 11:01:46 -0500
Subject: [PATCH 1/2] [LLDB][Telemetry] Collect telemetry from client when
allowed.
T
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 01/21] [LLDB][Telemetry]Define TargetInfo for collecting data
about
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d85a81b4e4cfc0fdc7c259d64f847e7bbeee56d2
4b134946c5f3aa315f5f4cb7cddfa571ff110a6d --e
https://github.com/AlexK0 updated
https://github.com/llvm/llvm-project/pull/131600
>From 2186582c6113033a7adf2c3ac7fb1a6fcde5726c Mon Sep 17 00:00:00 2001
From: Aleksandr Korepanov
Date: Mon, 17 Mar 2025 11:03:57 +0100
Subject: [PATCH 1/2] [LLDB][tests] Transfer APPDATA env for running tests
O
https://github.com/DanielCChen updated
https://github.com/llvm/llvm-project/pull/131200
>From 95377273d069e76023edf7ecc2df473e4e2f4aaa Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23 -0400
Subject: [PATCH 01/10] [compiler-rt] Disable
LLVM_ENABLE_PER_TARGET_RUNTIME_DI
@@ -743,6 +743,20 @@ def getBuildArtifact(self, name="a.out"):
"""Return absolute path to an artifact in the test's build
directory."""
return os.path.join(self.getBuildDir(), name)
+def get_process_working_directory(self):
+"""Get the working dire
@@ -743,6 +743,20 @@ def getBuildArtifact(self, name="a.out"):
"""Return absolute path to an artifact in the test's build
directory."""
return os.path.join(self.getBuildDir(), name)
+def get_process_working_directory(self):
+"""Get the working dire
@@ -5,11 +5,11 @@
# RUN: rm -rf %t.existing
# RUN: mkdir -p %t.existing
# RUN: %lldb -o 'diagnostics dump -d %t.existing'
-# RUN: file %t.existing | FileCheck %s
+# RUN: test -d %t.existing && echo "directory" | FileCheck %s
labath wrote:
I don't think you act
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/131736
After https://reviews.llvm.org/D116539, when `m_gdb_client_up` in
`PlatformRemoteGDBServer` is not null, the connection to a server is expected
to exist. However, `PlatformRemoteGDBServer::DisconnectRemote()
rocallahan wrote:
On Linux ARM64 both gdb and lldb seem to adjust the hardware behavior so that
single-stepping an instruction that fires a watchpoint leaves the PC pointing
to the next instruction.
Maybe this is not true on Mac? I can't test that myself.
https://github.com/llvm/llvm-project/
@@ -201,8 +201,15 @@ def test_watch_address_with_invalid_watch_size(self):
value.GetValueAsUnsigned(), 365, wp_opts, error
)
self.assertFalse(watchpoint)
-self.expect(
-error.GetCString(),
-exe=
rocallahan wrote:
These are the test log packets between the reverse-exec proxy to the
debugserver for the forward singlestep operation:
```
2025-03-17 15:49:10,842 INFO Sending packet vCont;s:4870aa
2025-03-17 15:49:10,843 INFO Received reply
T05thread:4870aa;threads:4870aa;thread-pcs:
@@ -0,0 +1,147 @@
+//===-- WriteMemoryRequestHandler.cpp
+//--===//
JDevlieghere wrote:
```suggestion
//===-- WriteMemoryRequestHandler.cpp -===//
```
https://github.com/llvm/llvm-project/pu
@@ -0,0 +1,147 @@
+//===-- WriteMemoryRequestHandler.cpp
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,147 @@
+//===-- WriteMemoryRequestHandler.cpp
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 01/25] [LLDB][Telemetry]Define TargetInfo for collecting data
about
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130169
>From 6bb322fd3ed0df56adcb2bc4687f89ee7f4cdf5f Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 27 Feb 2025 15:17:15 -0800
Subject: [PATCH] [lldb-dap] Adding support for cancelling a request.
Adding suppo
@@ -67,7 +67,7 @@ static Status ReadExpected(IOObjectSP &descriptor,
llvm::StringRef expected) {
if (status.Fail())
return status;
if (expected != result) {
-return Status::FromErrorStringWithFormatv("expected %s, got %s", expected,
+return Status::FromErrorStr
@@ -348,6 +351,71 @@ llvm::json::Value toJSON(const ExitedEventBody &);
// MARK: Requests
+// "CancelRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `cancel` request is used by the client in two
+//
@@ -152,6 +153,8 @@ struct Response {
bool fromJSON(const llvm::json::Value &, Response &, llvm::json::Path);
llvm::json::Value toJSON(const Response &);
+using VoidResponseBody = std::nullptr_t;
ashgti wrote:
Done.
https://github.com/llvm/llvm-project/pull/
@@ -0,0 +1,56 @@
+//===-- SourceRequestHandler.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
kastiglione wrote:
@luporl I have a fix, I'll share the link soon.
https://github.com/llvm/llvm-project/pull/131475
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,44 +9,66 @@
#ifndef LLDB_TOOLS_LLDB_DAP_DAPLOG_H
#define LLDB_TOOLS_LLDB_DAP_DAPLOG_H
+#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
#include "llvm/Support/FormatAdapters.h"
#include "llvm/Support/FormatVariadic.h"
#include
#include
+#include
#
Author: Jonas Devlieghere
Date: 2025-03-18T19:56:04-07:00
New Revision: 40885572783b1b1d3fe5dc7bce119f08728dc11f
URL:
https://github.com/llvm/llvm-project/commit/40885572783b1b1d3fe5dc7bce119f08728dc11f
DIFF:
https://github.com/llvm/llvm-project/commit/40885572783b1b1d3fe5dc7bce119f08728dc11f.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/131943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131943
>From c9770d124155beabcb133e47a5d798d22bcb7de2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 18 Mar 2025 17:47:26 -0700
Subject: [PATCH 1/2] [lldb-dap] Move request capabilities into request
oontvoo wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-03-18T22:54:08-04:00
New Revision: 04e39ce3fddaaec41d9c7babcca55133d7e49969
URL:
https://github.com/llvm/llvm-project/commit/04e39ce3fddaaec41d9c7babcca55133d7e49969
DIFF:
https://github.com/llvm/llvm-project/commit/04e39ce3fddaaec41d9c7babcca55133d7e49969.diff
LOG
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/131836
>From 03a4172a3a4dae7d1ed45570fff66a89e792ca71 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 11 Mar 2025 08:57:13 +
Subject: [PATCH 1/4] [llvm][ItaniumDemangle] Add function name location
tracki
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
+
+ /// The same as the executable-module
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes an exit status.
+struct ExitDescription {
+ int exit_code;
+ std::string description;
+};
+
@@ -1066,6 +1067,26 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
JDevlieghere wrote:
```suggestion
struct ExecutableM
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
+
+ /// The same as the executable-module
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes an exit status.
+struct ExitDescription {
+ int exit_code;
+ std::string description;
+};
+
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
+
+ /// The same as the executable-module
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
+
+ /// The same as the executable-module
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
JDevlieghere wrote:
Let'
@@ -66,6 +75,40 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes an exit status.
+struct ExitDescription {
+ int exit_code;
+ std::string description;
+};
+
oontvoo wrote:
Hi, friendly ping? @JDevlieghere thanks!
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -76,15 +76,36 @@ void CommandInfo::serialize(Serializer &serializer) const {
serializer.write("error_data", error_data.value());
}
+std::atomic CommandInfo::g_command_id_seed = 0;
+uint64_t CommandInfo::GetNextId() { return g_command_id_seed.fetch_add(1); }
satyajanga wrote:
> Pretty good start. There can be more than one breakpoint at a location and we
> need to be sure we test these cases. Like we can have an exception breakpoint
> (which might be at `cxa_throw`) and we can have a function breakpoint for
> this as well. We need to make sure we
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/130104
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -316,6 +316,36 @@ struct Source {
bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path);
llvm::json::Value toJSON(const Source &);
+// MARK: Events
+
+// "ExitedEvent": {
+// "allOf": [ { "$ref": "#/definitions/Event" }, {
+// "type": "object",
+//
@@ -112,3 +112,23 @@ def test_readMemory(self):
# Reads at offset 0x0 fail
mem = self.dap_server.request_readMemory("0x0", 0, 6)
self.assertEqual(mem["success"], False)
+
+def test_writeMemory(self):
+"""
+Tests the 'writeMemory' requ
@@ -0,0 +1,147 @@
+//===-- WriteMemoryRequestHandler.cpp
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -14,11 +14,11 @@
#ifndef LLDB_TOOLS_LLDB_DAP_TRANSPORT_H
#define LLDB_TOOLS_LLDB_DAP_TRANSPORT_H
+#include "DAPLog.h"
vogelsgesang wrote:
is a forward declaration sufficient?
https://github.com/llvm/llvm-project/pull/131916
___
@@ -1145,4 +1145,33 @@ lldb::SBValue Variables::FindVariable(uint64_t
variablesReference,
return variable;
}
+llvm::StringMap DAP::GetCapabilities() {
+ llvm::StringMap capabilities;
+
+ // Supported capabilities.
+ capabilities["supportTerminateDebuggee"] = true;
+ cap
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This distributes the registration of request related capabilities to the
corresponding request handler. Global and unsupported capabilities are
registered at the DAP level.
---
Full diff: https://g
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/131943
This distributes the registration of request related capabilities to the
corresponding request handler. Global and unsupported capabilities are
registered at the DAP level.
>From f2d2cf931ab65612303178c57
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131943
>From c9770d124155beabcb133e47a5d798d22bcb7de2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 18 Mar 2025 17:47:26 -0700
Subject: [PATCH] [lldb-dap] Move request capabilities into request handl
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/131916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1145,4 +1145,33 @@ lldb::SBValue Variables::FindVariable(uint64_t
variablesReference,
return variable;
}
+llvm::StringMap DAP::GetCapabilities() {
+ llvm::StringMap capabilities;
+
+ // Supported capabilities.
+ capabilities["supportTerminateDebuggee"] = true;
+ cap
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/131943
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
I noticed this while debugging some unit tests that the logs occasionally would
intersperse two log statements.
Previously, it was possible for a log statement to have two messages
interspersed since the tim
JDevlieghere wrote:
Rebase on top of #131658: The unit test should pass now.
https://github.com/llvm/llvm-project/pull/131404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131404
>From cd65c4cf07b5b2f03fd1f2ebe8d586b4d1bbc062 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 14 Mar 2025 15:19:58 -0700
Subject: [PATCH 1/4] [lldb] Expose the Target API lock through the SB AP
https://github.com/JDevlieghere approved this pull request.
LGTM modulo nits.
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/daltenty edited
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
+
+ /// The same as the executable-module
@@ -146,6 +155,59 @@ struct DebuggerInfo : public LLDBBaseTelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+struct ExecModuleInfo : public LLDBBaseTelemetryInfo {
+ lldb::ModuleSP exec_mod;
oontvoo wrote:
done
htt
rocallahan wrote:
@jasonmolenda Pavel Labath thought you might have some insight here. Thanks.
https://github.com/llvm/llvm-project/pull/128156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
@@ -109,7 +109,7 @@ if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
extend_path(default_install_path "${COMPILER_RT_INSTALL_PATH}" lib)
set(COMPILER_RT_INSTALL_LIBRARY_DIR "${default_install_path}" CACHE PATH
"Path where built compiler-rt libraries should be instal
@@ -76,15 +76,36 @@ void CommandInfo::serialize(Serializer &serializer) const {
serializer.write("error_data", error_data.value());
}
+std::atomic CommandInfo::g_command_id_seed = 0;
+uint64_t CommandInfo::GetNextId() { return g_command_id_seed.fetch_add(1); }
@@ -1559,10 +1560,29 @@ void Target::DidExec() {
void Target::SetExecutableModule(ModuleSP &executable_sp,
LoadDependentFiles load_dependent_files) {
+ telemetry::ScopedDispatcher helper(&m_debugger);
Log *log = GetLog(LLDBLog::Target);
1 - 100 of 130 matches
Mail list logo