[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,42 @@ +//===-- StatuslineTest.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,200 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,200 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/130768 WebKit does things like the following: ``` @class NSString; class NSString; ``` This would produce DWARF where `NSString` is a C++ forward declaration in a C++ CU, and an Objective-C forward declaration in an

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes WebKit does things like the following: ``` @class NSString; class NSString; ``` This would produce DWARF where `NSString` is a C++ forward declaration in a C++ CU, and an Objective-C forward declaration in

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Michael Buch via lldb-commits
@@ -351,6 +351,41 @@ static void PrepareContextToReceiveMembers(TypeSystemClang &ast, } } +/// Returns \c true if a forward declaration in C or C++ is actually an +/// Objective-C++ forward declaration. Otherwise, or on error, returns +/// \c false. +static bool IsCppForwar

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: > I don't know if you have worked on LLVM before but regardless, thank you for > making use of the nice error handling patterns we have. Even if sometimes > they're a bit too much. > I don't have any major problems with this, just some style points and a > couple of th

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: @labath @DavidSpickett I am done with the update of the files, I have compiled and checked the changes based on your mentioned comments. The only doubt I have is am I required to replace Status with llvm::Error/Expected at any other places too? Please feel free go thro

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/125843 >From 48e900c6a8bd24c7cbee057eb0d96b9f0b2b4f84 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 5 Feb 2025 10:11:38 + Subject: [PATCH 1/3] [lldb-dap] Support vscode launch URLs This commit

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Michael Buch via lldb-commits
@@ -351,6 +351,41 @@ static void PrepareContextToReceiveMembers(TypeSystemClang &ast, } } +/// Returns \c true if a forward declaration in C or C++ is actually an +/// Objective-C++ forward declaration. Otherwise, or on error, returns +/// \c false. +static bool IsCppForwar

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/11] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130653 >From 88f1cf3469c9f24a768f5147c22cfe414aea014e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Sat, 8 Mar 2025 17:55:34 -0800 Subject: [PATCH 1/3] [lldb-dap] Adding logging helpers. Improving logging by defin

[Lldb-commits] [lldb] [lldb] Preparation for DWARF indexing speedup (PR #123732)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: That is correct. https://github.com/llvm/llvm-project/pull/123732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread John Harrison via lldb-commits
@@ -239,14 +241,7 @@ void DAP::SendJSON(const llvm::json::Value &json) { std::lock_guard locker(mutex); SendJSON(json_str); - if (log) { -auto now = std::chrono::duration( -std::chrono::system_clock::now().time_since_epoch()); -*log << llvm::formatv("{0:f9

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread John Harrison via lldb-commits
@@ -711,22 +700,15 @@ PacketStatus DAP::GetNextObject(llvm::json::Object &object) { llvm::StringRef json_sref(json); llvm::Expected json_value = llvm::json::parse(json_sref); - if (auto error = json_value.takeError()) { -std::string error_str = llvm::toString(std::mo

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 1/9] [lldb-dap] implement jump to cursor. --- lldb/cmake/modules/

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/118160 >From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 30 Nov 2024 01:14:15 -0600 Subject: [PATCH 1/9] Added base files for NativeProcess for AIX ---

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: oh boy.. this is going to be messy. So what would happen if we treated `class NSString` and `@class NSString` as two distinct types? I guess that would be a problem because then we could end up with duplicate versions of everything that depends on that type (two `void foo(NSStri

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 1/7] [lldb-dap] implement jump to cursor. --- lldb/cmake/modules/

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/130773.diff 2 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py (+12-2) - (modified) lldb/tools/lldb-dap/Ha

[Lldb-commits] [lldb] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (PR #130640)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/130640 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle improperly nested blocks differently (PR #117725)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: > Will this patch cause us to be able to have a `DW_TAG_subprogram` whose range > is `[0x1000-0x2000)` and then have a `DW_AT_lexical_block` whose range > doesn't exist within the `DW_TAG_subprogram` range and we will add it to the > `DW_TAG_subprogram`? I worry because LTO and o

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -711,22 +700,15 @@ PacketStatus DAP::GetNextObject(llvm::json::Object &object) { llvm::StringRef json_sref(json); llvm::Expected json_value = llvm::json::parse(json_sref); - if (auto error = json_value.takeError()) { -std::string error_str = llvm::toString(std::mo

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/130653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -239,14 +241,7 @@ void DAP::SendJSON(const llvm::json::Value &json) { std::lock_guard locker(mutex); SendJSON(json_str); - if (log) { -auto now = std::chrono::duration( -std::chrono::system_clock::now().time_since_epoch()); -*log << llvm::formatv("{0:f9

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/130768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,265 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 1/6] [lldb-dap] implement jump to cursor. --- lldb/cmake/modules/

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-11 Thread Vy Nguyen via lldb-commits
oontvoo wrote: > I find it confusing to use the same entry type for > `Target::SetExecutableModule` and `Process::SetExitStatus`. I think it just > doesn't match the lldb object model. I suspect you somehow want to bracket > the existence of a process between a "start" and "exit" events, but t

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -240,6 +240,137 @@ using Message = std::variant; bool fromJSON(const llvm::json::Value &, Message &, llvm::json::Path); llvm::json::Value toJSON(const Message &); +// MARK: Types + +// "Source": { +// "type": "object", +// "description": "A `Source` is a descriptor for

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-11 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I find it confusing to use the same entry type for `Target::SetExecutableModule` and `Process::SetExitStatus`. I think it just doesn't match the lldb object model. I suspect you somehow want to bracket the existence of a process between a "start" and "exit"

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-11 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle improperly nested blocks differently (PR #117725)

2025-03-11 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/117725 >From a2fe723ccfce64c3ccef67bbc75deba050d8dcc2 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 26 Nov 2024 16:12:40 +0100 Subject: [PATCH] [lldb] Handle improperly nested blocks differently In 6c7f56192fa

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,144 @@ +//===-- Transport.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,64 @@ +""" +Make sure 'frame var' using DIL parser/evaultor works for local variables. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + +import os +import shutil +import time + + +

[Lldb-commits] [lldb] [lldb] s/ValidRange/ValidRanges in UnwindPlan (PR #127661)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: Ping https://github.com/llvm/llvm-project/pull/127661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preparation for DWARF indexing speedup (PR #123732)

2025-03-11 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123732 >From 9227e1c8f63fb037f140db0276dc1a6e2d9bb0d6 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 21 Jan 2025 11:50:31 +0100 Subject: [PATCH] [lldb] Preparation for DWARF indexing speedup This is part of the

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,103 @@ +//===-- GoToRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,103 @@ +//===-- GoToRequestHandler.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,120 @@ +//===-- GoToTargetsRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,11 @@ + +int main() { + + int var_1 = 10; + + var_1 = 20; // breakpoint 1 + + int var_2 = 40; // goto 1 + + return 0; +} vogelsgesang wrote: missing trailing new line https://github.com/llvm/llvm-project/pull/130503 ___

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,120 @@ +//===-- GoToTargetsRequestHandler.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,59 @@ +""" +Test lldb-dap gotoTarget request +""" + +from lldbsuite.test.lldbtest import line_number +import lldbdap_testcase +import os + + +class TestDAP_gotoTarget(lldbdap_testcase.DAPTestCaseBase): +def test_default(self): +""" +Tests the jump to

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,120 @@ +//===-- GoToTargetsRequestHandler.cpp +//--===// vogelsgesang wrote: incorrect linebreak in comment https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commi

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -79,6 +79,27 @@ enum class PacketStatus { enum class ReplMode { Variable = 0, Command, Auto }; +class Gotos { +public: + /// \return the line_entry corresponding with \p id + /// + /// If \p id is invalid std::nullopt is returned. + std::optional GetLineEntry(uint64_t

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -50,6 +50,8 @@ add_lldb_tool(lldb-dap Handler/DisconnectRequestHandler.cpp Handler/EvaluateRequestHandler.cpp Handler/ExceptionInfoRequestHandler.cpp +Handler/GoToRequestHandler.cpp +Handler/GoToTargetsRequestHandler.cpp vogelsgesang wr

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/118160 >From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 30 Nov 2024 01:14:15 -0600 Subject: [PATCH 1/8] Added base files for NativeProcess for AIX ---

[Lldb-commits] [lldb] cdd560e - [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (#130640)

2025-03-11 Thread via lldb-commits
Author: Michael Buch Date: 2025-03-11T08:13:05Z New Revision: cdd560eead457bcc6dbb28ef88d868bc68cfd7e6 URL: https://github.com/llvm/llvm-project/commit/cdd560eead457bcc6dbb28ef88d868bc68cfd7e6 DIFF: https://github.com/llvm/llvm-project/commit/cdd560eead457bcc6dbb28ef88d868bc68cfd7e6.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,146 @@ +//===-- Transport.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,146 @@ +//===-- Transport.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,58 @@ +//===-- DAPLog.h --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,146 @@ +//===-- Transport.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -838,19 +770,12 @@ llvm::Error DAP::Loop() { StopEventHandlers(); }); while (!disconnecting) { -llvm::json::Object object; -lldb_dap::PacketStatus status = GetNextObject(object); - -if (status == lldb_dap::PacketStatus::EndOfFile) { +std::optional nex

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: Ping. Jason, Adrian, I was waiting for you to submit this when you're ready to deal with the fallout, but maybe I should just submit that now? https://github.com/llvm/llvm-project/pull/128156 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/118160 >From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Sat, 30 Nov 2024 01:14:15 -0600 Subject: [PATCH 1/7] Added base files for NativeProcess for AIX ---

[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: > > You could make the test binary a cmake dependency, see > > `lldb/test/CMakeLists.txt`. Perhaps in: > > ``` > > if(TARGET lldb-server) > > add_lldb_test_dependency(lldb-server) > > endif() > > ``` > > Just so it's clear, it is not lldb-server itself that is the slow dependenc

[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: > > The test really is big and splitting it up is a good idea, but instead of > > an arbitrary 1/2/3 split, I think it be better to do it by functionality. > > Looking at the part of the code you moved, I can see several "themes" that > > we could use to split this up. One of the

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -46,12 +50,17 @@ struct LLDBConfig : public ::llvm::telemetry::Config { // Specifically: // - Length: 8 bits // - First two bits (MSB) must be 11 - the common prefix +// - Last two bits (LSB) are reserved for grand-children of LLDBTelemetryInfo labath wro

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [lldb][Mangled] Use early-return style in GetDemangledName (PR #130622)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/130622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: > > Didn't quite finish, but this is what I have so far. I am wondering about > > the usefulness of the `IdentifierInfo`. It started out its existence in a > > completely different world than what we have now -- where the operations > > were mainly defined on types instead of val

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread David Spickett via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -27,6 +27,10 @@ #include #include +#include labath wrote: ```suggestion #include ``` https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] 7ecb0d0 - [lldb][Mangled] Use early-return style in GetDemangledName (#130622)

2025-03-11 Thread via lldb-commits
Author: Michael Buch Date: 2025-03-11T08:12:46Z New Revision: 7ecb0d03a4d78357adc35137a3109ee305ac4fff URL: https://github.com/llvm/llvm-project/commit/7ecb0d03a4d78357adc35137a3109ee305ac4fff DIFF: https://github.com/llvm/llvm-project/commit/7ecb0d03a4d78357adc35137a3109ee305ac4fff.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > Don't use "${command:pickProcess}" at all. We need to bypass the regular > command logic. You could use a wildcard like ${pickProcess}. Why would we not use `${command:pickProcess}`? Why bypass the regular command logic? We can already determine the `lldb-dap` path inside

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/130773 None >From 3c396684ee07fecbfcaa64a44a469af38e8dcbae Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Tue, 11 Mar 2025 13:15:16 + Subject: [PATCH] [lldb][lldb-dap] setVariable request should send the correc

[Lldb-commits] [lldb] [lldb-dap] Support vscode launch URLs (PR #125843)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,37 @@ +import * as vscode from "vscode"; + +export class LaunchUriHandler implements vscode.UriHandler { +async handleUri(uri: vscode.Uri) { +try { +const params = new URLSearchParams(uri.query); +if (uri.path == '/launch/config') { -

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/130768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 1/5] [lldb-dap] implement jump to cursor. --- lldb/cmake/modules/

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/130582 >From 21fe9850c99b3eae4be65ac34c1f4f9c2d06ab2c Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Mon, 10 Mar 2025 05:39:52 -0500 Subject: [PATCH 1/5] Host.cpp base for AIX --- lldb/source/Host/CMa

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,66 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb-dap] Migrating terminated statistics to the event body. (PR #130454)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/130454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-11 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/129262 >From b40c3e7e4ebb154c5f231676451acbd17e1f39f7 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Fri, 28 Feb 2025 11:08:25 -0500 Subject: [PATCH 1/7] allow providing debug adapter arguments --- lldb/

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-11 Thread Matthew Bastien via lldb-commits
@@ -66,19 +70,17 @@ async function findDAPExecutable(): Promise { } async function getDAPExecutable( - session: vscode.DebugSession, + folder: vscode.WorkspaceFolder | undefined, matthewbastien wrote: Done. https://github.com/llvm/llvm-project/pull/129262

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
@@ -0,0 +1,58 @@ +//===-- DAPLog.h --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (PR #130640)

2025-03-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/130640 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,290 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] Make ELF files able to load section headers from memory. (PR #129166)

2025-03-11 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/129166 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more ARM checks in TestLldbGdbServer.py (PR #130277)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/130277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130026 >From c340c38a82880114471938b19512670d7f94245e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 6 Mar 2025 10:18:36 +0100 Subject: [PATCH 1/4] [lldb-dap] Refactoring IOStream into Transport handler. Inste

[Lldb-commits] [clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-11 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-nvptx64-nvidia-ubuntu` running on `as-builder-7` while building `clang,flang,lldb,llvm,mlir,offload,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/build

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130435 >From 02c34e87db59a0b87887aba479afbab70925241b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sat, 8 Mar 2025 19:47:17 + Subject: [PATCH 1/3] [lldb] fix set SBLineEntryColumn --- lldb/source/API/SBLineE

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130169 Adding support for cancelling requests. There are two forms of request cancellation. * Preemptively cancelling a request that is in the queue. * Actively cancelling the in progress request as a best effort attem

[Lldb-commits] [lldb] [lldb] Fix compile error. (PR #130091)

2025-03-11 Thread Adrian Kuegel via lldb-commits
https://github.com/akuegel created https://github.com/llvm/llvm-project/pull/130091 Followup to https://github.com/llvm/llvm-project/commit/878a64f94a264ea4b564d6063614ddb0b5da3f6c >From a07b4420127fab0008bb0111dc5f49baac6e050e Mon Sep 17 00:00:00 2001 From: Adrian Kuegel Date: Thu, 6 Mar 202

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make ELF files able to load section headers from memory. (PR #129166)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -270,14 +270,48 @@ class ObjectFileELF : public lldb_private::ObjectFile { lldb::SectionType GetSectionType(const ELFSectionHeaderInfo &H) const; static void ParseARMAttributes(lldb_private::DataExtractor &data, - uint64_t length,

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-11 Thread Adrian Prantl via lldb-commits
@@ -247,13 +247,15 @@ static lldb::addr_t GetVTableAddress(Process &process, // We have an object already read from process memory, // so just extract VTable pointer from it - DataExtractor data; - Status err; - auto size = valobj.GetData(data, err); - if (err.Fail() |

[Lldb-commits] [lldb] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (PR #130640)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/130640 >From 4761db28d9c58f633de502cb5fb772e64902a98e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 10 Mar 2025 17:00:11 + Subject: [PATCH] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during X

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130026 Instead of having two discrete InputStream and OutputStream helpers, this merges the two into a unifed 'Transport' handler. This handler is responsible for reading the DAP message headers, parsing the resulting

[Lldb-commits] [lldb] [lldb] Objective-C runtime: Work around a bug in the shared cache builder (PR #130209)

2025-03-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/130209 >From 1dc911414f8bf6441fec6384de046f45e7049870 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 6 Mar 2025 16:33:35 -0800 Subject: [PATCH] [lldb] Objective-C runtime: Work around a bug in the shared

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,66 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb][Mangled] Use early-return style in GetDemangledName (PR #130622)

2025-03-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > This looks good, although the "re-demangling" part sounds scary :) :D I'm trying to provide a way for the demangler to tell LLDB about individual bits of a demangled name (like where the basename starts/ends for example), which we can use in the frame name formatting. Turn

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread David Spickett via lldb-commits
@@ -0,0 +1,256 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 1/8] [lldb-dap] implement jump to cursor. --- lldb/cmake/modules/

[Lldb-commits] [lldb] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130503 >From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 9 Mar 2025 12:46:54 + Subject: [PATCH 01/10] [lldb-dap] implement jump to cursor. --- lldb/cmake/module

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-11 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/16] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130090 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   3   >