[Lldb-commits] [lldb] [LLDB]Fix test crash (PR #129921)

2025-03-05 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129921 >From 38f07a83ff621ae4879e4b0cbc8bd361d0b12a93 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 5 Mar 2025 14:45:24 -0500 Subject: [PATCH 1/4] [LLDB]Fix test crash Unregister the fake manager at end of test

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-05 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/129593 >From bca07d83152df179f7784d0003262fa54834 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Wed, 26 Feb 2025 13:55:35 -0800 Subject: [PATCH 1/4] Avoid force loading symbol files in statistics collection T

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-05 Thread David Peixotto via lldb-commits
@@ -0,0 +1,31 @@ +# RUN: %clang_host -g %S/Inputs/main.c -o %t-main.exe + +# When we enable symbol preload and dump stats there should be a non-zero +# time for parsing symbol tables for the main module. dmpots wrote: Added the comment, thanks! https://github.co

[Lldb-commits] [lldb] [LLDB]Fix test crash (PR #129921)

2025-03-05 Thread Vy Nguyen via lldb-commits
oontvoo wrote: P.S: Verified that it no longer crashed: ``` vyng@web:~/repo/oontvoo/llvm-project/build$ lldb ./tools/lldb/unittests/Core/LLDBCoreTests (lldb) target create "./tools/lldb/unittests/Core/LLDBCoreTests" Current executable set to '~/repo/oontvoo/llvm-project/build/tools/lldb/unitt

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This allows languages to make decisions based on the whole set of symbol contexts, giving them strictly more power than when they are only allowed to see one at a time. --- Full diff: ht

[Lldb-commits] [lldb] 46236f4 - [lldb] Add missing type conversion for Windows

2025-03-05 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2025-03-05T12:58:22-08:00 New Revision: 46236f4c3dbe11e14fe7ac1f4b903637efedfecf URL: https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf DIFF: https://github.com/llvm/llvm-project/commit/46236f4c3dbe11e14fe7ac1f4b903637efedfecf.diff

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/129937 This allows languages to make decisions based on the whole set of symbol contexts, giving them strictly more power than when they are only allowed to see one at a time. >From 3d6a826964326a408b8e3a9d79c

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -207,16 +207,15 @@ bool operator<(const SourceLoc lhs, const SourceLoc rhs) { void BreakpointResolver::SetSCMatchesByLine( SearchFilter &filter, SymbolContextList &sc_list, bool skip_prologue, llvm::StringRef log_ident, uint32_t line, std::optional column) { - llvm:

[Lldb-commits] [lldb] [lldb][Expression] Allow specifying a preferred ModuleList for lookup during expression evaluation (PR #129733)

2025-03-05 Thread via lldb-commits
@@ -332,6 +333,14 @@ class EvaluateExpressionOptions { m_language = SourceLanguage(language_type); } + void SetPreferredSymbolContexts(SymbolContextList modules) { jimingham wrote: Not modules https://github.com/llvm/llvm-project/pull/129733 _

[Lldb-commits] [lldb] [lldb][Expression] Allow specifying a preferred ModuleList for lookup during expression evaluation (PR #129733)

2025-03-05 Thread via lldb-commits
jimingham wrote: You should complete the module -> symbol_context mutatis mutandis. Other than that this seems like the right foundation for adding a user way to control the symbol lookups. https://github.com/llvm/llvm-project/pull/129733 ___ lldb-c

[Lldb-commits] [lldb] [LLDB]Fix test crash (PR #129921)

2025-03-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/129921 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Let languages see all SymbolContexts at once when filtering breakpoints (PR #129937)

2025-03-05 Thread Jonas Devlieghere via lldb-commits
@@ -354,14 +354,13 @@ class Language : public PluginInterface { virtual llvm::StringRef GetInstanceVariableName() { return {}; } - /// Returns true if this SymbolContext should be ignored when setting - /// breakpoints by line (number or regex). Helpful for languages that

[Lldb-commits] [lldb] [lldb][Expression] Allow specifying a preferred ModuleList for lookup during expression evaluation (PR #129733)

2025-03-05 Thread Michael Buch via lldb-commits
Michael137 wrote: > You should complete the module -> symbol_context mutatis mutandis. Other than > that this seems like the right foundation for adding a user way to control > the symbol lookups. I kept the list of preferred contexts as a `ModuleList` in `IRExecutionUnit`. That's why I kept

[Lldb-commits] [lldb] [lldb-dap] Improving EOF handling on stream input and adding new unit tests (PR #129581)

2025-03-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Haven't had a chance to investigate this yet, but this is failing consistently for me locally: ``` FAIL: test_termination (TestDAP_launch.TestDAP_launch) Tests the correct termination of lldb-dap upon a 'disconnect' ---

[Lldb-commits] [lldb] [lldb-dap] Improving EOF handling on stream input and adding new unit tests (PR #129581)

2025-03-05 Thread John Harrison via lldb-commits
ashgti wrote: That is a SIGPIPE, so something is writing after the output is closed. I can try that locally and see if I have the same issue. https://github.com/llvm/llvm-project/pull/129581 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb-dap] Use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER (PR #129948)

2025-03-05 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/129948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER (PR #129948)

2025-03-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/129948 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b5e70d0 - [lldb-dap] Use LLDB_INVALID_LINE_NUMBER & LLDB_INVALID_COLUMN_NUMBER (#129948)

2025-03-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-05T16:19:36-08:00 New Revision: b5e70d06827189cc701b4b02213549cee60c5160 URL: https://github.com/llvm/llvm-project/commit/b5e70d06827189cc701b4b02213549cee60c5160 DIFF: https://github.com/llvm/llvm-project/commit/b5e70d06827189cc701b4b02213549cee60c5160.d

<    1   2