labath wrote:
Thanks.
As we've learned in #123217, all of this relies on parsing the stop reason
strings, and I think the windows strings just don't have the expected format.
https://github.com/llvm/llvm-project/pull/128512
___
lldb-commits mailing l
Author: Pavel Labath
Date: 2025-02-25T09:03:03+01:00
New Revision: 6c17380ea896e9966645958ad3d76441cc25430c
URL:
https://github.com/llvm/llvm-project/commit/6c17380ea896e9966645958ad3d76441cc25430c
DIFF:
https://github.com/llvm/llvm-project/commit/6c17380ea896e9966645958ad3d76441cc25430c.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/128512
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-02-25T09:47:30+01:00
New Revision: 5088e1b435fd06de2bfccd3894dcc2f2c326630f
URL:
https://github.com/llvm/llvm-project/commit/5088e1b435fd06de2bfccd3894dcc2f2c326630f
DIFF:
https://github.com/llvm/llvm-project/commit/5088e1b435fd06de2bfccd3894dcc2f2c326630f.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/128515
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -202,6 +202,10 @@
#cmakedefine LLVM_HAS_LOGF128
/* Define if building LLVM with LLVM_BUILD_TELEMETRY */
+/* DEPRECATED - use LLVM_ENABLE_TELEMETRY */
#cmakedefine LLVM_BUILD_TELEMETRY ${LLVM_BUILD_TELEMETRY}
+/* Define if building LLVM with LLVM_ENABLE_TELEMETRY */
+#cma
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/11957
Here is the relevant piece of the build log
@@ -64,11 +64,19 @@ class Serializer {
/// This struct can be extended as needed to add additional configuration
/// points specific to a vendor's implementation.
struct Config {
- virtual ~Config() = default;
+#ifdef LLVM_ENABLE_TELEMETRY
+ static const bool BuildTimeEnableT
Michael137 wrote:
> Do we only pay the cost when a diagnostic is generated, or every time a
> DW_AT_file is parsed?
Currently it's on creation of the decl
https://github.com/llvm/llvm-project/pull/127829
___
lldb-commits mailing list
lldb-commits@lis
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
return UUID(random_bytes).GetAsString();
}
+void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const {
+ serializer.write("entry_kind", getKind());
+ serializer.write("se
@@ -21,6 +21,8 @@ void TelemetryInfo::serialize(Serializer &serializer) const {
}
Error Manager::dispatch(TelemetryInfo *Entry) {
+ assert(Config::BuildTimeEnableTelemetry &&
+ "Telemetry should have been enabled");
labath wrote:
Won't this be a prob
@@ -64,11 +64,19 @@ class Serializer {
/// This struct can be extended as needed to add additional configuration
/// points specific to a vendor's implementation.
struct Config {
- virtual ~Config() = default;
+#ifdef LLVM_ENABLE_TELEMETRY
+ static const bool BuildTimeEnableT
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/128534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -202,6 +202,10 @@
#cmakedefine LLVM_HAS_LOGF128
/* Define if building LLVM with LLVM_BUILD_TELEMETRY */
+/* DEPRECATED - use LLVM_ENABLE_TELEMETRY */
#cmakedefine LLVM_BUILD_TELEMETRY ${LLVM_BUILD_TELEMETRY}
+/* Define if building LLVM with LLVM_ENABLE_TELEMETRY */
+#cma
https://github.com/labath deleted
https://github.com/llvm/llvm-project/pull/128534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -64,11 +64,19 @@ class Serializer {
/// This struct can be extended as needed to add additional configuration
/// points specific to a vendor's implementation.
struct Config {
- virtual ~Config() = default;
+#ifdef LLVM_ENABLE_TELEMETRY
+ static const bool BuildTimeEnableT
https://github.com/labath commented:
For me the biggest question is what to do with tests when the setting is turned
off, as this makes them run but not succeed. Not running them is one option,
but maybe there's a way to disable this in a sufficiently decisive manner while
leaving a back door
labath wrote:
Yeah, I expect this could be a bit of a problem on several fronts:
- even if the memory usage is low enough to not matter, the fact that we have
to hit the filesystem to load the file is most likely going to slow things
down, particularly when you're using a remote filesystem (lik
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/128750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -17,6 +17,7 @@
#include "lldb/API/SBListener.h"
#include "lldb/API/SBProcess.h"
#include "lldb/API/SBStream.h"
+#include "lldb/Utility/IOObject.h" // IWYU pragma: keep
JDevlieghere wrote:
```suggestion
#include "lldb/Utility/IOObject.h"
```
https://github.
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/128712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. This is a lot cleaner and much less error prone.
https://github.com/llvm/llvm-project/pull/128505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/JDevlieghere commented:
Is it worth keeping `InputStream` and `OutputStream` around? Can we use a
`(Stream)File` directly?
https://github.com/llvm/llvm-project/pull/128750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
@@ -7,125 +7,34 @@
//===--===//
#include "IOStream.h"
+#include "lldb/Utility/IOObject.h" // IWYU pragma: keep
JDevlieghere wrote:
```suggestion
#include "lldb/Utility/IOObject.h"
```
https
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128750
>From b3f60a464deedae59d902f7417c74a64c5cbf5a1 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 24 Feb 2025 15:07:13 -0800
Subject: [PATCH 1/3] [lldb-dap] Use existing lldb::IOObjectSP for IO (NFC).
This
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/128726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Why do we need to touch source files to add a source file attribution from
debug info to a declaration? We don't require the actual presence of source
files in order to make source file attributions anywhere else in the debug info
handling.
Jim
> On Feb 25, 2025, at 2:06 AM
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/6] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
@@ -21,6 +21,8 @@ void TelemetryInfo::serialize(Serializer &serializer) const {
}
Error Manager::dispatch(TelemetryInfo *Entry) {
+ assert(Config::BuildTimeEnableTelemetry &&
+ "Telemetry should have been enabled");
oontvoo wrote:
Is there a way to s
Author: Julian Lettner
Date: 2025-02-25T08:52:03-08:00
New Revision: 568106c2150f4442ad39d9c58493b962c87763bd
URL:
https://github.com/llvm/llvm-project/commit/568106c2150f4442ad39d9c58493b962c87763bd
DIFF:
https://github.com/llvm/llvm-project/commit/568106c2150f4442ad39d9c58493b962c87763bd.diff
@@ -268,29 +267,24 @@ PipeWindows::GetReadNativeHandle() { return m_read; }
HANDLE
PipeWindows::GetWriteNativeHandle() { return m_write; }
-Status PipeWindows::ReadWithTimeout(void *buf, size_t size,
-const std::chrono::microseconds &duratio
@@ -300,70 +304,51 @@ void PipePosix::CloseWriteFileDescriptorUnlocked() {
}
}
-Status PipePosix::ReadWithTimeout(void *buf, size_t size,
- const std::chrono::microseconds &timeout,
- size_t &bytes_read) {
+ll
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
if (socket_pipe.CanWrite())
socket_pipe.CloseWriteFileDescriptor();
if (socket_pipe.CanRead()) {
-// The port number may be up to "65535\0".
-char port_cstr[6] =
@@ -300,70 +304,51 @@ void PipePosix::CloseWriteFileDescriptorUnlocked() {
}
}
-Status PipePosix::ReadWithTimeout(void *buf, size_t size,
- const std::chrono::microseconds &timeout,
- size_t &bytes_read) {
+ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This code is replicated in multiple places, and a subsequent commit would
introduce another copy of it in ThreadMemory.
---
Full diff: https://github.com/llvm/llvm-project/pull/128724.dif
@@ -15,11 +15,14 @@
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Timer.h"
+#include "clang/Basic/DarwinSDKInfo.h"
JDevlieghere wrote:
Yeah, this goes against all the work of localizing the places we depend on
clang.
https://github.com/llvm/llvm-pro
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/128602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-02-25T08:10:09-08:00
New Revision: 83c6b1a88852ac6462e2ae58cb4e5ebdeb0eadd3
URL:
https://github.com/llvm/llvm-project/commit/83c6b1a88852ac6462e2ae58cb4e5ebdeb0eadd3
DIFF:
https://github.com/llvm/llvm-project/commit/83c6b1a88852ac6462e2ae58cb4e5ebdeb0eadd3.diff
LOG:
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/128750
>From b3f60a464deedae59d902f7417c74a64c5cbf5a1 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 24 Feb 2025 15:07:13 -0800
Subject: [PATCH 1/2] [lldb-dap] Use existing lldb::IOObjectSP for IO (NFC).
This
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/9] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
@@ -21,6 +21,8 @@ void TelemetryInfo::serialize(Serializer &serializer) const {
}
Error Manager::dispatch(TelemetryInfo *Entry) {
+ assert(Config::BuildTimeEnableTelemetry &&
+ "Telemetry should have been enabled");
oontvoo wrote:
P.S: How about this
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 01/10] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details
@@ -55,8 +55,6 @@ TEST_F(PipeTest, OpenAsReader) {
}
#endif
-// This test is flaky on Windows on Arm.
-#ifndef _WIN32
TEST_F(PipeTest, WriteWithTimeout) {
ashgti wrote:
Should we add some tests for the Reader as well?
Something along the lines of:
```
* Re
@@ -581,6 +626,21 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
"XcodeSDK not specified");
XcodeSDK sdk = *options.XcodeSDKSelection;
auto key = sdk.GetString();
+
+ // xcrun doesn't search SDKs in the CommandLineT
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/128750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/128750
This simplifies the IOStream.cpp implementation by building on top of the
existing lldb::IOObjectSP.
Additionally, this should help ensure clients connected of a `--connection`
specifier properly detect shutdow
https://github.com/ashgti approved this pull request.
LGTM, this looks much nicer and consistent with the other RequestHandlers.
https://github.com/llvm/llvm-project/pull/128594
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This simplifies the IOStream.cpp implementation by building on top of the
existing lldb::IOObjectSP.
Additionally, this should help ensure clients connected of a `--connection`
specifier properly detect shut
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 041b7f508533417bcda4feaa03d6c16ff85275f5
b3f60a464deedae59d902f7417c74a64c5cbf5a1 --e
https://github.com/jasonmolenda approved this pull request.
Good idea. I think you need to also update ProcessWindows.cpp?
I'm still a little unsatisfied with my approach of "a thread calls
`DetectThreadStoppedAtUnexecutedBP()` and if it turns out it DID execute the
breakpoint, then calls `Set
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/9] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
@@ -581,6 +626,21 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
"XcodeSDK not specified");
XcodeSDK sdk = *options.XcodeSDKSelection;
auto key = sdk.GetString();
+
+ // xcrun doesn't search SDKs in the CommandLineT
@@ -569,10 +572,52 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
cache.insert({key, {error, true}});
return llvm::createStringError(llvm::inconvertibleErrorCode(), error);
}
+
+ if (path_or_err->empty())
+return llvm::createStringError("Em
Author: Jonas Devlieghere
Date: 2025-02-25T13:00:26-06:00
New Revision: 66af4923ce245a0fd9427db8e4861354576d0866
URL:
https://github.com/llvm/llvm-project/commit/66af4923ce245a0fd9427db8e4861354576d0866
DIFF:
https://github.com/llvm/llvm-project/commit/66af4923ce245a0fd9427db8e4861354576d0866.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/128594
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/4] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/5] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/128724
This code is replicated in multiple places, and a subsequent commit would
introduce another copy of it in ThreadMemory.
>From e53d5e606da5703152759fa927ac066575b4ab11 Mon Sep 17 00:00:00 2001
From: Felip
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
* One of the overloads of CreateStopReasonWithBreakpointSiteID was missing a
call to SetThreadHitBreakpointSite.
* ThreadMemory was missing a "DetectThreadStoppedAtUnexecutedBP" in its
Ca
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/128726
* One of the overloads of CreateStopReasonWithBreakpointSiteID was missing a
call to SetThreadHitBreakpointSite.
* ThreadMemory was missing a "DetectThreadStoppedAtUnexecutedBP" in its
CalculateStopInfo.
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/6] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
oontvoo wrote:
> I'm fairly ambivalent about the mechanism used to disable telemetry at build
> time, so no complaints here, though I do wonder what the point is: if there's
> no concrete implementation of the framework in the build tree, then telemetry
> is disabled at build time anyway. I su
@@ -202,6 +202,10 @@
#cmakedefine LLVM_HAS_LOGF128
/* Define if building LLVM with LLVM_BUILD_TELEMETRY */
+/* DEPRECATED - use LLVM_ENABLE_TELEMETRY */
oontvoo wrote:
@rupprecht Hi, do you know if there's any other place (bazel builds?) that need
updating?
https://github.com/JDevlieghere commented:
This feels like it's working around a shortcoming of `xcrun`. Since that's
somewhat within our control, have we asked the team to look into the CLT for an
SDK? They already do for binaries so I'm not sure why the SDK would need to
behave differently.
@@ -581,6 +626,21 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
"XcodeSDK not specified");
XcodeSDK sdk = *options.XcodeSDKSelection;
auto key = sdk.GetString();
+
+ // xcrun doesn't search SDKs in the CommandLineT
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/128712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -55,8 +55,6 @@ TEST_F(PipeTest, OpenAsReader) {
}
#endif
-// This test is flaky on Windows on Arm.
DavidSpickett wrote:
Likely me that disabled it, but I doubt I had tested it on x86 Windows since we
don't run a buildbot for it. Hopefully it'll be fine on
@@ -93,15 +93,13 @@ Status SharedSocket::CompleteSending(lldb::pid_t child_pid)
{
"WSADuplicateSocket() failed, error: %d", last_error);
}
- size_t num_bytes;
- Status error =
- m_socket_pipe.WriteWithTimeout(&protocol_info, sizeof(protocol_info),
-
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
if (socket_pipe.CanWrite())
socket_pipe.CloseWriteFileDescriptor();
if (socket_pipe.CanRead()) {
-// The port number may be up to "65535\0".
-char port_cstr[6] =
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
if (socket_pipe.CanWrite())
socket_pipe.CloseWriteFileDescriptor();
if (socket_pipe.CanRead()) {
-// The port number may be up to "65535\0".
-char port_cstr[6] =
@@ -1154,17 +1156,25 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
if (socket_pipe.CanWrite())
socket_pipe.CloseWriteFileDescriptor();
if (socket_pipe.CanRead()) {
-// The port number may be up to "65535\0".
-char port_cstr[6] =
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/7] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
labath wrote:
It looks like it's still flaky:
https://lab.llvm.org/buildbot/#/builders/18/builds/11957
I think there's still at least one possible way this can race (return without
reading all data):
1. read thread returns from the read call (reads some random data) and gets
suspended
2. we
@@ -15,11 +15,14 @@
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Timer.h"
+#include "clang/Basic/DarwinSDKInfo.h"
Michael137 wrote:
Is this a dependency we can pull in? Probably not?
https://github.com/llvm/llvm-project/pull/128712
__
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/128712
`GetSDKRoot` uses `xcrun` to find an SDK root path for a given SDK version
string. But if the SDK doesn't exist in the Xcode installations, but instead
lives in the `CommandLineTools`, `xcrun` will fail to f
https://github.com/JDevlieghere approved this pull request.
Nice cleanup!
https://github.com/llvm/llvm-project/pull/128724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
I don't feel qualified to express an opinion on the implementation, but I
really appreciate the new interfaces.
https://github.com/llvm/llvm-project/pull/128719
___
lldb-commits mailing list
lldb-commits@lis
@@ -569,10 +572,52 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
cache.insert({key, {error, true}});
return llvm::createStringError(llvm::inconvertibleErrorCode(), error);
}
+
+ if (path_or_err->empty())
+return llvm::createStringError("Em
@@ -569,10 +572,52 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
cache.insert({key, {error, true}});
return llvm::createStringError(llvm::inconvertibleErrorCode(), error);
}
+
+ if (path_or_err->empty())
+return llvm::createStringError("Em
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/128719
The main motivation for this was the inconsistency in handling of partial
reads/writes between the windows and posix implementations (windows was
returning partial reads, posix was trying to fill the buffer comp
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The main motivation for this was the inconsistency in handling of partial
reads/writes between the windows and posix implementations (windows was
returning partial reads, posix was trying to fill the buffer co
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
`GetSDKRoot` uses `xcrun` to find an SDK root path for a given SDK version
string. But if the SDK doesn't exist in the Xcode installations, but instead
lives in the `CommandLineTools`, `xcrun` will fail to
@@ -569,10 +572,52 @@ static bool ResolveAndVerifyCandidateSupportDir(FileSpec
&path) {
cache.insert({key, {error, true}});
return llvm::createStringError(llvm::inconvertibleErrorCode(), error);
}
+
+ if (path_or_err->empty())
+return llvm::createStringError("Em
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/128571
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/128534
>From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 24 Feb 2025 11:32:03 -0500
Subject: [PATCH 1/8] [llvm][telemetr]Change Telemetry-disabling mechanism.
Details:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/128571
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
86 matches
Mail list logo
