[Lldb-commits] [lldb] f5d80c3 - [lldb] Avoid Function::GetAddressRange in SymbolFileCTF (#128517)

2025-02-24 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-25T08:57:55+01:00 New Revision: f5d80c335d79d0b35741bfc762f8157a24f5491a URL: https://github.com/llvm/llvm-project/commit/f5d80c335d79d0b35741bfc762f8157a24f5491a DIFF: https://github.com/llvm/llvm-project/commit/f5d80c335d79d0b35741bfc762f8157a24f5491a.diff

[Lldb-commits] [lldb] [lldb] Avoid Function::GetAddressRange in SymbolFileCTF (PR #128517)

2025-02-24 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/128517 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't hand out UnwindPlan::Row shared_ptrs (PR #128181)

2025-02-24 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/128181 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor custom & testing related request handlers (NFC) (PR #128549)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/128549 Continuation of the work started in https://github.com/llvm/llvm-project/pull/128262. Builds on top of #128453. >From 0bf14ccd21f06ee3c53d64b5139760072d6405b1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghe

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Continuation of the work started in https://github.com/llvm/llvm-project/pull/128262. Builds on top of https://github.com/llvm/llvm-project/pull/128549. --- Patch is 126.29 KiB, truncated to 20.00

[Lldb-commits] [lldb] [lldb-dap] Refactor remaining request handlers (NFC)Remaining request handlers (PR #128551)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Continuation of the work started in https://github.com/llvm/llvm-project/pull/128262. Builds on top of https://github.com/llvm/llvm-project/pull/128550. --- Patch is 230.81 KiB, truncated to 20.00

[Lldb-commits] [lldb] [lldb] Avoid Function::GetAddressRange in SymbolFileCTF (PR #128517)

2025-02-24 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/128517 SymbolFileCTF never creates discontinuous functions, so this is technically NFC, but it takes us one step closer to removing the deprecated API. >From 01ee867cca41202c2a87f8216b75aa5d6d9603cd Mon Sep 17 00:00:00

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Completes the work started in https://github.com/llvm/llvm-project/pull/128262. This PR removes the old way of register request handlers with callbacks. Builds on top of https://github.com/llvm/llvm

[Lldb-commits] [lldb] [lldb-dap] Refactor custom & testing related request handlers (NFC) (PR #128549)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Continuation of the work started in https://github.com/llvm/llvm-project/pull/128262. Builds on top of #128453. --- Patch is 45.92 KiB, truncated to 20.00 KiB below, full version: https://github.c

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 51ce6c437fec1fe0170d077424e1cbc141d05c2b 76c1fd886868c1f330e79997a499330ee308dee2 --e

[Lldb-commits] [lldb] 51ce6c4 - [lldb-dap] Fix error C2065: 'PATH_MAX': undeclared identifier

2025-02-24 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-24T12:16:05-06:00 New Revision: 51ce6c437fec1fe0170d077424e1cbc141d05c2b URL: https://github.com/llvm/llvm-project/commit/51ce6c437fec1fe0170d077424e1cbc141d05c2b DIFF: https://github.com/llvm/llvm-project/commit/51ce6c437fec1fe0170d077424e1cbc141d05c2b.d

[Lldb-commits] [lldb] [lldb-dap] Refactor request handlers (NFC) (PR #128262)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` > running on `as-builder-10` while building `lldb` at step 8 "build-default". Should be fixed by 51ce6c437fec1fe0170d077424e1cbc141d05c2b https://github.com/llvm/llvm-project/pull/128262

[Lldb-commits] [lldb] 82264d2 - [lldb-dap] Refactor stepping related request handlers (NFC) (#128453)

2025-02-24 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-24T13:50:11-06:00 New Revision: 82264d23a1cc2ad9334f9a277cb92043a8bac446 URL: https://github.com/llvm/llvm-project/commit/82264d23a1cc2ad9334f9a277cb92043a8bac446 DIFF: https://github.com/llvm/llvm-project/commit/82264d23a1cc2ad9334f9a277cb92043a8bac446.d

[Lldb-commits] [lldb] [lldb-dap] Refactor stepping related request handlers (NFC) (PR #128453)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/128453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/128553 >From d6a556acb94c334c24308743aeedfaa7da51f872 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 24 Feb 2025 12:50:21 -0600 Subject: [PATCH 1/2] [lldb-dap] Finish refactoring the request handlers

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/128553 >From d6a556acb94c334c24308743aeedfaa7da51f872 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 24 Feb 2025 12:50:21 -0600 Subject: [PATCH 1/3] [lldb-dap] Finish refactoring the request handlers

[Lldb-commits] [lldb] [lldb-dap] Refactor custom & testing related request handlers (NFC) (PR #128549)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/128549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9884803 - [lldb-dap] Refactor custom & testing related request handlers (NFC) (#128549)

2025-02-24 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-24T14:06:00-06:00 New Revision: 988480323d5ef9bb658f13ac598d4ce2aa23c782 URL: https://github.com/llvm/llvm-project/commit/988480323d5ef9bb658f13ac598d4ce2aa23c782 DIFF: https://github.com/llvm/llvm-project/commit/988480323d5ef9bb658f13ac598d4ce2aa23c782.d

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/128550 >From 95f575e5f58a4d4285377f9f6d0807573da90e44 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 24 Feb 2025 11:51:28 -0600 Subject: [PATCH 1/3] [lldb-dap] Refactor breakpoint related request hand

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/128550 >From 95f575e5f58a4d4285377f9f6d0807573da90e44 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 24 Feb 2025 11:51:28 -0600 Subject: [PATCH 1/2] [lldb-dap] Refactor breakpoint related request hand

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo ready_for_review https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor remaining request handlers (NFC)Remaining request handlers (PR #128551)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/128551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/128553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/128553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread John Harrison via lldb-commits
@@ -30,6 +30,7 @@ class RequestHandler { virtual void operator()(const llvm::json::Object &request) = 0; ashgti wrote: Should we also mark this `const`? I don't think any of the request handlers are using any state at the moment. https://github.com/llvm/ll

[Lldb-commits] [lldb] [llvm] [llvm][telemetry]Change Telemetry-disabling mechanism. (PR #128534)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/128534 >From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 24 Feb 2025 11:32:03 -0500 Subject: [PATCH 1/2] [llvm][telemetr]Change Telemetry-disabling mechanism. Details:

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
@@ -799,21 +788,40 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame, EmplaceSafeString(object, "name", frame_name); - auto source = CreateSource(frame); - - if (source) { -object.try_emplace("source", *source); -auto line_entry = frame.GetLineEntry(); -

[Lldb-commits] [lldb] [llvm] [llvm][telemetry]Change Telemetry-disabling mechanism. (PR #128534)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/128534 >From 236ab76b7c9433f8fed6586a4ee18351779cc191 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 24 Feb 2025 11:32:03 -0500 Subject: [PATCH 1/3] [llvm][telemetr]Change Telemetry-disabling mechanism. Details:

[Lldb-commits] [lldb] [lldb] Avoid Function::GetAddressRange in ThreadPlanStepRange::InSymbol (PR #128515)

2025-02-24 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGMT https://github.com/llvm/llvm-project/pull/128515 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127696 >From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 18 Feb 2025 15:58:08 -0500 Subject: [PATCH 1/5] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related metho

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/128268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/128268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/128571 None >From 57638e91c97486ad7739f9658fe88f7fb4d61fb2 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 24 Feb 2025 12:48:17 -0800 Subject: [PATCH] [lldb] Add fzf_history command to examples --- lldb/examp

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/128571.diff 1 Files Affected: - (added) lldb/examples/python/fzf_history.py (+99) ``diff diff --git a/lldb/examples/python/fzf_history.py

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b335d5a8303250cb49901ecae7570adf61abbd3c...57638e91c97486ad7739f9658fe88f7fb4d61fb2 lldb/

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC]Renaming functions to be consistent with LLDB naming style (PR #128574)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/128574 None >From a6ce60e61271aa2b57b8bc51bb1b0e0cd5896f68 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 24 Feb 2025 15:53:36 -0500 Subject: [PATCH] [LLDB][NFC]Renaming functions to be consistent with LLDB nami

[Lldb-commits] [lldb] [LLDB][NFC]Renaming functions to be consistent with LLDB naming style (PR #128574)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/128574.diff 3 Files Affected: - (modified) lldb/include/lldb/Core/Telemetry.h (+2-2) - (modified) lldb/source/Core/Telemetry.cpp (+2-2) - (modified)

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/128571 >From 57638e91c97486ad7739f9658fe88f7fb4d61fb2 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 24 Feb 2025 12:48:17 -0800 Subject: [PATCH 1/2] [lldb] Add fzf_history command to examples --- lldb/example

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/128571 >From 57638e91c97486ad7739f9658fe88f7fb4d61fb2 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 24 Feb 2025 12:48:17 -0800 Subject: [PATCH 1/3] [lldb] Add fzf_history command to examples --- lldb/example

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 1/2] [LLDB][Telemetry]Define TargetInfo for collecting data about a

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-24 Thread Vy Nguyen via lldb-commits
oontvoo wrote: (This PR assumes that we can rely on PR/128534 - that is, we always build the telemetry library. Whether it is enabled is dictated by Config::EnableTelemetry) https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb-dap] Refactor stepping related request handlers (NFC) (PR #128453)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/128453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor stepping related request handlers (NFC) (PR #128453)

2025-02-24 Thread John Harrison via lldb-commits
@@ -225,4 +225,11 @@ void RequestHandler::PrintWelcomeMessage() { #endif } +bool RequestHandler::HasInstructionGranularity( +const llvm::json::Object &request) { + if (std::optional value = request.getString("granularity")) +return value == "instruction"; + return fa

[Lldb-commits] [lldb] [lldb-dap] Refactor stepping related request handlers (NFC) (PR #128453)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM, one change for clairty https://github.com/llvm/llvm-project/pull/128453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor stepping related request handlers (NFC) (PR #128453)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/128453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH] [LLDB][Telemetry]Define TargetInfo for collecting data about a targ

[Lldb-commits] [lldb] [lldb-dap] Refactor request handlers (NFC) (PR #128262)

2025-02-24 Thread John Harrison via lldb-commits
ashgti wrote: I think making the `operator ()` const makes sense, to help ensure we don't add any state accidentally. I can't think of any requests that have state at the moment. All the state is stored in the DAP object. Create an instance for each request might be helpful if we have more com

[Lldb-commits] [lldb] [lldb-dap] Refactor custom & testing related request handlers (NFC) (PR #128549)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/128549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor stepping related request handlers (NFC) (PR #128453)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/128453 >From 34bd7c56ad67145501217464ef3e6b87a48d587a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 23 Feb 2025 21:07:55 -0600 Subject: [PATCH 1/2] [lldb-dap] Refactor stepping related request handle

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/128550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. LGTM, one question about some helpers. https://github.com/llvm/llvm-project/pull/128550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread John Harrison via lldb-commits
@@ -52,6 +52,9 @@ class RequestHandler { // Check if the step-granularity is `instruction`. bool HasInstructionGranularity(const llvm::json::Object &request); + lldb::SBValueList *GetTopLevelScope(int64_t variablesReference); + lldb::SBValue FindVariable(uint64_t variabl

[Lldb-commits] [lldb] [lldb-dap] Refactor custom & testing related request handlers (NFC) (PR #128549)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/128549 >From 16bb4bd6d5f100dceb139474b29cbfd3de6dce06 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 24 Feb 2025 11:28:17 -0600 Subject: [PATCH] [lldb-dap] Refactor custom & testing related request ha

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/128583 The TestDAP_ouput test is flaky due to the order of events during shutdown. We were stopping the output and error handle redirection after we finished the disconnect request, which can cause us to miss output e

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/128550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/128583 >From 176eae365226716a2a2ead2f6de21d801238cf1b Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 24 Feb 2025 13:35:29 -0800 Subject: [PATCH 1/2] [lldb-dap] Addressing the order of events during disconnect

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/128583 >From 176eae365226716a2a2ead2f6de21d801238cf1b Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 24 Feb 2025 13:35:29 -0800 Subject: [PATCH 1/3] [lldb-dap] Addressing the order of events during disconnect

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,100 @@ +import os +import re +import sys +import subprocess + +import lldb + + +@lldb.command() +def fzf_history(debugger, cmdstr, ctx, result, _): +"""Use fzf to search and select from lldb command history.""" +if sys.platform != "darwin": +result.SetEr

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Instead of using `pbcopy/pbpaste`, which makes this macOS only, could you use a Python temp file and read/write from that? https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes The TestDAP_ouput test is flaky due to the order of events during shutdown. We were stopping the output and error handle redirection after we finished the disconnect request, which can cause us to miss outpu

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/128583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/128583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d362319 - [lldb-dap] Refactor breakpoint related request handlers (NFC) (#128550)

2025-02-24 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-24T15:40:31-06:00 New Revision: d3623194044452e2f1b4e81c213bc8cbbe49c2a8 URL: https://github.com/llvm/llvm-project/commit/d3623194044452e2f1b4e81c213bc8cbbe49c2a8 DIFF: https://github.com/llvm/llvm-project/commit/d3623194044452e2f1b4e81c213bc8cbbe49c2a8.d

[Lldb-commits] [lldb] [lldb-dap] Refactor remaining request handlers (NFC)Remaining request handlers (PR #128551)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/128551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
@@ -30,6 +30,7 @@ class RequestHandler { virtual void operator()(const llvm::json::Object &request) = 0; JDevlieghere wrote: Yup, I was going to it in a separate commit, but I can include it here. https://github.com/llvm/llvm-project/pull/128553 __

[Lldb-commits] [lldb] [lldb-dap] Refactor request handlers (NFC) (PR #128262)

2025-02-24 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 8 "build-default". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/2395 Here is the relevant piece of the bui

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/128268 >From c54157f43966c2d9d62134110026f3fed02de379 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 21 Feb 2025 17:45:17 -0800 Subject: [PATCH 1/9] [lldb-dap] Add 'source' references to stack frames without s

[Lldb-commits] [lldb] 664cbd1 - [lldb-dap] skip TestDAP_server on windows to unblock CI. (#128278)

2025-02-24 Thread via lldb-commits
Author: John Harrison Date: 2025-02-24T09:45:51-08:00 New Revision: 664cbd1b5db190724ceea498d1f520eb66d78d69 URL: https://github.com/llvm/llvm-project/commit/664cbd1b5db190724ceea498d1f520eb66d78d69 DIFF: https://github.com/llvm/llvm-project/commit/664cbd1b5db190724ceea498d1f520eb66d78d69.diff

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
@@ -0,0 +1,100 @@ +import os +import re +import sys +import subprocess + +import lldb + + +@lldb.command() +def fzf_history(debugger, cmdstr, ctx, result, _): +"""Use fzf to search and select from lldb command history.""" +if sys.platform != "darwin": +result.SetEr

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/128268 >From 4378be2df5da154420306bc65d95a4b714b05fae Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 21 Feb 2025 17:45:17 -0800 Subject: [PATCH 1/8] [lldb-dap] Add 'source' references to stack frames without s

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread John Harrison via lldb-commits
ashgti wrote: Pulled and rebased my changes on the request handler refactor. https://github.com/llvm/llvm-project/pull/128268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
kastiglione wrote: > Instead of using `pbcopy/pbpaste`, which makes this macOS only, could you use > a Python temp file and read/write from that? @JDevlieghere I didn't do that because it would be an implementation I wouldn't even want to use, for platforms I don't use. Without a way to do co

[Lldb-commits] [lldb] [lldb-dap] Addressing the order of events during disconnect to flush output. (PR #128583)

2025-02-24 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/128583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e8f1623 - [lldb-dap] Addressing the order of events during disconnect to flush output. (#128583)

2025-02-24 Thread via lldb-commits
Author: John Harrison Date: 2025-02-24T14:41:19-08:00 New Revision: e8f1623a223adf5446e403aa6ce827a9b6dc URL: https://github.com/llvm/llvm-project/commit/e8f1623a223adf5446e403aa6ce827a9b6dc DIFF: https://github.com/llvm/llvm-project/commit/e8f1623a223adf5446e403aa6ce827a9b6dc.diff

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/128571 >From 57638e91c97486ad7739f9658fe88f7fb4d61fb2 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 24 Feb 2025 12:48:17 -0800 Subject: [PATCH 1/4] [lldb] Add fzf_history command to examples --- lldb/example

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
kastiglione wrote: I added a featureless invocation of fzf for when copy and paste support isn't available. https://github.com/llvm/llvm-project/pull/128571 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] do not show misleading error when there is no frame (PR #119103)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119103 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add 'source' references to stack frames without source files. (PR #128268)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Totally optional & I didn't think about it earlier, but this seems like something you might want to advertise through a release note. https://github.com/llvm/llvm-project/pull/128268 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [LLDB][NFC]Renaming functions to be consistent with LLDB naming style (PR #128574)

2025-02-24 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/128574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 62ec7b8 - [LLDB][NFC]Renaming functions to be consistent with LLDB naming style (#128574)

2025-02-24 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-02-24T20:21:16-05:00 New Revision: 62ec7b8de97a197c2522177a52bdc78205579930 URL: https://github.com/llvm/llvm-project/commit/62ec7b8de97a197c2522177a52bdc78205579930 DIFF: https://github.com/llvm/llvm-project/commit/62ec7b8de97a197c2522177a52bdc78205579930.diff LOG

[Lldb-commits] [lldb] 911e94c - [lldb-dap] Finish refactoring the request handlers (NFC) (#128553)

2025-02-24 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-24T16:46:12-06:00 New Revision: 911e94c6516926b462bc6d1d4a77dcc701b7e3db URL: https://github.com/llvm/llvm-project/commit/911e94c6516926b462bc6d1d4a77dcc701b7e3db DIFF: https://github.com/llvm/llvm-project/commit/911e94c6516926b462bc6d1d4a77dcc701b7e3db.d

[Lldb-commits] [lldb] [lldb-dap] Refactor breakpoint related request handlers (NFC) (PR #128550)

2025-02-24 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/5306 Here is the relevant piece

[Lldb-commits] [lldb] [lldb-dap] Finish refactoring the request handlers (NFC) (PR #128553)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/128553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ccbb888 - [lldb] do not show misleading error when there is no frame (#119103)

2025-02-24 Thread via lldb-commits
Author: oltolm Date: 2025-02-24T17:52:09-06:00 New Revision: ccbb8882ac75e73e23f31ad60588a2914ebeef04 URL: https://github.com/llvm/llvm-project/commit/ccbb8882ac75e73e23f31ad60588a2914ebeef04 DIFF: https://github.com/llvm/llvm-project/commit/ccbb8882ac75e73e23f31ad60588a2914ebeef04.diff LOG: [

[Lldb-commits] [lldb] [lldb][NFC] Fix comment in lldb/Core/ModuleList.h (PR #128602)

2025-02-24 Thread Julian Lettner via lldb-commits
https://github.com/yln created https://github.com/llvm/llvm-project/pull/128602 None >From 7df56dcd54371b95baf607efb583ccd420b0570e Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Mon, 24 Feb 2025 15:55:11 -0800 Subject: [PATCH] [lldb][NFC] Fix comment in lldb/Core/ModuleList.h --- lldb/i

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-24 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Do we only pay the cost when a diagnostic is generated, or every time a DW_AT_file is parsed? https://github.com/llvm/llvm-project/pull/127829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] Add fzf_history command to examples (PR #128571)

2025-02-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/128571 >From 57638e91c97486ad7739f9658fe88f7fb4d61fb2 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 24 Feb 2025 12:48:17 -0800 Subject: [PATCH 1/5] [lldb] Add fzf_history command to examples --- lldb/example

[Lldb-commits] [lldb] [lldb] do not show misleading error when there is no frame (PR #119103)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/119103 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC]Renaming functions to be consistent with LLDB naming style (PR #128574)

2025-02-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/128574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactor request handlers (NFC) (PR #128262)

2025-02-24 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I am thinking about how would this new approach work if we started executing requests in parallel (I know we're not planning to do that now, but this sort of started out from that), and it seems to me that the this design (a "singleton" object with a non-co

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-02-24 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,308 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-02-24 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,244 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-02-24 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-02-24 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I think I can live with looking up global variables in the current compile unit, as it's pretty clear these are the variables that should be looked at before any other CUs/modules. We will probably want to look up those as well (bring back the FindGlobalVar

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-02-24 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,244 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

  1   2   >