github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8b284dc31070b9d1d99c593146da6248a5ca545d
4c7990f8e2424a6dbb9954df071f4fc91c93d067 --e
JDevlieghere wrote:
Rebased on top of #127682
https://github.com/llvm/llvm-project/pull/126630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
As I had hoped, all the remaining uses of `LockableStreamFile` are now coming
from the IOHandler.
https://github.com/llvm/llvm-project/pull/126630
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
ajordanr-google wrote:
This apparently broke a downstream edge case with fuschia:
https://issues.fuchsia.dev/397455029, where they set all but the
`TINFO_LIBRARIES` variable.
I have given them a downstream fix, but wondering if I can rework the patch so
that this isn't an issue. I don't think
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string des
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127696
>From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 18 Feb 2025 15:58:08 -0500
Subject: [PATCH 1/2] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related
metho
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public
llvm::telemetry::TelemetryInfo {
void serialize(llvm::telemetry::Serializer &serializer) const override;
};
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+ int exit_code;
+ std::string des
@@ -73,6 +147,10 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each debugger is assigned a unique ID (session_id).
+ // All TelemetryInfo entries emitted for the same debugger instance
+ // will get the same session_
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() {
DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
void *baton) {
+#ifdef LLVM_BUILD_TELEMETRY
+ lldb_private::telemetry::SteadyTimePoint start_time =
+
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/127696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-02-18T08:10:38-08:00
New Revision: 7a781527682ebe90616b05fb2311b1d0d6fc997e
URL:
https://github.com/llvm/llvm-project/commit/7a781527682ebe90616b05fb2311b1d0d6fc997e
DIFF:
https://github.com/llvm/llvm-project/commit/7a781527682ebe90616b05fb2311b1d0d6fc997e.diff
L
@@ -477,19 +474,15 @@ class UnwindPlan {
uint32_t GetReturnAddressRegister() { return m_return_addr_register; }
uint32_t GetInitialCFARegister() const {
-if (m_row_list.empty())
- return LLDB_INVALID_REGNUM;
-return m_row_list.front()->GetCFAValue().GetRegiste
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/127519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3c2ba68915b268fd3b7d39bf62e19199b2cb8995
11384154451c75afc99a272e61c4e869d605a11e --e
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/127156
>From 0a6558940403814ffa2bf6c265bc0e9267eef855 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 13 Feb 2025 18:20:28 -0800
Subject: [PATCH 1/2] [lldb][Mach-O] Read dyld_all_image_infos addr from `mai
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-hexagon
Author: Pavel Labath (labath)
Changes
The main changes are:
- changing the internal row representation from vector to a map. This
wasn't strictly necessary, but I'm doing it because due the functions
not starting at the lowest address
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The main changes are:
- changing the internal row representation from vector to a map. This
wasn't strictly necessary, but I'm doing it because due the functions
not starting at the lowest address, the Row f
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/126757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vy Nguyen
Date: 2025-02-18T11:13:55-05:00
New Revision: 55dba06540d17cb9abf2fca094a3805b4eef3be3
URL:
https://github.com/llvm/llvm-project/commit/55dba06540d17cb9abf2fca094a3805b4eef3be3
DIFF:
https://github.com/llvm/llvm-project/commit/55dba06540d17cb9abf2fca094a3805b4eef3be3.diff
LOG
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/127661
The main changes are:
- changing the internal row representation from vector to a map. This
wasn't strictly necessary, but I'm doing it because due the functions
not starting at the lowest address, the Row for
@@ -486,9 +459,9 @@ bool UnwindPlan::PlanValidAtAddress(Address addr) {
// If the 0th Row of unwind instructions is missing, or if it doesn't provide
// a register to use to find the Canonical Frame Address, this is not a valid
// UnwindPlan.
- if (GetRowAtIndex(0).get()
@@ -446,18 +446,15 @@ class UnwindPlan {
m_plan_is_for_signal_trap(rhs.m_plan_is_for_signal_trap),
m_lsda_address(rhs.m_lsda_address),
m_personality_func_addr(rhs.m_personality_func_addr) {
-m_row_list.reserve(rhs.m_row_list.size());
-for (const
JDevlieghere wrote:
> Yesterday, I wasn't sure if we need the async stream mechanism. Today, I
> think we do (because of the prompt redrawing thingy). I think the two
> questions (async print and stream protection), but are separate in a way (the
> iohandlers still need, and the editline iohan
Author: Vy Nguyen
Date: 2025-02-18T10:44:16-05:00
New Revision: e1a393e39275ca0fea4bb19fa08c88bae3178cf8
URL:
https://github.com/llvm/llvm-project/commit/e1a393e39275ca0fea4bb19fa08c88bae3178cf8
DIFF:
https://github.com/llvm/llvm-project/commit/e1a393e39275ca0fea4bb19fa08c88bae3178cf8.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
CC @SEmmmer
https://github.com/llvm/llvm-project/pull/127505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> Two questions:
>
> * what about commands (like frame/target variable) which can return more than
> variable. I guess I'm wondering if this should be a SBValueList instead?
That makes sense.
> * what about commands (I don't know if we have any) whose output consists of
> mo
jimingham wrote:
I think Pavel is right, having this be an SBValueList would allow us to support
more commands. That should be just as easy to implement and use, and more
flexible.
https://github.com/llvm/llvm-project/pull/127566
___
lldb-commits ma
https://github.com/dlav-sc closed
https://github.com/llvm/llvm-project/pull/127507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/127519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
Thanks, all. Just to wrap up, the only change required here is to remove the
PluginInterface inheritance (and renaming the current
`Manager::getPluginName()` to `Manager::getInstanceName()` to avoid confusion.
https://github.com/llvm/llvm-project/pull/126588
__
@@ -5669,6 +5673,10 @@ bool ObjectFileMachO::GetCorefileMainBinaryInfo(addr_t
&value,
type = eBinaryTypeStandalone;
typestr = "standalone";
break;
+ case 4:
+type = eBinaryTypeUserAllImageInfos;
+typestr = "u
Author: Jason Molenda
Date: 2025-02-18T12:40:54-08:00
New Revision: 1f5edb17b23f5ac0576f83a6c122ce38bd5ec18e
URL:
https://github.com/llvm/llvm-project/commit/1f5edb17b23f5ac0576f83a6c122ce38bd5ec18e
DIFF:
https://github.com/llvm/llvm-project/commit/1f5edb17b23f5ac0576f83a6c122ce38bd5ec18e.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/127156
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
So it seems like if we ignore module loading errors for these cases, the
generic code in lldb does the right thing and produces an "as good as it can
do" module entry. So why would we ever want to elide a library if the scripted
side can't find a physical file for it? Whatev
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/4] Only include title on the first message
---
lldb/include/l
Author: dlav-sc
Date: 2025-02-18T21:06:48+03:00
New Revision: 49453bf18e1877a3bd4d1cef40bb52c209b9c1e3
URL:
https://github.com/llvm/llvm-project/commit/49453bf18e1877a3bd4d1cef40bb52c209b9c1e3
DIFF:
https://github.com/llvm/llvm-project/commit/49453bf18e1877a3bd4d1cef40bb52c209b9c1e3.diff
LOG:
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/127156
>From 0a6558940403814ffa2bf6c265bc0e9267eef855 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 13 Feb 2025 18:20:28 -0800
Subject: [PATCH 1/3] [lldb][Mach-O] Read dyld_all_image_infos addr from `mai
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/127156
>From 0a6558940403814ffa2bf6c265bc0e9267eef855 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 13 Feb 2025 18:20:28 -0800
Subject: [PATCH 1/4] [lldb][Mach-O] Read dyld_all_image_infos addr from `mai
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/127566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
- This type of entry is used to collect data about the debugger startup/exit
- Tests will be added (They may need to be shell test with a "test-only"
TelemetryManager plugin defined. I'm trying to figure out how
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/127696
- This type of entry is used to collect data about the debugger startup/exit
- Tests will be added (They may need to be shell test with a "test-only"
TelemetryManager plugin defined. I'm trying to figure out how
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running
on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/18/builds/11664
Here is the relevant piece of the build log
@@ -73,6 +147,10 @@ class TelemetryManager : public llvm::telemetry::Manager {
private:
std::unique_ptr m_config;
+ // Each debugger is assigned a unique ID (session_id).
+ // All TelemetryInfo entries emitted for the same debugger instance
+ // will get the same session_
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127566
>From 6f59b1116dd83b9cce526103cca98a5d2056720f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 17 Feb 2025 20:58:30 -0800
Subject: [PATCH 1/2] [lldb] Store the return ValueObject in the
Command
@@ -22,8 +22,6 @@ class ValueObject;
/// A collection of ValueObject values that.
class ValueObjectList {
public:
- const ValueObjectList &operator=(const ValueObjectList &rhs);
JDevlieghere wrote:
Essentially a no-op, but necessary to silence:
```
warning: d
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/4] Only include title on the first message
---
lldb/include/l
Jlalond wrote:
@JDevlieghere Cleaned up as you suggested, sorry about the initial rough state
but I mostly wanted a sanity check if I was overlooking anything.
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5ecce45ea2980aff35d1283d4dd3feb8f74de16c
19a03d8c40103298f0cb51af173f7be086eefd62 --e
rchamala wrote:
In my case, for non-scripted process of coredump, I see the module information
even when symbol is not found and I see a placeholder object being created for
the module. For scripted process, it shows only the main module due to the
limitation I pointed in this PR
Target 1 is
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/4] Only include title on the first message
---
lldb/include/l
@@ -493,36 +493,27 @@ class RangeDataVector {
#ifdef ASSERT_RANGEMAP_ARE_SORTED
assert(IsSorted());
#endif
-typename Collection::iterator pos;
-typename Collection::iterator end;
-typename Collection::iterator prev;
-bool can_combine = false;
-// First w
@@ -493,36 +493,27 @@ class RangeDataVector {
#ifdef ASSERT_RANGEMAP_ARE_SORTED
assert(IsSorted());
#endif
-typename Collection::iterator pos;
-typename Collection::iterator end;
-typename Collection::iterator prev;
-bool can_combine = false;
-// First w
@@ -493,36 +493,27 @@ class RangeDataVector {
#ifdef ASSERT_RANGEMAP_ARE_SORTED
assert(IsSorted());
#endif
-typename Collection::iterator pos;
-typename Collection::iterator end;
-typename Collection::iterator prev;
-bool can_combine = false;
-// First w
jimingham wrote:
It's never the case on Darwin that you know nothing about a loaded shared
library. You will always know at least its name, UUID, and load addresses. It
doesn't matter whether the binary exists on disk or not, we will always be able
to reconstruct at least a skeleton form fro
JDevlieghere wrote:
More context/background in #126630.
https://github.com/llvm/llvm-project/pull/127682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This makes GetOutputStreamSP and GetErrorStreamSP protected members of
Debugger. Users who want to print to the debugger's stream should use
GetAsyncOutputStreamSP and GetAsyncErrorStreamSP instead
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/127682
This makes GetOutputStreamSP and GetErrorStreamSP protected members of
Debugger. Users who want to print to the debugger's stream should use
GetAsyncOutputStreamSP and GetAsyncErrorStreamSP instead and the
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/5] Only include title on the first message
---
lldb/include/l
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127519
>From 627bb23342ee22dd263f0142ea43f644afd6faae Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 17 Feb 2025 17:29:40 +0100
Subject: [PATCH 1/2] [lldb] Add LineTable::{upper,lower}_bound
The motivation is #
vogelsgesang wrote:
Would be great if we could integrate this with `lldb-dap` right away, then we
could see how this works in practice in at least one GUI.
Note that lldb-dap already exposes SBValues via the protocol when evaluating an
expression. Afaict, the same logic only could also be wire
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 153dd19e3057169e6935027ffbc84b62b392aa35
bfe8f5c7338a24420223b794559d4c842d14d190 --e
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127519
>From 627bb23342ee22dd263f0142ea43f644afd6faae Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 17 Feb 2025 17:29:40 +0100
Subject: [PATCH 1/3] [lldb] Add LineTable::{upper,lower}_bound
The motivation is #
@@ -185,6 +185,48 @@ bool LineTable::GetLineEntryAtIndex(uint32_t idx,
LineEntry &line_entry) {
return false;
}
+uint32_t LineTable::lower_bound(const Address &so_addr) const {
+ if (so_addr.GetModule() != m_comp_unit->GetModule())
+return GetSize();
+
+ Entry search_
https://github.com/labath commented:
Two questions:
- what about commands (like frame/target variable) which can return more than
variable. I guess I'm wondering if this should be a SBValueList instead?
- what about commands (I don't know if we have any) whose output consists of
more than forma
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/26] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/27] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/27] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
labath wrote:
> I'm not convinced of that this change needs to be happen in ScriptedProcess
> ... May be we could have a setting to not discard all modules loaded in case
> 1 of them failed to load that would also work with other Process plugins.
> @jimingham what do you think ?
I'm confused.
labath wrote:
> > That said, not needing to replicate the locking logic in every IOHandler
> > would definitely be nice. However, I'm not certain about the feasibility of
> > that. In a way, I think that the PrintAsync approach is better because it
> > lets the IOHandler know that some async p
74 matches
Mail list logo
