[Lldb-commits] [lldb] [lldb] Correctly resolve (discontinuous) function offsets when disassembling (PR #126925)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. This looks straightforward. https://github.com/llvm/llvm-project/pull/126925 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/126988 lldb today has two rules: When a thread stops at a BreakpointSite, we set the thread's StopReason to be "breakpoint hit" (regardless if we've actually hit the breakpoint, or if we've merely stopped *at* th

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes lldb today has two rules: When a thread stops at a BreakpointSite, we set the thread's StopReason to be "breakpoint hit" (regardless if we've actually hit the breakpoint, or if we've merely stopped *at*

[Lldb-commits] [lldb] [LLDB] Added support for cross compiling with host python (PR #123735)

2025-02-12 Thread via lldb-commits
https://github.com/patryk4815 closed https://github.com/llvm/llvm-project/pull/123735 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-12 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The PRs I landed before this to make this run cleanly on the CI bots are https://github.com/llvm/llvm-project/pull/108518 https://github.com/llvm/llvm-project/pull/108504 https://github.com/llvm/llvm-project/pull/108127 https://github.com/llvm/llvm-project/pull/126838 (plus

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior (PR #105594)

2025-02-12 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: I'm abandoning this PR where I was working through all the CI regressions, but landed them in separate clean PRs. I created https://github.com/llvm/llvm-project/pull/126988 to re-land the July 2024 patch, rebased to current sources. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior (PR #105594)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/105594 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix: Could not find DAP in path (PR #126903)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/126903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add: show return value on step out (PR #106907)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/106907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Upgrade @types/node to fix TS2386 in node/module.d.ts (PR #126994)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/126994 Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Over

[Lldb-commits] [lldb] [lldb-dap] Upgrade @types/node to fix TS2386 in node/module.d.ts (PR #126994)

2025-02-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS238

[Lldb-commits] [lldb] 4238238 - [lldb-dap] Fix: Could not find DAP in path (#126903)

2025-02-12 Thread via lldb-commits
Author: Da-Viper Date: 2025-02-12T16:11:43-08:00 New Revision: 42382386843244cbbac0e23029e07969048e62c7 URL: https://github.com/llvm/llvm-project/commit/42382386843244cbbac0e23029e07969048e62c7 DIFF: https://github.com/llvm/llvm-project/commit/42382386843244cbbac0e23029e07969048e62c7.diff LOG:

[Lldb-commits] [lldb] cbb4e99 - [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (#126838)

2025-02-12 Thread via lldb-commits
Author: Jason Molenda Date: 2025-02-12T13:48:01-08:00 New Revision: cbb4e99f3613549c2168f52d6f348e3a7ee3cf55 URL: https://github.com/llvm/llvm-project/commit/cbb4e99f3613549c2168f52d6f348e3a7ee3cf55 DIFF: https://github.com/llvm/llvm-project/commit/cbb4e99f3613549c2168f52d6f348e3a7ee3cf55.diff

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/19470 Here is the relevant piece of th

[Lldb-commits] [lldb] 1b582ef - [lldb-dap] Bump the version number for publishing in the Marketplace

2025-02-12 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-12T16:14:00-08:00 New Revision: 1b582ef3c0a887409b513aae282682b23c7a1a41 URL: https://github.com/llvm/llvm-project/commit/1b582ef3c0a887409b513aae282682b23c7a1a41 DIFF: https://github.com/llvm/llvm-project/commit/1b582ef3c0a887409b513aae282682b23c7a1a41.d

[Lldb-commits] [lldb] [lldb-dap] Upgrade @types/node to fix TS2386 in node/module.d.ts (PR #126994)

2025-02-12 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/126994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-02-12 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From dd65babbf4c73a0b2fc2e4aa47a9a346bd5a9adf Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 01/14] [lldb] Analyze enum promotion type during parsing --- clang/

[Lldb-commits] [lldb] Define TelemetryVendor plugin. (PR #126588)

2025-02-12 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,46 @@ +//===-- TelemetryVendor.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Define TelemetryVendor plugin. (PR #126588)

2025-02-12 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/126588 >From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 10 Feb 2025 14:44:11 -0500 Subject: [PATCH 01/13] Define TelemetryVendor plugin. Details: Upstream in LLDB, we

[Lldb-commits] [lldb] Define TelemetryVendor plugin. (PR #126588)

2025-02-12 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/126588 >From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 10 Feb 2025 14:44:11 -0500 Subject: [PATCH 01/14] Define TelemetryVendor plugin. Details: Upstream in LLDB, we

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/126838 >From 4bc364c7217ad43b886ece04f4ee00e5b0a03ce3 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 11 Feb 2025 18:01:33 -0800 Subject: [PATCH 1/2] [lldb] Update ThreadPlanStepOut to handle new breakpoin

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/126838 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize the debugger's stdout and stderr streams (PR #126630)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Rebased. @labath can you confirm this is what you had in mind? https://github.com/llvm/llvm-project/pull/126630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize the debugger's stdout and stderr streams (PR #126630)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/126630 >From 55cc3a52ade13d0a0fdf115d9ce32b32c659fac1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 11 Feb 2025 19:54:35 -0800 Subject: [PATCH] [lldb] Synchronize the debugger's stdout and stderr str

[Lldb-commits] [lldb] [lldb] Add terminfo dependency for ncurses support (PR #126810)

2025-02-12 Thread Jordan R AW via lldb-commits
https://github.com/ajordanr-google updated https://github.com/llvm/llvm-project/pull/126810 >From ddd3febff5b77cc7b2101996d49729added00f2b Mon Sep 17 00:00:00 2001 From: Jordan R Abrahams-Whitehead Date: Tue, 1 Oct 2024 18:41:28 + Subject: [PATCH 1/2] [lldb] Add terminfo dependency for ncur

[Lldb-commits] [lldb] [lldb-dap] Ensure we do not print the close sentinel when closing stdout. (PR #126833)

2025-02-12 Thread John Harrison via lldb-commits
@@ -25,6 +26,10 @@ using llvm::Expected; using llvm::inconvertibleErrorCode; using llvm::StringRef; +namespace { +char kCloseSentinel[] = "\0"; +} // namespace ashgti wrote: Done. https://github.com/llvm/llvm-project/pull/126833 _

[Lldb-commits] [lldb] [lldb-dap] Ensure we do not print the close sentinel when closing stdout. (PR #126833)

2025-02-12 Thread John Harrison via lldb-commits
@@ -59,7 +64,10 @@ Error OutputRedirector::RedirectTo(std::function callback) { while (!m_stopped) { ssize_t bytes_count = ::read(read_fd, &buffer, sizeof(buffer)); // EOF detected. - if (bytes_count == 0) + if (bytes_count == 0 || as

[Lldb-commits] [lldb] [lldb-dap] Ensure we do not print the close sentinel when closing stdout. (PR #126833)

2025-02-12 Thread John Harrison via lldb-commits
@@ -59,7 +64,10 @@ Error OutputRedirector::RedirectTo(std::function callback) { while (!m_stopped) { ssize_t bytes_count = ::read(read_fd, &buffer, sizeof(buffer)); // EOF detected. - if (bytes_count == 0) + if (bytes_count == 0 || + (bytes_c

[Lldb-commits] [lldb] [lldb-dap] Ensure we do not print the close sentinel when closing stdout. (PR #126833)

2025-02-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/126833 >From af07cbad6524cfb0509f93565eb86584e4c3576c Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 11 Feb 2025 16:58:20 -0800 Subject: [PATCH 1/2] [lldb-dap] Ensure we do not print the close sentinel when cl

[Lldb-commits] [lldb] Define TelemetryVendor plugin. (PR #126588)

2025-02-12 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/126588 >From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Mon, 10 Feb 2025 14:44:11 -0500 Subject: [PATCH 01/12] Define TelemetryVendor plugin. Details: Upstream in LLDB, we

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/builds/13395 Here is the r

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 4 "build". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/16093 Here is the relevant piece of the build lo

[Lldb-commits] [lldb] [lldb] Update ThreadPlanStepOut to handle new breakpoint behavior (PR #126838)

2025-02-12 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/13554 Here is the relevant

[Lldb-commits] [lldb] fa71238 - [lldb] inserted a typeo when checking in a suggested fix

2025-02-12 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-02-12T14:00:41-08:00 New Revision: fa71238da800f3a818ec0e0649462389dc577890 URL: https://github.com/llvm/llvm-project/commit/fa71238da800f3a818ec0e0649462389dc577890 DIFF: https://github.com/llvm/llvm-project/commit/fa71238da800f3a818ec0e0649462389dc577890.diff

[Lldb-commits] [lldb] [llvm] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (PR #126746)

2025-02-12 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `lldb,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2277 Here is the relevan

[Lldb-commits] [lldb] [lldb-dap] Add: show return value on step out (PR #106907)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
@@ -663,6 +663,41 @@ def do_test_indexedVariables(self, enableSyntheticChildDebugging: bool): ]["variables"] self.verify_variables(verify_children, children) +def test_return_variables(self): JDevlieghere wrote: The arm64 ABI does not req

[Lldb-commits] [lldb] [lldb-dap] Add: show return value on step out (PR #106907)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/106907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 105b3a9 - [lldb-dap] add `debugAdapterExecutable` property to launch configuration (#126803)

2025-02-12 Thread via lldb-commits
Author: Matthew Bastien Date: 2025-02-12T15:49:38-08:00 New Revision: 105b3a92a72b9acdb01a9ce280a456bc4d5dce78 URL: https://github.com/llvm/llvm-project/commit/105b3a92a72b9acdb01a9ce280a456bc4d5dce78 DIFF: https://github.com/llvm/llvm-project/commit/105b3a92a72b9acdb01a9ce280a456bc4d5dce78.dif

[Lldb-commits] [lldb] [lldb-dap] add `debugAdapterExecutable` property to launch configuration (PR #126803)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/126803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change lldb's breakpoint handling behavior, reland (PR #126988)

2025-02-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM as this is a re-land and was previously reviewed. https://github.com/llvm/llvm-project/pull/126988 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb-dap] Add: show return value on step out (PR #106907)

2025-02-12 Thread via lldb-commits
@@ -663,6 +663,41 @@ def do_test_indexedVariables(self, enableSyntheticChildDebugging: bool): ]["variables"] self.verify_variables(verify_children, children) +def test_return_variables(self): jimingham wrote: Might be better to split this

[Lldb-commits] [lldb] [lldb-dap] Add: show return value on step out (PR #106907)

2025-02-12 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/106907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2