Da-Viper wrote:
@JDevlieghere was away for sometime could you please review this.
thanks
https://github.com/llvm/llvm-project/pull/106907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
@@ -6,15 +6,22 @@
# CHECK: Found 1 function(s).
# CHECK: foo: [input.o[0x0-0xe), input.o[0x14-0x1c)]
-# CHECK-NEXT: input.o[0x0]: cmpl $0x0, %edi
-# CHECK-NEXT: input.o[0x3]: je 0x14
-# CHECK-NEXT: input.o[0x5]: jmp0x7
-# CHECK-NEXT: input.o[0x7]: callq 0xe
-# CHECK
@@ -6,15 +6,22 @@
# CHECK: Found 1 function(s).
# CHECK: foo: [input.o[0x0-0xe), input.o[0x14-0x1c)]
-# CHECK-NEXT: input.o[0x0]: cmpl $0x0, %edi
-# CHECK-NEXT: input.o[0x3]: je 0x14
-# CHECK-NEXT: input.o[0x5]: jmp0x7
-# CHECK-NEXT: input.o[0x7]: callq 0xe
-# CHECK
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,
Alejandro =?utf-8?q?Álvarez_Ayllón?=,Yutong Zhu
<115899167+yutongz...@users.noreply.github.com>,
Juan Manuel
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch adds a new API to `SBType` to retrieve the value of a template
parameter given an index. We re-use the
`TypeSystemClang::GetIntegralTemplateArgument` for this and thus currently only
supports in
Michael137 wrote:
We now have three APIs to query template parameters:
`GetTemplateParameterType`/`GetTemplateParameterKind`/`GetTemplateParameterValue`.
Perhaps we could just represent a template parameter as an `SBValue` instead?
And return that via a `SBType::GetTemplateParameter`. Then the
@@ -964,6 +964,7 @@ class LLDB_API SBTarget {
friend class SBSection;
friend class SBSourceManager;
friend class SBSymbol;
+ friend class SBType;
Michael137 wrote:
These were only necessary to get access to `SBTarget::GetSP`
https://github.com/llvm/llv
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
e258bca9505f35e0a22cb213a305eea9b76d11ea...d69bd14f285f5508abc35b60172efc8839b7c0fd
lldb/
https://github.com/labath commented:
This is definitely better than what you had before, but I still think it's more
complicated than it needs to be. For one, I'd like to understand why is there a
need for separate `TelemetryManager` and `TelemetryConfig` fields. If the
downstream implementati
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/126746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,21 +41,20 @@ void LLDBBaseTelemetryInfo::serialize(Serializer
&serializer) const {
serializer.write("end_time", ToNanosec(end_time.value()));
}
-[[maybe_unused]] static std::string MakeUUID(lldb_private::Debugger *debugger)
{
+[[maybe_unused]] static std::string M
@@ -0,0 +1,46 @@
+import lldb
+import re
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class TestStatusline(PExpectTest):
+def do_setup(self):
+# Create a target and run to a b
@@ -0,0 +1,46 @@
+import lldb
+import re
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class TestStatusline(PExpectTest):
+def do_setup(self):
+# Create a target and run to a b
@@ -0,0 +1,46 @@
+import lldb
+import re
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class TestStatusline(PExpectTest):
+def do_setup(self):
+# Create a target and run to a b
@@ -0,0 +1,46 @@
+import lldb
+import re
+
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.lldbpexpect import PExpectTest
+
+
+class TestStatusline(PExpectTest):
+def do_setup(self):
+# Create a target and run to a b
https://github.com/Da-Viper created
https://github.com/llvm/llvm-project/pull/126903
Fixes #120839
>From 253ce7d35c1500606391eb4242fe3b32734c Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Wed, 12 Feb 2025 12:38:31 +
Subject: [PATCH] [lldb-dap] Fix: compare with the string instead of
@@ -446,6 +446,7 @@ class LLDB_API SBValue {
friend class SBModule;
friend class SBTarget;
friend class SBThread;
+ friend class SBType;
Michael137 wrote:
This was necessary to get access to the SBValue constructor
https://github.com/llvm/llvm-project/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The llvm versions of these functions do that, so we must to so as well.
Practically this meant that were were unable to correctly un-simplify the names
of some types when using type units, which resulted in ty
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/126901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (Da-Viper)
Changes
Fixes #120839
---
Full diff: https://github.com/llvm/llvm-project/pull/126903.diff
1 Files Affected:
- (modified) lldb/tools/lldb-dap/src-ts/debug-adapter-factory.ts (+2-2)
``diff
diff --git a/lldb/tool
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126901
This patch adds a new API to `SBType` to retrieve the value of a template
parameter given an index. We re-use the
`TypeSystemClang::GetIntegralTemplateArgument` for this and thus currently only
supports inte
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/126902
The llvm versions of these functions do that, so we must to so as well.
Practically this meant that were were unable to correctly un-simplify the names
of some types when using type units, which resulted in type
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/2] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
@@ -964,6 +964,7 @@ class LLDB_API SBTarget {
friend class SBSection;
friend class SBSourceManager;
friend class SBSymbol;
+ friend class SBType;
labath wrote:
Okay, sorry, this is my bad. I didn't mean to imply that it should be done in
this patch. I
https://github.com/labath approved this pull request.
This looks okay to me (modulo the friend messup). Given this is a public API
and whatnot, it might be a good idea to wait if folks in the US have any
thoughts on this.
https://github.com/llvm/llvm-project/pull/126901
___
@@ -687,6 +687,39 @@ lldb::TemplateArgumentKind
SBType::GetTemplateArgumentKind(uint32_t idx) {
return eTemplateArgumentKindNull;
}
+lldb::SBValue SBType::GetTemplateArgumentValue(lldb::SBTarget target,
+ uint32_t idx) {
+ LLDB
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/5] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/126901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/126902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/3] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
Michael137 wrote:
> > Perhaps we could just represent a template parameter as an SBValue instead?
>
> I'm not sure I understand. Do you mean, even for type template template
> parameters? How would that work? By creating an empty value of the given
> type? And how would we pass the "kind" of t
@@ -687,6 +687,39 @@ lldb::TemplateArgumentKind
SBType::GetTemplateArgumentKind(uint32_t idx) {
return eTemplateArgumentKindNull;
}
+lldb::SBValue SBType::GetTemplateArgumentValue(lldb::SBTarget target,
+ uint32_t idx) {
+ LLDB
@@ -964,6 +964,7 @@ class LLDB_API SBTarget {
friend class SBSection;
friend class SBSourceManager;
friend class SBSymbol;
+ friend class SBType;
labath wrote:
This is completely optional, it just seemed like a good opportunity to
advertise [my idea](h
@@ -687,6 +687,39 @@ lldb::TemplateArgumentKind
SBType::GetTemplateArgumentKind(uint32_t idx) {
return eTemplateArgumentKindNull;
}
+lldb::SBValue SBType::GetTemplateArgumentValue(lldb::SBTarget target,
+ uint32_t idx) {
+ LLDB
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126746
>From 008537373cd928fea9ac04b1aed39c2ecafec65a Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Tue, 11 Feb 2025 10:36:06 -0500
Subject: [PATCH 1/5] Define -DLLVM_BUILD_TELEMETRY to be used in ifdef (by
users of
Author: Vy Nguyen
Date: 2025-02-12T09:33:52-05:00
New Revision: fc4d87100a01f08dbdf78b68e1a6a5c2584d840d
URL:
https://github.com/llvm/llvm-project/commit/fc4d87100a01f08dbdf78b68e1a6a5c2584d840d
DIFF:
https://github.com/llvm/llvm-project/commit/fc4d87100a01f08dbdf78b68e1a6a5c2584d840d.diff
LOG
https://github.com/oontvoo closed
https://github.com/llvm/llvm-project/pull/126746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/5] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/126505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Makes sense. I suspect all of those uses of the method were candidates for
corrupting the debugger output.
https://github.com/llvm/llvm-project/pull/126821
___
lldb-commits mailing list
lldb-commit
Author: Pavel Labath
Date: 2025-02-12T10:47:22+01:00
New Revision: 37f36cbffb890a0c144211dec0c3589bd17f2a36
URL:
https://github.com/llvm/llvm-project/commit/37f36cbffb890a0c144211dec0c3589bd17f2a36
DIFF:
https://github.com/llvm/llvm-project/commit/37f36cbffb890a0c144211dec0c3589bd17f2a36.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/126505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -964,6 +964,7 @@ class LLDB_API SBTarget {
friend class SBSection;
friend class SBSourceManager;
friend class SBSymbol;
+ friend class SBType;
Michael137 wrote:
Ah fair enough, reverted that for now
https://github.com/llvm/llvm-project/pull/126901
_
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/126803
>From a07148100b02fa109cd3131d2d7742cdc0ae2bfa Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Tue, 11 Feb 2025 16:38:43 -0500
Subject: [PATCH 1/2] add `debugAdapterExecutable` property to launch
co
@@ -152,6 +152,10 @@
"program"
],
"properties": {
+ "debugAdapterExecutable": {
+"type": "string",
+"markdownDescription": "The LLDB debug adapter executable to
use. Either an absolute path or t
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/126925
We need to iterate through the all symbol context ranges returned by (since
#126505) SymbolContext::GetAddressRange. This also includes a fix to print the
function offsets as signed values.
I've also wanted to
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/8] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,43 @@
+//===-- TelemetryVendor.h
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/9] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/126901
>From d69bd14f285f5508abc35b60172efc8839b7c0fd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 12 Feb 2025 12:27:22 +
Subject: [PATCH 1/3] [lldb][SBAPI] Add new SBType::GetTemplateParameterValue
A
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
We need to iterate through the all symbol context ranges returned by (since
#126505) SymbolContext::GetAddressRange. This also includes a fix to
print the function offsets as signed values.
I've also wanted t
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 1/7] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we w
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,46 @@
+//===-- TelemetryVendor.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -152,6 +152,10 @@
"program"
],
"properties": {
+ "debugAdapterExecutable": {
+"type": "string",
+"markdownDescription": "The LLDB debug adapter executable to
use. Either an absolute path or t
https://github.com/vogelsgesang approved this pull request.
good find! LGTM
https://github.com/llvm/llvm-project/pull/126903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/126803
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/10] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
oontvoo wrote:
> This is definitely better than what you had before, but I still think it's
> more complicated than it needs to be. For one, I'd like to understand why is
> there a need for separate `TelemetryManager` and `TelemetryConfig` fields. If
> the downstream implementation is going to
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/11] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/126935
Currently we're creating inheritable (`~FD_CLOEXEC`) file descriptors in the
(few) cases where we need to pass an FD to a subprocess. The problem with these
is that, in a multithreaded application such as lldb,
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/126833
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -58,16 +56,19 @@ Error
OutputRedirector::RedirectTo(std::function callback) {
char buffer[OutputBufferSize];
while (!m_stopped) {
ssize_t bytes_count = ::read(read_fd, &buffer, sizeof(buffer));
- // EOF detected.
- if (bytes_count == 0)
-brea
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/106907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-12T19:09:09-08:00
New Revision: 73ab0c076215125a249eee117f51f2ce4f5f9b50
URL:
https://github.com/llvm/llvm-project/commit/73ab0c076215125a249eee117f51f2ce4f5f9b50
DIFF:
https://github.com/llvm/llvm-project/commit/73ab0c076215125a249eee117f51f2ce4f5f9b50.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/126994
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3801,6 +3801,23 @@ void request_variables(const llvm::json::Object
&request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+// Show return value if there is any ( in the top frame )
vogelsgesang wrote:
should we add a releas
@@ -3801,6 +3801,23 @@ void request_variables(const llvm::json::Object
&request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+// Show return value if there is any ( in the top frame )
+auto process = g_dap.target.GetProcess();
+auto sel
@@ -663,6 +663,41 @@ def do_test_indexedVariables(self,
enableSyntheticChildDebugging: bool):
]["variables"]
self.verify_variables(verify_children, children)
+def test_return_variables(self):
+"""
+Test the stepping out of a function with r
JDevlieghere wrote:
LGTM!
> @tedwoodward does this PR also address your request in #123842, or did you
> have something else in mind?
I was thinking the same thing. I'm pretty sure this is doing exactly what Ted's
asking for.
https://github.com/llvm/llvm-project/pull/126803
___
https://github.com/JDevlieghere approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/126903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I understand the issue in point two--this patch may unnecessarily require a
> separate tinfo library even when the headers and objects are available via
> ncurses. But could you explain more on your recommended solutions,
> particularly on why we would need to set an opti
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/126972
None
>From 3a8b692f3dffc280c2e4cbbbd4041a9cd334c5f7 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 12 Feb 2025 12:56:34 -0800
Subject: [PATCH] [lldb] Use LLDB_LOG_ERROR in ObjectFilePECOFF.cpp (NFC)
--
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/126972.diff
1 Files Affected:
- (modified) lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
(+11-22)
``diff
diff --git a/lldb/
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/126972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/compnerd approved this pull request.
Thanks for cleaning this up!
https://github.com/llvm/llvm-project/pull/126972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/126821
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-12T08:29:06-08:00
New Revision: eff3c343b08cfc46016708b3182ac062d45b3e21
URL:
https://github.com/llvm/llvm-project/commit/eff3c343b08cfc46016708b3182ac062d45b3e21
DIFF:
https://github.com/llvm/llvm-project/commit/eff3c343b08cfc46016708b3182ac062d45b3e21.d
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/126901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ajordanr-google wrote:
> This isn't using TINFO_LIBRARIES anywhere. Presumably you'll need to add it
> to LLDB_CURSES_LIBS like the original spack patch.
Hmm. This patch does seem to work locally, so it's not _required_. I would have
thought the logic is entirely in the `find_package` invocati
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/15] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/16] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
ajordanr-google wrote:
Thanks, this does clear it up! Yeah I'd rather have it work out of the bod.
I'll see what I can do for doing the autodetection ergonomically, and get back
to you. If not, I'll add a flag.
https://github.com/llvm/llvm-project/pull/126810
__
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/17] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/126588
>From c7734011094995c64137de6f8122033d2a981610 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Mon, 10 Feb 2025 14:44:11 -0500
Subject: [PATCH 01/17] Define TelemetryVendor plugin.
Details:
Upstream in LLDB, we
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/126588
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
- This isn't using `TINFO_LIBRARIES` anywhere. Presumably you'll need to add it
to `LLDB_CURSES_LIBS` like the original spack patch.
- This doesn't work on systems that have `ncruses` and `panel`, but no separate
`terminfo` library. The purpose of the CMake module is to fin
1 - 100 of 142 matches
Mail list logo
