[Lldb-commits] [lldb] LLDB: correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
puremourning wrote: Yes, on it. Sorry I should have marked this PR [wip]. https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] LLDB: correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store the command in the CommandReturnObject (PR #125132)

2025-02-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > This looks good. I wonder if we ought to do something a little less ad hoc > about the cases where our command return objects are from HandleCommands, so > they won't necessarily have the result of a single command. In the case where > a UI is parsing these, it might very

[Lldb-commits] [lldb] [WIP] LLDB: correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
https://github.com/puremourning updated https://github.com/llvm/llvm-project/pull/125312 >From 6af277d30baaa1c8ff56bb4da13a6687dfa0c729 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Fri, 31 Jan 2025 22:38:04 + Subject: [PATCH] LLDB: correct event when removing all watchpoints Previously

[Lldb-commits] [lldb] LLDB: correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] LLDB: correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
puremourning wrote: Done. The test fails (expectedly) at the line following "DeleteAllWatchpoints" prior to this patch, and passes after. https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [WIP] LLDB: correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] WatchAddress ignores modify option (PR #124847)

2025-02-01 Thread Ben Jackson via lldb-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/124847 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] correct event when removing all watchpoints (PR #125312)

2025-02-01 Thread Ben Jackson via lldb-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add logging for missing `.dwo` files (PR #116436)

2025-02-01 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/116436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add logging for missing `.dwo` files (PR #116436)

2025-02-01 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: yes, that is sufficient. Didn't know about `image dump separate-debug-info` https://github.com/llvm/llvm-project/pull/116436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #125347)

2025-02-01 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/125347 This commit adds support for column breakpoints to lldb-dap. To do so, support for the `breakpointLocations` request was added. To find all available breakpoint positions, we iterate over the line table. T

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #125347)

2025-02-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes This commit adds support for column breakpoints to lldb-dap. To do so, support for the `breakpointLocations` request was added. To find all available breakpoint positions, we iterate over the line

[Lldb-commits] [lldb] [llvm] [lldb-dap] Support column breakpoints (PR #125347)

2025-02-01 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @Micahel137 Do you know if there is any way I could manually trigger the `lldb-aarch64-ubuntu` and the MacOS CI before merging this, to get CI feedback before merging this? https://github.com/llvm/llvm-project/pull/125347 ___ lldb

[Lldb-commits] [lldb] Bugfix: Not showing the synthetic children of values behind pointers (PR #117755)

2025-02-01 Thread Sergey Kuznetsov via lldb-commits
skuznetsov wrote: > > @clayborg Thank you, Greg! Lots of that info is not described anywhere, no > > wonder I missed it. Let me try your fixes in my provider, and I will get > > back to you. > > By some reason my provider works in CLI lldb, but not in lldb-dap, but I > > will check if your sug