[Lldb-commits] [lldb] [lldb] Improve isolation between Process plugins and OS plugins (PR #125302)

2025-01-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes Generally speaking, process plugins (e.g. ProcessGDBRemote) should not be aware of OS plugin threads. However, ProcessGDBRemote attempts to check for the existence of OS threads when calc

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: Ah true

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: Feel fr

[Lldb-commits] [lldb] LLDB: WatchAddress ignores modify option (PR #124847)

2025-01-31 Thread Ben Jackson via lldb-commits
puremourning wrote: Looking again, of course you're right and the behaviour of RemoveAll and Remove is inconsistent today, so I don't see a problem with fixing it. https://github.com/llvm/llvm-project/pull/124847 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( kuilpd wrote: Alright, wi

[Lldb-commits] [lldb] [lldb] Improve isolation between Process plugins and OS plugins (PR #125302)

2025-01-31 Thread via lldb-commits
https://github.com/jimingham approved this pull request. That seems obviously right, it doesn't make sense to require every process plugin to be aware of backing threads, but it does seem quite reasonable for generic code to be aware of them. https://github.com/llvm/llvm-project/pull/125302 __

[Lldb-commits] [lldb] [lldb] Store the command in the CommandReturnObject (PR #125132)

2025-01-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/125132 >From aa41718c6f8220d5369453e91e372e4f52c37c6a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 30 Jan 2025 15:00:14 -0800 Subject: [PATCH] [lldb] Store the command in the CommandReturnObject --

[Lldb-commits] [lldb] [lldb] Store the command in the CommandReturnObject (PR #125132)

2025-01-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/125132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store the command in the CommandReturnObject (PR #125132)

2025-01-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes As suggested in #125006. Depending on which PR lands first, I'll update `TestCommandInterepterPrintCallback.py` to check that the `CommandReturnObject` passed to the callback has the correct command

[Lldb-commits] [lldb] [lldb] Store the command in the CommandReturnObject (PR #125132)

2025-01-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/125132 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][Windows] WoA HW Watchpoint support in LLDB (PR #108072)

2025-01-31 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: @omjavaid Apparently, these changes break lldb-remote-linux-win buildbot with the following error: ``` FAILED: tools/lldb/source/Plugins/Process/Windows/Common/CMakeFiles/lldbPluginProcessWindowsCommon.dir/NativeRegisterContextWindows_WoW64.cpp.obj ccache C:\PROGRA~1\MICR

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-01-31 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: > Maybe I'm missing something. In the host case, m_address is set to invalid, > but m_value has the address in it and is a host address, so then we get to: > > // m_address could be invalid but we could still have a local buffer // > containing the dynamic value. if ((m_addr

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/125125 >From 24ddc550e3ee61b863cbaea05ff49981bc20f7ad Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 30 Jan 2025 14:25:16 -0800 Subject: [PATCH 1/5] [lldb] Use llvm::Error instead of CommandReturnObje

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 0d46657cb6bf04430ff8222e1974e49441767d47...bbecf2f990c1fdf8ed993c3bba4c68212ebb299c lldb

[Lldb-commits] [lldb] 6deee0d - [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (#125125)

2025-01-31 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-31T13:23:26-08:00 New Revision: 6deee0d5b36c8b4b83209759df8d4933e4922bc8 URL: https://github.com/llvm/llvm-project/commit/6deee0d5b36c8b4b83209759df8d4933e4922bc8 DIFF: https://github.com/llvm/llvm-project/commit/6deee0d5b36c8b4b83209759df8d4933e4922bc8.d

[Lldb-commits] [lldb] [lldb] Use llvm::Error instead of CommandReturnObject for error reporting (PR #125125)

2025-01-31 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/125125 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 01/12] [lldb] Analyze enum promotion type during parsing --- clang/

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-01-31 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: Ok, fair point. I'll come up with a more robust solution. https://github.com/llvm/llvm-project/pull/125143 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 87b7f63 - Revert "Reland "[lldb] Implement basic support for reverse-continue" (#125242)"

2025-01-31 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2025-01-31T13:11:20-08:00 New Revision: 87b7f63a117c340a6d9ca47959335fd7ef6c7ad2 URL: https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2 DIFF: https://github.com/llvm/llvm-project/commit/87b7f63a117c340a6d9ca47959335fd7ef6c7ad2.diff

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
@@ -172,7 +172,4 @@ def test_ref_and_ptr(self): # The pointer should just show the right number of elements: -ptrAddr = self.findVariable("ptr").GetValue() -self.expect_expr( -"ptr", result_type="std::span *", result_summary=f"{ptrAddr} si

[Lldb-commits] [lldb] LLDB: correct event when removing all watchpoints (PR #125312)

2025-01-31 Thread Ben Jackson via lldb-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/125312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB: correct event when removing all watchpoints (PR #125312)

2025-01-31 Thread Ben Jackson via lldb-commits
https://github.com/puremourning created https://github.com/llvm/llvm-project/pull/125312 Previously we incorrectly emitted a "breakpoint changed" event when removing all watchpoints (e.g. via SBTarget::DeleteAllWatchpoints()). Correct it to emit the "watchpoint changed" event, as that's what "

[Lldb-commits] [lldb] LLDB: WatchAddress ignores modify option (PR #124847)

2025-01-31 Thread Ben Jackson via lldb-commits
puremourning wrote: https://github.com/llvm/llvm-project/pull/125312 https://github.com/llvm/llvm-project/pull/124847 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB: correct event when removing all watchpoints (PR #125312)

2025-01-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ben Jackson (puremourning) Changes Previously we incorrectly emitted a "breakpoint changed" event when removing all watchpoints (e.g. via SBTarget::DeleteAllWatchpoints()). Correct it to emit the "watchpoint changed" event, as that's what

[Lldb-commits] [lldb] LLDB: correct event when removing all watchpoints (PR #125312)

2025-01-31 Thread Ben Jackson via lldb-commits
https://github.com/puremourning updated https://github.com/llvm/llvm-project/pull/125312 >From 0bf7cf47b3373f3bd23802fcd41f6b831fff6adf Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Fri, 31 Jan 2025 22:38:04 + Subject: [PATCH] LLDB: correct event when removing all watchpoints Previously

[Lldb-commits] [lldb] [LLDB][Save Core Options] Custom ranges should follow the same safety checks as everyone else (PR #125323)

2025-01-31 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/125323 I encountered a `qMemoryRegionInfo not supported` error when capturing a Minidump. This was surprising, and I started looking around I found @jasonmolenda's fix in #115963 and then realized I was not validated

[Lldb-commits] [lldb] [LLDB][Save Core Options] Custom ranges should follow the same safety checks as everyone else (PR #125323)

2025-01-31 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes I encountered a `qMemoryRegionInfo not supported` error when capturing a Minidump. This was surprising, and I started looking around I found @jasonmolenda's fix in #115963 and then realized I was not validate

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( kuilpd wrote: Well... I t

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: > Mostl

[Lldb-commits] [lldb] dbabad0 - [lldb] Use validation combination of options in TestAbbreviations (#125270)

2025-01-31 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-31T11:57:49-08:00 New Revision: dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6 URL: https://github.com/llvm/llvm-project/commit/dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6 DIFF: https://github.com/llvm/llvm-project/commit/dbabad0fc04e7106a07dbeeb8ff23dc32ce6b2c6.d

[Lldb-commits] [lldb] 2a2d6e6 - [lldb-dap] Bump the version to 0.2.9

2025-01-31 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-01-31T11:57:20-08:00 New Revision: 2a2d6e66ce3a87f4f5168df717782d777063f7b8 URL: https://github.com/llvm/llvm-project/commit/2a2d6e66ce3a87f4f5168df717782d777063f7b8 DIFF: https://github.com/llvm/llvm-project/commit/2a2d6e66ce3a87f4f5168df717782d777063f7b8.d

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( kuilpd wrote: > > Iterati

[Lldb-commits] [lldb] [lldb] Make ValueObjectDynamicValue::UpdateValue() point to a host b… (PR #125143)

2025-01-31 Thread via lldb-commits
jimingham wrote: Maybe I'm missing something. In the host case, m_address is set to invalid, but m_value has the address in it and is a host address, so then we get to: // m_address could be invalid but we could still have a local buffer // containing the dynamic value. if ((m_address.

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: Apologi

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: Unless

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/125294 >From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Fri, 31 Jan 2025 13:05:14 -0800 Subject: [PATCH 1/2] [lldb] Show value for libcxx and libstdcxx summary and remove

[Lldb-commits] [lldb] LLDB: WatchAddress ignores modify option (PR #124847)

2025-01-31 Thread Ben Jackson via lldb-commits
puremourning wrote: > Seeing as you are working on watchpoints here, I found that `void > WatchpointList::RemoveAll(bool notify)` is sending the wrong event of > `Target::eBroadcastBitBreakpointChanged` instead of sending > `Target::eBroadcastBitWatchpointChanged`. Might be a good fix to get i

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( kuilpd wrote: Yes, but I

[Lldb-commits] [lldb] [lldb] Show value for libcxx and libstdcxx summary and remove pointer value in libcxx container summary (PR #125294)

2025-01-31 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/125294 >From bbecf2f990c1fdf8ed993c3bba4c68212ebb299c Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Fri, 31 Jan 2025 13:05:14 -0800 Subject: [PATCH 1/3] [lldb] Show value for libcxx and libstdcxx summary and remove

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Michael Buch via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( Michael137 wrote: That's

[Lldb-commits] [clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-31 Thread Ilia Kuklin via lldb-commits
@@ -2367,11 +2369,36 @@ size_t DWARFASTParserClang::ParseChildEnumerators( } if (name && name[0] && got_value) { - m_ast.AddEnumerationValueToEnumerationType( + auto ECD = m_ast.AddEnumerationValueToEnumerationType( kuilpd wrote: It's used i

[Lldb-commits] [lldb] [lldb] Implement bidirectional access for backing<->backed thread relationship (PR #125300)

2025-01-31 Thread via lldb-commits
@@ -470,6 +470,18 @@ class Thread : public std::enable_shared_from_this, virtual void ClearStackFrames(); + /// Derived classes implementing SetBackingThread should use this to provide + /// bidirectional access to the Backing-Backed relationship. + void SetBackedThread(

<    1   2