[Lldb-commits] [lldb] [lldb][OpenBSD] Make use of Environment class (PR #122040)

2025-01-08 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. If you feel up to it, you could also put into the common code (under `#if !APPLE && !WINDOWS`) and delete the implementations in other OSes as well. https://github.com/llvm/llvm-project/pull/122040 ___

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/120979 >From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Mon, 23 Dec 2024 10:22:40 -0600 Subject: [PATCH 1/5] Some base #if _AIX changes --- .../Host/posix/

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM, @labath ? https://github.com/llvm/llvm-project/pull/120979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][RFC][lldb] faster indexing (PR #122128)

2025-01-08 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/122128 None >From b534596aa6d7c2c38610d8b32a06ca7a8c6857f5 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 8 Jan 2025 15:27:30 + Subject: [PATCH] faster indexing --- .../Plugins/SymbolFile/DWARF/DWARFUnit.

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Pavel Labath via lldb-commits
@@ -14,6 +14,7 @@ #include #include +#include labath wrote: If bzero is out, then the header should go out as well (unless it used for other things, but I don't see anything like that). If anyone wants to reintroduce bzero, they can/should re-add the hea

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/120979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 81898ac - Revert "[lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (#120457)"

2025-01-08 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2025-01-08T15:49:46+01:00 New Revision: 81898ac00e04ed3f352534a810829bdf4e6e14b7 URL: https://github.com/llvm/llvm-project/commit/81898ac00e04ed3f352534a810829bdf4e6e14b7 DIFF: https://github.com/llvm/llvm-project/commit/81898ac00e04ed3f352534a810829bdf4e6e14b7.dif

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #120457)

2025-01-08 Thread Benjamin Kramer via lldb-commits
d0k wrote: Reverted this in 81898ac00e04ed3f352534a810829bdf4e6e14b7. Apart from breaking windows, I'm also seeing some weirdness when debugging iOS apps with this change, don't know what's going on. https://github.com/llvm/llvm-project/pull/120457 _

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/120979 >From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Mon, 23 Dec 2024 10:22:40 -0600 Subject: [PATCH 1/6] Some base #if _AIX changes --- .../Host/posix/

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-08 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/119052 >From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 6 Dec 2024 18:17:44 -0800 Subject: [PATCH 1/3] Add SBPRogress class to enable commands to async report to l

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 29ed6000d21edd1a88b2daad242e1f356cafbaca...26424c0ad0b85106ce20b8d93f40bc583805abd0 lldb/

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-08 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/119052 >From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 6 Dec 2024 18:17:44 -0800 Subject: [PATCH 1/4] Add SBPRogress class to enable commands to async report to l

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-08 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @JDevlieghere Do we want to add new tests having the external bit by default? I added unit tests in the [external category bit](https://github.com/llvm/llvm-project/pull/120171/files#diff-a1f24599f1588366a91518f71afd1a54b6f8172a1f0891747e6972d126be4159) PR. Any additional test r

[Lldb-commits] [lldb] [lldb] Move GetEnvironment function into common code (PR #122173)

2025-01-08 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/122173 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move GetEnvironment function into common code (PR #122173)

2025-01-08 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/122173 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move GetEnvironment function into common code (PR #122173)

2025-01-08 Thread Pavel Labath via lldb-commits
@@ -114,6 +114,12 @@ void LogChannelSystem::Initialize() { void LogChannelSystem::Terminate() { g_system_log.Disable(); } #if !defined(__APPLE__) && !defined(_WIN32) +extern "C" { +extern char **environ; +} labath wrote: ```suggestion extern "C" char **enviro

[Lldb-commits] [lldb] 18de1db - [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (#120979)

2025-01-08 Thread via lldb-commits
Author: Dhruv Srivastava Date: 2025-01-09T09:38:25+05:30 New Revision: 18de1db0cfbfbbf12d16338923b43077a87dce18 URL: https://github.com/llvm/llvm-project/commit/18de1db0cfbfbbf12d16338923b43077a87dce18 DIFF: https://github.com/llvm/llvm-project/commit/18de1db0cfbfbbf12d16338923b43077a87dce18.di

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/120979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,64 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,64 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -229,3 +229,64 @@ bytes. `zt0`'s value and whether it is active or not will be saved prior to expression evaluation and restored afterwards. + +## Guarded Control Stack Extension (GCS) + +GCS support includes the following new registers: + +* `gcs_features_enabled` +* `gcs_

[Lldb-commits] [lldb] [lldb][Docs] Add Guarded Control Stack to AArch64 Linux page (PR #117860)

2025-01-08 Thread Omair Javaid via lldb-commits
omjavaid wrote: I read the documentation again and find some minor points. Feel free to ignore them if you want. https://github.com/llvm/llvm-project/pull/117860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #120457)

2025-01-08 Thread Leandro Lupori via lldb-commits
luporl wrote: > LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` > running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 > "test". > > Full details are available at: > https://lab.llvm.org/buildbot/#/builders/141/builds/5258 > Here is the relevant

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
omjavaid wrote: @DavidSpickett have you posted rest of the patches for GCS other than this one? https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #120457)

2025-01-08 Thread John Harrison via lldb-commits
ashgti wrote: I'll take a look https://github.com/llvm/llvm-project/pull/120457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][RFC][lldb] faster indexing (PR #122128)

2025-01-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fdd7cafb9078e146634a3fbb72a8949108dca425 b534596aa6d7c2c38610d8b32a06ca7a8c6857f5 --e

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -1629,10 +1630,10 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo( std::tie(flag, flags) = flags.split(' '); omjavaid wrote: instead of tokenizing and checking cant we just use `if (value.contains("mt")) region_info.SetMemoryTagged

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -164,12 +164,17 @@ void lldb_private::ParseLinuxSMapRegions(llvm::StringRef linux_smap, if (!name.contains(' ')) { if (region) { if (name == "VmFlags") { - if (value.contains("mt")) -region->SetMemoryTagged(MemoryRegionInfo::eYes); -

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -101,12 +105,13 @@ class MemoryRegionInfo { bool operator==(const MemoryRegionInfo &rhs) const { return m_range == rhs.m_range && m_read == rhs.m_read && m_write == rhs.m_write && m_execute == rhs.m_execute && - m_shared == rhs.m_shared && -

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-08 Thread Omair Javaid via lldb-commits
@@ -2796,11 +2796,17 @@ GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo( // Flags MemoryRegionInfo::OptionalBool memory_tagged = region_info.GetMemoryTagged(); -if (memory_tagged != MemoryRegionInfo::eDontKnow) { +MemoryRegionInfo::OptionalBo

[Lldb-commits] [lldb] [lldb] Move GetEnvironment function into common code (PR #122173)

2025-01-08 Thread Brad Smith via lldb-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/122173 None >From 43784f2bb5f4755f9cf1e63738ad4c566c7d3044 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Wed, 8 Jan 2025 16:23:11 -0500 Subject: [PATCH] [lldb] Move GetEnvironment function into common code --- lldb/

[Lldb-commits] [lldb] [lldb] Move GetEnvironment function into common code (PR #122173)

2025-01-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brad Smith (brad0) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122173.diff 5 Files Affected: - (modified) lldb/source/Host/common/Host.cpp (+6) - (modified) lldb/source/Host/freebsd/Host.cpp (-6) - (modified) lldb

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-08 Thread via lldb-commits
@@ -0,0 +1,117 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-08 Thread via lldb-commits
@@ -0,0 +1,117 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-08 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/119052 >From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 6 Dec 2024 18:17:44 -0800 Subject: [PATCH 1/4] Add SBPRogress class to enable commands to async report to l

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-08 Thread via lldb-commits
@@ -0,0 +1,356 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-08 Thread via lldb-commits
@@ -0,0 +1,191 @@ +//===-- DILLexer.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-08 Thread via lldb-commits
@@ -0,0 +1,356 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Updated the branch @labath @DavidSpickett https://github.com/llvm/llvm-project/pull/120979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][OpenBSD][NFC] Replace tab with spaces (PR #122041)

2025-01-08 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/122041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread David Spickett via lldb-commits
@@ -730,9 +730,21 @@ ConnectionStatus ConnectionFileDescriptor::ConnectFile( struct termios options; ::tcgetattr(fd, &options); -// Set port speed to maximum +// Set port speed to the available maximum +#ifdef B115200 ::cfsetospeed(&options, B115200);

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread David Spickett via lldb-commits
@@ -14,6 +14,7 @@ #include #include +#include DavidSpickett wrote: this can go now, right? Now that bzero is not being used. https://github.com/llvm/llvm-project/pull/120979 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb][OpenBSD][NFC] Replace tab with spaces (PR #122041)

2025-01-08 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/122041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 30b7da7 - [lldb][OpenBSD][NFC] Replace tab with spaces (#122041)

2025-01-08 Thread via lldb-commits
Author: Brad Smith Date: 2025-01-08T10:19:21Z New Revision: 30b7da72f2abef7cad4d1b38e141e7d2ef170d88 URL: https://github.com/llvm/llvm-project/commit/30b7da72f2abef7cad4d1b38e141e7d2ef170d88 DIFF: https://github.com/llvm/llvm-project/commit/30b7da72f2abef7cad4d1b38e141e7d2ef170d88.diff LOG: [l

[Lldb-commits] [lldb] [lldb][OpenBSD][NFC] Replace tab with spaces (PR #122041)

2025-01-08 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/122041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Dhruv Srivastava via lldb-commits
@@ -730,9 +730,21 @@ ConnectionStatus ConnectionFileDescriptor::ConnectFile( struct termios options; ::tcgetattr(fd, &options); -// Set port speed to maximum +// Set port speed to the available maximum +#ifdef B115200 ::cfsetospeed(&options, B115200);

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread Dhruv Srivastava via lldb-commits
@@ -14,6 +14,7 @@ #include #include +#include DhruvSrivastavaX wrote: Yes, it does not have any immediate need, but just keeping it in reference to @labath's comment: https://github.com/llvm/llvm-project/pull/120979#discussion_r1905127075 Possibly for fut

[Lldb-commits] [lldb] [lldb][AIX] Some base #if _AIX changes of a minimal lldb build (PR #120979)

2025-01-08 Thread David Spickett via lldb-commits
@@ -14,6 +14,7 @@ #include #include +#include DavidSpickett wrote: Understood, leave it in then. https://github.com/llvm/llvm-project/pull/120979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb][OpenBSD] Make use of Environment class (PR #122040)

2025-01-08 Thread Brad Smith via lldb-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/122040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 647e8d8 - [lldb][OpenBSD] Make use of Environment class (#122040)

2025-01-08 Thread via lldb-commits
Author: Brad Smith Date: 2025-01-08T16:18:11-05:00 New Revision: 647e8d8dee8c2b68f0b9da7956e4af272b52149b URL: https://github.com/llvm/llvm-project/commit/647e8d8dee8c2b68f0b9da7956e4af272b52149b DIFF: https://github.com/llvm/llvm-project/commit/647e8d8dee8c2b68f0b9da7956e4af272b52149b.diff LO