llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This moves the ownership of the threads that forward stdout/stderr to the DAP
object itself to ensure that the threads are joined and that the forwarding is
cleaned up when the DAP connection is disconnected.
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From f59cf06ff3d11baabee10ba47151a8c9d4e03733 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/3] [lldb-dap] Ensure the IO forwarding threads are managed
by t
jasonmolenda wrote:
I debugged the two test failures I'm seeing on an M4, neither is related to the
SME changes. I will handle those two issues separately, this is ready to land.
https://github.com/llvm/llvm-project/pull/119171
___
lldb-commits maili
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/120457
>From f59cf06ff3d11baabee10ba47151a8c9d4e03733 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 17 Dec 2024 17:45:34 -0800
Subject: [PATCH 1/2] [lldb-dap] Ensure the IO forwarding threads are managed
by t
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/5] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
@@ -257,8 +257,8 @@ enum StopReason {
};
/// Command Return Status Types.
-enum ReturnStatus {
- eReturnStatusInvalid,
+enum ReturnStatus : int {
+ eReturnStatusInvalid = 0,
oontvoo wrote:
carry-over comment from previous patch("Why is this needed?")
This
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/119716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
oontvoo wrote:
> > Pavel's suggestion was to split up the patch to make reviewing easier
>
> It was, but this wasn't the kind of separation I had in mind. For me as
> least, it's very hard to review features in these "horizontal" slices. It's
> also unclear how (if ever) will this code be test
Author: Dhruv Srivastava
Date: 2024-12-18T12:44:31Z
New Revision: 0c6860622c249ae7adc784c66a8d0b1335a9e7df
URL:
https://github.com/llvm/llvm-project/commit/0c6860622c249ae7adc784c66a8d0b1335a9e7df
DIFF:
https://github.com/llvm/llvm-project/commit/0c6860622c249ae7adc784c66a8d0b1335a9e7df.diff
L
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
@labath what do you think?
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -21,8 +21,8 @@
#include
#include
-#include
#include
+#include
DavidSpickett wrote:
Please make a PR for these clang-format changes.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/3] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/120279
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/4] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120459
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/120457
This moves the ownership of the threads that forward stdout/stderr to the DAP
object itself to ensure that the threads are joined and that the forwarding is
cleaned up when the DAP connection is disconnected.
T
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/120456
Became unused since the recent
https://github.com/llvm/llvm-project/pull/110648
>From e9a8d02777b3e618a7c55f6b13d8b2ce2a73162c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 18 Dec 2024 17:10:42 +000
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Became unused since the recent
https://github.com/llvm/llvm-project/pull/110648
---
Full diff: https://github.com/llvm/llvm-project/pull/120456.diff
2 Files Affected:
- (modified) lldb/source/Plugins/Sym
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b1d42465fc1485d46b4727e6830272f369fb6cb5
f59cf06ff3d11baabee10ba47151a8c9d4e03733 --e
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/6] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From 44fa888e6fce3788342011e445b97b293cba1c5e Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 12 Dec 2024 10:47:09 -0500
Subject: [PATCH 1/7] [lldb][telemetry] Implement LLDB Telemetry (part 1)
Details:
-
@@ -226,13 +238,13 @@ MainLoopPosix::~MainLoopPosix() {
#endif
m_read_fds.erase(m_interrupt_pipe.GetReadFileDescriptor());
m_interrupt_pipe.Close();
- assert(m_read_fds.size() == 0);
+ assert(m_read_fds.size() == 0);
assert(m_signals.size() == 0);
}
MainLoopPosix:
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/120279
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,63 @@
+# Tests that LLDB correctly finds the implementation
+# DIE (with a `DW_AT_APPLE_objc_complete_type`)
+# given an interface DIE (without said attribute).
+#
+# RUN: split-file %s %t
+# RUN: %clangxx_host %t/lib.m -c -g -o %t/lib.o
+# RUN: %clangxx_host %t/main.m
https://github.com/labath approved this pull request.
> Something that's not currently clear to me is why frame var *f succeeds even
> without the DW_AT_APPLE_objc_complete_type infrastructure. If it's using the
> ObjC runtime, which should make expr do the same, in which case we can remove
>
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120390
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX deleted
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -47,8 +47,7 @@ static void write_string(int error_fd, const char *str) {
(void)r;
}
-[[noreturn]] static void ExitWithError(int error_fd,
- const char *operation) {
+[[noreturn]] static void ExitWithError(int error_fd, const char *ope
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: wanglei (wangleiat)
Changes
According to the documentation described at
https://github.com/loongson/la-abi-specs/blob/release/ladwarf.adoc, the
dwarf numbers for floating-point registers range from 32 to 63.
An incorrect dwarf number will p
https://github.com/wangleiat created
https://github.com/llvm/llvm-project/pull/120391
According to the documentation described at
https://github.com/loongson/la-abi-specs/blob/release/ladwarf.adoc, the
dwarf numbers for floating-point registers range from 32 to 63.
An incorrect dwarf number wil
DhruvSrivastavaX wrote:
So, all the tests have passed.
I would request you to merge as I dont have the write access yet.
Thanks!!
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
DavidSpickett wrote:
> Yes, to handle the 64-bit debuggees in AIX, we would need the ptrace64 call.
> It will apply to all the ptrace calls in general.
It is used in the NativeProcess/Thread plugins, but since those are new plugins
only for AIX they dont need an #if AIX.
Thanks. Yes I see that
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 01/10] Added XCOFF Header Parsing
---
.../ObjectFil
labath wrote:
I'm also not very thrilled by this. I think your use case would be very hard to
support in the long term. From the sound of things, you're using a fairly
limited subset of the lldb api (SBModule, SBCompileUnit, SBType?), but even so,
i think we can't guarantee that neither of the
@@ -81,9 +79,44 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120390
>From 6361863d1533361146677c3bac8ce325ed2721a9 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 03:10:23 -0600
Subject: [PATCH 1/2] Added AIX version of ptrace
---
lldb/source/Ho
@@ -226,13 +238,13 @@ MainLoopPosix::~MainLoopPosix() {
#endif
m_read_fds.erase(m_interrupt_pipe.GetReadFileDescriptor());
m_interrupt_pipe.Close();
- assert(m_read_fds.size() == 0);
+ assert(m_read_fds.size() == 0);
assert(m_signals.size() == 0);
}
MainLoopPosix:
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120378
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -139,8 +177,53 @@ FileSpec HostInfoPosix::GetDefaultShell() {
return FileSpec("/bin/sh");
}
+FileSpec HostInfoPosix::GetProgramFileSpec() {
+ static FileSpec g_program_filespec;
+
+ if (!g_program_filespec) {
+char exe_path[PATH_MAX];
+ssize_t len = readlink("/p
Author: David Spickett
Date: 2024-12-18T09:43:54Z
New Revision: 66bdbfbaa08fa3d8e64a7fe136a8fb717f5cdbb7
URL:
https://github.com/llvm/llvm-project/commit/66bdbfbaa08fa3d8e64a7fe136a8fb717f5cdbb7
DIFF:
https://github.com/llvm/llvm-project/commit/66bdbfbaa08fa3d8e64a7fe136a8fb717f5cdbb7.diff
LOG
DhruvSrivastavaX wrote:
AIX ptrace (ptrace,ptracex,ptrace64) has a different format, so we would need
an AIX specific case anyway.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
https://github.com/DhruvSrivastavaX deleted
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Can you summarise the need for ptrace64? Mainly, will this only apply to
launching a process or does it apply to any ptrace call?
I wonder:
1. How many #ifdef we're going to end up with
2. Whether AIX should use ptrace64 everywhere if your intention is to only
support AIX
DhruvSrivastavaX wrote:
> Please link to the English docs -
> https://www.ibm.com/docs/en/aix/7.3?topic=p-ptrace-ptracex-ptrace64-subroutine
> instead.
Apologies for the blunder, I myself dont speak French by the way. 😀 Corrected
https://github.com/llvm/llvm-project/pull/120390
_
@@ -193,8 +192,13 @@ struct ForkLaunchInfo {
}
// Start tracing this child that is about to exec.
+#if !defined(_AIX)
DavidSpickett wrote:
Generally I would prefer positive conditions as the first part of an if. So
here it would be if AIX use ptrace6
DavidSpickett wrote:
> Apologies for the blunder, I myself dont speak French by the way. 😀 Corrected
I am kinda impressed how many languages they have available, but the downside
is that Google seems to love choosing a non-English one for me.
https://github.com/llvm/llvm-project/pull/120390
__
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 01/11] Added XCOFF Header Parsing
---
.../ObjectFil
@@ -127,19 +162,31 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+ // Need to set this as XCOFF is only c
@@ -79,9 +79,45 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
DhruvSrivastavaX wrote:
So, I have handled all the comments. Please merge if everything is alright.
@labath @DavidSpickett
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
DhruvSrivastavaX wrote:
> I am kinda impressed how many languages they have available, but the downside
> is that Google seems to love choosing a non-English one for me.
Pretty much same for me. It will always be either Japanese or Korean. French is
a new addition perhaps. 😄
https://github.c
@@ -21,8 +21,8 @@
#include
#include
-#include
#include
+#include
DhruvSrivastavaX wrote:
Added by clang-format
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists
@@ -47,8 +47,7 @@ static void write_string(int error_fd, const char *str) {
(void)r;
}
-[[noreturn]] static void ExitWithError(int error_fd,
- const char *operation) {
+[[noreturn]] static void ExitWithError(int error_fd, const char *ope
DavidSpickett wrote:
I just pushed the clang-format changes for you, rebase to include them.
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
DavidSpickett wrote:
You can send a formatting PR then one for actual changes, where the first
commit is the formatting. You'll just need to rebase the second one once the
first one lands. This will save us some back and forth.
You can use one of those stacked PR manager tools but for <= 2 cha
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120378
>From cf6a863b6da6bdaf474d2abc4524960b6436f645 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 02:17:04 -0600
Subject: [PATCH] AIX Changes for MainLoop
---
lldb/source/Host/posi
DhruvSrivastavaX wrote:
Okay sure. Thats a great suggestion.
Updated my branch for this one.
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/labath commented:
Small patch, but a lot of comments:
- with the last round of MainLoop changes, the sigmask changes aren't necessary
anymore -- just drop them (this also sort of means we could just use `poll`
everywhere, but I kinda like it because of the increased precision
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -127,19 +162,31 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+ // Need to set this as XCOFF is only c
https://github.com/labath approved this pull request.
Two more quick comments, but otherwise looks good. Thanks for your patience.
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
@@ -79,9 +79,45 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
DavidSpickett wrote:
Please link to the English docs -
https://www.ibm.com/docs/en/aix/7.3?topic=p-ptrace-ptracex-ptrace64-subroutine
instead.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -127,19 +162,31 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+ // Need to set this as XCOFF is only c
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/120518
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/119171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,11 +50,19 @@ def test_register_commands(self):
# verify that logging does not assert
self.log_enable("registers")
+error_str_matched = False
+if self.get_sme_available() == True and self.platformIsDarwin():
JDevlieghere w
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/119171
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
75 matches
Mail list logo
