https://github.com/frederick-vs-ja approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/118059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/LilyWangLL edited
https://github.com/llvm/llvm-project/pull/118059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/LilyWangLL edited
https://github.com/llvm/llvm-project/pull/118059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
This is what I would have assumed reading
https://en.cppreference.com/w/cpp/chrono, so LGTM. Thank you for the proactive
fix!
Given that this has built on other platforms without issue, is it worth
checking if libcxx also has this q
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/118093
During lldb testing dotest.py opens files to dump testcase results, but doesn't
close them.
This patch makes neccessary changes to fix the file descriptors leak.
>From e449a10882233c52d9ae8602376489340afdf6e9
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
During lldb testing dotest.py opens files to dump testcase results, but doesn't
close them.
This patch makes neccessary changes to fix the file descriptors leak.
---
Full diff: https://github.com/llvm/llvm-project/p
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/118094
Currently SyntheticCappingTestCase fails with
```
AttributeError: type object 'fooSynthProvider' has no attribute
'reset_max_num_children_max'
```
The source of the issue is that lldb during PythonSynthDataForma
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
Currently SyntheticCappingTestCase fails with
```
AttributeError: type object 'fooSynthProvider' has no attribute
'reset_max_num_children_max'
```
The source of the issue is that lldb during PythonSynthDataFormatterTe
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/118095
Currently lldb testsuite requires some interactive input:
```
test_artificial_source_location (TestSourceManager.SourceManagerTestCase)
There is a running process, kill it and restart?: [Y/n]
```
This patch set
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
Currently lldb testsuite requires some interactive input:
```
test_artificial_source_location (TestSourceManager.SourceManagerTestCase)
There is a running process, kill it and restart?: [Y/n]
```
This patch sets lldb
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
fedb9fdb98314ff0ddff065dbd6ef8b2b7e6ec96...11d1f52ea2bc578c9bd15646d653f5e2a1626750
lldb
DavidSpickett wrote:
On what platform are you seeing this problem? None of Linaro's bots have an
issue with the test.
Is it because you're using remote debugging and only in that case it prompts
for this?
https://github.com/llvm/llvm-project/pull/118095
___
DavidSpickett wrote:
Seems fine but please expand on `Currently SyntheticCappingTestCase fails with`
to say where it fails. Linaro's bots don't have a problem with this test, so I
assume you are using a different kind of setup.
https://github.com/llvm/llvm-project/pull/118094
_
DavidSpickett wrote:
It leaks the fds if `dumpSessionInfo` is never called, do I understand
correctly? If so please add that information to the PR description.
https://github.com/llvm/llvm-project/pull/118093
___
lldb-commits mailing list
lldb-commits
dlav-sc wrote:
> It leaks the fds if `dumpSessionInfo` is never called
Yeah, `dumpSessionInfo` closes session log file, but looks like
`dumpSessionInfo` isn't called anywhere. Honestly, I don't understand the
necessity of the function in that case, maybe we can remove it.
https://github.com/l
https://github.com/DavidSpickett approved this pull request.
Happy for it to be fixed and removed in another PR if it's unused.
Saves us resurrecting a broken function if we do want it back in future.
https://github.com/llvm/llvm-project/pull/118093
_
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/118093
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dlav-sc wrote:
> Seems fine but please expand on `Currently SyntheticCappingTestCase fails
> with` to say where it fails.
I can provide the fail log. Looks like lldb firstly runs
`PythonSynthDataFormatterTestCase` and then `SyntheticCappingTestCase`, but it
doesn't really matter, because if
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,213 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
dlav-sc wrote:
> On what platform are you seeing this problem?
I've encountered with the problem using remote debugging at first, but then I
was able to reproduce it on x86 host platform with command looks like this (I
don't remember exactly):
```
python3 lldb/test/API/dotest.py -A x86-64 -C b
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 1/5] Added XCOFF Header Parsing
---
.../ObjectFile/
DhruvSrivastavaX wrote:
It is updated now. Please provide your review and merge if everything is good.
@labath
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/118059
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/118160
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e874c8fc27bbc0e340691d5b5d01c7a1bd365890
3462b9263d4f268a89baf4b956b8dc851858fe0a --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dhruv Srivastava (DhruvSrivastavaX)
Changes
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-projec
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/3] Added base files for NativeProcess for AIX
---
28 matches
Mail list logo
