https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/115337
Fixed the @skipUnlessAArch64MTELinuxCompiler decorator in case of Windows host.
>From d9f799f02fb47804d4e35c5fd73433280b650257 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 7 Nov 2024 20:22:57 +040
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21835ee28d47037137ea5a73ba466211b3e1a2d1
f227cd7076f27917da400f307635ee2376267b95 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Fixed the @skipUnlessAArch64MTELinuxCompiler decorator in case of
Windows host.
---
Full diff: https://github.com/llvm/llvm-project/pull/115337.diff
1 Files Affected:
- (modified) lldb/packages/Python/
dwblaikie wrote:
@zmodem perhaps you know someone who might be able to look at a CodeView change?
https://github.com/llvm/llvm-project/pull/113102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -11,23 +11,28 @@
#define LLDB_TOOLS_LLDB_DAP_INSTRUCTIONBREAKPOINT_H
#include "Breakpoint.h"
+#include "DAPForward.h"
+
+#include "lldb/lldb-defines.h"
+#include "lldb/lldb-types.h"
+
+#include
namespace lldb_dap {
// Instruction Breakpoint
struct InstructionBreakpo
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/115318
This test checks the thread backtrace for entries of intermediate frames that
aren't aligned to 16 bytes. In order to do that, it sets a single breakpoint
and makes sure we stop there. It seems sufficien
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/115208
>From 125c8976906ff25da6e212dff21d1b129575bd28 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 6 Nov 2024 09:36:48 -0800
Subject: [PATCH 1/4] [lldb-dap] Refactoring breakpoints to not use the `g_dap`
ref
@@ -11,23 +11,28 @@
#define LLDB_TOOLS_LLDB_DAP_INSTRUCTIONBREAKPOINT_H
#include "Breakpoint.h"
+#include "DAPForward.h"
+
+#include "lldb/lldb-defines.h"
+#include "lldb/lldb-types.h"
+
+#include
namespace lldb_dap {
// Instruction Breakpoint
struct InstructionBreakpo
https://github.com/jimingham approved this pull request.
`expr` is much more common than `exit` or `env` so this seems like a fine idea.
https://github.com/llvm/llvm-project/pull/115359
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/115359
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/115382
Add the ability to override the disassembly CPU and CPU features through a
target setting (`target.disassembly-cpu` and
`target.disassembly-features`) and a `disassemble` command option (`--cpu` and
`--fea
Author: Dave Lee
Date: 2024-11-07T11:24:00-08:00
New Revision: 60e3a81c4299baf80e7b80db9cb8368223ee9546
URL:
https://github.com/llvm/llvm-project/commit/60e3a81c4299baf80e7b80db9cb8368223ee9546
DIFF:
https://github.com/llvm/llvm-project/commit/60e3a81c4299baf80e7b80db9cb8368223ee9546.diff
LOG:
@@ -0,0 +1,31 @@
+// Test lldb is able to compute the fully qualified names on templates with
+// -gsimple-template-names and -fdebug-types-section.
+
+// REQUIRES: lld
+
+// Test against logging to see if we print the fully qualified names correctly.
+// RUN: %clangxx --target=x8
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/112811
>From 3fc0675398547617731d0501e3d4b98e2ffc480e Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 9 Oct 2024 22:35:46 -0700
Subject: [PATCH 1/3] [lldb][dwarf] Compute fully qualified names on simplified
templ
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/115288
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Lua doesn't guarantee compatibility between minor versions to Lua 5.3 and
5.4 are more like Python 2 and Python 3 rather than Python 3.9 and 3.11 for
example. I might try to get it working with both at some point (mostly because
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/112811
>From 3fc0675398547617731d0501e3d4b98e2ffc480e Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 9 Oct 2024 22:35:46 -0700
Subject: [PATCH 1/4] [lldb][dwarf] Compute fully qualified names on simplified
templ
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Add the ability to override the disassembly CPU and CPU features through a
target setting (`target.disassembly-cpu` and
`target.disassembly-features`) and a `disassemble` command option (`--cpu` and
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/115401
https://github.com/llvm/llvm-project/pull/111859 fixed these tests for DWARFv4
on Linux by adjusting the manual index. As part of the change we unXFAILed
these tests for DWARFv4 on all platforms. However, th
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/115401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
https://github.com/llvm/llvm-project/pull/111859 fixed these tests for DWARFv4
on Linux by adjusting the manual index. As part of the change we unXFAILed
these tests for DWARFv4 on all platforms. However,
Michael137 wrote:
https://github.com/llvm/llvm-project/pull/115401
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/115401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/115401
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/115382
>From b5947cfe8fd7702f801c91f48ca050a5c839a707 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 7 Nov 2024 14:08:50 -0800
Subject: [PATCH 1/3] [lldb] Support overriding the disassembly CPU & feat
Author: Michael Buch
Date: 2024-11-08T00:23:38Z
New Revision: 1ced07e06e23659a96dbf6d53cd68d3bbbe3d792
URL:
https://github.com/llvm/llvm-project/commit/1ced07e06e23659a96dbf6d53cd68d3bbbe3d792
DIFF:
https://github.com/llvm/llvm-project/commit/1ced07e06e23659a96dbf6d53cd68d3bbbe3d792.diff
LOG:
@@ -11,23 +11,28 @@
#define LLDB_TOOLS_LLDB_DAP_INSTRUCTIONBREAKPOINT_H
#include "Breakpoint.h"
+#include "DAPForward.h"
+
+#include "lldb/lldb-defines.h"
+#include "lldb/lldb-types.h"
+
+#include
namespace lldb_dap {
// Instruction Breakpoint
struct InstructionBreakpo
@@ -2701,28 +2702,21 @@ void request_setBreakpoints(const llvm::json::Object
&request) {
// to an empty array.
if (breakpoints) {
for (const auto &bp : *breakpoints) {
- auto bp_obj = bp.getAsObject();
+ const auto *bp_obj = bp.getAsObject();
if (bp_ob
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/115288
Technically you can manually set `LUA_LIBRARIES` and others to use a different
version, and I don't see any version checks in the C++ code. However, I'm not
sure that is intentional, it looks more like a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Technically you can manually set `LUA_LIBRARIES` and others to use a different
version, and I don't see any version checks in the C++ code. However, I'm not
sure that is intentional, it looks more lik
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/115208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo commented:
Besides everything mentioned by Pavel, this looks pretty good.
https://github.com/llvm/llvm-project/pull/115208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
Michael137 wrote:
This also fails on the macOS buildbots:
```
FAIL: test_inline_static_members_dwarf4_dsym
(TestConstStaticIntegralMember.TestCase)
--
Traceback (most recent call last):
File
"/Users/ec2-user/jenkins/workspace
Author: David Spickett
Date: 2024-11-07T15:27:12Z
New Revision: 85eec89600085a054650585d3a3287a6e0a93a50
URL:
https://github.com/llvm/llvm-project/commit/85eec89600085a054650585d3a3287a6e0a93a50
DIFF:
https://github.com/llvm/llvm-project/commit/85eec89600085a054650585d3a3287a6e0a93a50.diff
LOG
DavidSpickett wrote:
I've disabled the new tests on Windows but can't look into the reason for the
failures until next week.
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
Author: Ilia Kuklin
Date: 2024-11-07T16:06:03+05:00
New Revision: 1361c19c04d0b3d9156fe0c5393d158cf69c14e7
URL:
https://github.com/llvm/llvm-project/commit/1361c19c04d0b3d9156fe0c5393d158cf69c14e7
DIFF:
https://github.com/llvm/llvm-project/commit/1361c19c04d0b3d9156fe0c5393d158cf69c14e7.diff
L
https://github.com/kuilpd closed
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/115208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4572,235 +4554,219 @@ void request__testGetTargetBreakpoints(const
llvm::json::Object &request) {
// "(with reason `instruction breakpoint`) is generated.\nClients "
// "should only call this request if the corresponding capability "
// "`supp
@@ -7,12 +7,15 @@
//===--===//
#include "BreakpointBase.h"
+
#include "JSONUtils.h"
+#include "llvm/ADT/StringRef.h"
labath wrote:
```suggestion
#include "BreakpointBase.h"
#include "JSON
@@ -10,6 +10,8 @@
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINT_H
#include "BreakpointBase.h"
+#include "DAPForward.h"
+
#include "lldb/API/SBBreakpoint.h"
labath wrote:
```suggestion
#include "DAPForward.h"
#include "lldb/API/SBBreakpoint.h"
```
https://github.co
@@ -7,10 +7,19 @@
//===--===//
#include "Breakpoint.h"
-#include "DAP.h"
+
#include "JSONUtils.h"
+
+#include "lldb/API/SBAddress.h"
#include "lldb/API/SBBreakpointLocation.h"
+#include "lldb/API/SBLineEntr
https://github.com/labath commented:
This PR is much easier to review. I mainly focused on the stylistic parts. I'll
leave it to the lldb-dap maintainers to review the functionality.
Copying polymorphic objects around is asking for trouble, and I don't think we
should be doing that. You didn't
@@ -9,21 +9,27 @@
#ifndef LLDB_TOOLS_LLDB_DAP_EXCEPTIONBREAKPOINT_H
#define LLDB_TOOLS_LLDB_DAP_EXCEPTIONBREAKPOINT_H
-#include
+#include "DAPForward.h"
#include "lldb/API/SBBreakpoint.h"
+#include "lldb/lldb-enumerations.h"
+
+#include
+#include
labath
@@ -3202,8 +3184,7 @@ void request_setDataBreakpoints(const llvm::json::Object
&request) {
for (const auto &bp : *breakpoints) {
const auto *bp_obj = bp.getAsObject();
if (bp_obj) {
labath wrote:
here too
https://github.com/llvm/llvm-project/
@@ -11,23 +11,28 @@
#define LLDB_TOOLS_LLDB_DAP_INSTRUCTIONBREAKPOINT_H
#include "Breakpoint.h"
+#include "DAPForward.h"
+
+#include "lldb/lldb-defines.h"
+#include "lldb/lldb-types.h"
+
+#include
labath wrote:
```suggestion
#include "Breakpoint.h"
#include
@@ -9,21 +9,25 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
+#include "DAPForward.h"
+
#include
labath wrote:
```suggestion
#include "DAPForward.h"
#include
```
https://github
@@ -7,18 +7,19 @@
//===--===//
#include "FunctionBreakpoint.h"
+
#include "DAP.h"
labath wrote:
```suggestion
#include "FunctionBreakpoint.h"
#include "DAP.h"
```
https://github.com/llvm/l
@@ -6,27 +6,55 @@
//
//===--===//
-#include
-#include
-#include
-#include
+#include "JSONUtils.h"
-#include "llvm/ADT/StringRef.h"
-#include "llvm/Support/FormatVariadic.h"
-#include "llvm/Support/Path.
@@ -8,22 +8,30 @@
//===--===//
#include "InstructionBreakpoint.h"
+
#include "DAP.h"
#include "JSONUtils.h"
+#include "lldb/API/SBBreakpoint.h"
+#include "lldb/API/SBTarget.h"
+
+#include "llvm/ADT/String
@@ -95,6 +100,8 @@ class DWARFBaseDIE {
const char *GetName() const;
+ const char *getShortName() const { return GetName(); }
labath wrote:
(I was considering the same thing, but I don't particularly care either way)
https://github.com/llvm/llvm-project/
@@ -46,6 +48,7 @@ class DWARFBaseDIE {
explicit operator bool() const { return IsValid(); }
bool IsValid() const { return m_cu && m_die; }
+ bool isValid() const { return IsValid(); }
labath wrote:
I'm sorry, I guess I wasn't clear about this. What I was
@@ -11,23 +11,28 @@
#define LLDB_TOOLS_LLDB_DAP_INSTRUCTIONBREAKPOINT_H
#include "Breakpoint.h"
+#include "DAPForward.h"
+
+#include "lldb/lldb-defines.h"
+#include "lldb/lldb-types.h"
+
+#include
namespace lldb_dap {
// Instruction Breakpoint
struct InstructionBreakpo
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
@llvm/pr-subscribers-lldb
Author: None (anjenner)
Changes
…Stream.
CachedFileStream has previously performed the commit step in its destructor,
but this means its only recourse for error handling is report_fatal_error.
Modify this to add an
https://github.com/anjenner created
https://github.com/llvm/llvm-project/pull/115331
…Stream.
CachedFileStream has previously performed the commit step in its destructor,
but this means its only recourse for error handling is report_fatal_error.
Modify this to add an explicit commit() method,
DavidSpickett wrote:
Test was fixed by https://github.com/llvm/llvm-project/pull/114628.
https://github.com/llvm/llvm-project/pull/114295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
@@ -0,0 +1,31 @@
+// Test lldb is able to compute the fully qualified names on templates with
+// -gsimple-template-names and -fdebug-types-section.
+
+// REQUIRES: lld
+
+// Test against logging to see if we print the fully qualified names correctly.
+// RUN: %clangxx --target=x8
weliveindetail wrote:
We see a few tests failing for this reason downstream in swift-lldb:
https://github.com/swiftlang/swift/pull/76894#issuecomment-2441139173 I filed a
ticket to investigate the actual issue
https://github.com/swiftlang/llvm-project/issues/9540
It would be great to unblock
walter-erquinigo wrote:
> With these changes, and the fact that BreakpointBase has a DAP& member, the
> breakpoints cannot be copied.
I don't see that as a problem, but if at some point we need some more
flexibility, we should be able to use std::reference_wrapper to store the ref
and then a
https://github.com/walter-erquinigo approved this pull request.
accepting because it seems you addressed all of Pavel's issues
https://github.com/llvm/llvm-project/pull/115208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
@@ -1010,12 +1024,21 @@ def is_toolchain_with_mte():
int main() {
void* ptr = __arm_mte_create_random_tag((void*)(0), 0);
}"""
-cmd = "echo '%s' | %s -march=armv8.5-a+memtag -x c -o %s -" % (
-test_src,
-co
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/115337
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/115408
None
>From db9978e0bf8ce26a71eb73393c4951d14cdbd510 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 7 Nov 2024 17:18:50 -0800
Subject: [PATCH] [lldb] Support riscv32 corefiles
---
.../Plugins
@@ -11,23 +11,28 @@
#define LLDB_TOOLS_LLDB_DAP_INSTRUCTIONBREAKPOINT_H
#include "Breakpoint.h"
+#include "DAPForward.h"
+
+#include "lldb/lldb-defines.h"
+#include "lldb/lldb-types.h"
+
+#include
namespace lldb_dap {
// Instruction Breakpoint
struct InstructionBreakpo
JDevlieghere wrote:
Although Lua doesn't use semver, the difference between 5.3 and 5.4 isn't as
stark as I thought. LLDB builds fine against Lua 5.4 and I was able to make the
test pass. I just need to make a change so we don't hardcode `5.3` in the path.
https://github.com/llvm/llvm-project
Author: wanglei
Date: 2024-11-08T10:43:57+08:00
New Revision: 1c8fca82a0f4ac6df5db539e96adcad143f5ebe7
URL:
https://github.com/llvm/llvm-project/commit/1c8fca82a0f4ac6df5db539e96adcad143f5ebe7
DIFF:
https://github.com/llvm/llvm-project/commit/1c8fca82a0f4ac6df5db539e96adcad143f5ebe7.diff
LOG:
https://github.com/wangleiat edited
https://github.com/llvm/llvm-project/pull/114742
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/wangleiat closed
https://github.com/llvm/llvm-project/pull/114742
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
72 matches
Mail list logo
