Author: Walter Erquinigo
Date: 2024-11-05T07:12:20-05:00
New Revision: 5d39e0c7e1b50fc9a0f77daeef5eb63bcbba5b35
URL:
https://github.com/llvm/llvm-project/commit/5d39e0c7e1b50fc9a0f77daeef5eb63bcbba5b35
DIFF:
https://github.com/llvm/llvm-project/commit/5d39e0c7e1b50fc9a0f77daeef5eb63bcbba5b35.di
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/114973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/114973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/114831
>From a98e1f6034479800f0c4ea053f9bee854151b04d Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 4 Nov 2024 17:56:06 +0100
Subject: [PATCH] Revert "Fix pointer to reference type (#113596)"
This reverts comm
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/113521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/114529
>From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 20 Oct 2024 11:35:15 +0100
Subject: [PATCH 1/2] [WIP][lldb][Expression] More reliable function call
resol
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/114973
Reverts llvm/llvm-project#113521
>From 84633d7ccc926abff46c6480dbe7ccc7e48247ce Mon Sep 17 00:00:00 2001
From: Walter Erquinigo
Date: Tue, 5 Nov 2024 07:11:32 -0500
Subject: [PATCH] Revert "[LLDB] Add
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu`
running on `as-builder-9` while building `lldb,llvm` at step 16
"test-check-lldb-api".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/195/builds/622
Here is the relevant pi
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux`
running on `systemz-1` while building `lldb,llvm` at step 6 "test-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/88/builds/4281
Here is the relevant piece of the build lo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
Reverts llvm/llvm-project#113521 due to build bot failures mentioned in
the original PR.
---
Full diff: https://github.com/llvm/llvm-project/pull/114973.diff
7 Files Affected:
- (modified) lld
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/114529
>From 9337e170d920eaabe2b59a25622f0c554ca5afcf Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 20 Oct 2024 11:35:15 +0100
Subject: [PATCH 1/2] [WIP][lldb][Expression] More reliable function call
resol
@@ -47,6 +48,10 @@ class LLDB_API SBStream {
void Print(const char *str);
+ bool HasColor();
+
+ void FormatAnsiTerminalCodes(llvm::StringRef format);
labath wrote:
You can't have a StringRef in the SB API. This needs to be a const char *. All
the inter
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ilia Kuklin (kuilpd)
Changes
The information about an enum's best promotion type is discarded after
compilation and is not present in debug info. This patch repeats the same
analysis of each enum value as in the front-end to determine the
https://github.com/kuilpd created
https://github.com/llvm/llvm-project/pull/115005
The information about an enum's best promotion type is discarded after
compilation and is not present in debug info. This patch repeats the same
analysis of each enum value as in the front-end to determine the b
kuilpd wrote:
My thought process for this patch:
https://github.com/llvm/llvm-project/issues/86989#issuecomment-2438116468
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
b2d2494731976ab7aa9702f3134472db694b9332...62c801145a2312d2c9339d30cf116fc2e709d630
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b2d2494731976ab7aa9702f3134472db694b9332
62c801145a2312d2c9339d30cf116fc2e709d630 --e
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 5290832b802d98b9d293b6910c0837911ec490c4 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 1/4] [lldb] Analyze enum promotion type during parsing
---
clang/in
@@ -46,6 +48,7 @@ class DWARFBaseDIE {
explicit operator bool() const { return IsValid(); }
bool IsValid() const { return m_cu && m_die; }
+ bool isValid() const { return IsValid(); }
labath wrote:
How about using `operator bool` as the common api ?
htt
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-11-05T16:39:31+01:00
New Revision: 1a684591da84dea644de6524a1d8646b245f636b
URL:
https://github.com/llvm/llvm-project/commit/1a684591da84dea644de6524a1d8646b245f636b
DIFF:
https://github.com/llvm/llvm-project/commit/1a684591da84dea644de6524a1d8646b245f636b.diff
https://github.com/labath commented:
I'd say this looks very good. Given this is a relatively novel approach, I'd
suggest we give folks a bit more time to take a look at this.
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing
kuilpd wrote:
> Not that this shouldn't be fixed, just weighing of the amount of complexity
> added here versus the benefit.
I don't really know how useful it is in general to know the actual promotion
type of the enum, I guess only for using enum values in expressions without
explicit castin
https://github.com/Michael137 approved this pull request.
LGTM too, thanks!
Given the pre-DWARFv4 spec isn't very specific about how to differentiate
static vs non-static members, leaving out the check/assert for
`DW_TAG_data_member_location` as Pavel suggested seems correct.
https://github.c
labath wrote:
I'm worried about the same thing as Michael. My question is: if the promotion
type can be computed from the information in dwarf (can it always?), and clang
already has code to compute it (not from DWARF, but from.. clang AST I guess),
can we refactor that code somehow so that it
@@ -362,6 +369,18 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
Michael137 wrote:
I haven't done an in-depth review of the patch yet but my first instinct here
is that this looks like a lot of work for LLDB which the compiler has already
done, so we ideally don't want to repeat. Where is this actually an issue from
a user perspective? In the example you ga
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/114831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/114896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> This is a fairly large refactor of the lldb-dap to allow multiple DAP
> sessions from a single lldb-dap server.
The obvious question after an opening like this is whether the patch can be
split into multiple smaller changes. I would expect that at least the "remove
g_dap globa
https://github.com/labath commented:
I think this looks good now. Is there anything you'd like to add, Michael?
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -362,6 +369,18 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
set.namespaces.Insert(ConstString(name), ref);
break;
+case DW_TAG_member: {
+ // In DWARF 4 and earlier `static const` members of a struct, a class or
a
+ // union have an
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/111859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -910,6 +911,183 @@ void request_attach(const llvm::json::Object &request) {
}
}
+// "BreakpointLocationsRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+// "description": "The `breakpointLocations` request returns all poss
Author: Walter Erquinigo
Date: 2024-11-05T06:33:25-05:00
New Revision: 6620cd25234a42ca4b51490627afcb93fa443dc3
URL:
https://github.com/llvm/llvm-project/commit/6620cd25234a42ca4b51490627afcb93fa443dc3
DIFF:
https://github.com/llvm/llvm-project/commit/6620cd25234a42ca4b51490627afcb93fa443dc3.di
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
@@ -0,0 +1,26 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test im
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
https://github.com/labath commented:
I'm kinda late to the party (particularly as there's an analogous "progress"
setting), but I have to say I was surprised to see a
`disable-breakpoint-ansi-suffix` setting. That sounds like too low level of a
model. The model I would expect/find more natural
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 5290832b802d98b9d293b6910c0837911ec490c4 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 1/4] [lldb] Analyze enum promotion type during parsing
---
clang/in
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Intentionally or not, this also fixes TestInlineStepping.py
`test_with_python_api` on Arm 32 bit.
https://github.com/llvm/llvm-project/pull/114628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
Author: walter erquinigo
Date: 2024-11-05T13:29:51-05:00
New Revision: e952728f88c8b0e0208dc991dd9a04fe8c211cfb
URL:
https://github.com/llvm/llvm-project/commit/e952728f88c8b0e0208dc991dd9a04fe8c211cfb
DIFF:
https://github.com/llvm/llvm-project/commit/e952728f88c8b0e0208dc991dd9a04fe8c211cfb.di
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/114628
>From 042ac07ed67a5465aaf5c2dc8c4396adf5da2948 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Fri, 1 Nov 2024 17:23:12 -0700
Subject: [PATCH 1/5] More refinement of call site handling in stepping.
When you s
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/114628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-11-05T10:33:24-08:00
New Revision: 23a01a413d29f2d5b1f6204d0237e3884ae0231e
URL:
https://github.com/llvm/llvm-project/commit/23a01a413d29f2d5b1f6204d0237e3884ae0231e
DIFF:
https://github.com/llvm/llvm-project/commit/23a01a413d29f2d5b1f6204d0237e3884ae0231e.diff
LOG
jimingham wrote:
> Intentionally or not, this also fixes TestInlineStepping.py
> `test_with_python_api` on Arm 32 bit.
That's plausible. I removed the skip along with this patch, let's see if that
holds on the bots.
https://github.com/llvm/llvm-project/pull/114628
__
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/114896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-11-05T11:23:23-08:00
New Revision: 803f957e87e4083f6d61c8991171eeeaf0e6bd61
URL:
https://github.com/llvm/llvm-project/commit/803f957e87e4083f6d61c8991171eeeaf0e6bd61
DIFF:
https://github.com/llvm/llvm-project/commit/803f957e87e4083f6d61c8991171eeeaf0e6bd61.diff
LOG
jimingham wrote:
This patch seems to fail on x86_64 Linux, but I don't understand how this patch
could cause the reported failure. The failure is in a lldb-dap test, here:
File
"/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-9dkps-1/llvm-project/github-pull-requests/lldb/test/API/tools/ll
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
d2d1b5897e871f7b4873befbe2b85db58744e42b...ec85f0f7397c4790442cf99cd51ce61510da498f
lldb/
walter-erquinigo wrote:
Yeah, splitting it would be a nice idea
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,15 +12,19 @@
namespace lldb_dap {
-SourceBreakpoint::SourceBreakpoint(const llvm::json::Object &obj)
-: Breakpoint(obj), logMessage(std::string(GetString(obj, "logMessage"))),
+SourceBreakpoint::SourceBreakpoint(DAP *dap, const llvm::json::Object &obj)
+: Break
@@ -9,21 +9,28 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
+
namespace lldb_dap {
struct BreakpointBase {
+ // Associat
@@ -173,7 +171,7 @@ def do_test_scopes_variables_setVariable_evaluate(
"value": "1",
},
"declaration": {
-"equals": {"line": 12, "column": 14},
+"equals": {"line": 15
Author: Jonas Devlieghere
Date: 2024-11-05T18:05:33-08:00
New Revision: 7c20bdf373d6cd7f35dee5c71cf94f0eb1be3200
URL:
https://github.com/llvm/llvm-project/commit/7c20bdf373d6cd7f35dee5c71cf94f0eb1be3200
DIFF:
https://github.com/llvm/llvm-project/commit/7c20bdf373d6cd7f35dee5c71cf94f0eb1be3200.d
59 matches
Mail list logo
