[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread via lldb-commits
@@ -621,6 +623,9 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommand( pfunc(debugger_arg, PythonString(args), SWIGBridge::ToSWIGWrapper(std::move(exe_ctx_ref_sp)), cmd_retobj_arg.obj(), dict); + if (PyErr_Occurred()) jimingham

[Lldb-commits] [lldb] [lldb-dap] Always pass disableASLR to the DAP executable (PR #113891)

2024-10-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/113891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b4e1af0 - [lldb-dap] Always pass disableASLR to the DAP executable (#113891)

2024-10-29 Thread via lldb-commits
Author: Michael Buch Date: 2024-10-29T18:40:06Z New Revision: b4e1af0096fd05ed4bddf11b48b604d75a7103d0 URL: https://github.com/llvm/llvm-project/commit/b4e1af0096fd05ed4bddf11b48b604d75a7103d0 DIFF: https://github.com/llvm/llvm-project/commit/b4e1af0096fd05ed4bddf11b48b604d75a7103d0.diff LOG:

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/114112 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/114112 >From c58438160c016841c6a72e53cd5c4985ebd1e521 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 29 Oct 2024 11:19:33 -0700 Subject: [PATCH 1/2] [lldb] Use Py_InitializeFromConfig with Python >= 3

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread Jacob Lalonde via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread Jacob Lalonde via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread Jacob Lalonde via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] Fix return value of 'PluginManager::RegisterPlugin()'. (PR #114120)

2024-10-29 Thread Miro Bucko via lldb-commits
https://github.com/mbucko created https://github.com/llvm/llvm-project/pull/114120 None >From 3c831942c752004a6e46c1f5ddd5e783ee2176e0 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Tue, 29 Oct 2024 13:02:21 -0700 Subject: [PATCH] Fix return value of 'PluginManager::RegisterPlugin()'. --- l

[Lldb-commits] [lldb] Fix return value of 'PluginManager::RegisterPlugin()'. (PR #114120)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/114120.diff 1 Files Affected: - (modified) lldb/source/Core/PluginManager.cpp (+1-1) ``diff diff --git a/lldb/source/Core/PluginManager.cpp

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-29 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/114122 Because of a build failure with libc++17. See https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/912/execution/node/107/log/ >From 00d136ed33cdc4362f7f23804ee184ddb1fb2539 Mon Sep 17 0

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-10-29 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: see #114122 https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8193832 - [lldb] Search main function with lldb::eFunctionNameTypeFull when getting default file and line. (#113980)

2024-10-29 Thread via lldb-commits
Author: Zequan Wu Date: 2024-10-29T16:23:33-04:00 New Revision: 8193832fb988e3df1e8e726634783805dca8d9b6 URL: https://github.com/llvm/llvm-project/commit/8193832fb988e3df1e8e726634783805dca8d9b6 DIFF: https://github.com/llvm/llvm-project/commit/8193832fb988e3df1e8e726634783805dca8d9b6.diff LOG

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/114119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [llvm] [DWARF] Fix arity of DW_OP_bra (PR #114136)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/114136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread Alex Langford via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes API test failed for remote debugging in [#112657](https://github.com/llvm/llvm-project/pull/112657) Fixing it properly --- Full diff: https://github.com/llvm/llvm-project/pull/114119.diff 1 Files Affected: - (mod

[Lldb-commits] [lldb] Fix return value of 'PluginManager::RegisterPlugin()'. (PR #114120)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/114120 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-29 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/114122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
@@ -99,31 +99,45 @@ def test_stdout_stderr_redirection(self): @expectedFlakeyLinux(bugnumber="llvm.org/pr26437") @skipIfDarwinEmbedded # debugserver can't create/write files on the device def test_stdout_stderr_redirection_to_existing_files(self): -"""Exerc

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-29 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/113007 >From eab35bd50d89a16494d8f08421a12aef77356c43 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Tue, 22 Oct 2024 14:34:44 -0700 Subject: [PATCH 1/2] [lldb] Extend FindTypes to optionally search by mangle

[Lldb-commits] [lldb] [llvm] [DWARF] Fix arity of DW_OP_bra (PR #114136)

2024-10-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/114136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/114161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-29 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/114158 This fixes the two test suite failures that I missed in the PR: https://github.com/llvm/llvm-project/pull/112939 One was a poorly written test case - it assumed that on connect to a gdb-remote with a running

[Lldb-commits] [lldb] Fix the sort function for languages to have "strict weak ordering". (PR #114160)

2024-10-29 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/114160 >From 237cb04100fd35df22b4e743c575681f31b54970 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Tue, 29 Oct 2024 17:11:43 -0700 Subject: [PATCH 1/2] Fix the sort function for languages to have "strict weak ord

[Lldb-commits] [lldb] [lldb] Search main function with lldb::eFunctionNameTypeFull when getting default file and line. (PR #113980)

2024-10-29 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/113980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 8a0cb9ac869334fd6c6bd6aad8408623a7ccd7f6...dfa32524d1e6cac75471975de1e2a28225efce83 lldb/

[Lldb-commits] [lldb] [llvm] [DWARF] Fix arity of DW_OP_bra (PR #114136)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/114136 Found by my POC DWARF expression evaluation fuzzer. >From b4f93c43634ac4a20693da560522f3b13a516ac7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 29 Oct 2024 15:13:19 -0700 Subject: [PATCH] [

[Lldb-commits] [lldb] [llvm] [DWARF] Fix arity of DW_OP_bra (PR #114136)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Found by my POC DWARF expression evaluation fuzzer. --- Full diff: https://github.com/llvm/llvm-project/pull/114136.diff 2 Files Affected: - (modified) lldb/unittes

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-29 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: @Michael137 I wasn't able to run `yaml2obj` to convert back an object file that contains debug info, I'm not sure if the issue is that `yaml2obj` doesn't support something that's encoded in the debug info, or some bug with MachO. This is the error: ``` error: wrote too much

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread via lldb-commits
R-Goc wrote: Looks good. https://github.com/llvm/llvm-project/pull/114112 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-29 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/113007 >From eab35bd50d89a16494d8f08421a12aef77356c43 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Tue, 22 Oct 2024 14:34:44 -0700 Subject: [PATCH 1/3] [lldb] Extend FindTypes to optionally search by mangle

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/114119 >From a1b19dfcce99cfbfea5a3e7004e1a04e0b13a3e2 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Tue, 29 Oct 2024 12:50:28 -0700 Subject: [PATCH] [lldb] Fix API test for file redirection to existing files --- .../

[Lldb-commits] [lldb] Fix the sort function for languages to have "strict weak ordering". (PR #114160)

2024-10-29 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/114160 If you build libstdc++ with "debug" strictness, the test TestTypeLookup.py will assert. That's because we're calling llvm::sort (which redirects to std::sort) with a function that doesn't obey strict weak or

[Lldb-commits] [lldb] Fix the sort function for languages to have "strict weak ordering". (PR #114160)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes If you build libstdc++ with "debug" strictness, the test TestTypeLookup.py will assert. That's because we're calling llvm::sort (which redirects to std::sort) with a function that doesn't obey strict weak ordering

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 39303e24b6f628f3c080f1b54bd12383a55b9b3a...dfcd21afd11b6e384ece06f128636dde2c075ac6 lldb/

[Lldb-commits] [lldb] Fix the sort function for languages to have "strict weak ordering". (PR #114160)

2024-10-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 39303e24b6f628f3c080f1b54bd12383a55b9b3a 237cb04100fd35df22b4e743c575681f31b54970 --e

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/114119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-29 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/114161 The tests were using the variable directly to get the dwarf version used for the test. That's only the overridden value, and won't be set if we're using the compiler default. I also put a comment by the var

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes The tests were using the variable directly to get the dwarf version used for the test. That's only the overridden value, and won't be set if we're using the compiler default. I also put a comment by the variable

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 39303e24b6f628f3c080f1b54bd12383a55b9b3a...7fe3b6ac2e32dcb3660affa422ae8909b11670e2 lldb/

[Lldb-commits] [lldb] Fix return value of 'PluginManager::RegisterPlugin()'. (PR #114120)

2024-10-29 Thread via lldb-commits
jimingham wrote: We obviously aren't checking this return anywhere. The only way it can return false that I can see is if you call RegisterPlugin with no callback pointer - which seems more like a programming error than a run-time check. Do we actually need this bool return? https://github.

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-29 Thread Augusto Noronha via lldb-commits
@@ -2758,6 +2758,15 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query, TypeResults &results) { return true; // Keep iterating over index types, language mismatch. } +// Since mangled names are unique, we only need to check if the names are +// the

[Lldb-commits] [lldb] a325c53 - [lldb] Fix lldb windows build breakage from https://github.com/llvm/llvm-project/pull/112657.

2024-10-29 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2024-10-29T14:38:02-07:00 New Revision: a325c5359310316e393e7e446373fca645002ecb URL: https://github.com/llvm/llvm-project/commit/a325c5359310316e393e7e446373fca645002ecb DIFF: https://github.com/llvm/llvm-project/commit/a325c5359310316e393e7e446373fca645002ecb.diff LOG

[Lldb-commits] [lldb] Fix return value of 'PluginManager::RegisterPlugin()'. (PR #114120)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
@@ -209,7 +209,7 @@ template class PluginInstances { Instance instance = Instance(name, description, callback, std::forward(args)...); m_instances.push_back(instance); JDevlieghere wrote: While you're here... :-) Should this use `emplace_back`

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Sorry to clarify. I think based on @felipepiovezan comment here: https://github.com/llvm/llvm-project/pull/108870#issuecomment-281588 On Clang 17 we compile fine, just the assertion fails to find the expected function name (because of the `std::__1` inline namespace): ```

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-29 Thread Augusto Noronha via lldb-commits
@@ -1032,11 +1032,17 @@ void SymbolFileCTF::FindTypes(const lldb_private::TypeQuery &match, ConstString name = match.GetTypeBasename(); for (TypeSP type_sp : GetTypeList().Types()) { -if (type_sp && type_sp->GetName() == name) { - results.InsertUnique(type_sp); -

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread via lldb-commits
@@ -621,6 +623,9 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommand( pfunc(debugger_arg, PythonString(args), SWIGBridge::ToSWIGWrapper(std::move(exe_ctx_ref_sp)), cmd_retobj_arg.obj(), dict); + if (PyErr_Occurred()) jimingham

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes Because of a build failure with libc++17. See https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/912/execution/node/107/log/ --- Full diff: https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] 2ab98df - [lldb] Update link to GreenDragon in the docs

2024-10-29 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-29T09:45:29-07:00 New Revision: 2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7 URL: https://github.com/llvm/llvm-project/commit/2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7 DIFF: https://github.com/llvm/llvm-project/commit/2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7.d

[Lldb-commits] [lldb] [lldb-dap] Always pass disableASLR to the DAP executable (PR #113891)

2024-10-29 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: > If we don't always want forward `disableASLR` we could instead flip the > condition to: > > ``` > if not disableASLR: > args_dict["disableASLR"] = disableASLR > ``` > > Any thoughts? I think "if not" would make it more confusing. The way it is in this patch seems fin

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
@@ -621,6 +623,9 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommand( pfunc(debugger_arg, PythonString(args), SWIGBridge::ToSWIGWrapper(std::move(exe_ctx_ref_sp)), cmd_retobj_arg.obj(), dict); + if (PyErr_Occurred()) kastiglion

[Lldb-commits] [lldb] [lldb] Lookup static const members in FindGlobalVariables (PR #111859)

2024-10-29 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/111859 >From 4c394ec162b58b3cde3af924a5e9be1de8250a07 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Tue, 30 Jul 2024 17:02:10 +0500 Subject: [PATCH 1/3] [lldb] Lookup static const members in FindGlobalVariables Stat

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] [lldb-dap] Fix for missing 'raw_string_ostream::flush' removal in ProgressEvent.cpp; addressing #108745 (PR #114087)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/114087 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Always pass disableASLR to the DAP executable (PR #113891)

2024-10-29 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. https://github.com/llvm/llvm-project/pull/113891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
@@ -621,6 +623,9 @@ bool lldb_private::python::SWIGBridge::LLDBSwigPythonCallCommand( pfunc(debugger_arg, PythonString(args), SWIGBridge::ToSWIGWrapper(std::move(exe_ctx_ref_sp)), cmd_retobj_arg.obj(), dict); + if (PyErr_Occurred()) kastiglion

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/113996 >From 75f96b84c9bd2b3211edb5fa8806092711133251 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Oct 2024 15:49:50 -0700 Subject: [PATCH 1/3] [lldb] Set return status to Failed when Python command raise

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/113996 >From 75f96b84c9bd2b3211edb5fa8806092711133251 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Oct 2024 15:49:50 -0700 Subject: [PATCH 1/4] [lldb] Set return status to Failed when Python command raise

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-29 Thread Jacob Lalonde via lldb-commits
@@ -6,6 +6,8 @@ // //===--===// +#include Jlalond wrote: It's also passing the Windows CI. @bulbazord I can help @kusmour validate if you want, but I personally think CI is good enough ht

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
@@ -0,0 +1,27 @@ +import os +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +class TestCase(TestBase): +NO_DEBUG_INFO_TESTCASE = True + +def test(self): +""" +Check that a Python command, which raises an unha

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/113996 >From 75f96b84c9bd2b3211edb5fa8806092711133251 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 28 Oct 2024 15:49:50 -0700 Subject: [PATCH 1/2] [lldb] Set return status to Failed when Python command raise

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
@@ -0,0 +1,27 @@ +import os kastiglione wrote: What are the issues with a new file? https://github.com/llvm/llvm-project/pull/113996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2ab98dfe19ac384f0cfac1a1fafc56b9dd7ad9b7 c58438160c016841c6a72e53cd5c4985ebd1e521 --e

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This fixes the deprecation warning for Py_SetPythonHome, which was deprecated in Python 3.11. With this patch, when building against Python 3.8 or later, we now use Py_InitializeFromConfig instead.

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: CC @R-Goc https://github.com/llvm/llvm-project/pull/114112 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-29 Thread Alex Langford via lldb-commits
@@ -6,6 +6,8 @@ // //===--===// +#include bulbazord wrote: CI is good enough for me here. I've approved the PR. https://github.com/llvm/llvm-project/pull/112657 ___

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/112657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] efc6d33 - [lldb] Fix write only file action to truncate the file (#112657)

2024-10-29 Thread via lldb-commits
Author: Wanyi Date: 2024-10-29T14:22:51-04:00 New Revision: efc6d33be9f4b4d0f0e8d3d5f198f2616b75792b URL: https://github.com/llvm/llvm-project/commit/efc6d33be9f4b4d0f0e8d3d5f198f2616b75792b DIFF: https://github.com/llvm/llvm-project/commit/efc6d33be9f4b4d0f0e8d3d5f198f2616b75792b.diff LOG: [l

[Lldb-commits] [lldb] [llvm] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-29 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/112657 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use Py_InitializeFromConfig with Python >= 3.8 (NFC) (PR #114112)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/114112 This fixes the deprecation warning for Py_SetPythonHome, which was deprecated in Python 3.11. With this patch, when building against Python 3.8 or later, we now use Py_InitializeFromConfig instead. Fixes

[Lldb-commits] [lldb] [lldb] Lookup static const members in FindGlobalVariables (PR #111859)

2024-10-29 Thread Ilia Kuklin via lldb-commits
@@ -3490,7 +3490,7 @@ VariableSP SymbolFileDWARF::ParseVariableDIE(const SymbolContext &sc, ModuleSP module = GetObjectFile()->GetModule(); if (tag != DW_TAG_variable && tag != DW_TAG_constant && - (tag != DW_TAG_formal_parameter || !sc.function)) + tag != DW_TA

[Lldb-commits] [lldb] [lldb] Use LLVM's helper for Unicode conversion (NFC) (PR #112582)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Friendly ping https://github.com/llvm/llvm-project/pull/112582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Search main function with lldb::eFunctionNameTypeFull when getting default file and line. (PR #113980)

2024-10-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/113980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-10-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Hi @vogelsgesang , the test you added on this PR breaks the LLDB matrix bot, in particular it breaks the 15 & 17 clang tests. Could you add a `skipIf` annotation if this test is only supposed to pass when working with newer versions of libcxx/clang? https://green.lab.llv

[Lldb-commits] [lldb] [lldb] Lookup static const members in FindGlobalVariables (PR #111859)

2024-10-29 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/111859 >From 4c394ec162b58b3cde3af924a5e9be1de8250a07 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Tue, 30 Jul 2024 17:02:10 +0500 Subject: [PATCH 1/4] [lldb] Lookup static const members in FindGlobalVariables Stat

[Lldb-commits] [lldb] [lldb] Add a compiler/interpreter of LLDB data formatter bytecode to lldb/examples (PR #113398)

2024-10-29 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/113398 >From 0b88de8fe7f5e4ea7f4089be403b271cd7b086d0 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 22 Oct 2024 16:29:50 -0700 Subject: [PATCH 1/2] Add a compiler/interpreter of LLDB data formatter byt

[Lldb-commits] [lldb] Improve namespace lookup using .debug_names parent chain (PR #110062)

2024-10-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/110062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix API test for file redirection to existing files (PR #114119)

2024-10-29 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/114119 API test failed for remote debugging in [#112657](https://github.com/llvm/llvm-project/pull/112657) Fixing it properly >From dfa32524d1e6cac75471975de1e2a28225efce83 Mon Sep 17 00:00:00 2001 From: Wanyi Ye Da

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/113996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Always pass disableASLR to the DAP executable (PR #113891)

2024-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: If we don't always want forward `disableASLR` we could instead flip the condition to: ``` if not disableASLR: args_dict["disableASLR"] = disableASLR ``` Any thoughts? https://github.com/llvm/llvm-project/pull/113891 ___ lldb-com

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,27 @@ +import os DavidSpickett wrote: A bit surprised we don't have a scripted commands test that this could be added to instead of making a new file. https://github.com/llvm/llvm-project/pull/113996 ___ ll

[Lldb-commits] [lldb] [lldb] Set return status to Failed when Python command raises uncaught exception (PR #113996)

2024-10-29 Thread David Spickett via lldb-commits
@@ -0,0 +1,27 @@ +import os +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +class TestCase(TestBase): +NO_DEBUG_INFO_TESTCASE = True + +def test(self): +""" +Check that a Python command, which raises an unha

[Lldb-commits] [lldb] Fix a couple of tests that were incorrectly using configuration.dwarf_version (PR #114161)

2024-10-29 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/114161 >From 7fe3b6ac2e32dcb3660affa422ae8909b11670e2 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Tue, 29 Oct 2024 17:39:36 -0700 Subject: [PATCH 1/2] Fix a couple of tests that were incorrectly using configurat

[Lldb-commits] [lldb] [lldb][test] Skip `LibCxxInternalsRecognizerTestCase` on clang <= 17 (PR #114122)

2024-10-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Note that for the clang-15 failure you'll have to make sure we account for inline namespaces in the test assertion https://github.com/llvm/llvm-project/pull/114122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-29 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/114158 >From 0695a7b57597fd08a802dbe4af06291ceb75d9f1 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Mon, 28 Oct 2024 17:58:43 -0700 Subject: [PATCH 1/4] =?UTF-8?q?Revert=20"Revert=20"Add=20the=20ability=20t?= =?UT

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-10-29 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Friendly ping, otherwise I'll merge it in a couple of days https://github.com/llvm/llvm-project/pull/113508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix call site breakpoint patch (PR #114158)

2024-10-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This fixes the two test suite failures that I missed in the PR: https://github.com/llvm/llvm-project/pull/112939 One was a poorly written test case - it assumed that on connect to a gdb-remote with a running proce

[Lldb-commits] [lldb] 75b37c3 - [DWARF] Fix arity of DW_OP_bra (#114136)

2024-10-29 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-29T16:41:01-07:00 New Revision: 75b37c3191254d0c418058cb94c3a7922b7ba71e URL: https://github.com/llvm/llvm-project/commit/75b37c3191254d0c418058cb94c3a7922b7ba71e DIFF: https://github.com/llvm/llvm-project/commit/75b37c3191254d0c418058cb94c3a7922b7ba71e.d

[Lldb-commits] [lldb] [LLDB] Add a target.launch-working-dir setting (PR #113521)

2024-10-29 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Friendly ping, otherwise I'll merge it in a couple of days https://github.com/llvm/llvm-project/pull/113521 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 62ff85f - [lldb-dap] Fix for missing 'raw_string_ostream::flush' removal in ProgressEvent.cpp; addressing #108745 (#114087)

2024-10-29 Thread via lldb-commits
Author: Santhosh Kumar Ellendula Date: 2024-10-30T10:50:59+05:30 New Revision: 62ff85f0799560b42754ef77b5f64ca2c7feeff7 URL: https://github.com/llvm/llvm-project/commit/62ff85f0799560b42754ef77b5f64ca2c7feeff7 DIFF: https://github.com/llvm/llvm-project/commit/62ff85f0799560b42754ef77b5f64ca2c7f

[Lldb-commits] [lldb] [lldb-dap] Fix for missing 'raw_string_ostream::flush' removal in ProgressEvent.cpp; addressing #108745 (PR #114087)

2024-10-29 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 closed https://github.com/llvm/llvm-project/pull/114087 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits