https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/112596
>From 890d2bcf655a2e1e58b025cc0df7b4e42956e4c6 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Sat, 28 Sep 2024 15:05:37 -0700
Subject: [PATCH 1/3] Add support for reading the dynamic symbol table from
progr
@@ -737,19 +752,35 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- std::mutex m_destroy_callback_mutex;
- lldb::callback_token_t m_destroy_callback_next_token = 0;
- struct
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-backend-hexagon
Author: Jonas Devlieghere (JDevlieghere)
Changes
ValueObject is part of lldbCore for historical reasons, but it can totally
stand on its own. This does introduce a circular dependency between lldbCore
and lldbV
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 395093ec150accf19b8158f9d2327ba470e92867
9cd8c9fd40ec13d6828d42a8693bf0dc9074d909 --e
https://github.com/kusmour updated
https://github.com/llvm/llvm-project/pull/112657
>From 4acbf064144144142a6126f8d9c3e6b5f9cf48e9 Mon Sep 17 00:00:00 2001
From: Wanyi Ye
Date: Mon, 14 Oct 2024 22:37:50 -0700
Subject: [PATCH] [lldb] Fix write only file action to truncate the file
---
lldb/sou
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/112657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/112657
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/112939
>From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 3 Oct 2024 18:24:46 -0700
Subject: [PATCH 01/10] Add the ability to break on call-site locations, report
the
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From 7881a25f21ffabc97417a7daa38fe8148615d36c Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:23:43 -0700
Subject: [PATCH] [lldb] Extend FindTypes to optionally search by mangled ty
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From eab35bd50d89a16494d8f08421a12aef77356c43 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:34:44 -0700
Subject: [PATCH] [lldb] Extend FindTypes to optionally search by mangled ty
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From 3267f7a2001e769217e3192f6efb67fb77973339 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/113398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/113398
>From c4360a6979a38f7e9a11edc07f02d8b3ac5bd2aa Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 22 Oct 2024 16:29:50 -0700
Subject: [PATCH] Add a compiler/interpreter of LLDB data formatter bytecode
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/113398
This PR adds a proof-of-concept for a bytecode designed to ship and run LLDB
data formatters. More motivation and context can be found in the
`formatter-bytecode.md` file and on discourse.
>From 64252584
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This PR adds a proof-of-concept for a bytecode designed to ship and run LLDB
data formatters. More motivation and context can be found in the
`formatter-bytecode.md` file and on discourse.
---
Patch
cmtice wrote:
It appears that in all the .h files that you moved from Core to ValueObject,
you did not update the ifdef variable at the top of the file? I would have
expected, e.g. that "LLDB_CORE_VALUEOBJECT_H" should be changed to
"LLDB_VALUEOBJECT_VALUEOBJECT_H". Shouldn't it?
https://gi
JDevlieghere wrote:
> It appears that in all the .h files that you moved from Core to ValueObject,
> you did not update the ifdef variable at the top of the file? I would have
> expected, e.g. that "LLDB_CORE_VALUEOBJECT_H" should be changed to
> "LLDB_VALUEOBJECT_VALUEOBJECT_H". Shouldn't it?
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2e0506f83bfde6db93454bdf28e4a71c160d4f5b...642525847da7d874a127f94f155fd738e3d78196
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2e0506f83bfde6db93454bdf28e4a71c160d4f5b
642525847da7d874a127f94f155fd738e3d78196 --e
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/113393
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,46 @@
+// Itanium ABI:
+// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s
+// RUN: %lldb -f %t_linux.o -b -o "
https://github.com/jeffreytan81 approved this pull request.
LGTM. Pending Jonas's comment and clang-format
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN
mstorsjo wrote:
> The amount of churn is already pretty high -- please make sure the original
> commit, fixes, and reverts get added to
> https://github.com/llvm/llvm-project/blob/main/.git-blame-ignore-revs. At the
> end of the day, we have a number of tests and files which are sensitive to
Author: Jonas Devlieghere
Date: 2024-10-22T09:00:08-07:00
New Revision: cd4b33c9a976543171bb7b3455c485f99cfe654b
URL:
https://github.com/llvm/llvm-project/commit/cd4b33c9a976543171bb7b3455c485f99cfe654b
DIFF:
https://github.com/llvm/llvm-project/commit/cd4b33c9a976543171bb7b3455c485f99cfe654b.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -43,6 +43,10 @@ char TeeLogHandler::ID;
llvm::ManagedStatic Log::g_channel_map;
+// The error log is used by LLDB_LOG_ERROR and LLDB_LOG_ERRORV. If the given
JDevlieghere wrote:
Already fixed in the latest version of this PR :-)
https://github.com/llvm/
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/ZequanWu approved this pull request.
https://github.com/llvm/llvm-project/pull/112928
_
https://github.com/rocallahan updated
https://github.com/llvm/llvm-project/pull/112079
>From bb96e6ddd2d6448be01b1965591cf8ee77e14569 Mon Sep 17 00:00:00 2001
From: Robert O'Callahan
Date: Fri, 19 Jul 2024 22:46:42 +1200
Subject: [PATCH] [lldb] Implement basic support for reverse-continue
This
tritao wrote:
Given this was already approved, what's missing for the merge?
https://github.com/llvm/llvm-project/pull/78977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldrumm wrote:
@AaronBallman you said this has happened before, but I don't see this in
history. Can you link to the commit to which you're referring?
I only see one other commit (9783f28cb) that touches the root `.gitattributes`
https://github.com/llvm/llvm-project/pull/86318
_
jimingham wrote:
This is just naming, but it seems odd to have hidden the SectionLoadList in
Target, to then have Target::SectionLoadListIsEmpty() as a primary API. "What
is this SectionLoadList thing of which you speak???"
Maybe "HasLoadedSections"?
https://github.com/llvm/llvm-project/pull
https://github.com/JDevlieghere commented:
Protecting the section load list seems reasonable. I left one inline comment +
this needs to be `clang-format`'ed.
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@
@@ -5066,3 +5066,17 @@ llvm::json::Value
Target::ReportStatistics(const lldb_private::StatisticsOptions &options) {
return m_stats.ToJSON(*this, options);
}
+
+bool Target::SectionLoadListIsEmpty() const {
+ return const_cast(this)->GetSectionLoadList().IsEmpty();
--
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/5] [lldb] Fix crash due to missing MS
jimingham wrote:
BTW, the general change seems fine to me, none of the clients actually needed
to know about the list, they were just asking "can I use load addresses" and
"resolve this load address for me" so they didn't need to know how that was
done.
https://github.com/llvm/llvm-project/pu
https://github.com/igorkudrin approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/113251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/111911
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -43,6 +43,10 @@ char TeeLogHandler::ID;
llvm::ManagedStatic Log::g_channel_map;
+// The error log is used by LLDB_LOG_ERROR and LLDB_LOG_ERRORV. If the given
labath wrote:
```suggestion
// The error log is used by LLDB_LOG_ERROR. If the given
```
https:/
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN: lld-link /out:%t_win.exe %t_win.obj /nodefaultlib /entry:main /debug
+// RUN: %lldb -f %t_win.exe -b -o "target variable mp1 mp2 mp3 mp4 mp5
Author: Jordan Rupprecht
Date: 2024-10-22T10:34:15-05:00
New Revision: 5942be03eadc8abd320e3dad1abcc4e87ce4171a
URL:
https://github.com/llvm/llvm-project/commit/5942be03eadc8abd320e3dad1abcc4e87ce4171a
DIFF:
https://github.com/llvm/llvm-project/commit/5942be03eadc8abd320e3dad1abcc4e87ce4171a.di
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/113251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mstorsjo wrote:
> > > It's my understanding that text=auto does not override core.autocrlf. As
> > > far as I can tell from the documentation it honours the user's
> > > configuration for core.eol in combination with core.autocrlf - from git
> > > config --help:
>
> > This doesn't match my ex
mstorsjo wrote:
> So if I've read that correctly, `core.autocrlf=false` is a red herring and
> you should really set `core.eol=lf` if you want git to use `lf` on windows.
That perhaps may be the case, but all common docs and all common practices
around this revolve around setting `core.autocrl
mstorsjo wrote:
> This patch is about respecting local config, which is the exact opposite of
> that suggestion. It would be a way to solve the line-ending issue by fiat,
> not by co-operation, so I'm against it on principle. To be clear I very much
> don't like CRLF, but I also very much don'
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
Lots of code around LLDB was directly accessing the target's section load list.
This NFC patch makes the section load list private to the Target class can
access it, but everyone else now uses accessor funct
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mstorsjo wrote:
> I think this is due to a subtly of config. Setting `core.autocrlf` to `false`
> doesn't actually do anything since it's the default.
In Git for Windows, the default actually is `core.autocrlf` set to `true`. When
manually installing, the installer wizard used to ask the user
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 commented:
`TypeSystemClang.cpp` change LGTM. Though It'd be nice if we added the same
test-coverage also for non-MSVC (only found shell tests for PDB, and 1 API test
that didn't enumerate all the cases).
I gu
ldrumm wrote:
>> It's my understanding that text=auto does not override core.autocrlf. As far
>> as I can tell from the documentation it honours the user's configuration for
>> core.eol in combination with core.autocrlf - from git config --help:
> This doesn't match my experience.
I think thi
ldrumm wrote:
> It always ends like this.
Ends Like what?
As far as I can see all this has done has exposed latent bugs in our testing
and in clang's parser
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
lldb-commits@l
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Stefan Gränitz (weliveindetail)
Changes
In the MS ABI, member pointers to `CXXRecordDecl`s must have a
`MSInheritanceAttr` in order to be complete. Otherwise we cannot query their
size
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/3] [lldb] Fix crash due to missing MS
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 92
walter-erquinigo wrote:
Man, this is fantastic. I'll try to implement a little compiler for this for my
language (Mojo).
https://github.com/llvm/llvm-project/pull/113398
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
@@ -5066,3 +5066,17 @@ llvm::json::Value
Target::ReportStatistics(const lldb_private::StatisticsOptions &options) {
return m_stats.ToJSON(*this, options);
}
+
+bool Target::SectionLoadListIsEmpty() const {
+ return const_cast(this)->GetSectionLoadList().IsEmpty();
--
@@ -5066,3 +5066,17 @@ llvm::json::Value
Target::ReportStatistics(const lldb_private::StatisticsOptions &options) {
return m_stats.ToJSON(*this, options);
}
+
+bool Target::SectionLoadListIsEmpty() const {
+ return const_cast(this)->GetSectionLoadList().IsEmpty();
--
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/113412
None
>From 89c932a72dc2289dd194f7b7950623589948e872 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Tue, 22 Oct 2024 08:10:43 -0700
Subject: [PATCH] [lldb] Avoid repeated hash lookups (NFC)
---
.../In
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/113412.diff
1 Files Affected:
- (modified)
lldb/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp
(+3-4)
``
rupprecht wrote:
The `command-expr-diagnostics.test` test added here (migrated from API->shell,
really) is flaky for me. It expects this:
```
(lldb) p a+b
˄ ˄
│ ╰─ error: use of undeclared identifier 'b'
╰─ error: use of undeclared identifier 'a'
```
But half the tim
rupprecht wrote:
I'm unable to observe this issue with a fully optimized build, hinting that
this is some UB conveniently being optimized out in release builds, but
sanitizers aren't picking anything up.
https://github.com/llvm/llvm-project/pull/112109
_
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/2] [lldb] Fix crash due to missing MS
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
weliveindetail wrote:
Ok right, member function pointers are more than just offsets. So, hard-coding
`clang::Type::MemberPointer` to the system pointer size wouldn't work there.
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dc84337f7b5bb2447e30f3364ebc863e9e04b8be
851ee7a3fd4f1ae294f3e0baaf0944caeadb7d05 --e
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -2771,6 +2771,9 @@ static bool GetCompleteQualType(clang::ASTContext *ast,
ast, llvm::cast(qual_type)->getModifiedType(),
allow_completion);
+ case clang::Type::MemberPointer:
+return !qual_type.get
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
Michael137 wrote:
> > I guess a follow-up question is how to set the MSInheritanceAttr. Infer it
> > from the class DIE? Or add a new DWARF attribute?
> > Well, maybe, but not sure. I believe it has a set of attributes that convey
> > the i
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN: lld-link /out:%t_win.exe %t_win.obj /nodefaultlib /entry:main /debug
+// RUN: %lldb -f %t_win.exe -b -o "target variable mp1 mp2 mp3 mp4 mp5
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN: lld-link /out:%t_win.exe %t
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/Michael137 approved this pull request.
lgtm (modulo test comment)
https://github.com/llvm/llvm-project/pull/112928
__
https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/113251
>From 0d27f7643007805bc2b1f2965edbd71d6563dae3 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Mon, 21 Oct 2024 19:29:50 -0700
Subject: [PATCH 1/2] [lldb][test] Fix TestUseSourceCache for readonly source
@@ -6,3 +6,6 @@ include Makefile.rules
# Copy file into the build folder to enable the test to modify it.
main-copy.cpp: main.cpp
cp -f $< $@
+ifneq "$(OS)" "Windows_NT" # chmod is not available on Windows
rupprecht wrote:
Excellent. Removed the condit
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/113251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
AaronBallman wrote:
> But if every single Windows developer involved here say that they want LF,
> and they don't want any ambiguity about it? Is it more important to give
> hypothetical users the choice to pick what they like, at the cost of every
> single current developer who do not want th
ldrumm wrote:
Yes. An RFC makes sense. None of us here speak for every windows developer. I
will submit one to discourse once I iron out the kinks and am ready to try again
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
weliveindetail wrote:
> This might be related to https://github.com/llvm/llvm-project/issues/56458
> even though my repro is different.
Actually, rather this one: https://github.com/llvm/llvm-project/issues/56449 It
adds `MSInheritanceAttr` support in NativePDB. The patch in this PR is about
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/113248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/4] [lldb] Fix crash due to missing MS
weliveindetail wrote:
I think it's valuable to get the full config log on buildbots. If this check
becomes too much of a burden, I'd rather propose to either turn the error into
a warning or revisit the option to guard it by
`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` (see my original patch for de
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/113248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
Thanks for the feedback! Yes, I think fixing the crash is a valuable addition
on its own. It broke use-cases where we just want to set a breakpoint and
encounter this type on the way, but don't actually care about its byte size.
> I guess a follow-up question is how to se
ldrumm wrote:
> if all tests would have been cleaned up before this
That was most certainly my intention, and I saw green before merging, so I
must've looked in the wrong place
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing
mstorsjo wrote:
> > if all tests would have been cleaned up before this
>
> That was most certainly my intention, and I saw green before merging, so I
> must've looked in the wrong place
Ah, right - as we've seen that the CI runner normally only updates an existing
checkout, where changes to
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/113278
Lots of code around LLDB was directly accessing the target's section load list.
This NFC patch makes the section load list private to the Target class can
access it, but everyone else now uses accessor functio
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/113278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
The test caused a crash in the past:
```
> bin/lldb.exe
> llvm-project-build-main/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/ms-abi.cpp.tmp.exe
> -b -o "target variable mp1 mp2 mp3 mp4 mp5 mp6 mp7 mp8 mp9"
Exception Code: 0x8003
...
#6 0x7ffabb6be846 clang:
https://github.com/weliveindetail ready_for_review
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/113102
>From 1001412f5d48385cf2e7489e44ea7b6b08e65258 Mon Sep 17 00:00:00 2001
From: Thomas Fransham
Date: Mon, 12 Aug 2024 16:04:12 +0100
Subject: [PATCH 1/2] [DebugInfo] Add explicit visibility macros to CodeView
mstorsjo wrote:
> I must have missed this PR originally. I oppose letting Git change any line
> endings. It always ends like this.
Also just for context - the Clang precommit CI is allegedly still broken,
because those buildbots happened to be restarted when we had these
gitattributes in plac
Author: Kazu Hirata
Date: 2024-10-22T07:59:41-07:00
New Revision: 5dbfb49490c5f06c9c7843051471956b11ef2abd
URL:
https://github.com/llvm/llvm-project/commit/5dbfb49490c5f06c9c7843051471956b11ef2abd
DIFF:
https://github.com/llvm/llvm-project/commit/5dbfb49490c5f06c9c7843051471956b11ef2abd.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/113248
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
GkvJwa wrote:
> I think it's valuable to get the full config log on buildbots. If this check
> b
95 matches
Mail list logo
