[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-18 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: This PR isn't complete yet, but early feedback is welcome. Next step is to get test coverage. There are similar cases for types like `CXXRecord`, `Enum` or `ObjCInterface` that attempt to query the complete type on the fly. Maybe we should do that for `MemberPointer` as w

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: > This seems to have broken precommit CI on Windows: > https://buildkite.com/llvm-project/github-pull-requests/builds/65#0192a01b-d3ac-44ad-abff-e53ac4a206ab > all of the failures look related to line endings, and I noticed that I got a > ton of command line messages of the

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
@@ -0,0 +1,201 @@ +JSON Symbol File Format +=== + +The JSON symbol file format encodes symbols in a text based, human readable +format. JSON symbol files can be used to symbolicate programs that miss symbol bulbazord wrote: Suggestion: `miss`

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: The failures are timeouts. https://github.com/llvm/llvm-project/pull/112801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
@@ -0,0 +1,201 @@ +JSON Symbol File Format +=== + +The JSON symbol file format encodes symbols in a text based, human readable +format. JSON symbol files can be used to symbolicate programs that miss symbol +information, for example because they have been strip

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
@@ -0,0 +1,201 @@ +JSON Symbol File Format +=== + +The JSON symbol file format encodes symbols in a text based, human readable +format. JSON symbol files can be used to symbolicate programs that miss symbol +information, for example because they have been strip

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread via lldb-commits
ldrumm wrote: On Fri Oct 18, 2024 at 7:39 PM BST, Aaron Ballman wrote: > @ldrumm -- can you revert these changes ASAP? They're causing > significant problems in practice, so best to get us back to green rather > than fix forward. Thanks! Reverted. https://github.com/llvm/llvm-project/pull/863

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/112938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7437f3e - [lldb] Document SymbolFileJSON (#112938)

2024-10-18 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-18T13:24:15-07:00 New Revision: 7437f3ef7e2c56f0f54154bba1260150bbf7a59e URL: https://github.com/llvm/llvm-project/commit/7437f3ef7e2c56f0f54154bba1260150bbf7a59e DIFF: https://github.com/llvm/llvm-project/commit/7437f3ef7e2c56f0f54154bba1260150bbf7a59e.d

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/112938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 922992a - Fix typo "instrinsic" (#112899)

2024-10-18 Thread via lldb-commits
Author: Jay Foad Date: 2024-10-18T15:58:33+01:00 New Revision: 922992a22f7c87c192cf96606038df3cf20d6404 URL: https://github.com/llvm/llvm-project/commit/922992a22f7c87c192cf96606038df3cf20d6404 DIFF: https://github.com/llvm/llvm-project/commit/922992a22f7c87c192cf96606038df3cf20d6404.diff LOG:

[Lldb-commits] [lldb] [lldb] Document SymbolFileJSON (PR #112938)

2024-10-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/112938 >From ea45421b4c4e7973abf0461bec75988800babe77 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 18 Oct 2024 10:18:54 -0700 Subject: [PATCH 1/3] [lldb] Document SymbolFileJSON I've had multiple r

[Lldb-commits] [lldb] [lldb] Add GetMangledTypeName to TypeSystem/CompilerType (PR #113006)

2024-10-18 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/113006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] More aggressively deduplicate global warnings based on contents. (PR #112801)

2024-10-18 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/112801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3d84b74 - [lldb] Add GetMangledTypeName to TypeSystem/CompilerType (#113006)

2024-10-18 Thread via lldb-commits
Author: Augusto Noronha Date: 2024-10-18T22:57:45-07:00 New Revision: 3d84b74cb3543428c35fc39e889684497286d482 URL: https://github.com/llvm/llvm-project/commit/3d84b74cb3543428c35fc39e889684497286d482 DIFF: https://github.com/llvm/llvm-project/commit/3d84b74cb3543428c35fc39e889684497286d482.dif

[Lldb-commits] [lldb] [lldb][test][NFC] Document DYLIB_NAME Makefile variable (PR #112735)

2024-10-18 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/112735 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-18 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,631 @@ +## This test verifies that loading an ELF file that has no section headers can +## load the dynamic symbol table using the DT_SYMTAB, DT_SYMENT, DT_HASH or +## the DT_GNU_HASH .dynamic key/value pairs that are loaded via the PT_DYNAMIC +## segment. +## +## This

[Lldb-commits] [lldb] [lldb][test][NFC] Document DYLIB_NAME Makefile variable (PR #112735)

2024-10-18 Thread Pavel Labath via lldb-commits
@@ -13,6 +13,13 @@ # the building of the a.out executable program. For example, # DYLIB_ONLY := YES # +# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME +# controls the name of the produced dylib. E.g., if set to "foo", +# the generated dylib will be called "f

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-10-18 Thread Pavel Labath via lldb-commits
labath wrote: > But lldb-test does not recognize the object file generated by yaml2obj on a > linux ppc64 system (where I have only the merged changes and the xcoff > changes only present in this PR). Is it not supposed to work that way or am I > missing something? It should work. It's likely

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-10-18 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Ok right. Yes, and it is working fine on AIX. Let me get a little more familiar with lldb-test's working and I will try to figure out what's wrong. Thanks! https://github.com/llvm/llvm-project/pull/111814 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-10-18 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Ok right. Yes, and it is working fine on AIX. Let me get a little more familiar with lldb-test's working and I will try to figure out what's wrong. Thanks! https://github.com/llvm/llvm-project/pull/111814 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF Object File Header for AIX (PR #111814)

2024-10-18 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/111814 >From 08c9d5ae66ca857d165dc878ebd1b2e0de364a24 Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Thu, 10 Oct 2024 02:24:42 -0500 Subject: [PATCH 1/7] Taking base file structure from ELF as reference

[Lldb-commits] [lldb] [lldb][test][NFC] Document DYLIB_NAME Makefile variable (PR #112735)

2024-10-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/112735 >From 6da0d2a549418d86e8877564ba7c6ff7c56db2eb Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 17 Oct 2024 16:52:48 +0100 Subject: [PATCH 1/2] [lldb][test][NFC] Document DYLIB_NAME Makefile variable -

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

2024-10-18 Thread Martin Storsjö via lldb-commits
mstorsjo wrote: This causes lots of build time warnings when building with GCC, like this: ``` [271/4090] Building CXX object lib/Obj...akeFiles/LLVMObject.dir/Minidump.cpp.o In file included from ../include/llvm/Object/Minidump.h:16, from ../lib/Object/Minidump.cpp:9: ../include

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Emit a log message when we break MapImported invariant (PR #112748)

2024-10-18 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/112748 >From 247f2638be2decf0f806050e90c25c4b664b2f97 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 17 Oct 2024 17:40:35 +0100 Subject: [PATCH 1/6] [lldb][ClangASTImporter][NFC] Emit a log message when we

[Lldb-commits] [lldb] [lldb][test][NFC] Document DYLIB_NAME Makefile variable (PR #112735)

2024-10-18 Thread Michael Buch via lldb-commits
@@ -13,6 +13,13 @@ # the building of the a.out executable program. For example, # DYLIB_ONLY := YES # +# When specifying one of the DYLIB_*_SOURCES variables, DYLIB_NAME +# controls the name of the produced dylib. E.g., if set to "foo", +# the generated dylib will be called "f

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

2024-10-18 Thread Pavel Labath via lldb-commits
labath wrote: Fixing definitely. Jacob, please change this to a hex constant and put the string in the comment. The name of the constants also seems out of place here. All of the other constants (even those that wrap existing windows ALL_CAPS) constants are using CamelCase). I'd suggest `enum

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-18 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/112566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-18 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/112566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add test for ASTImporter's name conflict resolution (PR #112566)

2024-10-18 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,9 @@ +#ifndef PLUGIN_H_IN +#define PLUGIN_H_IN + +extern "C" { +void plugin_entry(void); +void plugin_init(void); +} + +#endif // _H_IN labath wrote: ```suggestion #endif // PLUGIN_H_IN ``` https://github.com/llvm/llvm-project/pull/112566

<    1   2