https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/112895
>From cc3a4a94e9e2eb8b4cf763d4c8c477c71776ee93 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 16 Oct 2024 17:34:53 +0200
Subject: [PATCH 1/2] [lldb] Add timed callbacks to the MainLoop class
The motivati
AaronBallman wrote:
This seems to have broken precommit CI on Windows:
https://buildkite.com/llvm-project/github-pull-requests/builds/65#0192a01b-d3ac-44ad-abff-e53ac4a206ab
all of the failures look related to line endings, and I noticed that I got a
ton of command line messages of the for
Author: Michael Buch
Date: 2024-10-18T14:19:42+01:00
New Revision: 3bc765dbbf9bf0eceab1c9679b9f761b3f760d56
URL:
https://github.com/llvm/llvm-project/commit/3bc765dbbf9bf0eceab1c9679b9f761b3f760d56
DIFF:
https://github.com/llvm/llvm-project/commit/3bc765dbbf9bf0eceab1c9679b9f761b3f760d56.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/shiltian approved this pull request.
Can't believe this many Lol
https://github.com/llvm/llvm-project/pull/112899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-webassembly
@llvm/pr-subscribers-clang
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/112899.diff
19 Files Affected:
- (modified) clang/utils/TableGen/RISCVVEmitter.cpp (+2-2)
- (modified) flang/
https://github.com/banach-space approved this pull request.
LGTM, thanks!
I blame my editor's dictionary 😂
https://github.com/llvm/llvm-project/pull/112899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
ldrumm wrote:
There are a couple of things to unpack here
> a number of test input files need to be in LF form to work
Which ones? Either there's a bug in a parser somewhere, or I missed some test
files. In either case I'd like to fix the issue. I watched the buildbots quite
closely last nigh
https://github.com/cor3ntin approved this pull request.
cute typo :)
https://github.com/llvm/llvm-project/pull/112899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The motivating use case is being able to "time out" certain operations (by
adding a timed callback which will force the termination of the loop), but the
design is flexible enough to accomodate other use cases
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/112895
The motivating use case is being able to "time out" certain operations (by
adding a timed callback which will force the termination of the loop), but the
design is flexible enough to accomodate other use cases a
weliveindetail wrote:
This might be related to https://github.com/llvm/llvm-project/issues/56458 even
though my repro is different.
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
medismailben wrote:
LGTM but it would be nice if we made the `optional` fields stand out more by
either making it **bold** in the paragraph or add an `(optional)` on the
example lists.
https://github.com/llvm/llvm-project/pull/112938
___
lldb-commit
https://github.com/Jlalond commented:
A lot of this is over my head, but I left a few comments anyway.
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/medismailben approved this pull request.
Also may be you can point to the crashlog script as an example where this is
already being used.
https://github.com/llvm/llvm-project/pull/112938
___
lldb-commits mailing list
lldb-commits@li
Author: Kazu Hirata
Date: 2024-10-18T10:40:13-07:00
New Revision: a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0
URL:
https://github.com/llvm/llvm-project/commit/a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0
DIFF:
https://github.com/llvm/llvm-project/commit/a01d7df09048e0b0b002c3f8420bcc8c7eab3ea0.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/112823
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/112811
>From cee4a4f1ba6cbaa59ccd0278441f65eb26c06f96 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 9 Oct 2024 22:35:46 -0700
Subject: [PATCH] [lldb][dwarf] Compute fully qualified names on simplified
template
felipepiovezan wrote:
> > > > > do we have in mind any other languages that will implement this?
> > > >
> > > >
> > > > I suspect any language wanting to implement this notion of function
> > > > splitting (e.g. all the users of corosplitter) and virtual frames could
> > > > have a use for t
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/112811
>From db1e81bcbcc65af6963e84992154ffde16b13a10 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 9 Oct 2024 22:35:46 -0700
Subject: [PATCH] [lldb][dwarf] Compute fully qualified names on simplified
template
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/113024.diff
1 Files Affected:
- (modified) lldb/source/Core/DataFileCache.cpp (+6-8)
``diff
diff --git a/lldb/source/Core/DataFileC
@@ -237,6 +237,10 @@ class TypeSystem : public PluginInterface,
virtual ConstString GetDisplayTypeName(lldb::opaque_compiler_type_t type) =
0;
+ // Defaults to GetTypeName(type). Override if your language desires
+ // specialized behavior.
JDevlieghere
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/113006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/113006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/113024
None
>From 02829d780f3032c86992a3ae6a13ab27017e5635 Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Fri, 18 Oct 2024 09:10:44 -0700
Subject: [PATCH] [lldb] Avoid repeated hash lookups (NFC)
---
lldb/s
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream,
continue;
}
-auto &loc = *detail.source_location;
remaining_details.push_back(detail);
+ }
+
+ // Sort the diagnostics.
+ auto sort = [](auto &ds) {
+llvm::sort(ds.begin(), ds.end(), [](
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cc13d4fb4a208363ed1dab29829cd200a3e39c52
eb1f2bbd08d7f50286f0451ce0a6191c71c634eb --e
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/112899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From e35350b790f34660911c23cdbe34e6a0347f924d Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
https://github.com/kazutakahirata updated
https://github.com/llvm/llvm-project/pull/112823
>From 621d5b5a767daa4046dffec522c39e4bc652ac1b Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Thu, 17 Oct 2024 07:52:35 -0700
Subject: [PATCH 1/2] [lldb] Avoid repeated map lookups (NFC)
---
lldb/sour
@@ -102,11 +102,9 @@ llvm::Error CommandObjectMultiword::LoadUserSubcommand(
std::string str_name(name);
- auto pos = m_subcommand_dict.find(str_name);
- if (pos == m_subcommand_dict.end()) {
-m_subcommand_dict[str_name] = cmd_obj_sp;
+ auto [pos, inserted] = m_subco
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/112938
I've had multiple request for documentation about the JSON symbol file format
that LLDB supports. This patch documents the structure and fields, shows a
handful of examples and explains how to use it in LL
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
I've had multiple request for documentation about the JSON symbol file format
that LLDB supports. This patch documents the structure and fields, shows a
handful of examples and explains how to use i
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/112938
>From ea45421b4c4e7973abf0461bec75988800babe77 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 18 Oct 2024 10:18:54 -0700
Subject: [PATCH 1/2] [lldb] Document SymbolFileJSON
I've had multiple r
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/112939
Previously lldb didn't support setting breakpoints on call site locations.
This patch adds that ability.
It would be very slow if we did this by searching all the debug information for
every inlined subro
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
Previously lldb didn't support setting breakpoints on call site locations.
This patch adds that ability.
It would be very slow if we did this by searching all the debug information for
every inlined subroutine
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,6 +40,9 @@ class MainLoopBase {
class ReadHandle;
public:
+ using TimePoint = std::chrono::time_pointhttps://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -155,7 +181,9 @@ Status MainLoopPosix::RunImpl::Poll() {
void *sigset_ptr;
size_t sigset_len;
} extra_data = {&kernel_sigset, sizeof(kernel_sigset)};
- if (syscall(__NR_pselect6, nfds, &read_fd_set, nullptr, nullptr, nullptr,
+ if (syscall(__NR_pselect6, nfds, &r
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7da0a698526ff657c2348a6e4bb835fc764177da
9c6705b21df14dc911665e1082c9b31ce00d7e7c --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7da0a698526ff657c2348a6e4bb835fc764177da...9c6705b21df14dc911665e1082c9b31ce00d7e7c
lldb/
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/112451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream,
continue;
}
-auto &loc = *detail.source_location;
remaining_details.push_back(detail);
+ }
+
+ // Sort the diagnostics.
+ auto sort = [](auto &ds) {
+llvm::sort(ds.begin(), ds.end(), [](
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From 7d01c051172c89a722e386c9fb607919d4be11bc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From 3585c9ce2a79e7608ea666c9be5c398d0d5ce1cb Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/112939
>From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 3 Oct 2024 18:24:46 -0700
Subject: [PATCH 1/2] Add the ability to break on call-site locations, report
the c
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112801
>From 14b4120a75f35ef8ade38e6dee2c60685de10c9b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 17 Oct 2024 16:44:07 -0700
Subject: [PATCH] More aggressively deduplicate global warnings based on
co
@@ -305,6 +319,16 @@ class BreakpointLocation
/// It also takes care of decrementing the ignore counters.
/// If it returns false we should continue, otherwise stop.
bool IgnoreCountShouldStop();
+
+ // If this location knows that the virtual stack frame it represents
Author: Adrian Prantl
Date: 2024-10-18T16:55:21-07:00
New Revision: 2b7e9d27817da54c34a6f02dc00d2466c31f6fa0
URL:
https://github.com/llvm/llvm-project/commit/2b7e9d27817da54c34a6f02dc00d2466c31f6fa0
DIFF:
https://github.com/llvm/llvm-project/commit/2b7e9d27817da54c34a6f02dc00d2466c31f6fa0.diff
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/113006
Swift types have mangled names, so there should be a way to read those from the
compiler type.
This patch upstreams these two changes from swiftlang/llvm-project (which were
added there since at least 2016
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
Swift types have mangled names, so there should be a way to read those from the
compiler type.
This patch upstreams these two changes from swiftlang/llvm-project (which were
added there since at least
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/113007
Swift types have mangled type names. This adds functionality to look up those
types through the FindTypes API by searching for the mangled type name instead
of the regular name.
>From eb1f2bbd08d7f50286f04
augusto2112 wrote:
This depends on https://github.com/llvm/llvm-project/pull/113006
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
Swift types have mangled type names. This adds functionality to look up those
types through the FindTypes API by searching for the mangled type name instead
of the regular name.
---
Full diff: https:/
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
@@ -281,6 +283,18 @@ class BreakpointLocation
/// Returns the breakpoint location ID.
lldb::break_id_t GetID() const { return m_loc_id; }
+
+ // Set the line entry that should be shown to users for this location.
+ // It is up to the caller to verify that this is a val
mstorsjo wrote:
This breaks a number of tests on Windows.
Previously, to have tests working on Windows, one would do `git config --global
core.autocrlf false` or similar, before checking out llvm-project - a number of
test input files _need_ to be in LF form to work. This was brought up earlie
llvmbot wrote:
@llvm/pr-subscribers-backend-systemz
Author: Jay Foad (jayfoad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/112899.diff
19 Files Affected:
- (modified) clang/utils/TableGen/RISCVVEmitter.cpp (+2-2)
- (modified) flang/docs/OptionComparison.md (+1-1)
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self):
self.build()
self.step_in_template()
+@add_test_categories(["pyapi"])
+def test_virtual_inline_stepping(self):
+"""Test stepping through a virtual inlined call stack"""
+
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
https://github.com/adrian-prantl approved this pull request.
Very exciting, this is something I've wished for for a long time!
https://github.com/llvm/llvm-project/pull/112939
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self):
self.build()
self.step_in_template()
+@add_test_categories(["pyapi"])
+def test_virtual_inline_stepping(self):
+"""Test stepping through a virtual inlined call stack"""
+
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
@@ -369,6 +393,13 @@ class BreakpointLocation
lldb::break_id_t m_loc_id; ///< Breakpoint location ID.
StoppointHitCounter m_hit_counter; ///< Number of times this breakpoint
/// location has been hit.
+ std::optional m_preferred_line_en
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/112939
>From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 3 Oct 2024 18:24:46 -0700
Subject: [PATCH 1/3] Add the ability to break on call-site locations, report
the c
@@ -312,6 +315,112 @@ void CompileUnit::ResolveSymbolContext(
0, file_indexes, src_location_spec, &line_entry);
}
+ // If we didn't manage to find a breakpoint that matched the line number
+ // requested, that might be because it is only an inline call site, and
+
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/112939
>From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 3 Oct 2024 18:24:46 -0700
Subject: [PATCH 1/4] Add the ability to break on call-site locations, report
the c
@@ -656,6 +671,49 @@ void
BreakpointLocation::SendBreakpointLocationChangedEvent(
}
}
+std::optional BreakpointLocation::GetSuggestedStackFrameIndex() {
+ if (!GetPreferredLineEntry())
+return {};
+ LineEntry preferred = *GetPreferredLineEntry();
+ SymbolContext sc;
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/112939
>From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 3 Oct 2024 18:24:46 -0700
Subject: [PATCH 1/5] Add the ability to break on call-site locations, report
the c
@@ -369,6 +393,13 @@ class BreakpointLocation
lldb::break_id_t m_loc_id; ///< Breakpoint location ID.
StoppointHitCounter m_hit_counter; ///< Number of times this breakpoint
/// location has been hit.
+ std::optional m_preferred_line_en
@@ -357,3 +363,61 @@ def step_in_template(self):
step_sequence = [["// In max_value specialized", "into"]]
self.run_step_sequence(step_sequence)
+
+def run_to_call_site_and_step(self, source_regex, func_name, start_pos):
+main_spec = lldb.SBFileSpec
https://github.com/jimingham approved this pull request.
It's a bit sad we can't come up with a scenario that uses this for the
languages in the llvm.org repo. But the idea is clear the code really simple,
and it obviously belongs in the Language, so LGTM.
https://github.com/llvm/llvm-project
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self):
self.build()
self.step_in_template()
+@add_test_categories(["pyapi"])
+def test_virtual_inline_stepping(self):
+"""Test stepping through a virtual inlined call stack"""
+
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/112939
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -508,8 +508,20 @@ void BreakpointLocation::GetDescription(Stream *s,
s->PutCString("re-exported target = ");
else
s->PutCString("where = ");
+
+ // If there's a preferred line entry for printing, use that.
+ bool show_function_info = true;
+
@@ -656,6 +671,49 @@ void
BreakpointLocation::SendBreakpointLocationChangedEvent(
}
}
+std::optional BreakpointLocation::GetSuggestedStackFrameIndex() {
+ if (!GetPreferredLineEntry())
+return {};
+ LineEntry preferred = *GetPreferredLineEntry();
medi
@@ -537,7 +549,10 @@ void BreakpointLocation::GetDescription(Stream *s,
if (sc.line_entry.line > 0) {
s->EOL();
s->Indent("location = ");
- sc.line_entry.DumpStopContext(s, true);
+ if (GetPreferredLineEntry())
+GetPrefe
AaronBallman wrote:
I just had someone in my office hours also running into problems from this
commit. I went to revert the changes myself and I cannot because of merge
conflicts... due to line endings.
@ldrumm -- can you revert these changes ASAP? They're causing significant
problems in prac
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/112939
>From 9c6705b21df14dc911665e1082c9b31ce00d7e7c Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Thu, 3 Oct 2024 18:24:46 -0700
Subject: [PATCH 1/6] Add the ability to break on call-site locations, report
the c
@@ -357,3 +363,61 @@ def step_in_template(self):
step_sequence = [["// In max_value specialized", "into"]]
self.run_step_sequence(step_sequence)
+
+def run_to_call_site_and_step(self, source_regex, func_name, start_pos):
+main_spec = lldb.SBFileSpec
@@ -656,6 +671,49 @@ void
BreakpointLocation::SendBreakpointLocationChangedEvent(
}
}
+std::optional BreakpointLocation::GetSuggestedStackFrameIndex() {
+ if (!GetPreferredLineEntry())
+return {};
+ LineEntry preferred = *GetPreferredLineEntry();
+ SymbolContext sc;
@@ -32,6 +32,12 @@ def test_step_in_template_with_python_api(self):
self.build()
self.step_in_template()
+@add_test_categories(["pyapi"])
+def test_virtual_inline_stepping(self):
+"""Test stepping through a virtual inlined call stack"""
+
labath wrote:
Thank you for looking into this.
https://github.com/llvm/llvm-project/pull/111409
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,20 @@
+#ifndef SERVICE_H_IN
+#define SERVICE_H_IN
+
+struct ServiceAux;
+
+struct Service {
+ struct State;
+ bool start(State *) { return true; }
+
+#ifdef HIDE_FROM_PLUGIN
labath wrote:
I'm wondering if this is really how the original code looked l
@@ -0,0 +1,20 @@
+#ifndef SERVICE_H_IN
+#define SERVICE_H_IN
+
+struct ServiceAux;
+
+struct Service {
+ struct State;
+ bool start(State *) { return true; }
+
+#ifdef HIDE_FROM_PLUGIN
Michael137 wrote:
Yea unfortunately this is what the internal users are doin
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jayfoad created
https://github.com/llvm/llvm-project/pull/112899
None
>From 3a3b67f30cde766adaede4cc53bec340fbe5d99f Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Fri, 18 Oct 2024 13:53:51 +0100
Subject: [PATCH] Fix typo "instrinsic"
---
clang/utils/TableGen/RISCVVEmitter.
aeubanks wrote:
I believe Chrome is also seeing many test failures due to this
(https://crbug.com/374115887), although I haven't yet confirmed it's due to
this specific commit.
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing
Jlalond wrote:
https://github.com/llvm/llvm-project/commit/c742a5dc2e67e1f0020a1fd9f602b369b740eafc
Jinsong already authored a fix this to this build warning this morning
https://github.com/llvm/llvm-project/pull/108448
___
lldb-commits mailing list
l
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112566
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kuilpd wrote:
> The code I'm referring to is the `UniqueDWARFASTTypeMap` class (and the code
> surrounding it). We use that to determine whether to DIEs describe the same
> type. My idea was something like: a) look up the type that is supposed to
> contain the variable we're searching for (usi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1a871b2122470491f73b51f3e57718bc3bda08f1
cc3a4a94e9e2eb8b4cf763d4c8c477c71776ee93 --e
@@ -0,0 +1,43 @@
+"""
+Test SBTarget::FindGlobalVariables API.
+"""
Michael137 wrote:
Could we re-use `TestConstStaticIntegralMember.py`? Surprised it doesn't
already have the tests added here XFAILed
https://github.com/llvm/llvm-project/pull/111859
___
https://github.com/Dinistro approved this pull request.
LGTM, thanks for the fixes 😄
https://github.com/llvm/llvm-project/pull/112899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/112928
In the MS ABI, member pointers to `CXXRecordDecl`s must have a
`MSInheritanceAttr` in order to be complete. Otherwise we cannot query their
size in memory. This patch checks `MemberPointer` types for com
mstorsjo wrote:
> > a number of test input files need to be in LF form to work
>
> Which ones?
A whole bunch of them. @AaronBallman's link to
https://buildkite.com/llvm-project/github-pull-requests/builds/65#0192a01b-d3ac-44ad-abff-e53ac4a206ab
shows mostly what I saw. If including `clang
1 - 100 of 130 matches
Mail list logo
