[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -2990,18 +2992,34 @@ void ObjectFileELF::ParseSymtab(Symtab &lldb_symtab) { // section, nomatter if .symtab was already parsed or not. This is because // minidebuginfo normally removes the .symtab symbols which have their // matching .dynsym counterparts. + bool found

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
@@ -3895,3 +3924,103 @@ std::optional ObjectFileELF::GetDynamicData() { } return std::nullopt; } + + +std::optional +ObjectFileELF::GetDynsymDataFromDynamic(uint32_t &num_symbols) { + // Every ELF file which represents an executable or shared library has + // mandatory .

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond approved this pull request. I left some comments. All code layout options and comment concerns, otherwise LGTM! https://github.com/llvm/llvm-project/pull/112596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-16 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > I adapted the code from here > > https://github.com/llvm/llvm-project/blob/a62768c427ec1f34d7c3823021a6c5a794709103/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py#L516 > > into `lldbgdbproxy.py`: > ``` > +lldb_server_exe = lldbgdbserverutils

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes The codecvt header has been deprecated in C++17. Use locale to convert between std::string and std::wstring in Editline. --- Full diff: https://github.com/llvm/llvm-project/pull/112582.diff 2 File

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/112582 The codecvt header has been deprecated in C++17. Use locale to convert between std::string and std::wstring in Editline. >From de1a1c4cfb5a8c3fc47194275fcc8fc48b7cbbf9 Mon Sep 17 00:00:00 2001 From: Jonas

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > [this](https://godbolt.org/z/4WsnMvz5G) _might_ be a non-deprecated way of > achieving this, though I'm not entirely sure about its portability (windows > is the main question, but I guess we don't use editline there anyway). I > don't think you have to do that, but it is

[Lldb-commits] [lldb] [lldb] Use system c++ lib for stl libs (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/112598 This change partially reverts #112357 to avoid test failures on machines which do not have gcc installed. Test run: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/lldb-linux-x64/b87338973

[Lldb-commits] [lldb] Add support for reading the dynamic symbol table from PT_DYNAMIC (PR #112596)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6558e5615ae9e6af6168b0a363808854fd3f 890d2bcf655a2e1e58b025cc0df7b4e42956e4c6 --e

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Haowei (zeroomega) Changes This change partially reverts #112357 to avoid test failures on machines which do not have gcc installed. Test run: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/lldb-linux-x64/b873389735080

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega edited https://github.com/llvm/llvm-project/pull/112598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use system c++ lib for LLDB STL tests (PR #112598)

2024-10-16 Thread via lldb-commits
https://github.com/zeroomega updated https://github.com/llvm/llvm-project/pull/112598 >From fe4fe7395d36a89d6df62c8bf6212cff0f665b9f Mon Sep 17 00:00:00 2001 From: Haowei Wu Date: Wed, 16 Oct 2024 11:24:34 -0700 Subject: [PATCH] [lldb] Use system c++ lib for LLDB STL tests This change partiall

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-16 Thread Jessica Clarke via lldb-commits
https://github.com/jrtc27 closed https://github.com/llvm/llvm-project/pull/112420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From af2e73635f85bd56b708e1240ad2c6837b7e449f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/6] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb] Use Locale to convert between std::wstring and std::string (NFC) (PR #112582)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 92ad0397f494a9895385057586cc59a908107f81 de1a1c4cfb5a8c3fc47194275fcc8fc48b7cbbf9 --e

[Lldb-commits] [lldb] [lldb] Lookup static const members in FindGlobalVariables (PR #111859)

2024-10-16 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > I think we may want to implement this in a slightly different matter: find > the unique definition DIE for the given type (we use that concept when > parsing types) and then search for child inside that -- instead of searching > through all (possibly one per CU) definitions of

[Lldb-commits] [lldb] ad5e2bf - [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (#112420)

2024-10-16 Thread via lldb-commits
Author: Brooks Davis Date: 2024-10-16T20:41:38+01:00 New Revision: ad5e2bf6e934abd9fef39d3b88f40d4f3c1a7d60 URL: https://github.com/llvm/llvm-project/commit/ad5e2bf6e934abd9fef39d3b88f40d4f3c1a7d60 DIFF: https://github.com/llvm/llvm-project/commit/ad5e2bf6e934abd9fef39d3b88f40d4f3c1a7d60.diff

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-16 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/112276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-16 Thread Adrian Vogelsgesang via lldb-commits
@@ -962,6 +962,68 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool SendEv

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-16 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: (wrote that update too quickly while running out the door -- I can run the lldb-shell tests both with and without your patch, and they pass. I'm not able to repo the failure the CI bots saw.) https://github.com/llvm/llvm-project/pull/111409

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-16 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/112657 When FileAction opens file with write access for lldb stdout/stderr redirect, it doesn't clear the file nor append to the end of the file if it already exists. Instead, it writes from cursor index 0. This func

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/112655 None >From 826b8ad10ef9d24e744aa00298ca380bfcd4c79a Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 16 Oct 2024 06:49:47 -0700 Subject: [PATCH] [lldb] Avoid repeated map lookups (NFC) --- lldb/so

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112655.diff 1 Files Affected: - (modified) lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (+1-1) ``diff diff --git a/l

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1b4a173fa41e02eddec9f1cf41324aa4ea8a7fa5 eac4e0b05f6c55dc9621edb3c2ba6b07876b3efb --e

[Lldb-commits] [lldb] [lldb] Fix write only file action to truncate the file (PR #112657)

2024-10-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes When FileAction opens file with write access for lldb stdout/stderr redirect, it doesn't clear the file nor append to the end of the file if it already exists. Instead, it writes from cursor index 0. This function

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
@@ -5324,7 +5324,7 @@ std::string ProcessGDBRemote::HarmonizeThreadIdsForProfileData( std::map::iterator iterator = m_thread_id_to_used_usec_map.find(thread_id); if (iterator != m_thread_id_to_used_usec_map.end()) { - prev_used_usec = m_thr

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/112655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid repeated map lookups (NFC) (PR #112655)

2024-10-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2