[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2024-10-15 Thread Pavel Labath via lldb-commits
labath wrote: > NativeProcessManager::Attach Also worth noting that the test is *attaching*. That's probably because on darwin we are launching the process in suspended mode and then asking the debugserver to attach to it. That's might not be what the packet forwarder expects (or is it?) htt

[Lldb-commits] [lldb] [lldb][test] Fix the test TestArrayFromStdModule.py (PR #112485)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3860e29e0e743c5f411c3023396d1ea07c28da7d...4736ff60f79352f2f9f703eced07c3555fef8a63 lldb

[Lldb-commits] [lldb] 282ab2f - [lldb] Avoid repeated hash lookups (NFC) (#112471)

2024-10-15 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-10-15T23:11:30-07:00 New Revision: 282ab2f1895450707c9f8fc6a46634620165d1c9 URL: https://github.com/llvm/llvm-project/commit/282ab2f1895450707c9f8fc6a46634620165d1c9 DIFF: https://github.com/llvm/llvm-project/commit/282ab2f1895450707c9f8fc6a46634620165d1c9.diff L

[Lldb-commits] [lldb] [lldb] Avoid repeated hash lookups (NFC) (PR #112471)

2024-10-15 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/112471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix tests Test*FromStdModule where called missing at(0) (PR #112485)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/112485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Can we change the Darwin case to `USE_LIBCPP` though? The less reliance on > the system stdlib the better i think. I cannot test it on Darwin, so I would leave that to the Darwin experts. > Also lets check that the PR CI actually does run the test (aka doesn't > trigger the

[Lldb-commits] [lldb] [lldb] Log errors to the system log if they would otherwise get dropped (PR #111911)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/111911 >From 55eab57c695d4be99305d2b6cee0c4f44261a473 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 10 Oct 2024 14:39:44 -0700 Subject: [PATCH 1/4] [lldb] Log errors to the system log if they would

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
@@ -98,10 +94,31 @@ void RenderDiagnosticDetails(Stream &stream, continue; } -auto &loc = *detail.source_location; remaining_details.push_back(detail); + } + + // Sort the diagnostics. + auto sort = [](auto &ds) { +std::sort(ds.begin(), ds.end(), [](a

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/112420 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] eca3206 - [lldb] Fix command-expr-diagnostics.test for Windows (#112109)

2024-10-15 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-16T05:33:27+05:00 New Revision: eca3206d29e7ce97dd6336deaa3da96be37f8277 URL: https://github.com/llvm/llvm-project/commit/eca3206d29e7ce97dd6336deaa3da96be37f8277 DIFF: https://github.com/llvm/llvm-project/commit/eca3206d29e7ce97dd6336deaa3da96be37f82

[Lldb-commits] [lldb] cc13d4f - [lldb] Make the system log a NOOP on non-Darwin platforms

2024-10-15 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-15T16:13:42-07:00 New Revision: cc13d4fb4a208363ed1dab29829cd200a3e39c52 URL: https://github.com/llvm/llvm-project/commit/cc13d4fb4a208363ed1dab29829cd200a3e39c52 DIFF: https://github.com/llvm/llvm-project/commit/cc13d4fb4a208363ed1dab29829cd200a3e39c52.d

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112451 …reverse order The second inner loop (only) was missing the check for offset > column. Also this patch sorts the diagnostics before printing them. >From 934214ae1daf3fd70ee1cf332b269d636fbbc193 Mon Sep 1

[Lldb-commits] [lldb] [lldb] Fix a crash when two diagnostics are on the same column or in … (PR #112451)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes …reverse order The second inner loop (only) was missing the check for offset > column. Also this patch sorts the diagnostics before printing them. --- Full diff: https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] 5f2cf99 - DynamicLoaderDarwin load images in parallel with preload (#110646)

2024-10-15 Thread via lldb-commits
Author: Dmitrii Galimzianov Date: 2024-10-15T13:25:01-07:00 New Revision: 5f2cf99e146ce99d4e148038d9bdd012331b4821 URL: https://github.com/llvm/llvm-project/commit/5f2cf99e146ce99d4e148038d9bdd012331b4821 DIFF: https://github.com/llvm/llvm-project/commit/5f2cf99e146ce99d4e148038d9bdd012331b4821

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel with preload (PR #110646)

2024-10-15 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/110646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel with preload (PR #110646)

2024-10-15 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Very nice! And now we'll see what all the CI bots think of this change. :) https://github.com/llvm/llvm-project/pull/110646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] de7f7ea - [lldb][test] Fix TestStdCXXDisassembly test (#112357)

2024-10-15 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-10-16T00:08:58+04:00 New Revision: de7f7ea884525cca24e8797319452bd8bc150752 URL: https://github.com/llvm/llvm-project/commit/de7f7ea884525cca24e8797319452bd8bc150752 DIFF: https://github.com/llvm/llvm-project/commit/de7f7ea884525cca24e8797319452bd8bc150752.dif

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test (PR #112357)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/112357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Brooks Davis via lldb-commits
https://github.com/brooksdavis updated https://github.com/llvm/llvm-project/pull/112420 >From 1732a1841a24e411cb261d7ae3bff16af618268c Mon Sep 17 00:00:00 2001 From: Brooks Davis Date: Tue, 15 Oct 2024 20:03:54 +0100 Subject: [PATCH 1/3] [llbd] Finish Turn lldb_private::Status into a value typ

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/112446 Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for #112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB. >From 4c53565414c95ddd49050363

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for #112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB. --- Full diff: https://

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently all of LLDB is being compiled with -Wno-deprecated-declarations. That's not desirable, especially as part of the LLVM monorepo, as we miss deprecation warnings from LLVM and clang. Accord

[Lldb-commits] [lldb] [lldb] Disable warning about codecvt_utf8 deprecation (NFC) (PR #112446)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: There was an attempt to remove this (https://reviews.llvm.org/D106035) but this hit some issues on Arch and with column counting which is out of scope for what I'm trying to achieve. https://github.com/llvm/llvm-project/pull/112446 _

[Lldb-commits] [lldb] [lldb] Narrow scope of -Wno-deprecated-declarations (NFC) (PR #112276)

2024-10-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/112276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -290,6 +290,30 @@ The initial repl-mode can be configured with the cli flag `--repl-mode=` and may also be adjusted at runtime using the lldb command `lldb-dap repl-mode `. + `lldb-dap custom-event` vogelsgesang wrote: afaict, this command could also

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Adrian Vogelsgesang via lldb-commits
@@ -962,6 +962,44 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a custom DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/2] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
@@ -962,6 +962,44 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a custom DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/3] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 224f62de9e34d537b1fd282b47b773b04bea34f1...ea5bf236b32bb852d4461d37b732f6e7f0f3007b lldb/

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 224f62de9e34d537b1fd282b47b773b04bea34f1 ea5bf236b32bb852d4461d37b732f6e7f0f3007b --e

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
@@ -290,6 +290,30 @@ The initial repl-mode can be configured with the cli flag `--repl-mode=` and may also be adjusted at runtime using the lldb command `lldb-dap repl-mode `. + `lldb-dap custom-event` ashgti wrote: Renamed the event to `lldb-dap send-ev

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/4] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread via lldb-commits
@@ -962,6 +962,67 @@ bool ReplModeRequestHandler::DoExecute(lldb::SBDebugger debugger, return true; } +// Sends a DAP event with an optional body. +// +// See +// https://code.visualstudio.com/api/references/vscode-api#debug.onDidReceiveDebugSessionCustomEvent +bool SendEv

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/112384 >From 61f5407be7fed86428d46e0ea0a6d418a8e25bf7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 15 Oct 2024 09:13:49 -0700 Subject: [PATCH 1/5] [lldb-dap] Creating an API for sending custom dap events fro

[Lldb-commits] [lldb] 69f7758 - Revert "[lldb] Fix command-expr-diagnostics.test for Windows (#112109)"

2024-10-15 Thread Muhammad Omair Javaid via lldb-commits
Author: Muhammad Omair Javaid Date: 2024-10-16T06:08:13+05:00 New Revision: 69f7758ddba662b63667507f2c472c008909dd7e URL: https://github.com/llvm/llvm-project/commit/69f7758ddba662b63667507f2c472c008909dd7e DIFF: https://github.com/llvm/llvm-project/commit/69f7758ddba662b63667507f2c472c008909dd

[Lldb-commits] [lldb] [lldb] Improve unwinding for discontinuous functions (PR #111409)

2024-10-15 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Alex had a PR a month ago https://github.com/llvm/llvm-project/pull/106791 that got reverted from the same test failing on x86, I tried to repo the failure a few times on an intel mac and never succeeded. I'll try again with your patch when I have that set up. If this tes

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-15 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Or is @slydiman implying this PR isn't needed anymore? This patch should fix the following tests: array/TestArrayFromStdModule.py vector-of-vectors/TestVectorOfVectorsFromStdModule.py vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py See the buildbot https://lab

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. looks pretty good. Just a minor nit https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Walter Erquinigo via lldb-commits
@@ -1896,6 +1896,8 @@ void request_initialize(const llvm::json::Object &request) { cmd.AddCommand( "repl-mode", new ReplModeRequestHandler(), "Get or set the repl behavior of lldb-dap evaluation requests."); + cmd.AddCommand("custom-event", new CustomDAPEventReq

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/112384 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llbd] Finish Turn lldb_private::Status into a value type. (#10616) (PR #112420)

2024-10-15 Thread Brooks Davis via lldb-commits
https://github.com/brooksdavis updated https://github.com/llvm/llvm-project/pull/112420 >From 1732a1841a24e411cb261d7ae3bff16af618268c Mon Sep 17 00:00:00 2001 From: Brooks Davis Date: Tue, 15 Oct 2024 20:03:54 +0100 Subject: [PATCH 1/2] [llbd] Finish Turn lldb_private::Status into a value typ

[Lldb-commits] [lldb] [lldb-dap] Creating an API for sending custom dap events from lldb-dap. (PR #112384)

2024-10-15 Thread John Harrison via lldb-commits
@@ -1896,6 +1896,8 @@ void request_initialize(const llvm::json::Object &request) { cmd.AddCommand( "repl-mode", new ReplModeRequestHandler(), "Get or set the repl behavior of lldb-dap evaluation requests."); + cmd.AddCommand("custom-event", new CustomDAPEventReq

<    1   2