labath wrote:
> Regarding limiting the output, I'm happy to draw the line at
> `LLDB_LOG_ERRORV`. The system log is pretty cheap on our platform and I
> assumed it's the same on Linux, so personally I would hope it doesn't deter
> anyone from using `LLDB_LOG_ERROR`.
>From the looks of things,
DmT021 wrote:
> I think that's where the real perf difference you were measuring kicked in
> (you showed a 10.5 second versus 13.4 second time difference for preload
> versus parallel in the beginning), do I have that right?
That's right.
> Do you prefer the non-preload approach?
No, I thin
shafik wrote:
This crash is due to this set of changes:
https://github.com/llvm/llvm-project/issues/11
https://github.com/llvm/llvm-project/pull/78041
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -123,30 +123,79 @@ void CommandReturnObject::SetError(llvm::Error error) {
}
}
-llvm::StringRef
-CommandReturnObject::GetInlineDiagnosticString(unsigned indent) {
- RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics);
+std::string CommandReturnObject::Get
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/111977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
kastiglione wrote:
> so they know they have to escape it depending on their use case
in the example shown, `"some arg?"` is quoted, which normally escapes a glob.
Do we really need to force an additional level of escaping on users? Hopefully
not but I can see that this is tricky.
https://gith
https://github.com/JDevlieghere approved this pull request.
LGTM with the other comments addressed.
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
zeroomega wrote:
> In fact, I ran into that on Friday myself. I checked `LLDB_INCLUDE_TESTS=Off`
rocallahan wrote:
> I'd say that this is failing because macos generates slightly different
> packet sequences, and the test is not expecting those.
Makes sense. But given Mac tests don't run against PRs, and I don't have a Mac,
how am I supposed to debug this?
https://github.com/llvm/llvm-pr
https://github.com/oontvoo edited
https://github.com/llvm/llvm-project/pull/111891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -70,6 +70,8 @@ class CommandObjectMultiword : public CommandObject {
return m_subcommand_dict;
}
+ std::string GetTopSubcommands(int count);
oontvoo wrote:
P.S: Actually, didn't end up renaming it Jim's suggestion, but to something
else, hopefully
@@ -194,28 +194,54 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
@@ -194,28 +194,54 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
101 - 114 of 114 matches
Mail list logo
