[Lldb-commits] [lldb] [LLDB]Provide clearer error message for invalid commands. (PR #111891)

2024-10-12 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/111891 >From 4493bf07c8b18dac39a2a421f97fa34cd15a6031 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Thu, 10 Oct 2024 14:48:08 -0400 Subject: [PATCH 1/3] [LLDB]Provide clearer error message for invalid commands. Somet

[Lldb-commits] [lldb] [LLDB]Provide clearer error message for invalid commands. (PR #111891)

2024-10-12 Thread Vy Nguyen via lldb-commits
@@ -3,8 +3,10 @@ # RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out # RUN: %lldb -b -o 'help breakpoint set' -o 'breakpoint set -f main.c -l 2 -u 21' %t.out | FileCheck %s --check-prefix HELP --check-prefix CHECK # RUN: %lldb -b -o 'help _regexp-break' -o 'b main.c:2:21' %t.

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/112107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread Jonas Devlieghere via lldb-commits
@@ -9,6 +9,7 @@ #ifndef LLDB_API_SBSTRUCTUREDDATA_H #define LLDB_API_SBSTRUCTUREDDATA_H +#include "SBCommandReturnObject.h" JDevlieghere wrote: ```suggestion #include "lldb/API/SBCommandReturnObject.h" ``` https://github.com/llvm/llvm-project/pull/112109 ___

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread Jonas Devlieghere via lldb-commits
@@ -45,13 +45,14 @@ class LLDB_API SBCommandReturnObject { const char *GetOutput(); const char *GetError(); + SBStructuredData GetErrorData(); #ifndef SWIG LLDB_DEPRECATED_FIXME("Use PutOutput(SBFile) or PutOutput(FileSP)", "PutOutput(SBFile

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread Jonas Devlieghere via lldb-commits
@@ -123,30 +123,80 @@ void CommandReturnObject::SetError(llvm::Error error) { } } -llvm::StringRef +std::string CommandReturnObject::GetInlineDiagnosticString(unsigned indent) { - RenderDiagnosticDetails(m_diag_stream, indent, true, m_diagnostics); + StreamString diag_str

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c2750807ba2a419425ee90dadda09ad5121517fe cf7ea7aa4d458ad82c39afb2b0879ec32a88a2db --e

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r c2750807ba2a419425ee90dadda09ad5121517fe...cf7ea7aa4d458ad82c39afb2b0879ec32a88a2db lldb/

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-12 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: In fact, I ran into that on Friday myself. I checked `LLDB_INCLUDE_TESTS=Off` in my setup and it appeared to be incompatible with `LLDB_ENABLE_PYTHON=On` if `lldb-python` is part of `LLVM_DISTRIBUTION_COMPONENTS`. The error said something like `lldb-python-scripts` is lac

[Lldb-commits] [lldb] c275080 - [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (#112062)

2024-10-12 Thread via lldb-commits
Author: Adrian Prantl Date: 2024-10-12T13:36:33-07:00 New Revision: c2750807ba2a419425ee90dadda09ad5121517fe URL: https://github.com/llvm/llvm-project/commit/c2750807ba2a419425ee90dadda09ad5121517fe DIFF: https://github.com/llvm/llvm-project/commit/c2750807ba2a419425ee90dadda09ad5121517fe.diff

[Lldb-commits] [lldb] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*String (PR #112062)

2024-10-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/112062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/112109 This allows IDEs to render LLDB expression diagnostics to their liking without relying on characterprecise ASCII art from LLDB. It is exposed as a versioned SBStructuredData object, since it is expected t

[Lldb-commits] [lldb] [lldb] Expose structured command diagnostics via the SBAPI. (PR #112109)

2024-10-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes This allows IDEs to render LLDB expression diagnostics to their liking without relying on characterprecise ASCII art from LLDB. It is exposed as a versioned SBStructuredData object, since it is expecte

[Lldb-commits] [lldb] [lldb] Speed up FindInMemory tests (PR #111951)

2024-10-12 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/111951 >From e027444340be4020002126da0d2c8a705c2c7e3f Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 10 Oct 2024 20:27:10 -0700 Subject: [PATCH 1/2] [lldb] Speed up FindInMemory tests A memory region can be

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-12 Thread Keith Smiley via lldb-commits
https://github.com/keith created https://github.com/llvm/llvm-project/pull/112107 Previously on macOS with lldb-argdumper if you ran: ``` lldb -o r -- /tmp/foo "some arg?" ``` It would fail with this error: ``` error: shell expansion failed (reason: lldb-argdumper exited with error 1). consi

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Keith Smiley (keith) Changes Previously on macOS with lldb-argdumper if you ran: ``` lldb -o r -- /tmp/foo "some arg?" ``` It would fail with this error: ``` error: shell expansion failed (reason: lldb-argdumper exited with error 1). con