[Lldb-commits] [lldb] Improve namespace lookup using .debug_names parent chain (PR #110062)

2024-10-10 Thread Pavel Labath via lldb-commits
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery( m_fallback.GetTypesWithQuery(query, callback); } +void DebugNamesDWARFIndex::GetNamespacesWithParents( +ConstString name, const CompilerDeclContext &parent_decl_ctx, +llvm::function_ref callback) { +

[Lldb-commits] [lldb] Improve namespace lookup using .debug_names parent chain (PR #110062)

2024-10-10 Thread Pavel Labath via lldb-commits
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery( m_fallback.GetTypesWithQuery(query, callback); } +void DebugNamesDWARFIndex::GetNamespacesWithParents( +ConstString name, const CompilerDeclContext &parent_decl_ctx, +llvm::function_ref callback) { +

[Lldb-commits] [lldb] Improve namespace lookup using .debug_names parent chain (PR #110062)

2024-10-10 Thread Pavel Labath via lldb-commits
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery( m_fallback.GetTypesWithQuery(query, callback); } +void DebugNamesDWARFIndex::GetNamespacesWithParents( +ConstString name, const CompilerDeclContext &parent_decl_ctx, +llvm::function_ref callback) { +

[Lldb-commits] [lldb] Improve namespace lookup using .debug_names parent chain (PR #110062)

2024-10-10 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/110062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-10 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail deleted https://github.com/llvm/llvm-project/pull/111531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-10 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/111686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-10 Thread Stefan Gränitz via lldb-commits
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS) "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`") endif() endforeach() + + # On Windows make is not part of the MSYS tools that llvm-lit takes care of + if(LLDB_TEST_MAKE) +set(LLDB_DEFAULT_TEST_MAKE

[Lldb-commits] [lldb] 7890919 - [lldb] Check for Python 'packaging' module at configuration time (#111747)

2024-10-10 Thread via lldb-commits
Author: Stefan Gränitz Date: 2024-10-10T11:34:19+02:00 New Revision: 7890919fb8323faf70fb16a05f91d4f602ce52fb URL: https://github.com/llvm/llvm-project/commit/7890919fb8323faf70fb16a05f91d4f602ce52fb DIFF: https://github.com/llvm/llvm-project/commit/7890919fb8323faf70fb16a05f91d4f602ce52fb.diff

[Lldb-commits] [lldb] [lldb] Check for Python 'packaging' module at configuration time (PR #111747)

2024-10-10 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/111747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for Python 'packaging' module at configuration time (PR #111747)

2024-10-10 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: No worries, we have it now. Thanks for the quick review! https://github.com/llvm/llvm-project/pull/111747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0e91323 - [lldb] Add early CMake check for 'make' tool (#111531)

2024-10-10 Thread via lldb-commits
Author: Stefan Gränitz Date: 2024-10-10T12:55:31+02:00 New Revision: 0e913237871e8c9290e82be30be8b3484952eee0 URL: https://github.com/llvm/llvm-project/commit/0e913237871e8c9290e82be30be8b3484952eee0 DIFF: https://github.com/llvm/llvm-project/commit/0e913237871e8c9290e82be30be8b3484952eee0.diff

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-10 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/111531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] elf-memory.test requires LLDB build with Python support (PR #111810)

2024-10-10 Thread Alex Bradbury via lldb-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/111810 Otherwise it fails with "error: Embedded script interpreter unavailable. LLDB was built without scripting language support." >From 2aa842033dd91c7138dc8fe2c61a5f9fdaf2d8c0 Mon Sep 17 00:00:00 2001 From: Alex Bradbur

[Lldb-commits] [lldb] [lldb][test] elf-memory.test requires LLDB build with Python support (PR #111810)

2024-10-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Bradbury (asb) Changes Otherwise it fails with "error: Embedded script interpreter unavailable. LLDB was built without scripting language support." --- Full diff: https://github.com/llvm/llvm-project/pull/111810.diff 1 Files Affecte

[Lldb-commits] [lldb] [lldb][test] Enable static linking with libcxx for import-std-module tests (PR #98701)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/98701 >From c5332e409c05c1700c6563a7c9af9a82e3831ebf Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 14 Jun 2024 19:00:39 + Subject: [PATCH] [lldb][test] Enable static linking with libcxx for imp

[Lldb-commits] [lldb] [lldb][test] Use `xcrun -f strip` for API tests on Darwin (PR #111842)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111842 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 058ede0 - [lldb][test] Use `xcrun -f strip` for API tests on Darwin (#111842)

2024-10-10 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-10-10T17:14:13+02:00 New Revision: 058ede06c4ffd4e3c9f54d947e3bfb027c2d0557 URL: https://github.com/llvm/llvm-project/commit/058ede06c4ffd4e3c9f54d947e3bfb027c2d0557 DIFF: https://github.com/llvm/llvm-project/commit/058ede06c4ffd4e3c9f54d947e3bfb027c2d055

[Lldb-commits] [lldb] [lldb][test] Use `xcrun -f strip` for API tests on Darwin (PR #111842)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/111842 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-10 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: > it should definitely be enabled by default when we're at the point to merge > it, and the setting should only be a safety mechanism if this turns out to > cause a problem for a configuration we weren't able to test. That's fine with me either. > I would even put it explicitly

[Lldb-commits] [lldb] 7e16571 - [lldb][libc++] Hide all libc++ implementation details from stacktraces (#108870)

2024-10-10 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-10-10T19:27:27+02:00 New Revision: 7e16571eb02e7e9da24fee45359e981af783d0d0 URL: https://github.com/llvm/llvm-project/commit/7e16571eb02e7e9da24fee45359e981af783d0d0 DIFF: https://github.com/llvm/llvm-project/commit/7e16571eb02e7e9da24fee45359e981af783d0d0

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

2024-10-10 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread via lldb-commits
@@ -38,19 +38,23 @@ class Args { std::unique_ptr ptr; char quote = '\0'; +/// The position of the argument in the original argument string. +std::optional column; char *data() { return ptr.get(); } public: ArgEntry() = default; -ArgEntry(ll

[Lldb-commits] [lldb] [lldb] Make sure Status is updated in GetFrameBaseValue (PR #111882)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/111882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make sure Status is updated in GetFrameBaseValue (PR #111882)

2024-10-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This fixes the following assertion: "Cannot create Expected from Error success value." The problem was that GetFrameBaseValue returned false without updating the Status argument. This patch makes

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread via lldb-commits
@@ -2078,6 +2078,11 @@ bool CommandInterpreter::HandleCommand(const char *command_line, ElapsedTime elapsed(execute_time); cmd_obj->SetOriginalCommandString(real_original_command_string); +pos = real_original_command_string.rfind(remainder); jimin

[Lldb-commits] [lldb] [lldb] Make sure Status is updated in GetFrameBaseValue (PR #111882)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/111882 This fixes the following assertion: "Cannot create Expected from Error success value." The problem was that GetFrameBaseValue return false without updating the Status argument. This patch makes sure that e

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread via lldb-commits
@@ -3180,15 +3180,24 @@ void CommandInterpreter::IOHandlerInputComplete(IOHandler &io_handler, if ((result.Succeeded() && io_handler.GetFlags().Test(eHandleCommandFlagPrintResult)) || io_handler.GetFlags().Test(eHandleCommandFlagPrintErrors)) { -// Display a

[Lldb-commits] [lldb] [lldb][debugserver][NFC] Simplify macOS thread name fetching. (PR #111684)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/111684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b800ff6 - [lldb][debugserver][NFC] Simplify macOS thread name fetching. (#111684)

2024-10-10 Thread via lldb-commits
Author: Donough Liu Date: 2024-10-10T11:46:19-07:00 New Revision: b800ff67dae59e194c8e9fc5d795a5932dc726f8 URL: https://github.com/llvm/llvm-project/commit/b800ff67dae59e194c8e9fc5d795a5932dc726f8 DIFF: https://github.com/llvm/llvm-project/commit/b800ff67dae59e194c8e9fc5d795a5932dc726f8.diff L

[Lldb-commits] [lldb] [lldb][debugserver][NFC] Simplify macOS thread name fetching. (PR #111684)

2024-10-10 Thread via lldb-commits
github-actions[bot] wrote: @ldm0 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, yo

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @rocallahan Let me know if you need me to merge this on your behalf. https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [LLDB]Provide clearer error message for invalid commands. (PR #111891)

2024-10-10 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/111891 Sometimes users (esp. gdb-longtime users) accidentally use GDB syntax, such as `breakpoint foo`, and they would get an error message from LLDB saying simply `Invalid command "breakpoint foo"`, which is not very

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-10 Thread David Mentler via lldb-commits
https://github.com/mentlerd created https://github.com/llvm/llvm-project/pull/111892 Work in progress attempt at fixing #111291. Looking for maintainer feedback/direction from @Michael137 >From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001 From: David Mentler Date: Mon, 7

[Lldb-commits] [lldb] [LLDB]Provide clearer error message for invalid commands. (PR #111891)

2024-10-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes Sometimes users (esp. gdb-longtime users) accidentally use GDB syntax, such as `breakpoint foo`, and they would get an error message from LLDB saying simply `Invalid command "breakpoint foo"`, which is not very

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-10 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] Return an llvm::Error from GetFrameBaseValue (PR #111882)

2024-10-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/111882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > @rocallahan Let me know if you need me to merge this on your behalf. Please do! Thanks! https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [lldb] [lldb] Fixed TestEchoCommands.test running on a remote target (PR #94127)

2024-10-10 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/94127 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable find-module.test in case of a remote target (PR #94165)

2024-10-10 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman closed https://github.com/llvm/llvm-project/pull/94165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-10 Thread Pavel Labath via lldb-commits
Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs(): configuration.make_path = "gmake" else: configuration.make_path = "make" +if ' ' in configuration.make_path: +

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-10 Thread Pavel Labath via lldb-commits
Stefan =?utf-8?q?Gränitz?= , Stefan =?utf-8?q?Gränitz?= Message-ID: In-Reply-To: @@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS) "`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`") endif() endforeach() + + # On Windows make is not part of the MSYS tool

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-10-10 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/108495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace Code Owners with Maintainers (PR #111686)

2024-10-10 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'll land this on Monday unless anyone objects. After that anyone can make their own changes as usual. https://github.com/llvm/llvm-project/pull/111686 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [lldb] Lookup static const members in FindGlobalVariables (PR #111859)

2024-10-10 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/111859 >From 4c394ec162b58b3cde3af924a5e9be1de8250a07 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Tue, 30 Jul 2024 17:02:10 +0500 Subject: [PATCH] [lldb] Lookup static const members in FindGlobalVariables Static c

[Lldb-commits] [lldb] [lldb][test] Use `xcrun -f strip` for API tests on Darwin (PR #111842)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/111842 A follow-up for https://github.com/llvm/llvm-project/pull/111816. This is to fix buildbot failure https://lab.llvm.org/staging/#/builders/195/builds/4242. TestSymbolFileJSON.py doesn't pass with llvm-strip

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/98694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/98694 >From 35db69bd4f65c2b99ba8f366d7de36e7901ccb88 Mon Sep 17 00:00:00 2001 From: Vladimir Vereschaka Date: Thu, 30 May 2024 03:04:58 + Subject: [PATCH] [lldb][test] Fix TestStdCXXDisassembly test when tests a

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev ready_for_review https://github.com/llvm/llvm-project/pull/98694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix TestStdCXXDisassembly test for case when tests are linked with libc++ statically (PR #98694)

2024-10-10 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: Rebased&undrafted https://github.com/llvm/llvm-project/pull/98694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c77b107 - [lldb] Introduce an always-on system log category/channel (#108495)

2024-10-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-10T08:47:30-07:00 New Revision: c77b10746160f985625603b1e9c837b44caa5c67 URL: https://github.com/llvm/llvm-project/commit/c77b10746160f985625603b1e9c837b44caa5c67 DIFF: https://github.com/llvm/llvm-project/commit/c77b10746160f985625603b1e9c837b44caa5c67.d

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/108495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-10-10 Thread Michael Buch via lldb-commits
Michael137 wrote: Just to circle back on this. Managed to reduce the crash I was seeing to something pretty simple. The gist of the issue is that we silently create ODR violations in LLDB's scratch context (and LLDB uses `ODRHandlingType::Liberal`, so we try to continue `ASTImport`ing despite

[Lldb-commits] [lldb] f2c5aa9 - [lldb] Fix a variety of LLDB_LOG format strings

2024-10-10 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-10T09:56:31-07:00 New Revision: f2c5aa920054fa60372a161520e6ea8e8d23880d URL: https://github.com/llvm/llvm-project/commit/f2c5aa920054fa60372a161520e6ea8e8d23880d DIFF: https://github.com/llvm/llvm-project/commit/f2c5aa920054fa60372a161520e6ea8e8d23880d.d

[Lldb-commits] [lldb] Add SBDebugger:: AddNotificationCallback API (PR #111206)

2024-10-10 Thread via lldb-commits
jimingham wrote: > (This is in reply to Jim's comment > [here](https://github.com/llvm/llvm-project/pull/111206#issuecomment-2400376223). > I can't quote it, because github garbles it beyond recognition, probably > because it was sent by email :/) I'm trying to remember not to believe the bi

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-10 Thread Dmitrii Galimzianov via lldb-commits
DmT021 wrote: > I was chatting with Jim Ingham and he was a little bummed that we're looking > at doing this in a single DynamicLoader plugin, instead of having the > DynamicLoader plugin create a list of ModuleSpec's and having a central > method in ModuleList or something, create Modules for

[Lldb-commits] [lldb] DynamicLoaderDarwin load images in parallel (PR #110439)

2024-10-10 Thread via lldb-commits
jimingham wrote: > > it should definitely be enabled by default when we're at the point to merge > > it, and the setting should only be a safety mechanism if this turns out to > > cause a problem for a configuration we weren't able to test. > > That's fine with me either. > > > I would even p

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread via lldb-commits
jimingham wrote: Except for the test request, this LGTM. https://github.com/llvm/llvm-project/pull/110901 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread Adrian Prantl via lldb-commits
@@ -38,19 +38,23 @@ class Args { std::unique_ptr ptr; char quote = '\0'; +/// The position of the argument in the original argument string. +std::optional column; char *data() { return ptr.get(); } public: ArgEntry() = default; -ArgEntry(ll

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread via lldb-commits
@@ -0,0 +1,11 @@ +# RUN: echo quit | %lldb -o "log enable -x" \ jimingham wrote: Can you write one of these tests where the wrong option isn't the first? From the standpoint of "things you could get wrong", "only working for the first option" seems a likely fa

[Lldb-commits] [lldb] d5e1de6 - [lldb] Implement basic support for reverse-continue (#99736)

2024-10-10 Thread via lldb-commits
Author: Robert O'Callahan Date: 2024-10-10T13:01:47-07:00 New Revision: d5e1de6da96c1ab3b8cae68447e8ed3696a7006e URL: https://github.com/llvm/llvm-project/commit/d5e1de6da96c1ab3b8cae68447e8ed3696a7006e DIFF: https://github.com/llvm/llvm-project/commit/d5e1de6da96c1ab3b8cae68447e8ed3696a7006e.d

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add Extension to Save a thread and N pointers deep (PR #111601)

2024-10-10 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/111601 >From 2d693e8208ea99fc57b1137668ee0e12777ab767 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 8 Oct 2024 15:52:45 -0700 Subject: [PATCH 1/5] Create new extension for save core to save a thread and N po

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/111907 This adds an include for SBLanguages.h in lldb-enumerations.h so that files that need this enum do not have to explicitly include SBLanguages. >From 133ace4b281abf205d35bbb6ed6ef7b2a39a8c2a Mon Sep 17 00:

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread via lldb-commits
github-actions[bot] wrote: @rocallahan Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[Lldb-commits] [lldb] Support inline diagnostics in CommandReturnObject (PR #110901)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
@@ -38,19 +38,23 @@ class Args { std::unique_ptr ptr; char quote = '\0'; +/// The position of the argument in the original argument string. +std::optional column; char *data() { return ptr.get(); } public: ArgEntry() = default; -ArgEntry(ll

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This adds an include for SBLanguages.h in lldb-enumerations.h so that files that need this enum do not have to explicitly include SBLanguages. --- Full diff: https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a4916d200518ac077be93995af18bd80fcb89cc2 133ace4b281abf205d35bbb6ed6ef7b2a39a8c2a --e

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/111907 >From c179c081ff76ce53a0c13265b1e68eb682699415 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 10 Oct 2024 12:58:06 -0700 Subject: [PATCH] [lldb] Add include for SBLanguages in lldb-enumeration

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with format fix https://github.com/llvm/llvm-project/pull/111907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/111907 >From e4393924a46dc62f2edfae5675b48002042f2032 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 10 Oct 2024 12:58:06 -0700 Subject: [PATCH] [lldb] Add include for SBLanguages in lldb-enumeration

[Lldb-commits] [lldb] 69b0b7e - [lldb] Return an llvm::Error from GetFrameBaseValue (#111882)

2024-10-10 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-10-10T13:11:08-07:00 New Revision: 69b0b7e7ac3adc42df517c25ed7017b5af9be9f1 URL: https://github.com/llvm/llvm-project/commit/69b0b7e7ac3adc42df517c25ed7017b5af9be9f1 DIFF: https://github.com/llvm/llvm-project/commit/69b0b7e7ac3adc42df517c25ed7017b5af9be9f1.d

[Lldb-commits] [lldb] [lldb] Return an llvm::Error from GetFrameBaseValue (PR #111882)

2024-10-10 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/111882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add include for SBLanguages in lldb-enumerations (PR #111907)

2024-10-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/111907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b355426 - [lldb] Add include for SBLanguages in lldb-enumerations (#111907)

2024-10-10 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-10-10T13:11:46-07:00 New Revision: b3554265f24aa570bbc8693af8420a306c459f94 URL: https://github.com/llvm/llvm-project/commit/b3554265f24aa570bbc8693af8420a306c459f94 DIFF: https://github.com/llvm/llvm-project/commit/b3554265f24aa570bbc8693af8420a306c459f94.d

[Lldb-commits] [lldb] [LLDB] FindLibCppStdFunctionCallableInfo improvements (PR #111892)

2024-10-10 Thread David Mentler via lldb-commits
https://github.com/mentlerd updated https://github.com/llvm/llvm-project/pull/111892 >From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001 From: David Mentler Date: Mon, 7 Oct 2024 21:46:50 +0200 Subject: [PATCH 1/5] Make existing tests break --- .../data-formatter-stl/libcx

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: Looks like `TestReverseContinueBreakpoints.py` is failing on the bots (https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/13228/console) https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: I don't know what your normal protocol is but maybe you should revert it while I debug the failure? The last successful CI run in this PR was from September 25. https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailin

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-10-10 Thread Augusto Noronha via lldb-commits
augusto2112 wrote: I'll revert it! https://github.com/llvm/llvm-project/pull/99736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2