abhina-sree wrote:
> The default is set to OF_Text instead of OF_None, this change in value does
> not affect any other platforms other than z/OS. Setting this parameter
> correctly is required to open files on z/OS in the correct encoding. The
> IsText parameter is based on the context of whe
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere deleted
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Use SEND_ERROR (continue processing, but skip generation) instead of
FATAL_ERROR (stop processing and generation). This means that developers get to
see all errors at once, instead of seeing just th
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/111763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
I could have sworn I added it here, but apparently not. Thanks!
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
@@ -126,6 +127,8 @@ class MachThread {
protected:
static bool GetBasicInfo(thread_t threadID,
struct thread_basic_info *basic_info);
+ static bool GetExtendedInfo(thread_t threadID,
+ struct thread_extended_info *extend
@@ -0,0 +1,79 @@
+//===-- DiagnosticsRendering.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,79 @@
+//===-- DiagnosticsRendering.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
jimingham wrote:
I asked some folks who know and the proc_pidinfo call and the
extended_thread_info read the same data, so this should be NFC...
https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -265,6 +264,25 @@ bool MachThread::GetBasicInfo(thread_t thread,
return false;
}
+struct thread_extended_info *MachThread::GetExtendedInfo() {
+ if (MachThread::GetExtendedInfo(m_mach_port_number, &m_extended_info))
+return &m_extended_info;
+ return NULL;
+}
+
+boo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e85fcb763173590fdcd5cb922b7ca1fc97cf170b
aefa120446a4c31fe9569d76ae3950c29d8d35e9 --e
@@ -126,6 +127,8 @@ class MachThread {
protected:
static bool GetBasicInfo(thread_t threadID,
struct thread_basic_info *basic_info);
+ static bool GetExtendedInfo(thread_t threadID,
+ struct thread_extended_info *extend
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/111686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tool
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tool
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/JDevlieghere approved this pull request.
LGTM with detection hoisted.
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits ma
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/111483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Fine by me.
https://github.com/llvm/llvm-project/pull/111686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From c700dd4b5bf5009b934d259becddab9fc10b9cb2 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching.
Remove unnecessary `proc_
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/111744
This is a draft. Only the last 2 commits will remain after rebase.
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/111747
This module is used in various helper scripts since
https://github.com/llvm/llvm-project/pull/93712
From 6abfaf205142ffeaec76e72fcaf33bac72d2c51d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Stefan Gränitz (weliveindetail)
Changes
This module is used in various helper scripts since
https://github.com/llvm/llvm-project/pull/93712
---
Full diff: https://github.com/llvm/llvm-project/pull/111747.diff
1 Files Affected:
- (modifi
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 6ec95d9321072323755783ed3f5e56acbfaf37cc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 0be5ebe9109e10f340431b3ff8c56febedf64b6b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail approved this pull request.
Yes agree, LGTM
https://github.com/llvm/llvm-project/pull/111729
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM if this makes sense to @jasonmolenda
https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -0,0 +1,79 @@
+//===-- DiagnosticsRendering.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110065
>From ce87c9d2b62c9b05e8ef76d7cc4036420ee563f3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 24 Sep 2024 17:42:49 -0700
Subject: [PATCH 01/13] Add the addr info when appropriate for NIX' crash
signals
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From 2fece4588cf99f268b6e6e91b1225fe63cd91898 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 01/10] Create set for the stop reasons we collect, and add
break
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
SBLanguages.h uses a uint16_t but is missing the include for ``,
if any file includes this without including that it will cause a build error so
this commit adds this include.
---
Full di
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/111763
SBLanguages.h uses a uint16_t but is missing the include for ``, if
any file includes this without including that it will cause a build error so
this commit adds this include.
>From f652fa49979306cf38bdb
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/111763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-10-09T14:41:50-07:00
New Revision: ac3321f104ae2a0639845f860b05c97568bb24e2
URL:
https://github.com/llvm/llvm-project/commit/ac3321f104ae2a0639845f860b05c97568bb24e2
DIFF:
https://github.com/llvm/llvm-project/commit/ac3321f104ae2a0639845f860b05c97568bb24e2.d
https://github.com/medismailben approved this pull request.
Nice! LGTM!
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -374,6 +375,21 @@ void DebugNamesDWARFIndex::GetFullyQualifiedType(
m_fallback.GetFullyQualifiedType(context, callback);
}
+bool DebugNamesDWARFIndex::SameAsEntryContext(
+const CompilerContext &query_context,
+const DebugNames::Entry &entry) const {
+ // TODO: c
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/111601
>From b128131f457a013102b2a0b2fcb968956d980076 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 8 Oct 2024 15:52:45 -0700
Subject: [PATCH 1/4] Create new extension for save core to save a thread and N
po
@@ -444,6 +499,72 @@ void DebugNamesDWARFIndex::GetNamespaces(
m_fallback.GetNamespaces(name, callback);
}
+llvm::SmallVector
+DebugNamesDWARFIndex::GetTypeQueryParentContexts(TypeQuery &query) {
+ std::vector &query_decl_context =
+ query.GetContextRef();
+ llvm::Sma
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108907
>From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 19 Aug 2024 10:57:35 -0700
Subject: [PATCH 1/3] Fix StartDebuggingRequestHandler/ReplModeRequestHandler
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/108907
>From 37bcf4470a6771a196c528e16d3fa1b50b60f63a Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 23 Sep 2024 16:40:16 -0700
Subject: [PATCH 1/2] Improve type query using .debug_names parent chain
---
https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From 09a65dc9729938d5920174cac180164a8e3eb7a2 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching.
Remove unnecessary `proc_
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+ if(LLDB_TEST_MAKE)
+set(LLDB_DEFAULT_TEST_MAKE
https://github.com/ldm0 edited https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -265,6 +264,25 @@ bool MachThread::GetBasicInfo(thread_t thread,
return false;
}
+struct thread_extended_info *MachThread::GetExtendedInfo() {
+ if (MachThread::GetExtendedInfo(m_mach_port_number, &m_extended_info))
+return &m_extended_info;
+ return NULL;
+}
+
+boo
https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From aefa120446a4c31fe9569d76ae3950c29d8d35e9 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching (NFC)
Remove unnecessary `
ldm0 wrote:
> I asked some folks who know and the proc_pidinfo call and the
> extended_thread_info read the same data, so this should be NFC...
Yes, this PR does not intend to change the behavior:
[`thread_info`](https://github.com/apple/darwin-xnu/blob/a1babec6b135d1f35b2590a1990af3c5c5393479
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108495
>From 98f1b5e8a37987e185038380ccc5203a8fae8063 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 25 Sep 2024 11:04:56 -0700
Subject: [PATCH] [lldb] Introduce an always-on system log category/chann
Author: David Spickett
Date: 2024-10-09T09:14:48+01:00
New Revision: de4f2c976f9fa11173c71b2b070225c9be89ceef
URL:
https://github.com/llvm/llvm-project/commit/de4f2c976f9fa11173c71b2b070225c9be89ceef
DIFF:
https://github.com/llvm/llvm-project/commit/de4f2c976f9fa11173c71b2b070225c9be89ceef.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/111543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs():
configuration.make_path = "gmake"
else:
configuration.make_path = "make"
+if ' ' in configuration.make_path:
+configuration.make_path = f'"{configuration.make_path}"'
welivei
@@ -250,6 +250,9 @@ def delete_module_cache(path):
if is_configured("dsymutil"):
dotest_cmd += ["--dsymutil", config.dsymutil]
+if is_configured("make"):
+dotest_cmd += ["--make", config.make]
+
weliveindetail wrote:
`--make` is added if `LLDB_TEST_MA
https://github.com/weliveindetail commented:
Two notes inline
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/111531
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:40:37 +0200
Subject: [PATCH 1/3] [lldb] Add early CMake check for 'm
https://github.com/ldm0 created https://github.com/llvm/llvm-project/pull/111684
Remove unnecessary `proc_pidinfo` calling.
>From e8432f711822d605b5136574967f7c7f133dfe73 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thre
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Donough Liu (ldm0)
Changes
Remove unnecessary `proc_pidinfo` calling.
---
Full diff: https://github.com/llvm/llvm-project/pull/111684.diff
2 Files Affected:
- (modified) lldb/tools/debugserver/source/MacOSX/MachThread.cpp (+25-22)
- (mo
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/omjavaid updated
https://github.com/llvm/llvm-project/pull/108072
>From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001
From: Muhammad Omair Javaid
Date: Tue, 10 Sep 2024 18:03:29 +0500
Subject: [PATCH 1/4] WoA hardware breakpoint/watchpoint support
---
..
Author: David Spickett
Date: 2024-10-09T08:51:38Z
New Revision: 146d3f04ff92e396ea40ab581304e65e8511d8ac
URL:
https://github.com/llvm/llvm-project/commit/146d3f04ff92e396ea40ab581304e65e8511d8ac
DIFF:
https://github.com/llvm/llvm-project/commit/146d3f04ff92e396ea40ab581304e65e8511d8ac.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/111648
Reverts llvm/llvm-project#111543
https://lab.llvm.org/buildbot/#/builders/18/builds/5140 failed here again.
Clearly there is something different on Arm but I don't know what it is yet.
>From 358ad5760066
Author: David Spickett
Date: 2024-10-09T09:55:39+01:00
New Revision: b43e003d90f0a7c045e9961a80013fc9c6d6e9b3
URL:
https://github.com/llvm/llvm-project/commit/b43e003d90f0a7c045e9961a80013fc9c6d6e9b3
DIFF:
https://github.com/llvm/llvm-project/commit/b43e003d90f0a7c045e9961a80013fc9c6d6e9b3.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/111648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Reverts llvm/llvm-project#111543
https://lab.llvm.org/buildbot/#/builders/18/builds/5140 failed here again.
Clearly there is something different on Arm but I don't know what it is yet.
---
Full diff:
emrekultursay wrote:
> With this in mind, deleting the file is representative of an editor wanting
> to save the file using the deletion strategy,...
Yes. I had meant it is not representative of what Android Studio (or _some_
editors) does.
> think it's not our goal here to ensure the editor
https://github.com/omjavaid updated
https://github.com/llvm/llvm-project/pull/108072
>From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001
From: Muhammad Omair Javaid
Date: Tue, 10 Sep 2024 18:03:29 +0500
Subject: [PATCH 1/3] WoA hardware breakpoint/watchpoint support
---
..
https://github.com/omjavaid edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/omjavaid edited
https://github.com/llvm/llvm-project/pull/108072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/omjavaid updated
https://github.com/llvm/llvm-project/pull/108072
>From ac61e5a75ce59f7834034494a03b43e81bf02d41 Mon Sep 17 00:00:00 2001
From: Muhammad Omair Javaid
Date: Tue, 10 Sep 2024 18:03:29 +0500
Subject: [PATCH 1/2] WoA hardware breakpoint/watchpoint support
---
..
omjavaid wrote:
@DavidSpickett @labath I have updated this PR and dropped hardware breakpoint
support for the unresolved "set hw break on main" issue As x86_64 windows also
does not support hardware breakpoints (probably for the same reason).
This PR now only implements HW watchpoint support.
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/111531
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:40:37 +0200
Subject: [PATCH 1/2] [lldb] Add early CMake check for 'm
weliveindetail wrote:
Thanks for the quick feedback. Yes, makes sense. Here we go.
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
40b8a0fd174397e87925da3f1837d74d5d6
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/111686
To align with the new policy:
https://llvm.org/docs/DeveloperPolicy.html#maintainers
I've assumed that Jonas will be the "Lead Maintainer" as he was the default
Code Owner.
I know the past Code Owners w
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
To align with the new policy:
https://llvm.org/docs/DeveloperPolicy.html#maintainers
I've assumed that Jonas will be the "Lead Maintainer" as he was the default
Code Owner.
I know the past Code Owne
DavidSpickett wrote:
Folks may want to read the new wording for themselves, but at least by my
interpretation there's not much change from what I myself have been doing and
what I've seen the folks listed in this file doing. So I don't think you're
opting into a whole lot more work.
https://g
DavidSpickett wrote:
Added a bunch of you on review not because this is some complex change, but
just as a heads up in case you did want to reconsider being listed here or
suggest alternatives.
https://github.com/llvm/llvm-project/pull/111686
___
lld
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/111686
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/110062
>From c5bbc5f17dd5039fb9d5a01ade2397afd5d4c967 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 24 Sep 2024 14:43:44 -0700
Subject: [PATCH] Improve namespace lookup
---
.../Plugins/SymbolFile/DWARF/
https://github.com/ldm0 updated https://github.com/llvm/llvm-project/pull/111684
>From 8573fde9b7ffa035b2ee9da132c910515a6d1d26 Mon Sep 17 00:00:00 2001
From: Liu Dingming
Date: Wed, 9 Oct 2024 21:57:24 +0800
Subject: [PATCH] [lldb] Simplify macOS thread name fetching (NFC)
Remove unnecessary `
Author: jeffreytan81
Date: 2024-10-09T16:29:39-07:00
New Revision: 61a46780d10c8f4e12c9b5496f5ca3f2cc7fba66
URL:
https://github.com/llvm/llvm-project/commit/61a46780d10c8f4e12c9b5496f5ca3f2cc7fba66
DIFF:
https://github.com/llvm/llvm-project/commit/61a46780d10c8f4e12c9b5496f5ca3f2cc7fba66.diff
https://github.com/igorkudrin closed
https://github.com/llvm/llvm-project/pull/111483
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ldm0 edited https://github.com/llvm/llvm-project/pull/111684
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/110062
>From 37bcf4470a6771a196c528e16d3fa1b50b60f63a Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 23 Sep 2024 16:40:16 -0700
Subject: [PATCH 1/3] Improve type query using .debug_names parent chain
---
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/110062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 0a78922cc8e21c62ed7b09a88a14ff6119697cd9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
Author: Igor Kudrin
Date: 2024-10-09T18:11:05-07:00
New Revision: 68a5f5db7c970d22dc40637d7951b627fa50d5c1
URL:
https://github.com/llvm/llvm-project/commit/68a5f5db7c970d22dc40637d7951b627fa50d5c1
DIFF:
https://github.com/llvm/llvm-project/commit/68a5f5db7c970d22dc40637d7951b627fa50d5c1.diff
L
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/110901
>From 49b51bad4dd2ca41e61da38b1e35ffcb1eb9e7d6 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 9 Oct 2024 09:45:53 -0700
Subject: [PATCH] Support inline diagnostics in CommandReturnObject
and impl
@@ -38,19 +38,23 @@ class Args {
std::unique_ptr ptr;
char quote = '\0';
+/// The position of the argument in the original argument string.
+std::optional column;
char *data() { return ptr.get(); }
public:
ArgEntry() = default;
-ArgEntry(ll
@@ -160,6 +166,9 @@ class CommandReturnObject {
StreamTee m_out_stream;
StreamTee m_err_stream;
+ std::vector m_diagnostics;
+ StreamString m_diag_stream;
+ std::optional m_diagnostic_indent;
JDevlieghere wrote:
Maybe this will make sense later, but wh
@@ -19,12 +19,45 @@
#include "lldb/Interpreter/CommandObject.h"
#include "lldb/Interpreter/CommandReturnObject.h"
#include "lldb/Target/Target.h"
+#include "lldb/Utility/DiagnosticsRendering.h"
#include "lldb/Utility/StreamString.h"
#include "llvm/ADT/STLExtras.h"
using na
https://github.com/jasonmolenda approved this pull request.
Looks good to me, thanks for putting this PR together. I can merge the PR for
you, if you don't have permissions to do that on llvm-project currently.
https://github.com/llvm/llvm-project/pull/111684
__
jasonmolenda wrote:
> > Was the setting intended for testing purposes only, or did you intend to
> > include that in a final PR?
>
> The latter. IMO the risks involved by parallelization are a bit too high to
> do it without a flag. I'm even thinking about having it opt-in rather than
> opt-o
jasonmolenda wrote:
For what it's worth, this thread pool for parallel processing has been used in
another part of lldb - it's used on ELF systems when processing DWARF, when we
need to scan the debug info in the individual .o files iirc. So we've had some
living-on time with the thread pool
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/108907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
98 matches
Mail list logo
