https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/110726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2088,6 +2088,13 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+if (abi_sp)
+ address = abi_sp->FixCodeAddress(address);
---
https://github.com/jasonmolenda approved this pull request.
LGTM. Yes, the question of "when do we need to run an address through a Fix
method" is largely driven by the different ABIs we encounter on different
platforms. If we know it is a virtual address value (no metadata in high
bits/unad
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110065
>From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 24 Sep 2024 17:42:49 -0700
Subject: [PATCH 1/7] Add the addr info when appropriate for NIX' crash signals
-
jimingham wrote:
> > I actually think it's fine to change this behavior, I don't think anyone
> > would have expected SetError to AppendError...
>
> If you feel strongly about this (I actually think you have a point), you
> could make `SetError` as deprecated and have it call a newly added
>
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/110784
This commit improves the auto-completion in the Debug Console provided by
VS-Code.
So far, we were always suggesting completions for both LLDB commands and for
variables / expressions, even if the heurist
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Vogelsgesang (vogelsgesang)
Changes
This commit improves the auto-completion in the Debug Console provided by
VS-Code.
So far, we were always suggesting completions for both LLDB commands and for
variables / expressions, even if th
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 915df1ae41652e2f595ce741dcd8f01878ef4e30
41694e6e64b3f16cc5b8e4b64c89d27f4e076573 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
915df1ae41652e2f595ce741dcd8f01878ef4e30...41694e6e64b3f16cc5b8e4b64c89d27f4e076573
lldb/
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/110692
Rename option parsing related files from OptXYZ -> OptionXYZ, since Opt could
be confused with optimization and Opt as a short hand for Option is not really
that smaller to warrant its use.
>From 7ee776230f113
https://github.com/felipepiovezan approved this pull request.
Excited to see more of this being done!
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Zequan Wu
Date: 2024-10-01T13:52:51-04:00
New Revision: 4206c37bd11887c2c9dfc99e484753f6b8230a90
URL:
https://github.com/llvm/llvm-project/commit/4206c37bd11887c2c9dfc99e484753f6b8230a90
DIFF:
https://github.com/llvm/llvm-project/commit/4206c37bd11887c2c9dfc99e484753f6b8230a90.diff
LOG
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/110661
>From b4bf7c601d2b790ea5e65f68cb1fa9375457b558 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Mon, 9 Sep 2024 15:32:09 -0400
Subject: [PATCH] Propagate IsText parameter to openFileForRead funct
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/110707
This is a cleanup that moves the API towards value semantics.
>From ab6628eca01c67d2372d758f3c7bdf7681ee4407 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 1 Oct 2024 10:01:54 -0700
Subject: [PAT
labath wrote:
> > Seems reasonable, but you'll need to use the signal constants from
> > `UnixSignals` (looked up by string), as macros like `SIGBUS` might not
> > exist (windows) or might not have the right value (macos).
> > (NativeThreadLinux can get away with using them as it always runs o
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c71bfc59ee1cec32d56a82476461e242398f82ca
562b560ed8e2bc8c984c49c0bbdc92000f5ea3bc --e
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110065
>From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 24 Sep 2024 17:42:49 -0700
Subject: [PATCH 1/5] Add the addr info when appropriate for NIX' crash signals
-
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
> I don't like globals
Is this the only argument? I don't like globals too. But no one suggested
better solution w/o huge refactoring of MonitorProcessCallback.
Updated. The child process will crash 50/50 at the end, but no one will see.
The problem will remain hidden.
https:
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests,
ParseArangesWithMultipleTerminators) {
// Set the big endian length correctly.
const offset_t binary_data_size = sizeof(binary_data);
binary_data[3] = (uint8_t)binary_data_size - 4;
- DWARFDataExtractor data;
- data.Se
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/110058
>From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 25 Sep 2024 15:59:29 -0700
Subject: [PATCH 1/5] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with
llvm's
perry-ca wrote:
> @perry-ca raised some concerns in #109664 about this functionality requiring
> some context awareness, I don't think any of those is addressed by this patch
> either. Pretty much all of the callers apart from ASTReader is just using
> `IsText = true`.
It just happens that 90
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
This is a cleanup that moves the API towards value semantics.
---
Full diff: https://github.com/llvm/llvm-project/pull/110707.diff
9 Files Affected:
- (modified) lldb/include/lldb/Interpreter/Command
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests,
ParseArangesWithMultipleTerminators) {
// Set the big endian length correctly.
const offset_t binary_data_size = sizeof(binary_data);
binary_data[3] = (uint8_t)binary_data_size - 4;
- DWARFDataExtractor data;
- data.Se
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: AbdAlRahman Gad (AbdAlRahmanGad)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/110718.diff
4 Files Affected:
- (modified) lldb/include/lldb/Symbol/SymbolContext.h (+2-2)
- (modified) lldb/source/API/SBThread.cpp (+7-
AbdAlRahmanGad wrote:
@adrian-prantl
https://github.com/llvm/llvm-project/pull/110718
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kadircet requested changes to this pull request.
sorry this is same as https://github.com/llvm/llvm-project/pull/107906 (with a
bigger impact radius, as you're also changing getBufferForFile) and doesn't
address any of the issues mention about explaining the semantics of `IsT
labath wrote:
> Seems reasonable to me, given we end up here only for definition DIEs. (did
> have couple of questions though)
>
> > My fix consists of always fetching type size information from DWARF (which
> > so far existed as a fallback path). I'm not quite sure why this code was
> > ther
Author: Jay Foad
Date: 2024-10-01T14:12:34+01:00
New Revision: fe61dbf1d3350d11ab975e45f805f3bfe885b8b7
URL:
https://github.com/llvm/llvm-project/commit/fe61dbf1d3350d11ab975e45f805f3bfe885b8b7
DIFF:
https://github.com/llvm/llvm-project/commit/fe61dbf1d3350d11ab975e45f805f3bfe885b8b7.diff
LOG:
@@ -7,65 +7,45 @@
//===--===//
#include "DWARFDebugAranges.h"
-#include "DWARFDebugArangeSet.h"
#include "DWARFUnit.h"
#include "LogChannelDWARF.h"
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Tim
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/97443
>From 3a718c75d0458b7aece72f2ba8e5aa5a68815237 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 2 Jul 2024 18:43:34 +0200
Subject: [PATCH] [clang][RecordLayoutBuilder] Be stricter about inferring
packed
labath wrote:
I'm currently fighting some fires, so I didn't look at the new version yet, but
I think the biggest blocker right now are the global variables in the platform
class. I don't like globals, and I don't think they should be necessary to
solve the problem at hand. If you can revert t
Author: Michael Buch
Date: 2024-10-01T10:57:20+01:00
New Revision: a5f3a2a8414a16077ca9a5544d30dd44b30b901e
URL:
https://github.com/llvm/llvm-project/commit/a5f3a2a8414a16077ca9a5544d30dd44b30b901e
DIFF:
https://github.com/llvm/llvm-project/commit/a5f3a2a8414a16077ca9a5544d30dd44b30b901e.diff
slydiman wrote:
> I think the biggest blocker right now are the global variables in the
> platform class. I don't like globals, and I don't think they should be
> necessary to solve the problem at hand. If you can revert those (put them
> into a separate patch so we can continue the discussion
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/109656
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
abhina-sree wrote:
> > @perry-ca raised some concerns in #109664 about this functionality
> > requiring some context awareness, I don't think any of those is addressed
> > by this patch either. Pretty much all of the callers apart from ASTReader
> > is just using `IsText = true`.
>
> It just
labath wrote:
> I actually tried to yamlize one of my test crash dumps. The issue I
> encountered was the PT_NOTE sections wasn't being generated with content. Is
> there a way with obj2yaml to generate PT_NOTES with content?
yaml2obj was originally written for llvm testing, so it mainly focus
@@ -132,34 +134,33 @@ TEST_F(SymbolFileDWARFTests,
ParseArangesWithMultipleTerminators) {
// Set the big endian length correctly.
const offset_t binary_data_size = sizeof(binary_data);
binary_data[3] = (uint8_t)binary_data_size - 4;
- DWARFDataExtractor data;
- data.Se
Michael137 wrote:
Yea I agree, I think this makes things easier to reason about. And if the
"no-DW_AT_byte_size on definition" case comes up, that can be addressed
differently.
> We could do that, but then we'd also need to do that in
> ParseStructureLikeDIE. And we may need to figure out wha
https://github.com/labath approved this pull request.
Any more thoughts on this, Greg?
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
@@ -117,7 +119,7 @@ TEST_F(SymbolFileDWARFTests,
ParseArangesWithMultipleTerminators) {
unsigned char binary_data[] = {
0, 0, 0, 0, // unit_length that will be set correctly after this
0, 2, // DWARF version number (uint16_t)
- 0, 0, 0, 0, // CU offset
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/110661
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/abhina-sree updated
https://github.com/llvm/llvm-project/pull/110661
>From 1a5096483d5d6d84087e913b20f6f260452988b3 Mon Sep 17 00:00:00 2001
From: Abhina Sreeskantharajan
Date: Mon, 9 Sep 2024 15:32:09 -0400
Subject: [PATCH] Propagate IsText parameter to openFileForRead funct
https://github.com/AbdAlRahmanGad created
https://github.com/llvm/llvm-project/pull/110718
None
>From b4afb0b69bc07b5df72e2db29af4bc09bcafa526 Mon Sep 17 00:00:00 2001
From: AbdAlRahman Gad
Date: Tue, 1 Oct 2024 21:15:13 +0300
Subject: [PATCH] [lldb] Change SymbolContext::GetAddressRangeFromHe
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/110692
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Rahul Joshi (jurahul)
Changes
Rename option parsing related files from OptXYZ -> OptionXYZ, since Opt
could be confused with optimization and Opt as a short hand for Option is not
really that smaller to warrant its use.
---
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/110065
>From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 24 Sep 2024 17:42:49 -0700
Subject: [PATCH 1/6] Add the addr info when appropriate for NIX' crash signals
-
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c71bfc59ee1cec32d56a82476461e242398f82ca...f173ea4f7a2cd3fbbb8621b74266063706806fd8
lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Rahul Joshi (jurahul)
Changes
Rename option parsing related files from OptXYZ -> OptionXYZ, since Opt
could be confused with optimization and Opt as a short hand for Option is not
really that smaller to warrant its use.
---
Patch is 53.2
llvmbot wrote:
@llvm/pr-subscribers-lld
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Rename option parsing related files from OptXYZ -> OptionXYZ, since Opt
could be confused with optimization and Opt as a short hand for Option is not
really that smaller to warrant it
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/110726
This is similar to 9fe455fd0c7d, but for FA locations instead of register
locations.
This is useful for unwind plans that cannot create abstract unwind rules, but
instead must inspect the state of the pr
@@ -2088,6 +2088,12 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+address = abi_sp->FixCodeAddress(address);
felip
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/110726
>From a23540f5a793d7c9bb115f06a5af0266f8cfb038 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 24 Sep 2024 09:26:29 -0700
Subject: [PATCH 1/2] [lldb] Add isConstant mode for FA locati
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/110058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2088,6 +2088,12 @@ bool RegisterContextUnwind::ReadFrameAddress(
UnwindLogMsg("No suitable CFA found");
break;
}
+ case UnwindPlan::Row::FAValue::isConstant: {
+address = fa.GetConstant();
+address = abi_sp->FixCodeAddress(address);
felip
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This is similar to 9fe455fd0c7d, but for FA locations instead of register
locations.
This is useful for unwind plans that cannot create abstract unwind rules, but
instead must inspect the
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben commented:
LGTM!
https://github.com/llvm/llvm-project/pull/110707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
`SetError(Status error, const char* fallback_error_string)` was a badly named
API. What it actually does is APPEND either the error string in the incoming
`error`, or if that had no error string, the `fallback_error_string`, to
whatever was already in the command error.
So fa
jimingham wrote:
I actually think it's fine to change this behavior, I don't think anyone would
have expected SetError to AppendError...
https://github.com/llvm/llvm-project/pull/110707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
medismailben wrote:
> I actually think it's fine to change this behavior, I don't think anyone
> would have expected SetError to AppendError...
If you feel strongly about this (I actually think you have a point), you could
make `SetError` as deprecated and have it call a newly added `AppendErr
Jlalond wrote:
> yaml2obj was originally written for llvm testing, so it mainly focuses on
> sections and other things that are interesting there. Support for program
> headers came later, and it's done on an on-demand and self-serve basis. Also,
> obj2yaml is generally in a better state than
@@ -201,8 +201,8 @@ class SymbolContext {
bool GetAddressRange(uint32_t scope, uint32_t range_idx,
bool use_inline_block_range, AddressRange &range) const;
- bool GetAddressRangeFromHereToEndLine(uint32_t end_line, AddressRange &range,
-
Michael137 wrote:
> This is my main suspect for this failure in Green Dragon:
> https://green.lab.llvm.org/job/llvm.org/job/llvm-coverage/64/consoleFull
>
> Relevant test output:
>
> ```
> AIL: test_with_run_command_libcpp_dsym
> (TestDataFormatterGenericOptional.GenericOptionalDataFormatterT
hnrklssn wrote:
This is my main suspect for this failure in Green Dragon:
https://green.lab.llvm.org/job/llvm.org/job/llvm-coverage/64/consoleFull
Relevant test output:
```
AIL: test_with_run_command_libcpp_dsym
(TestDataFormatterGenericOptional.GenericOptionalDataFormatterTestCase)
--
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion,
bool try_dirty_pages,
CreateCoreFileMemoryRange(region));
}
+static void AddRegisterSections(Process &process, ThreadSP &thread_sp,
+CoreFileMemoryRanges
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/109477
>From 424b200b296df80071adad2c5ed52c93eaa05807 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 16 Sep 2024 13:02:59 -0700
Subject: [PATCH 1/7] Add Process code to get the fs_base region and the .tdata
s
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion,
bool try_dirty_pages,
CreateCoreFileMemoryRange(region));
}
+static void AddRegisterSections(Process &process, ThreadSP &thread_sp,
+CoreFileMemoryRanges
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/108448
>From d3137f697e130598b6ff7fa61b4cd098cb9e1b2a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 12 Sep 2024 13:10:58 -0700
Subject: [PATCH 1/8] Create set for the stop reasons we collect, and add
breakpo
72 matches
Mail list logo
