[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes As this comment around target initialization implies: ``` // This can be NULL if we don't know anything about the architecture or if // the target for an architecture isn't enabled in the llvm/clang that

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/110481 As this comment around target initialization implies: ``` // This can be NULL if we don't know anything about the architecture or if // the target for an architecture isn't enabled in the llvm/clang that w

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110481 >From 0669f9fbeddaf81edfca7e81f4883a1b95a780f6 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 30 Sep 2024 10:53:47 +0100 Subject: [PATCH 1/3] [lldb][TypeSystemClang] Add warning and defensive checks

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110481 >From 0669f9fbeddaf81edfca7e81f4883a1b95a780f6 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 30 Sep 2024 10:53:47 +0100 Subject: [PATCH 1/2] [lldb][TypeSystemClang] Add warning and defensive checks

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

Michael137 wrote: There's a couple more places we use these types unconditionally that I haven't added checks to. Should be testable by creating a `TypeSystemClang` with an empty triple and calling one of these APIs on it. https://github.com/llvm/llvm-project/pull/110481 _

[Lldb-commits] [lldb] Fix an integer trunctation issues for the DW_AT_frame_base DWARF loca… (PR #110388)

https://github.com/kusmour approved this pull request. https://github.com/llvm/llvm-project/pull/110388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b086f75 - Fix an integer trunctation issues for the DW_AT_frame_base DWARF location expression (#110388)

Author: Greg Clayton Date: 2024-09-30T09:04:09-07:00 New Revision: b086f7591ce8d4f810a472554d38b4437dff6919 URL: https://github.com/llvm/llvm-project/commit/b086f7591ce8d4f810a472554d38b4437dff6919 DIFF: https://github.com/llvm/llvm-project/commit/b086f7591ce8d4f810a472554d38b4437dff6919.diff

[Lldb-commits] [lldb] Fix an integer trunctation issues for the DW_AT_frame_base DWARF loca… (PR #110388)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/110388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110481 >From 0669f9fbeddaf81edfca7e81f4883a1b95a780f6 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 30 Sep 2024 10:53:47 +0100 Subject: [PATCH 1/4] [lldb][TypeSystemClang] Add warning and defensive checks

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -556,6 +558,34 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch) { si_signo = data.GetU32(&offset); si_errno = data.GetU32(&offset); si_code = data.GetU32(&offset); + // 64b ELF have a 4 byte pad. + if (data.GetAddressByteSize() == 8)

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/110065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -75,16 +75,25 @@ struct ELFLinuxPrStatus { static_assert(sizeof(ELFLinuxPrStatus) == 112, "sizeof ELFLinuxPrStatus is not correct!"); +union ELFSigval { + int sival_int; + void *sival_ptr; +}; + struct ELFLinuxSigInfo { - int32_t si_signo; - int32_t si_co

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -75,16 +75,25 @@ struct ELFLinuxPrStatus { static_assert(sizeof(ELFLinuxPrStatus) == 112, "sizeof ELFLinuxPrStatus is not correct!"); +union ELFSigval { + int sival_int; + void *sival_ptr; +}; + struct ELFLinuxSigInfo { - int32_t si_signo; - int32_t si_co

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110481 >From cba9ca2f2337c605d6992f3eece96e6ff15da8fe Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 30 Sep 2024 10:53:47 +0100 Subject: [PATCH] [lldb][TypeSystemClang] Add warning and defensive checks when

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

slydiman wrote: Polite ping. Let's complite this PR, please. https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

@@ -75,16 +75,25 @@ struct ELFLinuxPrStatus { static_assert(sizeof(ELFLinuxPrStatus) == 112, "sizeof ELFLinuxPrStatus is not correct!"); +union ELFSigval { + int sival_int; + void *sival_ptr; +}; + struct ELFLinuxSigInfo { - int32_t si_signo; - int32_t si_co

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/110543 I'm developing the Mojo language, and some symbol breakpoints don't work because of two reasons that got fixed1: - There's a prune step that operates on the assuption that the symbol is C-like. That w

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes I'm developing the Mojo language, and some symbol breakpoints don't work because of two reasons that this PR fixes: - There's a prune step that operates on the assuption that the symbol is C-lik

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/110543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 78ff340 - [LLDB][Minidump] Fix bug where we were using the wrong collection for thread stacks (#110579)

Author: Jacob Lalonde Date: 2024-09-30T17:56:32-07:00 New Revision: 78ff3401482384203b8ea664eee20fb81f8fb933 URL: https://github.com/llvm/llvm-project/commit/78ff3401482384203b8ea664eee20fb81f8fb933 DIFF: https://github.com/llvm/llvm-project/commit/78ff3401482384203b8ea664eee20fb81f8fb933.diff

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug where we were using the wrong collection for thread stacks (PR #110579)

https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/110579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

vogelsgesang wrote: (I will be waiting for one or two more weeks before merging this, in case there are any additional comments) https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110481 >From 0669f9fbeddaf81edfca7e81f4883a1b95a780f6 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 30 Sep 2024 10:53:47 +0100 Subject: [PATCH 1/5] [lldb][TypeSystemClang] Add warning and defensive checks

[Lldb-commits] [lldb] [lldb] Symlink Python binding to fully soversioned library (PR #110557)

https://github.com/tambry created https://github.com/llvm/llvm-project/pull/110557 In Debian packaging the soversionless library is typically put into a -dev package and links to the current soversion things should be built against. This means that installing the bindings requires unnecessari

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

jimingham wrote: That sounds entirely appropriate. Jim > On Sep 30, 2024, at 1:49 PM, Walter Erquinigo ***@***.***> wrote: > > > @walter-erquinigo commented on this pull request. > > In lldb/source/Core/Module.cpp > :

[Lldb-commits] [libcxx] [lldb] [lldb][libc++] Hide all libc++ implementation details from stacktraces (PR #108870)

https://github.com/adrian-prantl approved this pull request. The regexes look sane (and sufficiently restricted) to me, thanks! https://github.com/llvm/llvm-project/pull/108870 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug where we were using the wrong collection for stacks in mmeory 32 (PR #110579)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In my prior two save core API's, I experimented on how to save stacks with the new API. I incorrectly left these in, as the existing `m_thread_by_range_end` was the correct choice. I have removed the no-op

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug where we were using the wrong collection for stacks in mmeory 32 (PR #110579)

https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/110579 In my prior two save core API's, I experimented on how to save stacks with the new API. I incorrectly left these in, as the existing `m_thread_by_range_end` was the correct choice. I have removed the no-op col

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Add warning and defensive checks when ASTContext is not fully initialized (PR #110481)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/110481 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/109020 >From 60045b710e1102d6f220dfd4367f997b73bb64df Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Tue, 17 Sep 2024 09:56:09 -0700 Subject: [PATCH 1/2] Add warning message to `session save` when transcript isn't saved.

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

@@ -24,10 +24,10 @@ using namespace lldb; using namespace lldb_private; -BreakpointResolverName::BreakpointResolverName(const BreakpointSP &bkpt, walter-erquinigo wrote: Good catch, I didn't realize the formatter changes this file. https://github.com/llvm/ll

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

@@ -797,6 +797,10 @@ void Module::LookupInfo::Prune(SymbolContextList &sc_list, while (i < sc_list.GetSize()) { if (!sc_list.GetContextAtIndex(i, sc)) break; + if (!lldb_private::Language::LanguageIsCFamily(sc.GetLanguage())) { walter-erq

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

@@ -24,10 +24,10 @@ using namespace lldb; using namespace lldb_private; -BreakpointResolverName::BreakpointResolverName(const BreakpointSP &bkpt, jimingham wrote: There are only reformattings in this file, unless I'm missing something. Good to leave this so

[Lldb-commits] [lldb] [lldb] Symlink Python binding to fully soversioned library (PR #110557)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Raul Tambre (tambry) Changes In Debian packaging the soversionless library is typically put into a -dev package and links to the current soversion things should be built against. This means that installing the bindings requires unnecessar

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add breakpoint stop reasons to the minidump. (PR #108448)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108448 >From d3137f697e130598b6ff7fa61b4cd098cb9e1b2a Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 12 Sep 2024 13:10:58 -0700 Subject: [PATCH 1/7] Create set for the stop reasons we collect, and add breakpo

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/109020 >From 60045b710e1102d6f220dfd4367f997b73bb64df Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Tue, 17 Sep 2024 09:56:09 -0700 Subject: [PATCH 1/2] Add warning message to `session save` when transcript isn't saved.

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

@@ -797,6 +797,10 @@ void Module::LookupInfo::Prune(SymbolContextList &sc_list, while (i < sc_list.GetSize()) { if (!sc_list.GetContextAtIndex(i, sc)) break; + if (!lldb_private::Language::LanguageIsCFamily(sc.GetLanguage())) { jimingham

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/110543 >From 15132008232d446036a43a8ed3eed5883f80a2d5 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 30 Sep 2024 13:33:35 -0400 Subject: [PATCH] [LLDB] Fix symbol breakpoint lookups for non-C-like

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug where we were using the wrong collection for thread stacks (PR #110579)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/110579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Fix bug where we were using the wrong collection for stacks (PR #110579)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/110579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/110543 >From dcc5c787a7c146942fed66da5df01ef5a4401744 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 30 Sep 2024 13:33:35 -0400 Subject: [PATCH] [LLDB] Fix symbol breakpoint lookups for non-C-like

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/110543 >From d3aa6a3726224c51dc838dd72fef40e9520fd8de Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 30 Sep 2024 13:33:35 -0400 Subject: [PATCH] [LLDB] Fix symbol breakpoint lookups for non-C-like

[Lldb-commits] [lldb] [LLDB] Fix symbol breakpoint lookups for non-C-like languages (PR #110543)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/110543 >From f1088d6f159363086cb040783106ebf18130f645 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 30 Sep 2024 13:33:35 -0400 Subject: [PATCH] [LLDB] Fix symbol breakpoint lookups for non-C-like